1
0
mirror of https://github.com/chylex/Nextcloud-News.git synced 2024-10-17 08:42:48 +02:00
Commit Graph

158 Commits

Author SHA1 Message Date
Marco Nassabain
11bd056bdf 🩹 Patch readAll: concerns items shared with user
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Marco Nassabain
c640740444 🐛 Fix readAll: cannot read items we shared
- A shared item is still in our feed, but it's not ours to read

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Marco Nassabain
b27226d4ae 🚑 Fix bug - other user feeds show for shared item
- findAllFeeds doesn't return feeds of shared articles
- Disable feed cache handling for shared items

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Marco Nassabain
e78153c051 Sharing: update ownership in sql (sharedwith)
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Aurélien
5f69c256e3 Add function for avoid duplicate item (share)
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Marco Nassabain
f3c4d744c0 🐛 Share Item: feed_id not nullable, copy feed_id
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Jimmy Huynh
98d72bac54 (*) fix: item Model
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Jimmy Huynh
4294842a00 (*) fix: item Model
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Jimmy Huynh
b402fddef9 (+) Adding sharing_user names to EVERY articles + pre-condition if sharedArticle: no title feed (e.g.: from wikiRSS...)
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Marco Nassabain
785aaf6929 🐛 sharedCount: fix sql statement bug 1 => 1
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
WENDLING NICOLAS
ca2b8c6566 Add count for unread items
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Marco Nassabain
5fc486a84f 🔥 shareItem: set unread = true for shared article
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Marco Nassabain
f2ef07c661 🔥 findAllShared: add table alias in sql statement
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
WENDLING NICOLAS
3936362343 Get all shared items with an user
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Marco Nassabain
527eef0727 NewsItem: add share functions (mapper + service)
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Marco Nassabain
5b09e74f40 🗃 NewsItem: added share fields, feedId not null
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-04-08 22:31:21 +02:00
Paul Tirk
f18adeba26 fix invalid 'empty' checks
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Paul Tirk
f358c8213b add missing type hints
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Paul Tirk
822423af38 use last modified timestamp data instead of removed 'updatedAt' field
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Paul Tirk
8035142973 fix wrong function definition & remove leftover copyright headers
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Paul Tirk
323f215e3a separate serialization functions
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Paul Tirk
f22eddb91d remove unused 'findByName' method of folder mapper/service
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Paul Tirk
566a21b4a8 add possibility to serialize a reduced version of an entity
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Paul Tirk
06a45387ef lint & add missing copyright/author information
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Paul Tirk
5e4c927017 add folder api v2
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Paul Tirk
6e067dfd43 add serialization methods for v2 API
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
2021-04-08 10:23:11 +02:00
Sean Molenaar
90702dd297 DB: Use boolean parameter for unread/starred
Issue GH-1278

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-04-06 12:43:24 +02:00
Sean Molenaar
951f3eb7ee DB: Allow negative limits
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-04-05 19:18:19 +02:00
Sean Molenaar
78dce7ffe1 DB: Updates should use set()
Issue GH-1211

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-03-31 22:39:00 +02:00
Sean Molenaar
2baa7a2b91 Make PHPstan stricter
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-03-25 18:47:38 +01:00
Sean Molenaar
baf1ca8ec9 DB: Don't show deleted feed items
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-03-23 21:11:25 +01:00
Marco Nassabain
79c9df8dc1 🎨 Item: implode categories for search index
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-03-17 08:58:42 +01:00
Marco Nassabain
7e0aab358c 🎨 Item: store categories as json & add helper fns
+ added setter/getters that work with arrays to simplify use case

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-03-17 08:58:42 +01:00
Marco Nassabain
29b55ae030 Item: add categories into search index
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-03-17 08:58:42 +01:00
Jimmy Huynh
4e7a1b159a Add 'catagories' to jsonSerialize()
Signed-off-by: Jimmy Huynh <jimmy.huynh@etu.unistra.fr>
2021-03-17 08:58:42 +01:00
Jimmy Huynh
3dfbf64a6b ♻️ Renaming 'tags' into 'categories'
Signed-off-by: Jimmy Huynh <jimmy.huynh@etu.unistra.fr>
2021-03-17 08:58:42 +01:00
Marco Nassabain
ef0742e868 🐛 Fix Item model: set default value for setTags
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
2021-03-17 08:58:42 +01:00
Jimmy Huynh
f217384716 Update 'Item' model: add 'tags' field
Signed-off-by: Jimmy Huynh <jimmy.huynh@etu.unistra.fr>
2021-03-17 08:58:42 +01:00
Sean Molenaar
9d5d35ce23 DB: Fix offset quotes
Issue GH-1200

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-02-27 15:12:59 +01:00
Sean Molenaar
bf1e71f1a7 DB: Use ID as offset in item queries
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-02-23 17:16:20 +01:00
Sean Molenaar
4a107b3d53 General: Fix folder query
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-02-20 13:57:09 +01:00
Sean Molenaar
01e1db329c Command: Add debug item list commands
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-02-20 13:57:09 +01:00
anoy
8ca7ef7e49 update sorting column
follow-up for b4fa772bc5 (#1056)

Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2021-02-14 17:15:46 +01:00
Sean Molenaar
b4fa772bc5 Remove V1 item API
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-02-13 13:22:57 +01:00
anoy
7e9fd48f4a fix refetching of purged articles
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2021-02-10 13:58:13 +01:00
Sean Molenaar
6e9e2512ea DB: Remove unused fields
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-02-05 09:37:17 +01:00
Sean Molenaar
5406086829 Psalm: Fix class loading 2021-02-05 07:27:11 +01:00
anoy
5c7838e9bd fix result ordering for purging query
updated_date is currently always NULL

Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2021-02-04 09:03:06 +01:00
anoy
e601f07ee6 fix articlesPerUpdate alias
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2021-02-02 20:50:34 +01:00
anoy
f2b74a0ba1 fix item purger for PostgreSQL
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2021-02-02 13:48:55 +01:00
Sean Molenaar
023c61b88f Mappers: Implement item purging
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-01-30 18:27:06 +01:00
anoy
8d834cff35 fix typo in string template value
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2021-01-17 17:56:37 +01:00
anoy
fdf4fa454d fix TypeError in ItemMapper
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2021-01-15 15:16:41 +01:00
anoy
8b3516a949 fix opened state of folders is not restored
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2021-01-13 19:23:46 +01:00
Sean Molenaar
67b6c4e1b0 Fix psalm issues
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-01-12 13:29:08 +01:00
anoy
8de3ad77fc remove deprecated colon prefix for parameters
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2021-01-11 09:32:23 +01:00
Benjamin Brahmer
52f1142cd3 autofix round2 2021-01-08 22:45:10 +01:00
Benjamin Brahmer
67bbd6bfeb fix the test
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
2021-01-08 22:45:10 +01:00
Benjamin Brahmer
7180e11bdb fixes done by psalm
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
2021-01-08 22:45:10 +01:00
Sean Molenaar
d3cd465d87 Improve itemmapper wording
Co-authored-by: anoy. <anoymouserver@users.noreply.github.com>
2020-12-30 11:21:44 +01:00
Sean Molenaar
05377d023e Remove PHPunit integration tests
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-12-30 11:21:44 +01:00
anoy
d1c50b8e77 fix FeedMapper find exception
Exception: Argument 2 passed to OCA\News\Db\FeedMapper::find() must be of the type int, string given

Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2020-12-23 17:32:26 +01:00
Kevin Decherf
42ea24f2f4 Remove LastModified-based cursor when updating feeds
We remove the call to readSince() as some feeds push new articles with
pubDate prior to the lastModified time stored for these feeds (e.g.
lemonde.fr). As we go through all items of a feed again and again, we
prevent the constant update of an item's lastModified timestamp by
keeping the previous one if its fingerprint does not change.

Fixes #921

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
2020-12-15 20:02:21 +01:00
Sean Molenaar
e0edfd0dc5 Fix alias usage in v2 mapper
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-12-08 16:11:17 +01:00
Sean Molenaar
4ee3fcb781 Refactor User ID fetching and fix non-specific cleanup
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-12-08 13:58:12 +01:00
Sean Molenaar
8abddeab4f Remove usage of old Folder code
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-12-08 13:58:12 +01:00
anoy
c6c44be93b fix second where overrides previous condition
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2020-11-11 19:21:04 +01:00
Sean Molenaar
5bdc2df7f4 Fix unread count and related issues
Issue GH-924

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-11-10 16:47:42 +01:00
Sean Molenaar
10e8c28fea Add migration with foreign keys
Closes #829

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-11-03 19:58:37 +01:00
Sean Molenaar
ec6930da82
DB: stop overloading getID
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-10-28 23:08:53 +01:00
anoy
1fcab6e6c6 fix multiple results for guid_hash
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2020-10-09 20:38:58 +02:00
Tilo Spannagel
a74491ecde Add Type Info to Entities
Signed-off-by: Tilo Spannagel <development@tilosp.de>
2020-10-09 13:59:23 +02:00
anoy
bfcf38a480 update only relevant item fields
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-10-04 21:35:31 +02:00
anoy
0fe6384085 trim whitespaces in item titles
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2020-10-04 20:10:15 +02:00
anoy
d1b0e299f1 remove doubled execute
Signed-off-by: anoy <anoymouserver+github@mailbox.org>
2020-10-03 20:16:34 +02:00
Sean Molenaar
b9c31a73bd DB: Fix mime checking
Signed-off-by: Sean Molenaar <sean@m2mobi.com>
2020-10-03 14:01:36 +02:00
Benjamin Brahmer
4e6acf9c68 fix matching any string
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
2020-10-03 14:01:36 +02:00
Sean Molenaar
167dc70238 Fix various 15.0 bugs
Issue #821,#820,#819

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-10-03 14:01:36 +02:00
Sean Molenaar
e528361141 Add feed autodiscovery
Issue GH-415

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-09-29 21:15:53 +02:00
Sean Molenaar
35b53ecd40 OPML export command and fixes
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-09-29 14:56:07 +02:00
Sean Molenaar
d00d1ab2a2 Create V2 mapper, Service and management commands
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-09-27 15:35:31 +02:00
Benjamin Brahmer
66ce13a0c7 change statement for deleting items with help from @Talon24
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
2020-09-25 19:18:04 +02:00
Benjamin Brahmer
dd266ed05f fix import with invalid guid_hash
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
2020-08-29 23:45:26 +02:00
Sean Molenaar
54630030c3 Add phpstan checks
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2020-08-25 20:52:48 +02:00
David Engster
864794461f Do not create spurious links in item body
The 'str_replace' will match any HTML element that starts with '<a',
including things like '<address' or '<article', thus creating spurious
links in item bodies. Fix that by simply adding one whitespace.

Fixes issue #527.

Signed-off-by: David Engster <deng@randomsample.de>
2020-05-21 12:02:25 +02:00
Cesar Enrique Garcia Dabo
5b4f3d29e4 Always show the unread articles.
The unread articles folder will always be visible, regardless
of the "Show all" setting. If that setting is on, then an
additional "All articles" folder will be show as before, but
it doesn't substitute the "Uread articles" one.

A new URL /apps/news/#/items/unread is also created that jumps
to the unread articles.

Signed-off-by: Cesar Enrique Garcia Dabo <cquike@arcor.de>
2020-04-23 12:37:24 +02:00
Talon24
cc051c6ce7
Different solution for ONLY_FULL_GROUP_BY (see #406) (Issue #80) (#407)
* Group by moved to subquery, get feed details from outer query (see #406)

Signed-off-by: Talon <talontalon24@gmail.com>
2020-03-01 15:49:39 +01:00
Éloi Rivard
306d3cdc60
Basic Media-RSS support (#599)
Signed-off-by: Éloi Rivard <azmeuk@gmail.com>
2020-02-16 14:26:06 +01:00
Sean Molenaar
62bd42cb17 Stop assuming encoding of xml, let simplexml throw silently (#457) 2019-03-22 09:19:05 +01:00
Sean Molenaar
2698214c41 fix/allow CDATA encoding (#428) 2019-03-17 08:23:37 +01:00
Sean Molenaar
a3246a927d
Parser: Switch to feedIO for parsing instead of picoFeed 2019-01-30 20:36:40 +01:00
Sean Molenaar
becce6b752 Define an official codestyle and adhere to it. 2018-12-14 07:54:43 +01:00
Detlev Zundel
8337d2aa7d Fix lastModified to be a string rather than an integer. (#355)
This fixes https://github.com/nextcloud/news/issues/350#issue-369283392

Signed-off-by: Detlev Zundel <dzu@member.fsf.org>
2018-10-14 18:53:53 +02:00
Daniel Opitz
89f2c7cfdb add setters + getters to Folder and Item entities, fixed unit tests, rearranged methods 2018-09-28 23:24:10 +02:00
Daniel Opitz
159986553b add php7 types 2018-09-28 23:24:10 +02:00
Daniel Opitz
a3b5b516d2 add getters + setters for feed entity 2018-09-28 23:24:10 +02:00
Sean Molenaar
5b94705cf3 Core: Fix compatibility with nextcloud codestyle (#280) 2018-03-27 15:35:06 +02:00
Daniel Opitz
a97dd58e3b Split binary to booleans (#203)
* replaced old status with 2 flags for unread and starred

* add fields to db, replace int(1,0) with booleans in sql queries, removed StatusFlags class + refactor code relying to it

* add repair step for migration

* again use integer(1,0) instead of bool in sql queries, because of sqlite doesn't support true/false

* add/fix unit tests for new boolean status

* set unread/starred flags as statements in sql

* fixed mysql unknown column items.unread, fixed marking of read items on repair step

* remove unnecessary bool casts

* add empty checks to Items::is* methods

* update migration to use native sql instead of the querybuilder

* don't cast the flags manually, let the api do the work
2017-08-14 10:34:53 +02:00
Daniel Schaal
04f66c9710 Add updatedDate to item model (#81)
* Update picoFeed to v0.1.28

* Add updated_date to database and bump version to 10.1.1

* Add updatedDate to item model

* Check for updatedDate when updating a feed

* Fix unit test to check for newer updatedDate
2017-01-04 11:09:46 +01:00
Bernhard Posselt
8d63975360 revert 2016-10-02 18:05:49 +02:00