chylex/Nextcloud-News
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-News.git synced 2025-04-09 10:15:44 +02:00
Code

🩹 Patch ItemController + test to use ShareService

Browse Source 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
This commit is contained in:
Marco Nassabain 2021-03-04 00:16:19 +01:00 committed by Sean Molenaar
parent dd818c6203
commit 409c835433
2 changed files with 14 additions and 1 deletions
lib/Controller
ItemController.php
tests/Unit/Controller
ItemControllerTest.php

9
lib/Controller/ItemController.php
View File

@ -24,6 +24,7 @@ use \OCP\AppFramework\Http;
use \OCA\News\Service\Exceptions\ServiceException;
use \OCA\News\Service\Exceptions\ServiceNotFoundException;
use \OCA\News\Service\ItemServiceV2;
use \OCA\News\Service\ShareService;
use OCP\IUserSession;
/**
@ -43,6 +44,10 @@ class ItemController extends Controller
* @var FeedServiceV2
*/
private $feedService;
/**
* @var ShareService
*/
private $shareService;
/**
* @var IConfig
*/
@ -52,12 +57,14 @@ class ItemController extends Controller
IRequest $request,
FeedServiceV2 $feedService,
ItemServiceV2 $itemService,
ShareService $shareService,
IConfig $settings,
?IUserSession $userSession
) {
parent::__construct($request, $userSession);
$this->itemService = $itemService;
$this->feedService = $feedService;
$this->shareService = $shareService;
$this->settings = $settings;
}
@ -329,7 +336,7 @@ class ItemController extends Controller
public function share($itemId, $shareWithId)
{
try {
$this->itemService->share(
$this->shareService->share(
$this->getUserId(),
$itemId,
$shareWithId

6
tests/Unit/Controller/ItemControllerTest.php
View File

@ -16,6 +16,7 @@ namespace OCA\News\Tests\Unit\Controller;
use OCA\News\Controller\ItemController;
use OCA\News\Service\FeedServiceV2;
use OCA\News\Service\ItemServiceV2;
use OCA\News\Service\ShareService;
use \OCP\AppFramework\Http;
use \OCA\News\Db\Item;
@ -46,6 +47,10 @@ class ItemControllerTest extends TestCase
* @var \PHPUnit\Framework\MockObject\MockObject|FeedServiceV2
*/
private $feedService;
/**
* @var \PHPUnit\Framework\MockObject\MockObject|ShareService
*/
private $shareService;
/**
* @var \PHPUnit\Framework\MockObject\MockObject|IRequest
*/
@ -95,6 +100,7 @@ class ItemControllerTest extends TestCase
$this->request,
$this->feedService,
$this->itemService,
$this->shareService,
$this->settings,
$this->userSession
);