chylex/Nextcloud-News
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-News.git synced 2025-04-09 10:15:44 +02:00
Code

Fix favicon element making broken requests

Browse Source 
The markup for favicon `<img>` element in feed item used `src` instead of
`ng-src`, causing browser to make broken requests for
`.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D`

Changing the attribute to `ng-src` fixed that.

Signed-off-by: mormegil <mormegil@centrum.cz>
This commit is contained in:
mormegil 2021-08-20 14:27:09 +02:00 committed by Sean Molenaar
parent 0432d30e7b
commit 34c1f5c7a5
2 changed files with 2 additions and 1 deletions

1
CHANGELOG.md
View File

@ -12,6 +12,7 @@ The format is almost based on [Keep a Changelog](https://keepachangelog.com/en/1
### Fixed
- Set icon offset explicitly for navigation items
- Removed spurious requests for `.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D` (#1488)
## [15.x.x]
### Changed

2
templates/part.content.php
View File

@ -196,7 +196,7 @@
<span ng-if="!item.sharedBy" class="source"><?php p($l->t('from')) ?>
<a ng-href="#/items/feeds/{{ ::item.feedId }}/">
{{ ::Content.getFeed(item.feedId).title }}
<img ng-if="Content.getFeed(item.feedId).faviconLink && !Content.isCompactView()" src="{{ ::Content.getFeed(item.feedId).faviconLink }}" alt="favicon">
<img ng-if="Content.getFeed(item.feedId).faviconLink && !Content.isCompactView()" ng-src="{{ ::Content.getFeed(item.feedId).faviconLink }}" alt="favicon">
</a>
</span>
<span ng-if="item.sharedBy">