remove duplicate function

Signed-off-by: Paul Tirk <paultirk@paultirk.com>

lib/Controller/ItemApiController.php

@@ -231,7 +231,7 @@ class ItemApiController extends ApiController
     private function setStarredByItemId(int $itemId, bool $isStarred)
     {
         try {
-            $this->itemService->starByItemId($this->getUserId(), $itemId, $isStarred);
+            $this->itemService->star($this->getUserId(), $itemId, $isStarred);
         } catch (ServiceNotFoundException $ex) {
             return $this->error($ex, Http::STATUS_NOT_FOUND);
         }

lib/Service/ItemServiceV2.php

@@ -211,32 +211,6 @@ class ItemServiceV2 extends Service
         return $this->mapper->update($item);
     }
 
-    /**
-     * Mark an item as starred by id
-     *
-     * @param string $userId Item owner
-     * @param int $itemId
-     * @param bool   $starred
-     *
-     * @return Item
-     * @throws ServiceConflictException
-     * @throws ServiceNotFoundException
-     */
-    public function starByItemId(string $userId, int $itemId, bool $starred): Entity
-    {
-        try {
-            $item = $this->mapper->findFromUser($userId, $itemId);
-        } catch (DoesNotExistException $ex) {
-            throw ServiceNotFoundException::from($ex);
-        } catch (MultipleObjectsReturnedException $ex) {
-            throw ServiceConflictException::from($ex);
-        }
-
-        $item->setStarred($starred);
-
-        return $this->mapper->update($item);
-    }
-
     /**
      * Mark all items as read
      *

tests/Unit/Controller/ItemApiControllerTest.php

@@ -502,7 +502,7 @@ class ItemApiControllerTest extends TestCase
     public function testStarByItemId()
     {
         $this->itemService->expects($this->once())
-            ->method('starByItemId')
+            ->method('star')
             ->with($this->uid, 123, true);
 
         $this->class->starByItemId(123);
@@ -512,7 +512,7 @@ class ItemApiControllerTest extends TestCase
     public function testUnstarByItemId()
     {
         $this->itemService->expects($this->once())
-            ->method('starByItemId')
+            ->method('star')
             ->with($this->uid, 123, false);
 
         $this->class->unstarByItemId(123);