Add "servermods" folder to ignored folders in backups

.gitignore

@@ -192,6 +192,7 @@ ClientBin/
 *.dbmdl
 *.dbproj.schemaview
 *.jfm
+*.pfx
 *.publishsettings
 orleans.codegen.cs
 

.run/Agent 1.run.xml

@@ -5,7 +5,7 @@
     <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/.workdir/Agent1" />
     <option name="PASS_PARENT_ENVS" value="1" />
     <envs>
-      <env name="AGENT_KEY" value="K5ZRZYYJ9GWM2FS6XH5N5QQ7WZRPNDGHYMN5QP7RP6PPY27KRPMSYGCN" />
+      <env name="AGENT_KEY" value="JXBQQYG5T267RQS75MXWBTCJZY5CKTCCGQY22MCZPHSQQSJYCHH2NG2TCNXQY6TBSXM9NQDRS2CMX" />
       <env name="AGENT_NAME" value="Agent 1" />
       <env name="ALLOWED_RCON_PORTS" value="25575,27000,27001" />
       <env name="ALLOWED_SERVER_PORTS" value="25565,26000,26001" />
@@ -15,19 +15,14 @@
       <env name="MAX_MEMORY" value="12G" />
     </envs>
     <option name="USE_EXTERNAL_CONSOLE" value="0" />
-    <option name="ENV_FILE_PATHS" value="" />
-    <option name="REDIRECT_INPUT_PATH" value="" />
-    <option name="PTY_MODE" value="Auto" />
     <option name="USE_MONO" value="0" />
     <option name="RUNTIME_ARGUMENTS" value="" />
-    <option name="AUTO_ATTACH_CHILDREN" value="0" />
-    <option name="MIXED_MODE_DEBUG" value="0" />
     <option name="PROJECT_PATH" value="$PROJECT_DIR$/Agent/Phantom.Agent/Phantom.Agent.csproj" />
     <option name="PROJECT_EXE_PATH_TRACKING" value="1" />
     <option name="PROJECT_ARGUMENTS_TRACKING" value="1" />
     <option name="PROJECT_WORKING_DIRECTORY_TRACKING" value="0" />
     <option name="PROJECT_KIND" value="DotNetCore" />
-    <option name="PROJECT_TFM" value="net9.0" />
+    <option name="PROJECT_TFM" value="net8.0" />
     <method v="2">
       <option name="Build" />
     </method>

.run/Agent 2.run.xml

@@ -5,7 +5,7 @@
     <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/.workdir/Agent2" />
     <option name="PASS_PARENT_ENVS" value="1" />
     <envs>
-      <env name="AGENT_KEY" value="K5ZRZYYJ9GWM2FS6XH5N5QQ7WZRPNDGHYMN5QP7RP6PPY27KRPMSYGCN" />
+      <env name="AGENT_KEY" value="JXBQQYG5T267RQS75MXWBTCJZY5CKTCCGQY22MCZPHSQQSJYCHH2NG2TCNXQY6TBSXM9NQDRS2CMX" />
       <env name="AGENT_NAME" value="Agent 2" />
       <env name="ALLOWED_RCON_PORTS" value="27002-27006" />
       <env name="ALLOWED_SERVER_PORTS" value="26002-26006" />
@@ -15,19 +15,14 @@
       <env name="MAX_MEMORY" value="10G" />
     </envs>
     <option name="USE_EXTERNAL_CONSOLE" value="0" />
-    <option name="ENV_FILE_PATHS" value="" />
-    <option name="REDIRECT_INPUT_PATH" value="" />
-    <option name="PTY_MODE" value="Auto" />
     <option name="USE_MONO" value="0" />
     <option name="RUNTIME_ARGUMENTS" value="" />
-    <option name="AUTO_ATTACH_CHILDREN" value="0" />
-    <option name="MIXED_MODE_DEBUG" value="0" />
     <option name="PROJECT_PATH" value="$PROJECT_DIR$/Agent/Phantom.Agent/Phantom.Agent.csproj" />
     <option name="PROJECT_EXE_PATH_TRACKING" value="1" />
     <option name="PROJECT_ARGUMENTS_TRACKING" value="1" />
     <option name="PROJECT_WORKING_DIRECTORY_TRACKING" value="0" />
     <option name="PROJECT_KIND" value="DotNetCore" />
-    <option name="PROJECT_TFM" value="net9.0" />
+    <option name="PROJECT_TFM" value="net8.0" />
     <method v="2">
       <option name="Build" />
     </method>

.run/Agent 3.run.xml

@@ -5,7 +5,7 @@
     <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/.workdir/Agent3" />
     <option name="PASS_PARENT_ENVS" value="1" />
     <envs>
-      <env name="AGENT_KEY" value="K5ZRZYYJ9GWM2FS6XH5N5QQ7WZRPNDGHYMN5QP7RP6PPY27KRPMSYGCN" />
+      <env name="AGENT_KEY" value="JXBQQYG5T267RQS75MXWBTCJZY5CKTCCGQY22MCZPHSQQSJYCHH2NG2TCNXQY6TBSXM9NQDRS2CMX" />
       <env name="AGENT_NAME" value="Agent 3" />
       <env name="ALLOWED_RCON_PORTS" value="27007" />
       <env name="ALLOWED_SERVER_PORTS" value="26007" />
@@ -15,19 +15,14 @@
       <env name="MAX_MEMORY" value="2560M" />
     </envs>
     <option name="USE_EXTERNAL_CONSOLE" value="0" />
-    <option name="ENV_FILE_PATHS" value="" />
-    <option name="REDIRECT_INPUT_PATH" value="" />
-    <option name="PTY_MODE" value="Auto" />
     <option name="USE_MONO" value="0" />
     <option name="RUNTIME_ARGUMENTS" value="" />
-    <option name="AUTO_ATTACH_CHILDREN" value="0" />
-    <option name="MIXED_MODE_DEBUG" value="0" />
     <option name="PROJECT_PATH" value="$PROJECT_DIR$/Agent/Phantom.Agent/Phantom.Agent.csproj" />
     <option name="PROJECT_EXE_PATH_TRACKING" value="1" />
     <option name="PROJECT_ARGUMENTS_TRACKING" value="1" />
     <option name="PROJECT_WORKING_DIRECTORY_TRACKING" value="0" />
     <option name="PROJECT_KIND" value="DotNetCore" />
-    <option name="PROJECT_TFM" value="net9.0" />
+    <option name="PROJECT_TFM" value="net8.0" />
     <method v="2">
       <option name="Build" />
     </method>

.run/Controller.run.xml

@@ -14,19 +14,14 @@
       <env name="WEB_RPC_SERVER_HOST" value="localhost" />
     </envs>
     <option name="USE_EXTERNAL_CONSOLE" value="0" />
-    <option name="ENV_FILE_PATHS" value="" />
-    <option name="REDIRECT_INPUT_PATH" value="" />
-    <option name="PTY_MODE" value="Auto" />
     <option name="USE_MONO" value="0" />
     <option name="RUNTIME_ARGUMENTS" value="" />
-    <option name="AUTO_ATTACH_CHILDREN" value="0" />
-    <option name="MIXED_MODE_DEBUG" value="0" />
     <option name="PROJECT_PATH" value="$PROJECT_DIR$/Controller/Phantom.Controller/Phantom.Controller.csproj" />
     <option name="PROJECT_EXE_PATH_TRACKING" value="1" />
     <option name="PROJECT_ARGUMENTS_TRACKING" value="1" />
     <option name="PROJECT_WORKING_DIRECTORY_TRACKING" value="0" />
     <option name="PROJECT_KIND" value="DotNetCore" />
-    <option name="PROJECT_TFM" value="net9.0" />
+    <option name="PROJECT_TFM" value="net8.0" />
     <method v="2">
       <option name="Build" />
     </method>

.run/Web.run.xml

@@ -7,23 +7,18 @@
     <envs>
       <env name="ASPNETCORE_ENVIRONMENT" value="Development" />
       <env name="CONTROLLER_HOST" value="localhost" />
-      <env name="WEB_KEY" value="T5Y722D2GZBXT2H27QS95P2YQRFB2GCTKHSWT5CZFDTFKW52TCM9GDRW" />
+      <env name="WEB_KEY" value="BMNHM9RRPMCBBY29D9XHS6KBKZSRY7F5XFN27YZX96XXWJC2NM2D6YRHM9PZN9JGQGCSJ6FMB2GGZ" />
       <env name="WEB_SERVER_HOST" value="localhost" />
     </envs>
     <option name="USE_EXTERNAL_CONSOLE" value="0" />
-    <option name="ENV_FILE_PATHS" value="" />
-    <option name="REDIRECT_INPUT_PATH" value="" />
-    <option name="PTY_MODE" value="Auto" />
     <option name="USE_MONO" value="0" />
     <option name="RUNTIME_ARGUMENTS" value="" />
-    <option name="AUTO_ATTACH_CHILDREN" value="0" />
-    <option name="MIXED_MODE_DEBUG" value="0" />
     <option name="PROJECT_PATH" value="$PROJECT_DIR$/Web/Phantom.Web/Phantom.Web.csproj" />
     <option name="PROJECT_EXE_PATH_TRACKING" value="1" />
     <option name="PROJECT_ARGUMENTS_TRACKING" value="1" />
     <option name="PROJECT_WORKING_DIRECTORY_TRACKING" value="0" />
     <option name="PROJECT_KIND" value="DotNetCore" />
-    <option name="PROJECT_TFM" value="net9.0" />
+    <option name="PROJECT_TFM" value="net8.0" />
     <method v="2">
       <option name="Build" />
     </method>

.workdir/Controller/secrets/agent.auth

@@ -1 +0,0 @@
-满<EFBFBD>H<EFBFBD>c<EFBFBD>og<EFBFBD>

.workdir/Controller/secrets/agent.secret

@@ -0,0 +1 @@
+<EFBFBD>Z<EFBFBD>t<>MPI<49>GMZ<4D><5A><EFBFBD><EFBFBD>kN<6B>VF1X<><58>p

.workdir/Controller/secrets/web.auth

@@ -1 +0,0 @@
-<07>U<EFBFBD>/<2F><04><><EFBFBD>q

.workdir/Controller/secrets/web.key

@@ -0,0 +1,2 @@
+<EFBFBD><EFBFBD>h?Ο<05>Bx
+<02>

.workdir/Controller/secrets/web.secret

@@ -0,0 +1 @@
+T<EFBFBD>./g<11><>N<EFBFBD><4E>t<EFBFBD>$<24>!<21>(<28><>#<23>~<7E><>}<14><:

Agent/Phantom.Agent.Minecraft.Tests/Java/JavaPropertiesStreamTests.cs

@@ -1,289 +0,0 @@
-using System.Collections.Immutable;
-using NUnit.Framework;
-using Phantom.Agent.Minecraft.Java;
-using Phantom.Utils.Collections;
-
-namespace Phantom.Agent.Minecraft.Tests.Java;
-
-[TestFixture]
-public sealed class JavaPropertiesStreamTests {
-	public sealed class Reader {
-		private static async Task<ImmutableArray<KeyValuePair<string, string>>> Parse(string contents) {
-			using var stream = new MemoryStream(JavaPropertiesStream.Encoding.GetBytes(contents));
-			using var properties = new JavaPropertiesStream.Reader(stream);
-			return await properties.ReadProperties(CancellationToken.None).ToImmutableArrayAsync();
-		}
-		
-		private static ImmutableArray<KeyValuePair<string, string>> KeyValue(string key, string value) {
-			return [new KeyValuePair<string, string>(key, value)];
-		}
-		
-		[TestCase("")]
-		[TestCase("\n")]
-		public async Task EmptyLinesAreIgnored(string contents) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(ImmutableArray<KeyValuePair<string, string>>.Empty));
-		}
-		
-		[TestCase("# Comment")]
-		[TestCase("! Comment")]
-		[TestCase("# Comment\n! Comment")]
-		public async Task CommentsAreIgnored(string contents) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(ImmutableArray<KeyValuePair<string, string>>.Empty));
-		}
-		
-		[TestCase("key=value")]
-		[TestCase("key= value")]
-		[TestCase("key =value")]
-		[TestCase("key = value")]
-		[TestCase("key:value")]
-		[TestCase("key: value")]
-		[TestCase("key :value")]
-		[TestCase("key : value")]
-		[TestCase("key value")]
-		[TestCase("key\tvalue")]
-		[TestCase("key\fvalue")]
-		[TestCase("key \t\fvalue")]
-		public async Task SimpleKeyValue(string contents) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue("key", "value")));
-		}
-		
-		[TestCase("key")]
-		[TestCase(" key")]
-		[TestCase(" key ")]
-		[TestCase("key=")]
-		[TestCase("key:")]
-		public async Task KeyWithoutValue(string contents) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue("key", "")));
-		}
-		
-		[TestCase(@"\#key=value", "#key")]
-		[TestCase(@"\!key=value", "!key")]
-		public async Task KeyBeginsWithEscapedComment(string contents, string expectedKey) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue(expectedKey, "value")));
-		}
-		
-		[TestCase(@"\=key=value", "=key")]
-		[TestCase(@"\:key=value", ":key")]
-		[TestCase(@"\ key=value", " key")]
-		[TestCase("\\\tkey=value", "\tkey")]
-		[TestCase("\\\fkey=value", "\fkey")]
-		public async Task KeyBeginsWithEscapedDelimiter(string contents, string expectedKey) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue(expectedKey, "value")));
-		}
-		
-		[TestCase(@"start\=end=value", "start=end")]
-		[TestCase(@"start\:end:value", "start:end")]
-		[TestCase(@"start\ end value", "start end")]
-		[TestCase(@"start\ \:\=end = value", "start :=end")]
-		[TestCase("start\\ \\\t\\\fend = value", "start \t\fend")]
-		public async Task KeyContainsEscapedDelimiter(string contents, string expectedKey) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue(expectedKey, "value")));
-		}
-		
-		[TestCase(@"key = \ value", " value")]
-		[TestCase("key = \\\tvalue", "\tvalue")]
-		[TestCase("key = \\\fvalue", "\fvalue")]
-		[TestCase("key=\\ \\\t\\\fvalue", " \t\fvalue")]
-		public async Task ValueBeginsWithEscapedWhitespace(string contents, string expectedValue) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue("key", expectedValue)));
-		}
-		
-		[TestCase(@"key = value\", "value")]
-		public async Task ValueEndsWithTrailingBackslash(string contents, string expectedValue) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue("key", expectedValue)));
-		}
-		
-		[TestCase("key=\\\0", "\0")]
-		[TestCase(@"key=\\", "\\")]
-		[TestCase(@"key=\t", "\t")]
-		[TestCase(@"key=\n", "\n")]
-		[TestCase(@"key=\r", "\r")]
-		[TestCase(@"key=\f", "\f")]
-		[TestCase(@"key=\u3053\u3093\u306b\u3061\u306f", "こんにちは")]
-		[TestCase(@"key=\u3053\u3093\u306B\u3061\u306F", "こんにちは")]
-		[TestCase("key=\\\0\\\\\\t\\n\\r\\f\\u3053", "\0\\\t\n\r\fこ")]
-		public async Task ValueContainsEscapedSpecialCharacters(string contents, string expectedValue) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue("key", expectedValue)));
-		}
-		
-		[TestCase("key=first\\\nsecond", "first\nsecond")]
-		[TestCase("key=first\\\n    second", "first\nsecond")]
-		[TestCase("key=first\\\n#second", "first\n#second")]
-		[TestCase("key=first\\\n!second", "first\n!second")]
-		public async Task ValueContainsNewLine(string contents, string expectedValue) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue("key", expectedValue)));
-		}
-		
-		[TestCase("key=first\\\n    \\ second", "first\n second")]
-		[TestCase("key=first\\\n    \\\tsecond", "first\n\tsecond")]
-		[TestCase("key=first\\\n    \\\fsecond", "first\n\fsecond")]
-		[TestCase("key=first\\\n \t\f\\ second", "first\n second")]
-		public async Task ValueContainsNewLineWithEscapedLeadingWhitespace(string contents, string expectedValue) {
-			Assert.That(await Parse(contents), Is.EquivalentTo(KeyValue("key", expectedValue)));
-		}
-		
-		[Test]
-		public async Task ExampleFile() {
-			// From Wikipedia: https://en.wikipedia.org/wiki/.properties
-			const string ExampleFile = """
-			                           # You are reading a comment in ".properties" file.
-			                           ! The exclamation mark ('!') can also be used for comments.
-			                           # Comments are ignored.
-			                           # Blank lines are also ignored.
-			                           
-			                           # Lines with "properties" contain a key and a value separated by a delimiting character.
-			                           # There are 3 delimiting characters: equal ('='), colon (':') and whitespace (' ', '\t' and '\f').
-			                           website = https://en.wikipedia.org/
-			                           language : English
-			                           topic .properties files
-			                           # A word on a line will just create a key with no value.
-			                           empty
-			                           # Whitespace that appears between the key, the delimiter and the value is ignored.
-			                           # This means that the following are equivalent (other than for readability).
-			                           hello=hello
-			                           hello = hello
-			                           # To start the value with whitespace, escape it with a backslash ('\').
-			                           whitespaceStart = \ <-This space is not ignored.
-			                           # Keys with the same name will be overwritten by the key that is the furthest in a file.
-			                           # For example the final value for "duplicateKey" will be "second".
-			                           duplicateKey = first
-			                           duplicateKey = second
-			                           # To use the delimiter characters inside a key, you need to escape them with a ('\').
-			                           # However, there is no need to do this in the value.
-			                           delimiterCharacters\:\=\ = This is the value for the key "delimiterCharacters\:\=\ "
-			                           # Adding a backslash ('\') at the end of a line means that the value continues on the next line.
-			                           multiline = This line \
-			                           continues
-			                           # If you want your value to include a backslash ('\'), it should be escaped by another backslash ('\').
-			                           path = c:\\wiki\\templates
-			                           # This means that if the number of backslashes ('\') at the end of the line is even, the next line is not included in the value. 
-			                           # In the following example, the value for "evenKey" is "This is on one line\".
-			                           evenKey = This is on one line\\
-			                           # This line is a normal comment and is not included in the value for "evenKey".
-			                           # If the number of backslash ('\') is odd, then the next line is included in the value.
-			                           # In the following example, the value for "oddKey" is "This is line one and\# This is line two".
-			                           oddKey = This is line one and\\\
-			                           # This is line two
-			                           # Whitespace characters at the beginning of a line is removed.
-			                           # Make sure to add the spaces you need before the backslash ('\') on the first line. 
-			                           # If you add them at the beginning of the next line, they will be removed.
-			                           # In the following example, the value for "welcome" is "Welcome to Wikipedia!".
-			                           welcome = Welcome to \
-			                                     Wikipedia!
-			                           # If you need to add newlines and carriage returns, they need to be escaped using ('\n') and ('\r') respectively.
-			                           # You can also optionally escape tabs with ('\t') for readability purposes.
-			                           valueWithEscapes = This is a newline\n and a carriage return\r and a tab\t.
-			                           # You can also use Unicode escape characters (maximum of four hexadecimal digits).
-			                           # In the following example, the value for "encodedHelloInJapanese" is "こんにちは".
-			                           encodedHelloInJapanese = \u3053\u3093\u306b\u3061\u306f
-			                           """;
-			
-			ImmutableArray<KeyValuePair<string, string>> result = [
-				new ("website", "https://en.wikipedia.org/"),
-				new ("language", "English"),
-				new ("topic", ".properties files"),
-				new ("empty", ""),
-				new ("hello", "hello"),
-				new ("hello", "hello"),
-				new ("whitespaceStart", @" <-This space is not ignored."),
-				new ("duplicateKey", "first"),
-				new ("duplicateKey", "second"),
-				new ("delimiterCharacters:= ", @"This is the value for the key ""delimiterCharacters:= """),
-				new ("multiline", "This line \ncontinues"),
-				new ("path", @"c:\wiki\templates"),
-				new ("evenKey", @"This is on one line\"),
-				new ("oddKey", "This is line one and\\\n# This is line two"),
-				new ("welcome", "Welcome to \nWikipedia!"),
-				new ("valueWithEscapes", "This is a newline\n and a carriage return\r and a tab\t."),
-				new ("encodedHelloInJapanese", "こんにちは"),
-			];
-			
-			Assert.That(await Parse(ExampleFile), Is.EquivalentTo(result));
-		}
-	}
-	
-	public sealed class Writer {
-		private static async Task<string> Write(Func<JavaPropertiesStream.Writer, Task> write) {
-			using var stream = new MemoryStream();
-			
-			await using (var writer = new JavaPropertiesStream.Writer(stream)) {
-				await write(writer);
-			}
-			
-			return JavaPropertiesStream.Encoding.GetString(stream.ToArray());
-		}
-		
-		[TestCase("one line comment", "# one line comment\n")]
-		[TestCase("こんにちは", "# \\u3053\\u3093\\u306B\\u3061\\u306F\n")]
-		[TestCase("first line\nsecond line\r\nthird line", "# first line\n# second line\n# third line\n")]
-		public async Task Comment(string comment, string contents) {
-			Assert.That(await Write(writer => writer.WriteComment(comment, CancellationToken.None)), Is.EqualTo(contents));
-		}
-		
-		[TestCase("key", "value", "key=value\n")]
-		[TestCase("key", "", "key=\n")]
-		[TestCase("", "value", "=value\n")]
-		public async Task SimpleKeyValue(string key, string value, string contents) {
-			Assert.That(await Write(writer => writer.WriteProperty(key, value, CancellationToken.None)), Is.EqualTo(contents));
-		}
-		
-		[TestCase("#key", "value", "\\#key=value\n")]
-		[TestCase("!key", "value", "\\!key=value\n")]
-		public async Task KeyBeginsWithEscapedComment(string key, string value, string contents) {
-			Assert.That(await Write(writer => writer.WriteProperty(key, value, CancellationToken.None)), Is.EqualTo(contents));
-		}
-		
-		[TestCase("=key", "value", "\\=key=value\n")]
-		[TestCase(":key", "value", "\\:key=value\n")]
-		[TestCase(" key", "value", "\\ key=value\n")]
-		[TestCase("\tkey", "value", "\\tkey=value\n")]
-		[TestCase("\fkey", "value", "\\fkey=value\n")]
-		public async Task KeyBeginsWithEscapedDelimiter(string key, string value, string contents) {
-			Assert.That(await Write(writer => writer.WriteProperty(key, value, CancellationToken.None)), Is.EqualTo(contents));
-		}
-		
-		[TestCase("start=end", "value", "start\\=end=value\n")]
-		[TestCase("start:end", "value", "start\\:end=value\n")]
-		[TestCase("start end", "value", "start\\ end=value\n")]
-		[TestCase("start :=end", "value", "start\\ \\:\\=end=value\n")]
-		[TestCase("start \t\fend", "value", "start\\ \\t\\fend=value\n")]
-		public async Task KeyContainsEscapedDelimiter(string key, string value, string contents) {
-			Assert.That(await Write(writer => writer.WriteProperty(key, value, CancellationToken.None)), Is.EqualTo(contents));
-		}
-		
-		[TestCase("\\", "value", "\\\\=value\n")]
-		[TestCase("\t", "value", "\\t=value\n")]
-		[TestCase("\n", "value", "\\n=value\n")]
-		[TestCase("\r", "value", "\\r=value\n")]
-		[TestCase("\f", "value", "\\f=value\n")]
-		[TestCase("こんにちは", "value", "\\u3053\\u3093\\u306B\\u3061\\u306F=value\n")]
-		[TestCase("\\\t\n\r\fこ", "value", "\\\\\\t\\n\\r\\f\\u3053=value\n")]
-		[TestCase("first-line\nsecond-line\r\nthird-line", "value", "first-line\\nsecond-line\\r\\nthird-line=value\n")]
-		public async Task KeyContainsEscapedSpecialCharacters(string key, string value, string contents) {
-			Assert.That(await Write(writer => writer.WriteProperty(key, value, CancellationToken.None)), Is.EqualTo(contents));
-		}
-		
-		[TestCase("key", "\\", "key=\\\\\n")]
-		[TestCase("key", "\t", "key=\\t\n")]
-		[TestCase("key", "\n", "key=\\n\n")]
-		[TestCase("key", "\r", "key=\\r\n")]
-		[TestCase("key", "\f", "key=\\f\n")]
-		[TestCase("key", "こんにちは", "key=\\u3053\\u3093\\u306B\\u3061\\u306F\n")]
-		[TestCase("key", "\\\t\n\r\fこ", "key=\\\\\\t\\n\\r\\f\\u3053\n")]
-		[TestCase("key", "first line\nsecond line\r\nthird line", "key=first line\\nsecond line\\r\\nthird line\n")]
-		public async Task ValueContainsEscapedSpecialCharacters(string key, string value, string contents) {
-			Assert.That(await Write(writer => writer.WriteProperty(key, value, CancellationToken.None)), Is.EqualTo(contents));
-		}
-		
-		[Test]
-		public async Task ExampleFile() {
-			string contents = await Write(static async writer => {
-				await writer.WriteComment("Comment", CancellationToken.None);
-				await writer.WriteProperty("key", "value", CancellationToken.None);
-				await writer.WriteProperty("multiline", "first line\nsecond line", CancellationToken.None);
-			});
-			
-			Assert.That(contents, Is.EqualTo("# Comment\nkey=value\nmultiline=first line\\nsecond line\n"));
-		}
-	}
-}

Agent/Phantom.Agent.Minecraft.Tests/Phantom.Agent.Minecraft.Tests.csproj

@@ -1,23 +0,0 @@
-<Project Sdk="Microsoft.NET.Sdk">
-  
-  <PropertyGroup>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
-  
-  <PropertyGroup>
-    <IsPackable>false</IsPackable>
-  </PropertyGroup>
-  
-  <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" />
-    <PackageReference Include="NUnit" />
-    <PackageReference Include="NUnit3TestAdapter" />
-    <PackageReference Include="NUnit.Analyzers" />
-  </ItemGroup>
-  
-  <ItemGroup>
-    <ProjectReference Include="..\Phantom.Agent.Minecraft\Phantom.Agent.Minecraft.csproj" />
-  </ItemGroup>
-
-</Project>

Agent/Phantom.Agent.Minecraft/Command/MinecraftCommand.cs

@@ -8,7 +8,7 @@ public static class MinecraftCommand {
 	public static string Say(string message) {
 		return "say " + message;
 	}
-	
+
 	public static string SaveAll(bool flush) {
 		return flush ? "save-all flush" : "save-all";
 	}

Agent/Phantom.Agent.Minecraft/Instance/InstanceProcess.cs

@@ -9,24 +9,24 @@ public sealed class InstanceProcess : IDisposable {
 	
 	private readonly RingBuffer<string> outputBuffer = new (100);
 	private event EventHandler<string>? OutputEvent;
-	
+
 	public event EventHandler? Ended;
 	public bool HasEnded { get; private set; }
-	
+
 	private readonly Process process;
 	private readonly TaskCompletionSource processExited = AsyncTasks.CreateCompletionSource();
-	
+
 	internal InstanceProcess(InstanceProperties instanceProperties, Process process) {
 		this.InstanceProperties = instanceProperties;
 		this.process = process;
 		this.process.Exited += ProcessOnExited;
 		this.process.OutputReceived += ProcessOutputReceived;
 	}
-	
+
 	public async Task SendCommand(string command, CancellationToken cancellationToken) {
 		await process.StandardInput.WriteLineAsync(command.AsMemory(), cancellationToken);
 	}
-	
+
 	public void AddOutputListener(EventHandler<string> listener, uint maxLinesToReadFromHistory = uint.MaxValue) {
 		OutputEvent += listener;
 		
@@ -34,31 +34,31 @@ public sealed class InstanceProcess : IDisposable {
 			listener(this, line);
 		}
 	}
-	
+
 	public void RemoveOutputListener(EventHandler<string> listener) {
 		OutputEvent -= listener;
 	}
-	
+
 	private void ProcessOutputReceived(object? sender, Process.Output output) {
 		outputBuffer.Add(output.Line);
 		OutputEvent?.Invoke(this, output.Line);
 	}
-	
+
 	private void ProcessOnExited(object? sender, EventArgs e) {
 		OutputEvent = null;
 		HasEnded = true;
 		Ended?.Invoke(this, EventArgs.Empty);
 		processExited.SetResult();
 	}
-	
+
 	public void Kill() {
 		process.Kill(true);
 	}
-	
+
 	public async Task WaitForExit(TimeSpan timeout) {
 		await processExited.Task.WaitAsync(timeout);
 	}
-	
+
 	public void Dispose() {
 		process.Dispose();
 		OutputEvent = null;

Agent/Phantom.Agent.Minecraft/Java/JavaPropertiesFileEditor.cs

@@ -1,52 +1,92 @@
-namespace Phantom.Agent.Minecraft.Java;
+using System.Text;
+using Kajabity.Tools.Java;
+
+namespace Phantom.Agent.Minecraft.Java;
 
 sealed class JavaPropertiesFileEditor {
+	private static readonly Encoding Encoding = Encoding.GetEncoding("ISO-8859-1");
+
 	private readonly Dictionary<string, string> overriddenProperties = new ();
-	
+
 	public void Set(string key, string value) {
 		overriddenProperties[key] = value;
 	}
-	
+
-	public async Task EditOrCreate(string filePath, string comment, CancellationToken cancellationToken) {
+	public async Task EditOrCreate(string filePath) {
 		if (File.Exists(filePath)) {
 			string tmpFilePath = filePath + ".tmp";
-			await Edit(filePath, tmpFilePath, comment, cancellationToken);
+			File.Copy(filePath, tmpFilePath, overwrite: true);
+			await EditFromCopyOrCreate(filePath, tmpFilePath);
 			File.Move(tmpFilePath, filePath, overwrite: true);
 		}
 		else {
-			await Create(filePath, comment, cancellationToken);
+			await EditFromCopyOrCreate(null, filePath);
 		}
 	}
-	
+
-	private async Task Create(string targetFilePath, string comment, CancellationToken cancellationToken) {
+	private async Task EditFromCopyOrCreate(string? sourceFilePath, string targetFilePath) {
-		await using var targetWriter = new JavaPropertiesStream.Writer(targetFilePath);
+		var properties = new JavaProperties();
-		
+
-		await targetWriter.WriteComment(comment, cancellationToken);
+		if (sourceFilePath != null) {
-		
+			// TODO replace with custom async parser
-		foreach ((string key, string value) in overriddenProperties) {
+			await using var sourceStream = new FileStream(sourceFilePath, FileMode.Open, FileAccess.Read, FileShare.Read);
-			await targetWriter.WriteProperty(key, value, cancellationToken);
+			properties.Load(sourceStream, Encoding);
+		}
+
+		foreach (var (key, value) in overriddenProperties) {
+			properties[key] = value;
+		}
+
+		await using var targetStream = new FileStream(targetFilePath, FileMode.Create, FileAccess.Write, FileShare.Read);
+		await using var targetWriter = new StreamWriter(targetStream, Encoding);
+
+		await targetWriter.WriteLineAsync("# Properties");
+
+		foreach (var (key, value) in properties) {
+			await WriteProperty(targetWriter, key, value);
 		}
 	}
-	
+
-	private async Task Edit(string sourceFilePath, string targetFilePath, string comment, CancellationToken cancellationToken) {
+	private static async Task WriteProperty(StreamWriter writer, string key, string value) {
-		using var sourceReader = new JavaPropertiesStream.Reader(sourceFilePath);
+		await WritePropertyComponent(writer, key, escapeSpaces: true);
-		await using var targetWriter = new JavaPropertiesStream.Writer(targetFilePath);
+		await writer.WriteAsync('=');
-		
+		await WritePropertyComponent(writer, value, escapeSpaces: false);
-		await targetWriter.WriteComment(comment, cancellationToken);
+		await writer.WriteLineAsync();
-		
+	}
-		var remainingOverriddenPropertyKeys = new HashSet<string>(overriddenProperties.Keys);
+
-		
+	private static async Task WritePropertyComponent(TextWriter writer, string component, bool escapeSpaces) {
-		await foreach ((string key, string value) in sourceReader.ReadProperties(cancellationToken)) {
+		for (int index = 0; index < component.Length; index++) {
-			if (remainingOverriddenPropertyKeys.Remove(key)) {
+			var c = component[index];
-				await targetWriter.WriteProperty(key, overriddenProperties[key], cancellationToken);
+			switch (c) {
+				case '\\':
+				case '#':
+				case '!':
+				case '=':
+				case ':':
+				case ' ' when escapeSpaces || index == 0:
+					await writer.WriteAsync('\\');
+					await writer.WriteAsync(c);
+					break;
+				case var _ when c > 31 && c < 127:
+					await writer.WriteAsync(c);
+					break;
+				case '\t':
+					await writer.WriteAsync("\\t");
+					break;
+				case '\n':
+					await writer.WriteAsync("\\n");
+					break;
+				case '\r':
+					await writer.WriteAsync("\\r");
+					break;
+				case '\f':
+					await writer.WriteAsync("\\f");
+					break;
+				default:
+					await writer.WriteAsync("\\u");
+					await writer.WriteAsync(((int) c).ToString("X4"));
+					break;
 			}
-			else {
-				await targetWriter.WriteProperty(key, value, cancellationToken);
-			}
-		}
-		
-		foreach (string key in remainingOverriddenPropertyKeys) {
-			await targetWriter.WriteProperty(key, overriddenProperties[key], cancellationToken);
 		}
 	}
 }

Agent/Phantom.Agent.Minecraft/Java/JavaPropertiesStream.cs

@@ -1,284 +0,0 @@
-using System.Buffers;
-using System.Globalization;
-using System.Runtime.CompilerServices;
-using System.Text;
-using Phantom.Utils.Collections;
-
-namespace Phantom.Agent.Minecraft.Java;
-
-static class JavaPropertiesStream {
-	internal static readonly Encoding Encoding = Encoding.GetEncoding("ISO-8859-1");
-	
-	private static FileStreamOptions CreateFileStreamOptions(FileMode mode, FileAccess access) {
-		return new FileStreamOptions {
-			Mode = mode,
-			Access = access,
-			Share = FileShare.Read,
-			Options = FileOptions.SequentialScan,
-		};
-	}
-	
-	internal sealed class Reader : IDisposable {
-		private static readonly SearchValues<char> LineStartWhitespace = SearchValues.Create(' ', '\t', '\f');
-		private static readonly SearchValues<char> KeyValueDelimiter = SearchValues.Create('=', ':', ' ', '\t', '\f');
-		private static readonly SearchValues<char> Backslash = SearchValues.Create('\\');
-		
-		private readonly StreamReader reader;
-		
-		public Reader(Stream stream) {
-			this.reader = new StreamReader(stream, Encoding, leaveOpen: false);
-		}
-		
-		public Reader(string path) {
-			this.reader = new StreamReader(path, Encoding, detectEncodingFromByteOrderMarks: false, CreateFileStreamOptions(FileMode.Open, FileAccess.Read));
-		}
-		
-		public async IAsyncEnumerable<KeyValuePair<string, string>> ReadProperties([EnumeratorCancellation] CancellationToken cancellationToken) {
-			await foreach (string line in ReadLogicalLines(cancellationToken)) {
-				yield return ParseLine(line.AsSpan());
-			}
-		}
-		
-		private async IAsyncEnumerable<string> ReadLogicalLines([EnumeratorCancellation] CancellationToken cancellationToken) {
-			StringBuilder nextLogicalLine = new StringBuilder();
-			
-			while (await reader.ReadLineAsync(cancellationToken) is {} line) {
-				var span = line.AsSpan();
-				int startIndex = span.IndexOfAnyExcept(LineStartWhitespace);
-				if (startIndex == -1) {
-					continue;
-				}
-				
-				if (nextLogicalLine.Length == 0 && (span[0] == '#' || span[0] == '!')) {
-					continue;
-				}
-				
-				span = span[startIndex..];
-				
-				if (IsEndEscaped(span)) {
-					nextLogicalLine.Append(span[..^1]);
-					nextLogicalLine.Append('\n');
-				}
-				else {
-					nextLogicalLine.Append(span);
-					yield return nextLogicalLine.ToString();
-					nextLogicalLine.Clear();
-				}
-			}
-			
-			if (nextLogicalLine.Length > 0) {
-				yield return nextLogicalLine.ToString(startIndex: 0, nextLogicalLine.Length - 1); // Remove trailing new line.
-			}
-		}
-		
-		private static KeyValuePair<string, string> ParseLine(ReadOnlySpan<char> line) {
-			int delimiterIndex = -1;
-			
-			foreach (int candidateIndex in line.IndicesOf(KeyValueDelimiter)) {
-				if (candidateIndex == 0 || !IsEndEscaped(line[..candidateIndex])) {
-					delimiterIndex = candidateIndex;
-					break;
-				}
-			}
-			
-			if (delimiterIndex == -1) {
-				return new KeyValuePair<string, string>(line.ToString(), string.Empty);
-			}
-			
-			string key = ReadPropertyComponent(line[..delimiterIndex]);
-			
-			line = line[(delimiterIndex + 1)..];
-			int valueStartIndex = line.IndexOfAnyExcept(KeyValueDelimiter);
-			string value = valueStartIndex == -1 ? string.Empty : ReadPropertyComponent(line[valueStartIndex..]);
-			
-			return new KeyValuePair<string, string>(key, value);
-		}
-		
-		private static string ReadPropertyComponent(ReadOnlySpan<char> component) {
-			StringBuilder builder = new StringBuilder();
-			int nextStartIndex = 0;
-			
-			foreach (int backslashIndex in component.IndicesOf(Backslash)) {
-				if (backslashIndex == component.Length - 1) {
-					break;
-				}
-				
-				if (backslashIndex < nextStartIndex) {
-					continue;
-				}
-				
-				builder.Append(component[nextStartIndex..backslashIndex]);
-				
-				int escapedIndex = backslashIndex + 1;
-				int escapedLength = 1;
-				
-				char c = component[escapedIndex];
-				switch (c) {
-					case 't':
-						builder.Append('\t');
-						break;
-					
-					case 'n':
-						builder.Append('\n');
-						break;
-					
-					case 'r':
-						builder.Append('\r');
-						break;
-					
-					case 'f':
-						builder.Append('\f');
-						break;
-					
-					case 'u':
-						escapedLength += 4;
-						
-						int hexRangeStart = escapedIndex + 1;
-						int hexRangeEnd = hexRangeStart + 4;
-						
-						if (hexRangeEnd - 1 < component.Length) {
-							var hexString = component[hexRangeStart..hexRangeEnd];
-							int hexValue = int.Parse(hexString, NumberStyles.HexNumber);
-							builder.Append((char) hexValue);
-						}
-						else {
-							throw new FormatException("Malformed \\uxxxx encoding.");
-						}
-						
-						break;
-					
-					default:
-						builder.Append(c);
-						break;
-				}
-				
-				nextStartIndex = escapedIndex + escapedLength;
-			}
-			
-			builder.Append(component[nextStartIndex..]);
-			return builder.ToString();
-		}
-		
-		private static bool IsEndEscaped(ReadOnlySpan<char> span) {
-			if (span.EndsWith('\\')) {
-				int trailingBackslashCount = span.Length - span.TrimEnd('\\').Length;
-				return trailingBackslashCount % 2 == 1;
-			}
-			else {
-				return false;
-			}
-		}
-		
-		public void Dispose() {
-			reader.Dispose();
-		}
-	}
-	
-	internal sealed class Writer : IAsyncDisposable {
-		private const string CommentStart = "# ";
-		
-		private readonly StreamWriter writer;
-		private readonly Memory<char> oneCharBuffer = new char[1];
-		
-		public Writer(Stream stream) {
-			this.writer = new StreamWriter(stream, Encoding, leaveOpen: false);
-		}
-		
-		public Writer(string path) {
-			this.writer = new StreamWriter(path, Encoding, CreateFileStreamOptions(FileMode.Create, FileAccess.Write));
-		}
-		
-		public async Task WriteComment(string comment, CancellationToken cancellationToken) {
-			await Write(CommentStart, cancellationToken);
-			
-			for (int index = 0; index < comment.Length; index++) {
-				char c = comment[index];
-				switch (c) {
-					case var _ when c > 31 && c < 127:
-						await Write(c, cancellationToken);
-						break;
-					
-					case '\n':
-					case '\r':
-						await Write(c: '\n', cancellationToken);
-						await Write(CommentStart, cancellationToken);
-						
-						if (index < comment.Length - 1 && comment[index + 1] == '\n') {
-							index++;
-						}
-						
-						break;
-					
-					default:
-						await Write("\\u", cancellationToken);
-						await Write(((int) c).ToString("X4"), cancellationToken);
-						break;
-				}
-			}
-			
-			await Write(c: '\n', cancellationToken);
-		}
-		
-		public async Task WriteProperty(string key, string value, CancellationToken cancellationToken) {
-			await WritePropertyComponent(key, escapeSpaces: true, cancellationToken);
-			await Write(c: '=', cancellationToken);
-			await WritePropertyComponent(value, escapeSpaces: false, cancellationToken);
-			await Write(c: '\n', cancellationToken);
-		}
-		
-		private async Task WritePropertyComponent(string component, bool escapeSpaces, CancellationToken cancellationToken) {
-			for (int index = 0; index < component.Length; index++) {
-				char c = component[index];
-				switch (c) {
-					case '\\':
-					case '#':
-					case '!':
-					case '=':
-					case ':':
-					case ' ' when escapeSpaces || index == 0:
-						await Write(c: '\\', cancellationToken);
-						await Write(c, cancellationToken);
-						break;
-					
-					case var _ when c > 31 && c < 127:
-						await Write(c, cancellationToken);
-						break;
-					
-					case '\t':
-						await Write("\\t", cancellationToken);
-						break;
-					
-					case '\n':
-						await Write("\\n", cancellationToken);
-						break;
-					
-					case '\r':
-						await Write("\\r", cancellationToken);
-						break;
-					
-					case '\f':
-						await Write("\\f", cancellationToken);
-						break;
-					
-					default:
-						await Write("\\u", cancellationToken);
-						await Write(((int) c).ToString("X4"), cancellationToken);
-						break;
-				}
-			}
-		}
-		
-		private Task Write(char c, CancellationToken cancellationToken) {
-			oneCharBuffer.Span[0] = c;
-			return writer.WriteAsync(oneCharBuffer, cancellationToken);
-		}
-		
-		private Task Write(string value, CancellationToken cancellationToken) {
-			return writer.WriteAsync(value.AsMemory(), cancellationToken);
-		}
-		
-		public async ValueTask DisposeAsync() {
-			await writer.DisposeAsync();
-		}
-	}
-}

Agent/Phantom.Agent.Minecraft/Java/JavaRuntimeDiscovery.cs

@@ -1,7 +1,5 @@
 using System.Diagnostics;
-using System.Runtime.CompilerServices;
 using Phantom.Common.Data.Java;
-using Phantom.Utils.Collections;
 using Phantom.Utils.IO;
 using Phantom.Utils.Logging;
 using Serilog;
@@ -10,38 +8,35 @@ namespace Phantom.Agent.Minecraft.Java;
 
 public sealed class JavaRuntimeDiscovery {
 	private static readonly ILogger Logger = PhantomLogger.Create(nameof(JavaRuntimeDiscovery));
-	
+
 	public static string? GetSystemSearchPath() {
 		const string LinuxJavaPath = "/usr/lib/jvm";
-		
+
 		if (OperatingSystem.IsLinux() && Directory.Exists(LinuxJavaPath)) {
 			return LinuxJavaPath;
 		}
-		
+
 		return null;
 	}
-	
+
-	public static async Task<JavaRuntimeRepository> Scan(string folderPath, CancellationToken cancellationToken) {
+	public static IAsyncEnumerable<JavaRuntimeExecutable> Scan(string folderPath) {
-		var runtimes = await new JavaRuntimeDiscovery().ScanInternal(folderPath, cancellationToken).ToImmutableArrayAsync(cancellationToken);
+		return new JavaRuntimeDiscovery().ScanInternal(folderPath);
-		return new JavaRuntimeRepository(runtimes);
 	}
 	
 	private readonly Dictionary<string, int> duplicateDisplayNames = new ();
 	
-	private async IAsyncEnumerable<JavaRuntimeExecutable> ScanInternal(string folderPath, [EnumeratorCancellation] CancellationToken cancellationToken) {
+	private async IAsyncEnumerable<JavaRuntimeExecutable> ScanInternal(string folderPath) {
 		Logger.Information("Starting Java runtime scan in: {FolderPath}", folderPath);
-		
+
 		string javaExecutableName = OperatingSystem.IsWindows() ? "java.exe" : "java";
-		
+
 		foreach (var binFolderPath in Directory.EnumerateDirectories(Paths.ExpandTilde(folderPath), "bin", new EnumerationOptions {
 			MatchType = MatchType.Simple,
 			RecurseSubdirectories = true,
 			ReturnSpecialDirectories = false,
 			IgnoreInaccessible = true,
-			AttributesToSkip = FileAttributes.Hidden | FileAttributes.ReparsePoint | FileAttributes.System,
+			AttributesToSkip = FileAttributes.Hidden | FileAttributes.ReparsePoint | FileAttributes.System
 		}).Order()) {
-			cancellationToken.ThrowIfCancellationRequested();
-			
 			var javaExecutablePath = Paths.NormalizeSlashes(Path.Combine(binFolderPath, javaExecutableName));
 			
 			FileAttributes javaExecutableAttributes;
@@ -50,16 +45,16 @@ public sealed class JavaRuntimeDiscovery {
 			} catch (Exception) {
 				continue;
 			}
-			
+
 			if (javaExecutableAttributes.HasFlag(FileAttributes.ReparsePoint)) {
 				continue;
 			}
-			
+
 			Logger.Information("Found candidate Java executable: {JavaExecutablePath}", javaExecutablePath);
-			
+
 			JavaRuntime? foundRuntime;
 			try {
-				foundRuntime = await TryReadJavaRuntimeInformationFromProcess(javaExecutablePath, cancellationToken);
+				foundRuntime = await TryReadJavaRuntimeInformationFromProcess(javaExecutablePath);
 			} catch (OperationCanceledException) {
 				Logger.Error("Java process did not exit in time.");
 				continue;
@@ -67,18 +62,18 @@ public sealed class JavaRuntimeDiscovery {
 				Logger.Error(e, "Caught exception while reading Java version information.");
 				continue;
 			}
-			
+
 			if (foundRuntime == null) {
 				Logger.Error("Java executable did not output version information.");
 				continue;
 			}
-			
+
 			Logger.Information("Found Java {DisplayName} at: {Path}", foundRuntime.DisplayName, javaExecutablePath);
 			yield return new JavaRuntimeExecutable(javaExecutablePath, foundRuntime);
 		}
 	}
-	
+
-	private async Task<JavaRuntime?> TryReadJavaRuntimeInformationFromProcess(string javaExecutablePath, CancellationToken cancellationToken) {
+	private async Task<JavaRuntime?> TryReadJavaRuntimeInformationFromProcess(string javaExecutablePath) {
 		var startInfo = new ProcessStartInfo {
 			FileName = javaExecutablePath,
 			WorkingDirectory = Path.GetDirectoryName(javaExecutablePath),
@@ -86,39 +81,42 @@ public sealed class JavaRuntimeDiscovery {
 			RedirectStandardInput = false,
 			RedirectStandardOutput = false,
 			RedirectStandardError = true,
-			UseShellExecute = false,
+			UseShellExecute = false
 		};
-		
+
-		using var timeoutCancellationTokenSource = new CancellationTokenSource(TimeSpan.FromSeconds(5));
+		var process = new Process { StartInfo = startInfo };
-		using var combinedCancellationTokenSource = CancellationTokenSource.CreateLinkedTokenSource(timeoutCancellationTokenSource.Token, cancellationToken);
+		var cancellationTokenSource = new CancellationTokenSource(TimeSpan.FromSeconds(5));
-		
+
-		using var process = new Process();
+		try {
-		process.StartInfo = startInfo;
+			process.Start();
-		process.Start();
+
-		
+			JavaRuntimeBuilder runtimeBuilder = new ();
-		JavaRuntimeBuilder runtimeBuilder = new ();
+
-		
+			while (await process.StandardError.ReadLineAsync(cancellationTokenSource.Token) is {} line) {
-		while (await process.StandardError.ReadLineAsync(combinedCancellationTokenSource.Token) is {} line) {
+				ExtractJavaVersionPropertiesFromLine(line, runtimeBuilder);
-			ExtractJavaVersionPropertiesFromLine(line, runtimeBuilder);
+				
-			
+				JavaRuntime? runtime = runtimeBuilder.TryBuild(duplicateDisplayNames);
-			JavaRuntime? runtime = runtimeBuilder.TryBuild(duplicateDisplayNames);
+				if (runtime != null) {
-			if (runtime != null) {
+					return runtime;
-				return runtime;
+				}
 			}
+
+			await process.WaitForExitAsync(cancellationTokenSource.Token);
+			return null;
+		} finally {
+			process.Dispose();
+			cancellationTokenSource.Dispose();
 		}
-		
-		await process.WaitForExitAsync(combinedCancellationTokenSource.Token);
-		return null;
 	}
-	
+
 	private static void ExtractJavaVersionPropertiesFromLine(ReadOnlySpan<char> line, JavaRuntimeBuilder runtimeBuilder) {
 		line = line.TrimStart();
-		
+
 		int separatorIndex = line.IndexOf('=');
 		if (separatorIndex == -1) {
 			return;
 		}
-		
+
 		var propertyName = line[..separatorIndex].TrimEnd();
 		if (propertyName.Equals("java.specification.version", StringComparison.Ordinal)) {
 			runtimeBuilder.MainVersion = ExtractValue(line, separatorIndex);
@@ -130,16 +128,16 @@ public sealed class JavaRuntimeDiscovery {
 			runtimeBuilder.Vendor = ExtractValue(line, separatorIndex);
 		}
 	}
-	
+
 	private static string ExtractValue(ReadOnlySpan<char> line, int separatorIndex) {
 		return line[(separatorIndex + 1)..].Trim().ToString();
 	}
-	
+
 	private sealed class JavaRuntimeBuilder {
 		public string? MainVersion { get; set; } = null;
 		public string? FullVersion { get; set; } = null;
 		public string? Vendor { get; set; } = null;
-		
+
 		public JavaRuntime? TryBuild(Dictionary<string, int> duplicateDisplayNames) {
 			if (MainVersion == null || FullVersion == null || Vendor == null) {
 				return null;

Agent/Phantom.Agent.Minecraft/Java/JavaRuntimeExecutable.cs

@@ -2,4 +2,12 @@
 
 namespace Phantom.Agent.Minecraft.Java;
 
-sealed record JavaRuntimeExecutable(string ExecutablePath, JavaRuntime Runtime);
+public sealed class JavaRuntimeExecutable {
+	internal string ExecutablePath { get; }
+	internal JavaRuntime Runtime { get; }
+
+	internal JavaRuntimeExecutable(string executablePath, JavaRuntime runtime) {
+		this.ExecutablePath = executablePath;
+		this.Runtime = runtime;
+	}
+}

Agent/Phantom.Agent.Minecraft/Java/JavaRuntimeRepository.cs

@@ -6,29 +6,43 @@ using Phantom.Utils.Cryptography;
 namespace Phantom.Agent.Minecraft.Java;
 
 public sealed class JavaRuntimeRepository {
-	private readonly ImmutableDictionary<Guid, JavaRuntimeExecutable> runtimesByGuid;
+	private readonly Dictionary<string, Guid> guidsByPath = new ();
-	
+	private readonly Dictionary<Guid, JavaRuntimeExecutable> runtimesByGuid = new ();
-	internal JavaRuntimeRepository(ImmutableArray<JavaRuntimeExecutable> runtimes) {
+	private readonly ReaderWriterLockSlim rwLock = new (LockRecursionPolicy.NoRecursion);
-		var runtimesByGuidBuilder = ImmutableDictionary.CreateBuilder<Guid, JavaRuntimeExecutable>();
+
-		
-		foreach (JavaRuntimeExecutable runtime in runtimes) {
-			runtimesByGuidBuilder.Add(GenerateStableGuid(runtime.ExecutablePath), runtime);
-		}
-		
-		runtimesByGuid = runtimesByGuidBuilder.ToImmutable();
-	}
-	
 	public ImmutableArray<TaggedJavaRuntime> All {
-		[SuppressMessage("ReSharper", "UseCollectionExpression")]
+		get {
-		get => runtimesByGuid.Select(static kvp => new TaggedJavaRuntime(kvp.Key, kvp.Value.Runtime))
+			rwLock.EnterReadLock();
-		                     .OrderBy(static taggedRuntime => taggedRuntime.Runtime)
+			try {
-		                     .ToImmutableArray();
+				return runtimesByGuid.Select(static kvp => new TaggedJavaRuntime(kvp.Key, kvp.Value.Runtime)).OrderBy(static taggedRuntime => taggedRuntime.Runtime).ToImmutableArray();
+			} finally {
+				rwLock.ExitReadLock();
+			}
+		}
 	}
-	
+
-	internal bool TryGetByGuid(Guid guid, [MaybeNullWhen(false)] out JavaRuntimeExecutable runtime) {
+	public void Include(JavaRuntimeExecutable runtime) {
-		return runtimesByGuid.TryGetValue(guid, out runtime);
+		rwLock.EnterWriteLock();
+		try {
+			if (!guidsByPath.TryGetValue(runtime.ExecutablePath, out var guid)) {
+				guidsByPath[runtime.ExecutablePath] = guid = GenerateStableGuid(runtime.ExecutablePath);
+			}
+
+			runtimesByGuid[guid] = runtime;
+		} finally {
+			rwLock.ExitWriteLock();
+		}
 	}
-	
+
+	public bool TryGetByGuid(Guid guid, [MaybeNullWhen(false)] out JavaRuntimeExecutable runtime) {
+		rwLock.EnterReadLock();
+		try {
+			return runtimesByGuid.TryGetValue(guid, out runtime);
+		} finally {
+			rwLock.ExitReadLock();
+		}
+	}
+
 	private static Guid GenerateStableGuid(string executablePath) {
 		Random rand = new Random(StableHashCode.ForString(executablePath));
 		Span<byte> bytes = stackalloc byte[16];

Agent/Phantom.Agent.Minecraft/Java/JvmArgumentBuilder.cs

@@ -2,22 +2,27 @@
 
 namespace Phantom.Agent.Minecraft.Java;
 
-sealed class JvmArgumentBuilder(JvmProperties basicProperties) {
+sealed class JvmArgumentBuilder {
-	private readonly List<string> customArguments = [];
+	private readonly JvmProperties basicProperties;
-	
+	private readonly List<string> customArguments = new ();
+
+	public JvmArgumentBuilder(JvmProperties basicProperties) {
+		this.basicProperties = basicProperties;
+	}
+
 	public void Add(string argument) {
 		customArguments.Add(argument);
 	}
-	
+
 	public void AddProperty(string key, string value) {
 		customArguments.Add("-D" + key + "=\"" + value + "\""); // TODO test quoting?
 	}
-	
+
 	public void Build(Collection<string> target) {
 		foreach (var property in customArguments) {
 			target.Add(property);
 		}
-		
+
 		// In case of duplicate JVM arguments, typically the last one wins.
 		target.Add("-Xms" + basicProperties.InitialHeapMegabytes + "M");
 		target.Add("-Xmx" + basicProperties.MaximumHeapMegabytes + "M");

Agent/Phantom.Agent.Minecraft/Launcher/BaseLauncher.cs

@@ -1,4 +1,5 @@
-using System.Text;
+using System.Collections.ObjectModel;
+using System.Text;
 using Phantom.Agent.Minecraft.Instance;
 using Phantom.Agent.Minecraft.Java;
 using Phantom.Agent.Minecraft.Server;
@@ -9,23 +10,24 @@ namespace Phantom.Agent.Minecraft.Launcher;
 
 public abstract class BaseLauncher : IServerLauncher {
 	private readonly InstanceProperties instanceProperties;
-	
+
 	protected string MinecraftVersion => instanceProperties.ServerVersion;
-	
+	protected string InstanceFolder => instanceProperties.InstanceFolder;
+
 	private protected BaseLauncher(InstanceProperties instanceProperties) {
 		this.instanceProperties = instanceProperties;
 	}
-	
+
 	public async Task<LaunchResult> Launch(ILogger logger, LaunchServices services, EventHandler<DownloadProgressEventArgs> downloadProgressEventHandler, CancellationToken cancellationToken) {
 		if (!services.JavaRuntimeRepository.TryGetByGuid(instanceProperties.JavaRuntimeGuid, out var javaRuntimeExecutable)) {
 			return new LaunchResult.InvalidJavaRuntime();
 		}
-		
+
 		var vanillaServerJarPath = await services.ServerExecutables.DownloadAndGetPath(instanceProperties.LaunchProperties.ServerDownloadInfo, MinecraftVersion, downloadProgressEventHandler, cancellationToken);
 		if (vanillaServerJarPath == null) {
 			return new LaunchResult.CouldNotDownloadMinecraftServer();
 		}
-		
+
 		ServerJarInfo? serverJar;
 		try {
 			serverJar = await PrepareServerJar(logger, vanillaServerJarPath, cancellationToken);
@@ -35,15 +37,15 @@ public abstract class BaseLauncher : IServerLauncher {
 			logger.Error(e, "Caught exception while preparing the server jar.");
 			return new LaunchResult.CouldNotPrepareMinecraftServerLauncher();
 		}
-		
+
 		if (!File.Exists(serverJar.FilePath)) {
 			logger.Error("Missing prepared server or launcher jar: {FilePath}", serverJar.FilePath);
 			return new LaunchResult.CouldNotPrepareMinecraftServerLauncher();
 		}
-		
+
 		try {
 			await AcceptEula(instanceProperties);
-			await UpdateServerProperties(instanceProperties, cancellationToken);
+			await UpdateServerProperties(instanceProperties);
 		} catch (Exception e) {
 			logger.Error(e, "Caught exception while configuring the server.");
 			return new LaunchResult.CouldNotConfigureMinecraftServer();
@@ -51,20 +53,18 @@ public abstract class BaseLauncher : IServerLauncher {
 		
 		var processConfigurator = new ProcessConfigurator {
 			FileName = javaRuntimeExecutable.ExecutablePath,
-			WorkingDirectory = instanceProperties.InstanceFolder,
+			WorkingDirectory = InstanceFolder,
 			RedirectInput = true,
-			UseShellExecute = false,
+			UseShellExecute = false
 		};
 		
 		var processArguments = processConfigurator.ArgumentList;
 		PrepareJvmArguments(serverJar).Build(processArguments);
-		processArguments.Add("-jar");
+		PrepareJavaProcessArguments(processArguments, serverJar.FilePath);
-		processArguments.Add(serverJar.FilePath);
+
-		processArguments.Add("nogui");
-		
 		var process = processConfigurator.CreateProcess();
 		var instanceProcess = new InstanceProcess(instanceProperties, process);
-		
+
 		try {
 			process.Start();
 		} catch (Exception launchException) {
@@ -75,42 +75,48 @@ public abstract class BaseLauncher : IServerLauncher {
 			} catch (Exception killException) {
 				logger.Error(killException, "Caught exception trying to kill the server process after a failed launch.");
 			}
-			
+
 			return new LaunchResult.CouldNotStartMinecraftServer();
 		}
-		
+
 		return new LaunchResult.Success(instanceProcess);
 	}
-	
+
 	private JvmArgumentBuilder PrepareJvmArguments(ServerJarInfo serverJar) {
 		var builder = new JvmArgumentBuilder(instanceProperties.JvmProperties);
-		
+
 		foreach (string argument in instanceProperties.JvmArguments) {
 			builder.Add(argument);
 		}
-		
+
 		foreach (var argument in serverJar.ExtraArgs) {
 			builder.Add(argument);
 		}
-		
+
 		CustomizeJvmArguments(builder);
 		return builder;
 	}
-	
+
 	private protected virtual void CustomizeJvmArguments(JvmArgumentBuilder arguments) {}
-	
+
+	protected virtual void PrepareJavaProcessArguments(Collection<string> processArguments, string serverJarFilePath) {
+		processArguments.Add("-jar");
+		processArguments.Add(serverJarFilePath);
+		processArguments.Add("nogui");
+	}
+
 	private protected virtual Task<ServerJarInfo> PrepareServerJar(ILogger logger, string serverJarPath, CancellationToken cancellationToken) {
 		return Task.FromResult(new ServerJarInfo(serverJarPath));
 	}
-	
+
 	private static async Task AcceptEula(InstanceProperties instanceProperties) {
 		var eulaFilePath = Path.Combine(instanceProperties.InstanceFolder, "eula.txt");
-		await File.WriteAllLinesAsync(eulaFilePath, ["# EULA", "eula=true"], Encoding.UTF8);
+		await File.WriteAllLinesAsync(eulaFilePath, new [] { "# EULA", "eula=true" }, Encoding.UTF8);
 	}
-	
+
-	private static async Task UpdateServerProperties(InstanceProperties instanceProperties, CancellationToken cancellationToken) {
+	private static async Task UpdateServerProperties(InstanceProperties instanceProperties) {
 		var serverPropertiesEditor = new JavaPropertiesFileEditor();
 		instanceProperties.ServerProperties.SetTo(serverPropertiesEditor);
-		await serverPropertiesEditor.EditOrCreate(Path.Combine(instanceProperties.InstanceFolder, "server.properties"), comment: "server.properties", cancellationToken);
+		await serverPropertiesEditor.EditOrCreate(Path.Combine(instanceProperties.InstanceFolder, "server.properties"));
 	}
 }

Agent/Phantom.Agent.Minecraft/Launcher/LaunchResult.cs

@@ -4,11 +4,11 @@ namespace Phantom.Agent.Minecraft.Launcher;
 
 public abstract record LaunchResult {
 	private LaunchResult() {}
-	
+
 	public sealed record Success(InstanceProcess Process) : LaunchResult;
-	
+
 	public sealed record InvalidJavaRuntime : LaunchResult;
-	
+
 	public sealed record CouldNotDownloadMinecraftServer : LaunchResult;
 	
 	public sealed record CouldNotPrepareMinecraftServerLauncher : LaunchResult;

Agent/Phantom.Agent.Minecraft/Launcher/Types/FabricLauncher.cs

@@ -1,4 +1,5 @@
-using Phantom.Agent.Minecraft.Instance;
+using System.Collections.Immutable;
+using Phantom.Agent.Minecraft.Instance;
 using Phantom.Utils.IO;
 using Serilog;
 
@@ -18,10 +19,10 @@ public sealed class FabricLauncher : BaseLauncher {
 		if (!File.Exists(launcherJarPath)) {
 			await DownloadLauncher(logger, launcherJarPath, cancellationToken);
 		}
-		
+
-		return new ServerJarInfo(launcherJarPath, ["-Dfabric.installer.server.gameJar=" + Paths.NormalizeSlashes(serverJarPath)]);
+		return new ServerJarInfo(launcherJarPath, ImmutableArray.Create("-Dfabric.installer.server.gameJar=" + Paths.NormalizeSlashes(serverJarPath)));
 	}
-	
+
 	private async Task DownloadLauncher(ILogger logger, string targetFilePath, CancellationToken cancellationToken) {
 		// TODO customizable loader version, probably with a dedicated temporary folder
 		string installerUrl = $"https://meta.fabricmc.net/v2/versions/loader/{MinecraftVersion}/stable/stable/server/jar";
@@ -41,7 +42,7 @@ public sealed class FabricLauncher : BaseLauncher {
 			throw;
 		}
 	}
-	
+
 	private static void TryDeleteLauncherAfterFailure(ILogger logger, string filePath) {
 		if (File.Exists(filePath)) {
 			try {

Agent/Phantom.Agent.Minecraft/Launcher/Types/ForgeLauncher.cs

@@ -0,0 +1,29 @@
+using System.Collections.ObjectModel;
+using Phantom.Agent.Minecraft.Instance;
+using Phantom.Agent.Minecraft.Java;
+using Serilog;
+
+namespace Phantom.Agent.Minecraft.Launcher.Types; 
+
+public sealed class ForgeLauncher : BaseLauncher {
+	public ForgeLauncher(InstanceProperties instanceProperties) : base(instanceProperties) {}
+	
+	private protected override void CustomizeJvmArguments(JvmArgumentBuilder arguments) {
+		arguments.AddProperty("terminal.ansi", "true"); // TODO
+	}
+
+	protected override void PrepareJavaProcessArguments(Collection<string> processArguments, string serverJarFilePath) {
+		if (OperatingSystem.IsWindows()) {
+			processArguments.Add("@libraries/net/minecraftforge/forge/1.20.1-47.2.0/win_args.txt");
+		}
+		else {
+			processArguments.Add("@libraries/net/minecraftforge/forge/1.20.1-47.2.0/unix_args.txt");
+		}
+		
+		processArguments.Add("nogui");
+	}
+
+	private protected override Task<ServerJarInfo> PrepareServerJar(ILogger logger, string serverJarPath, CancellationToken cancellationToken) {
+		return Task.FromResult(new ServerJarInfo(Path.Combine(InstanceFolder, "run.sh")));
+	}
+}

Agent/Phantom.Agent.Minecraft/Phantom.Agent.Minecraft.csproj

@@ -6,7 +6,7 @@
   </PropertyGroup>
   
   <ItemGroup>
-    <InternalsVisibleTo Include="Phantom.Agent.Minecraft.Tests" />
+    <PackageReference Include="Kajabity.Tools.Java" />
   </ItemGroup>
   
   <ItemGroup>

Agent/Phantom.Agent.Minecraft/Properties/MinecraftServerProperties.cs

@@ -14,7 +14,7 @@ static class MinecraftServerProperties {
 		protected override ushort Read(string value) => ushort.Parse(value);
 		protected override string Write(ushort value) => value.ToString();
 	}
-	
+
 	public static readonly MinecraftServerProperty<ushort> ServerPort = new UnsignedShort("server-port");
 	public static readonly MinecraftServerProperty<ushort> RconPort = new UnsignedShort("rcon.port");
 	public static readonly MinecraftServerProperty<bool> EnableRcon = new Boolean("enable-rcon");

Agent/Phantom.Agent.Minecraft/Properties/MinecraftServerProperty.cs

@@ -4,14 +4,14 @@ namespace Phantom.Agent.Minecraft.Properties;
 
 abstract class MinecraftServerProperty<T> {
 	private readonly string key;
-	
+
 	protected MinecraftServerProperty(string key) {
 		this.key = key;
 	}
 	
 	protected abstract T Read(string value);
 	protected abstract string Write(T value);
-	
+
 	public void Set(JavaPropertiesFileEditor properties, T value) {
 		properties.Set(key, Write(value));
 	}

Agent/Phantom.Agent.Minecraft/Server/MinecraftServerExecutableDownloader.cs

@@ -10,22 +10,22 @@ namespace Phantom.Agent.Minecraft.Server;
 
 sealed class MinecraftServerExecutableDownloader {
 	private static readonly ILogger Logger = PhantomLogger.Create<MinecraftServerExecutableDownloader>();
-	
+
 	public Task<string?> Task { get; }
 	public event EventHandler<DownloadProgressEventArgs>? DownloadProgress;
 	public event EventHandler? Completed;
 	
 	private readonly CancellationTokenSource cancellationTokenSource = new ();
 	
-	private readonly List<CancellationTokenRegistration> listenerCancellationRegistrations = [];
+	private readonly List<CancellationTokenRegistration> listenerCancellationRegistrations = new ();
 	private int listenerCount = 0;
-	
+
 	public MinecraftServerExecutableDownloader(FileDownloadInfo fileDownloadInfo, string minecraftVersion, string filePath, MinecraftServerExecutableDownloadListener listener) {
 		Register(listener);
 		Task = DownloadAndGetPath(fileDownloadInfo, minecraftVersion, filePath, new DownloadProgressCallback(this), cancellationTokenSource.Token);
 		Task.ContinueWith(OnCompleted, TaskScheduler.Default);
 	}
-	
+
 	public void Register(MinecraftServerExecutableDownloadListener listener) {
 		int newListenerCount;
 		
@@ -38,14 +38,14 @@ sealed class MinecraftServerExecutableDownloader {
 		
 		Logger.Debug("Registered download listener, current listener count: {Listeners}", newListenerCount);
 	}
-	
+
 	private void Unregister(object? listenerObject) {
 		int newListenerCount;
 		
 		lock (this) {
 			MinecraftServerExecutableDownloadListener listener = (MinecraftServerExecutableDownloadListener) listenerObject!;
 			DownloadProgress -= listener.DownloadProgressEventHandler;
-			
+
 			newListenerCount = --listenerCount;
 			if (newListenerCount <= 0) {
 				cancellationTokenSource.Cancel();
@@ -59,19 +59,19 @@ sealed class MinecraftServerExecutableDownloader {
 			Logger.Debug("Unregistered download listener, current listener count: {Listeners}", newListenerCount);
 		}
 	}
-	
+
 	private void ReportDownloadProgress(DownloadProgressEventArgs args) {
 		DownloadProgress?.Invoke(this, args);
 	}
-	
+
 	private void OnCompleted(Task task) {
 		Logger.Debug("Download task completed.");
-		
+
 		lock (this) {
 			Completed?.Invoke(this, EventArgs.Empty);
 			Completed = null;
 			DownloadProgress = null;
-			
+
 			foreach (var registration in listenerCancellationRegistrations) {
 				registration.Dispose();
 			}
@@ -80,22 +80,22 @@ sealed class MinecraftServerExecutableDownloader {
 			cancellationTokenSource.Dispose();
 		}
 	}
-	
+
 	private sealed class DownloadProgressCallback {
 		private readonly MinecraftServerExecutableDownloader downloader;
-		
+
 		public DownloadProgressCallback(MinecraftServerExecutableDownloader downloader) {
 			this.downloader = downloader;
 		}
-		
+
 		public void ReportProgress(ulong downloadedBytes, ulong totalBytes) {
 			downloader.ReportDownloadProgress(new DownloadProgressEventArgs(downloadedBytes, totalBytes));
 		}
 	}
-	
+
 	private static async Task<string?> DownloadAndGetPath(FileDownloadInfo fileDownloadInfo, string minecraftVersion, string filePath, DownloadProgressCallback progressCallback, CancellationToken cancellationToken) {
 		string tmpFilePath = filePath + ".tmp";
-		
+
 		try {
 			Logger.Information("Downloading server version {Version} from: {Url} ({Size})", minecraftVersion, fileDownloadInfo.DownloadUrl, fileDownloadInfo.Size.ToHumanReadable(decimalPlaces: 1));
 			try {
@@ -105,10 +105,10 @@ sealed class MinecraftServerExecutableDownloader {
 				TryDeleteExecutableAfterFailure(tmpFilePath);
 				throw;
 			}
-			
+
-			File.Move(tmpFilePath, filePath, overwrite: true);
+			File.Move(tmpFilePath, filePath, true);
 			Logger.Information("Server version {Version} downloaded.", minecraftVersion);
-			
+
 			return filePath;
 		} catch (OperationCanceledException) {
 			Logger.Information("Download for server version {Version} was cancelled.", minecraftVersion);
@@ -120,17 +120,17 @@ sealed class MinecraftServerExecutableDownloader {
 			return null;
 		}
 	}
-	
+
 	private static async Task FetchServerExecutableFile(HttpClient http, DownloadProgressCallback progressCallback, FileDownloadInfo fileDownloadInfo, string filePath, CancellationToken cancellationToken) {
 		Sha1String downloadedFileHash;
-		
+
 		try {
 			var response = await http.GetAsync(fileDownloadInfo.DownloadUrl, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
 			response.EnsureSuccessStatusCode();
-			
+
 			await using var fileStream = new FileStream(filePath, FileMode.CreateNew, FileAccess.Write, FileShare.Read);
 			await using var responseStream = await response.Content.ReadAsStreamAsync(cancellationToken);
-			
+
 			using var streamCopier = new MinecraftServerDownloadStreamCopier(progressCallback, fileDownloadInfo.Size.Bytes);
 			downloadedFileHash = await streamCopier.Copy(responseStream, fileStream, cancellationToken);
 		} catch (OperationCanceledException) {
@@ -139,13 +139,13 @@ sealed class MinecraftServerExecutableDownloader {
 			Logger.Error(e, "Unable to download server executable.");
 			throw StopProcedureException.Instance;
 		}
-		
+
 		if (!downloadedFileHash.Equals(fileDownloadInfo.Hash)) {
 			Logger.Error("Downloaded server executable has mismatched SHA1 hash. Expected {Expected}, got {Actual}.", fileDownloadInfo.Hash, downloadedFileHash);
 			throw StopProcedureException.Instance;
 		}
 	}
-	
+
 	private static void TryDeleteExecutableAfterFailure(string filePath) {
 		if (File.Exists(filePath)) {
 			try {
@@ -155,33 +155,33 @@ sealed class MinecraftServerExecutableDownloader {
 			}
 		}
 	}
-	
+
 	private sealed class MinecraftServerDownloadStreamCopier : IDisposable {
 		private readonly StreamCopier streamCopier = new ();
 		private readonly IncrementalHash sha1 = IncrementalHash.CreateHash(HashAlgorithmName.SHA1);
-		
+
 		private readonly DownloadProgressCallback progressCallback;
 		private readonly ulong totalBytes;
 		private ulong readBytes;
-		
+
 		public MinecraftServerDownloadStreamCopier(DownloadProgressCallback progressCallback, ulong totalBytes) {
 			this.progressCallback = progressCallback;
 			this.totalBytes = totalBytes;
 			this.streamCopier.BufferReady += OnBufferReady;
 		}
-		
+
 		private void OnBufferReady(object? sender, StreamCopier.BufferEventArgs args) {
 			sha1.AppendData(args.Buffer.Span);
-			
+
 			readBytes += (uint) args.Buffer.Length;
 			progressCallback.ReportProgress(readBytes, totalBytes);
 		}
-		
+
 		public async Task<Sha1String> Copy(Stream source, Stream destination, CancellationToken cancellationToken) {
 			await streamCopier.Copy(source, destination, cancellationToken);
 			return Sha1String.FromBytes(sha1.GetHashAndReset());
 		}
-		
+
 		public void Dispose() {
 			sha1.Dispose();
 			streamCopier.Dispose();

Agent/Phantom.Agent.Minecraft/Server/MinecraftServerExecutables.cs

@@ -8,40 +8,40 @@ namespace Phantom.Agent.Minecraft.Server;
 
 public sealed partial class MinecraftServerExecutables {
 	private static readonly ILogger Logger = PhantomLogger.Create<MinecraftServerExecutables>();
-	
+
 	[GeneratedRegex(@"[^a-zA-Z0-9_\-\.]", RegexOptions.Compiled)]
 	private static partial Regex SanitizePathRegex();
-	
+
 	private readonly string basePath;
 	private readonly Dictionary<string, MinecraftServerExecutableDownloader> runningDownloadersByVersion = new ();
-	
+
 	public MinecraftServerExecutables(string basePath) {
 		this.basePath = basePath;
 	}
-	
+
 	internal async Task<string?> DownloadAndGetPath(FileDownloadInfo? fileDownloadInfo, string minecraftVersion, EventHandler<DownloadProgressEventArgs> progressEventHandler, CancellationToken cancellationToken) {
 		string serverExecutableFolderPath = Path.Combine(basePath, SanitizePathRegex().IsMatch(minecraftVersion) ? SanitizePathRegex().Replace(minecraftVersion, "_") : minecraftVersion);
 		string serverExecutableFilePath = Path.Combine(serverExecutableFolderPath, "server.jar");
-		
+
 		if (File.Exists(serverExecutableFilePath)) {
 			return serverExecutableFilePath;
 		}
-		
+
 		if (fileDownloadInfo == null) {
 			Logger.Error("Unable to download server executable for version {Version} because no download info was provided.", minecraftVersion);
 			return null;
 		}
-		
+
 		try {
 			Directories.Create(serverExecutableFolderPath, Chmod.URWX_GRX);
 		} catch (Exception e) {
 			Logger.Error(e, "Unable to create folder for server executable: {ServerExecutableFolderPath}", serverExecutableFolderPath);
 			return null;
 		}
-		
+
 		MinecraftServerExecutableDownloader? downloader;
 		MinecraftServerExecutableDownloadListener listener = new (progressEventHandler, cancellationToken);
-		
+
 		lock (this) {
 			if (runningDownloadersByVersion.TryGetValue(minecraftVersion, out downloader)) {
 				Logger.Information("A download for server version {Version} is already running, waiting for it to finish...", minecraftVersion);
@@ -54,11 +54,11 @@ public sealed partial class MinecraftServerExecutables {
 						runningDownloadersByVersion.Remove(minecraftVersion);
 					}
 				};
-				
+
 				runningDownloadersByVersion[minecraftVersion] = downloader;
 			}
 		}
-		
+
 		return await downloader.Task.WaitAsync(cancellationToken);
 	}
 }

Agent/Phantom.Agent.Minecraft/Server/ServerStatusProtocol.cs

@@ -16,20 +16,20 @@ public static class ServerStatusProtocol {
 		// https://wiki.vg/Server_List_Ping
 		tcpStream.WriteByte(0xFE);
 		await tcpStream.FlushAsync(cancellationToken);
-		
+
 		short messageLength = await ReadStreamHeader(tcpStream, cancellationToken);
 		return await ReadPlayerCounts(tcpStream, messageLength * 2, cancellationToken);
 	}
-	
+
 	private static async Task<short> ReadStreamHeader(NetworkStream tcpStream, CancellationToken cancellationToken) {
 		var headerBuffer = ArrayPool<byte>.Shared.Rent(3);
 		try {
-			await tcpStream.ReadExactlyAsync(headerBuffer, offset: 0, count: 3, cancellationToken);
+			await tcpStream.ReadExactlyAsync(headerBuffer, 0, 3, cancellationToken);
-			
+
 			if (headerBuffer[0] != 0xFF) {
 				throw new ProtocolException("Unexpected first byte in response from server: " + headerBuffer[0]);
 			}
-			
+
 			short messageLength = BinaryPrimitives.ReadInt16BigEndian(headerBuffer.AsSpan(1));
 			if (messageLength <= 0) {
 				throw new ProtocolException("Unexpected message length in response from server: " + messageLength);
@@ -40,12 +40,12 @@ public static class ServerStatusProtocol {
 			ArrayPool<byte>.Shared.Return(headerBuffer);
 		}
 	}
-	
+
 	private static async Task<InstancePlayerCounts> ReadPlayerCounts(NetworkStream tcpStream, int messageLength, CancellationToken cancellationToken) {
 		var messageBuffer = ArrayPool<byte>.Shared.Rent(messageLength);
 		try {
-			await tcpStream.ReadExactlyAsync(messageBuffer, offset: 0, messageLength, cancellationToken);
+			await tcpStream.ReadExactlyAsync(messageBuffer, 0, messageLength, cancellationToken);
-			return ReadPlayerCountsFromResponse(messageBuffer.AsSpan(start: 0, messageLength));
+			return ReadPlayerCountsFromResponse(messageBuffer.AsSpan(0, messageLength));
 		} finally {
 			ArrayPool<byte>.Shared.Return(messageBuffer);
 		}
@@ -54,7 +54,7 @@ public static class ServerStatusProtocol {
 	/// <summary>
 	/// Legacy query protocol uses the paragraph symbol (§) as separator encoded in UTF-16BE.
 	/// </summary>
-	private static readonly byte[] Separator = [0x00, 0xA7];
+	private static readonly byte[] Separator = { 0x00, 0xA7 };
 	
 	private static InstancePlayerCounts ReadPlayerCountsFromResponse(ReadOnlySpan<byte> messageBuffer) {
 		int lastSeparator = messageBuffer.LastIndexOf(Separator);
@@ -63,7 +63,7 @@ public static class ServerStatusProtocol {
 		if (lastSeparator == -1 || middleSeparator == -1) {
 			throw new ProtocolException("Could not find message separators in response from server.");
 		}
-		
+
 		var onlinePlayerCountBuffer = messageBuffer[(middleSeparator + Separator.Length)..lastSeparator];
 		var maximumPlayerCountBuffer = messageBuffer[(lastSeparator + Separator.Length)..];
 		

Agent/Phantom.Agent.Rpc/ControllerConnection.cs

@@ -0,0 +1,21 @@
+using Phantom.Common.Messages.Agent;
+using Phantom.Utils.Logging;
+using Phantom.Utils.Rpc.Runtime;
+using Serilog;
+
+namespace Phantom.Agent.Rpc;
+
+public sealed class ControllerConnection {
+	private static readonly ILogger Logger = PhantomLogger.Create(nameof(ControllerConnection));
+
+	private readonly RpcConnectionToServer<IMessageToController> connection;
+	
+	public ControllerConnection(RpcConnectionToServer<IMessageToController> connection) {
+		this.connection = connection;
+		Logger.Information("Connection ready.");
+	}
+
+	public Task Send<TMessage>(TMessage message) where TMessage : IMessageToController {
+		return connection.Send(message);
+	}
+}

Agent/Phantom.Agent.Rpc/KeepAliveLoop.cs

@@ -0,0 +1,44 @@
+using Phantom.Common.Messages.Agent;
+using Phantom.Common.Messages.Agent.ToController;
+using Phantom.Utils.Logging;
+using Phantom.Utils.Rpc.Runtime;
+using Serilog;
+
+namespace Phantom.Agent.Rpc;
+
+sealed class KeepAliveLoop {
+	private static readonly ILogger Logger = PhantomLogger.Create<KeepAliveLoop>();
+
+	private static readonly TimeSpan KeepAliveInterval = TimeSpan.FromSeconds(10);
+
+	private readonly RpcConnectionToServer<IMessageToController> connection;
+	private readonly CancellationTokenSource cancellationTokenSource = new ();
+
+	public KeepAliveLoop(RpcConnectionToServer<IMessageToController> connection) {
+		this.connection = connection;
+		Task.Run(Run);
+	}
+
+	private async Task Run() {
+		var cancellationToken = cancellationTokenSource.Token;
+		
+		try {
+			await connection.IsReady.WaitAsync(cancellationToken);
+			Logger.Information("Started keep-alive loop.");
+			
+			while (true) {
+				await Task.Delay(KeepAliveInterval, cancellationToken);
+				await connection.Send(new AgentIsAliveMessage()).WaitAsync(cancellationToken);
+			}
+		} catch (OperationCanceledException) {
+			// Ignore.
+		} finally {
+			cancellationTokenSource.Dispose();
+			Logger.Information("Stopped keep-alive loop.");
+		}
+	}
+
+	public void Cancel() {
+		cancellationTokenSource.Cancel();
+	}
+}

Agent/Phantom.Agent.Rpc/Phantom.Agent.Rpc.csproj

@@ -0,0 +1,12 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  
+  <PropertyGroup>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+  </PropertyGroup>
+  
+  <ItemGroup>
+    <ProjectReference Include="..\..\Common\Phantom.Common.Messages.Agent\Phantom.Common.Messages.Agent.csproj" />
+  </ItemGroup>
+
+</Project>

Agent/Phantom.Agent.Rpc/RpcClientRuntime.cs

@@ -0,0 +1,37 @@
+using NetMQ;
+using NetMQ.Sockets;
+using Phantom.Common.Messages.Agent;
+using Phantom.Common.Messages.Agent.BiDirectional;
+using Phantom.Common.Messages.Agent.ToController;
+using Phantom.Utils.Actor;
+using Phantom.Utils.Rpc.Runtime;
+using Phantom.Utils.Rpc.Sockets;
+using Serilog;
+
+namespace Phantom.Agent.Rpc;
+
+public sealed class RpcClientRuntime : RpcClientRuntime<IMessageToAgent, IMessageToController, ReplyMessage> {
+	public static Task Launch(RpcClientSocket<IMessageToAgent, IMessageToController, ReplyMessage> socket, ActorRef<IMessageToAgent> handlerActorRef, SemaphoreSlim disconnectSemaphore, CancellationToken receiveCancellationToken) {
+		return new RpcClientRuntime(socket, handlerActorRef, disconnectSemaphore, receiveCancellationToken).Launch();
+	}
+
+	private RpcClientRuntime(RpcClientSocket<IMessageToAgent, IMessageToController, ReplyMessage> socket, ActorRef<IMessageToAgent> handlerActor, SemaphoreSlim disconnectSemaphore, CancellationToken receiveCancellationToken) : base(socket, handlerActor, disconnectSemaphore, receiveCancellationToken) {}
+
+	protected override async Task RunWithConnection(ClientSocket socket, RpcConnectionToServer<IMessageToController> connection) {
+		var keepAliveLoop = new KeepAliveLoop(connection);
+		try {
+			await base.RunWithConnection(socket, connection);
+		} finally {
+			keepAliveLoop.Cancel();
+		}
+	}
+
+	protected override async Task SendDisconnectMessage(ClientSocket socket, ILogger logger) {
+		var unregisterMessageBytes = AgentMessageRegistries.ToController.Write(new UnregisterAgentMessage()).ToArray();
+		try {
+			await socket.SendAsync(unregisterMessageBytes).AsTask().WaitAsync(TimeSpan.FromSeconds(5), CancellationToken.None);
+		} catch (TimeoutException) {
+			logger.Error("Timed out communicating agent shutdown with the controller.");
+		}
+	}
+}

Agent/Phantom.Agent.Services/AgentFolders.cs

@@ -6,16 +6,16 @@ namespace Phantom.Agent.Services;
 
 public sealed class AgentFolders {
 	private static readonly ILogger Logger = PhantomLogger.Create<AgentFolders>();
-	
+
 	public string DataFolderPath { get; }
 	public string InstancesFolderPath { get; }
 	public string BackupsFolderPath { get; }
-	
+
 	public string TemporaryFolderPath { get; }
 	public string ServerExecutableFolderPath { get; }
-	
+
 	public string JavaSearchFolderPath { get; }
-	
+
 	public AgentFolders(string dataFolderPath, string temporaryFolderPath, string javaSearchFolderPath) {
 		this.DataFolderPath = Path.GetFullPath(dataFolderPath);
 		this.InstancesFolderPath = Path.Combine(DataFolderPath, "instances");
@@ -26,7 +26,7 @@ public sealed class AgentFolders {
 		
 		this.JavaSearchFolderPath = javaSearchFolderPath;
 	}
-	
+
 	public bool TryCreate() {
 		return TryCreateFolder(DataFolderPath) &&
 		       TryCreateFolder(InstancesFolderPath) &&
@@ -34,12 +34,12 @@ public sealed class AgentFolders {
 		       TryCreateFolder(TemporaryFolderPath) &&
 		       TryCreateFolder(ServerExecutableFolderPath);
 	}
-	
+
 	private static bool TryCreateFolder(string folderPath) {
 		if (Directory.Exists(folderPath)) {
 			return true;
 		}
-		
+
 		try {
 			Directories.Create(folderPath, Chmod.URWX_GRX);
 			return true;

Agent/Phantom.Agent.Services/AgentRegistrationHandler.cs

@@ -1,85 +0,0 @@
-using System.Collections.Immutable;
-using Phantom.Agent.Services.Instances;
-using Phantom.Common.Data.Replies;
-using Phantom.Common.Messages.Agent.ToAgent;
-using Phantom.Utils.Logging;
-using Phantom.Utils.Tasks;
-using Phantom.Utils.Threading;
-using Serilog;
-
-namespace Phantom.Agent.Services;
-
-public sealed class AgentRegistrationHandler {
-	private readonly ILogger logger = PhantomLogger.Create<AgentRegistrationHandler>();
-	
-	private readonly ManualResetEventSlim newSessionEvent = new ();
-	private ImmutableArray<ConfigureInstanceMessage> lastConfigureInstanceMessages;
-	
-	internal void OnRegistrationComplete(ImmutableArray<ConfigureInstanceMessage> configureInstanceMessages) {
-		ImmutableInterlocked.InterlockedExchange(ref lastConfigureInstanceMessages, configureInstanceMessages);
-	}
-	
-	internal void OnNewSession() {
-		newSessionEvent.Set();
-	}
-	
-	public async Task<bool> Start(AgentServices agentServices, CancellationToken cancellationToken) {
-		var configureInstanceMessages = ImmutableInterlocked.InterlockedExchange(ref lastConfigureInstanceMessages, value: default);
-		if (configureInstanceMessages.IsDefault) {
-			logger.Fatal("Handshake failed.");
-			return false;
-		}
-		
-		foreach (var configureInstanceMessage in configureInstanceMessages) {
-			var configureInstanceResult = await agentServices.InstanceManager.Request(GetCommand(configureInstanceMessage), cancellationToken);
-			if (!configureInstanceResult.Is(ConfigureInstanceResult.Success)) {
-				logger.Fatal("Unable to configure instance \"{Name}\" (GUID {Guid}), shutting down.", configureInstanceMessage.Configuration.InstanceName, configureInstanceMessage.InstanceGuid);
-				return false;
-			}
-		}
-		
-		agentServices.InstanceTicketManager.RefreshAgentStatus();
-		
-		_ = HandleNewSessionRegistrations(agentServices, cancellationToken);
-		return true;
-	}
-	
-	private async Task HandleNewSessionRegistrations(AgentServices agentServices, CancellationToken cancellationToken) {
-		while (cancellationToken.Check()) {
-			await newSessionEvent.WaitHandle.WaitOneAsync(cancellationToken);
-			newSessionEvent.Reset();
-			
-			try {
-				await HandleNewSessionRegistration(agentServices, cancellationToken);
-			} catch (Exception e) {
-				logger.Error(e, "Could not configure instances after re-registration.");
-			}
-		}
-	}
-	
-	private async Task HandleNewSessionRegistration(AgentServices agentServices, CancellationToken cancellationToken) {
-		var configureInstanceMessages = ImmutableInterlocked.InterlockedExchange(ref lastConfigureInstanceMessages, value: default);
-		if (configureInstanceMessages.IsDefaultOrEmpty) {
-			return;
-		}
-		
-		foreach (var configureInstanceMessage in configureInstanceMessages) {
-			var configureInstanceResult = await agentServices.InstanceManager.Request(GetCommand(configureInstanceMessage), cancellationToken);
-			if (!configureInstanceResult.Is(ConfigureInstanceResult.Success)) {
-				logger.Error("Unable to configure instance \"{Name}\" (GUID {Guid}).", configureInstanceMessage.Configuration.InstanceName, configureInstanceMessage.InstanceGuid);
-			}
-		}
-		
-		agentServices.InstanceTicketManager.RefreshAgentStatus();
-	}
-	
-	private static InstanceManagerActor.ConfigureInstanceCommand GetCommand(ConfigureInstanceMessage configureInstanceMessage) {
-		return new InstanceManagerActor.ConfigureInstanceCommand(
-			configureInstanceMessage.InstanceGuid,
-			configureInstanceMessage.Configuration,
-			configureInstanceMessage.LaunchProperties,
-			configureInstanceMessage.LaunchNow,
-			AlwaysReportStatus: true
-		);
-	}
-}

Agent/Phantom.Agent.Services/AgentServices.cs

@@ -1,8 +1,8 @@
 using Akka.Actor;
 using Phantom.Agent.Minecraft.Java;
+using Phantom.Agent.Rpc;
 using Phantom.Agent.Services.Backups;
 using Phantom.Agent.Services.Instances;
-using Phantom.Agent.Services.Rpc;
 using Phantom.Common.Data.Agent;
 using Phantom.Utils.Actor;
 using Phantom.Utils.Logging;
@@ -14,32 +14,39 @@ public sealed class AgentServices {
 	private static readonly ILogger Logger = PhantomLogger.Create<AgentServices>();
 	
 	public ActorSystem ActorSystem { get; }
-	
+
+	private AgentFolders AgentFolders { get; }
 	private AgentState AgentState { get; }
 	private BackupManager BackupManager { get; }
-	
+
 	internal JavaRuntimeRepository JavaRuntimeRepository { get; }
 	internal InstanceTicketManager InstanceTicketManager { get; }
 	internal ActorRef<InstanceManagerActor.ICommand> InstanceManager { get; }
-	
+
-	public AgentServices(AgentInfo agentInfo, AgentFolders agentFolders, AgentServiceConfiguration serviceConfiguration, ControllerConnection controllerConnection, JavaRuntimeRepository javaRuntimeRepository) {
+	public AgentServices(AgentInfo agentInfo, AgentFolders agentFolders, AgentServiceConfiguration serviceConfiguration, ControllerConnection controllerConnection) {
 		this.ActorSystem = ActorSystemFactory.Create("Agent");
 		
+		this.AgentFolders = agentFolders;
 		this.AgentState = new AgentState();
 		this.BackupManager = new BackupManager(agentFolders, serviceConfiguration.MaxConcurrentCompressionTasks);
 		
-		this.JavaRuntimeRepository = javaRuntimeRepository;
+		this.JavaRuntimeRepository = new JavaRuntimeRepository();
 		this.InstanceTicketManager = new InstanceTicketManager(agentInfo, controllerConnection);
 		
 		var instanceManagerInit = new InstanceManagerActor.Init(controllerConnection, agentFolders, AgentState, JavaRuntimeRepository, InstanceTicketManager, BackupManager);
 		this.InstanceManager = ActorSystem.ActorOf(InstanceManagerActor.Factory(instanceManagerInit), "InstanceManager");
 	}
-	
+
+	public async Task Initialize() {
+		await foreach (var runtime in JavaRuntimeDiscovery.Scan(AgentFolders.JavaSearchFolderPath)) {
+			JavaRuntimeRepository.Include(runtime);
+		}
+	}
+
 	public async Task Shutdown() {
 		Logger.Information("Stopping services...");
 		
 		await InstanceManager.Stop(new InstanceManagerActor.ShutdownCommand());
-		await InstanceTicketManager.Shutdown();
 		
 		BackupManager.Dispose();
 		

Agent/Phantom.Agent.Services/Backups/BackupArchiver.cs

@@ -23,9 +23,9 @@ sealed class BackupArchiver {
 		this.instanceProperties = instanceProperties;
 		this.cancellationToken = cancellationToken;
 	}
-	
+
 	private bool IsFolderSkipped(ImmutableList<string> relativePath) {
-		return relativePath is ["cache" or "crash-reports" or "debug" or "libraries" or "logs" or "mods" or "versions"];
+		return relativePath is ["cache" or "crash-reports" or "debug" or "libraries" or "logs" or "mods" or "servermods" or "versions"];
 	}
 	
 	[SuppressMessage("ReSharper", "ConvertIfStatementToReturnStatement")]
@@ -35,7 +35,7 @@ sealed class BackupArchiver {
 		if (relativePath.Count == 2 && name == "session.lock") {
 			return true;
 		}
-		
+
 		var extension = Path.GetExtension(name);
 		if (extension is ".jar" or ".zip") {
 			return true;
@@ -43,7 +43,7 @@ sealed class BackupArchiver {
 		
 		return false;
 	}
-	
+
 	public async Task<string?> ArchiveWorld(BackupCreationResult.Builder resultBuilder) {
 		string guid = instanceProperties.InstanceGuid.ToString();
 		string currentDateTime = DateTime.Now.ToString("yyyyMMdd-HHmmss");
@@ -63,7 +63,7 @@ sealed class BackupArchiver {
 			logger.Error(e, "Could not create backup folder: {Folder}", backupFolderPath);
 			return null;
 		}
-		
+
 		string temporaryFolderPath = Path.Combine(temporaryBasePath, guid + "_" + currentDateTime);
 		if (!await CopyWorldAndCreateTarArchive(temporaryFolderPath, backupFilePath, resultBuilder)) {
 			return null;
@@ -72,19 +72,19 @@ sealed class BackupArchiver {
 		logger.Debug("Created world backup: {FilePath}", backupFilePath);
 		return backupFilePath;
 	}
-	
+
 	private async Task<bool> CopyWorldAndCreateTarArchive(string temporaryFolderPath, string backupFilePath, BackupCreationResult.Builder resultBuilder) {
 		try {
 			if (!await CopyWorldToTemporaryFolder(temporaryFolderPath)) {
 				resultBuilder.Kind = BackupCreationResultKind.CouldNotCopyWorldToTemporaryFolder;
 				return false;
 			}
-			
+
 			if (!await CreateTarArchive(temporaryFolderPath, backupFilePath)) {
 				resultBuilder.Kind = BackupCreationResultKind.CouldNotCreateWorldArchive;
 				return false;
 			}
-			
+
 			return true;
 		} finally {
 			try {
@@ -95,7 +95,7 @@ sealed class BackupArchiver {
 			}
 		}
 	}
-	
+
 	private async Task<bool> CopyWorldToTemporaryFolder(string temporaryFolderPath) {
 		try {
 			await CopyDirectory(new DirectoryInfo(instanceProperties.InstanceFolder), temporaryFolderPath, ImmutableList<string>.Empty);
@@ -105,10 +105,10 @@ sealed class BackupArchiver {
 			return false;
 		}
 	}
-	
+
 	private async Task<bool> CreateTarArchive(string sourceFolderPath, string backupFilePath) {
 		try {
-			await TarFile.CreateFromDirectoryAsync(sourceFolderPath, backupFilePath, includeBaseDirectory: false, cancellationToken);
+			await TarFile.CreateFromDirectoryAsync(sourceFolderPath, backupFilePath, false, cancellationToken);
 			return true;
 		} catch (Exception e) {
 			logger.Error(e, "Could not create archive.");
@@ -116,7 +116,7 @@ sealed class BackupArchiver {
 			return false;
 		}
 	}
-	
+
 	private void DeleteBrokenArchiveFile(string filePath) {
 		if (File.Exists(filePath)) {
 			try {
@@ -126,38 +126,38 @@ sealed class BackupArchiver {
 			}
 		}
 	}
-	
+
 	private async Task CopyDirectory(DirectoryInfo sourceFolder, string destinationFolderPath, ImmutableList<string> relativePath) {
 		cancellationToken.ThrowIfCancellationRequested();
-		
+
 		bool needsToCreateFolder = true;
 		
 		foreach (FileInfo file in sourceFolder.EnumerateFiles()) {
 			var filePath = relativePath.Add(file.Name);
 			if (IsFileSkipped(filePath)) {
-				logger.Debug("Skipping file: {File}", string.Join(separator: '/', filePath));
+				logger.Debug("Skipping file: {File}", string.Join('/', filePath));
 				continue;
 			}
-			
+
 			if (needsToCreateFolder) {
 				needsToCreateFolder = false;
 				Directories.Create(destinationFolderPath, Chmod.URWX);
 			}
-			
+
 			await CopyFileWithRetries(file, destinationFolderPath);
 		}
-		
+
 		foreach (DirectoryInfo directory in sourceFolder.EnumerateDirectories()) {
 			var folderPath = relativePath.Add(directory.Name);
 			if (IsFolderSkipped(folderPath)) {
-				logger.Debug("Skipping folder: {Folder}", string.Join(separator: '/', folderPath));
+				logger.Debug("Skipping folder: {Folder}", string.Join('/', folderPath));
 				continue;
 			}
 			
 			await CopyDirectory(directory, Path.Join(destinationFolderPath, directory.Name), folderPath);
 		}
 	}
-	
+
 	private async Task CopyFileWithRetries(FileInfo sourceFile, string destinationFolderPath) {
 		var destinationFilePath = Path.Combine(destinationFolderPath, sourceFile.Name);
 		
@@ -172,7 +172,7 @@ sealed class BackupArchiver {
 				}
 				else {
 					logger.Warning("Failed copying file {File}, retrying...", sourceFile.FullName);
-					await Task.Delay(millisecondsDelay: 200, cancellationToken);
+					await Task.Delay(200, cancellationToken);
 				}
 			}
 		}

Agent/Phantom.Agent.Services/Backups/BackupCompressor.cs

@@ -19,27 +19,27 @@ static class BackupCompressor {
 		}
 		
 		var destinationFilePath = sourceFilePath + ".zst";
-		
+
 		if (!await TryCompressFile(sourceFilePath, destinationFilePath, cancellationToken)) {
 			try {
 				File.Delete(destinationFilePath);
 			} catch (Exception e) {
 				Logger.Error(e, "Could not delete compresed archive after unsuccessful compression: {Path}", destinationFilePath);
 			}
-			
+
 			return null;
 		}
-		
+
 		return destinationFilePath;
 	}
-	
+
 	private static async Task<bool> TryCompressFile(string sourceFilePath, string destinationFilePath, CancellationToken cancellationToken) {
 		var workingDirectory = Path.GetDirectoryName(sourceFilePath);
 		if (string.IsNullOrEmpty(workingDirectory)) {
 			Logger.Error("Invalid destination path: {Path}", destinationFilePath);
 			return false;
 		}
-		
+
 		var launcher = new ProcessConfigurator {
 			FileName = "zstd",
 			WorkingDirectory = workingDirectory,
@@ -50,16 +50,16 @@ static class BackupCompressor {
 				"--rm",
 				"--no-progress",
 				"-o", destinationFilePath,
-				"--", sourceFilePath,
+				"--", sourceFilePath
-			},
+			}
 		};
-		
+
 		static void OnZstdOutput(object? sender, Process.Output output) {
 			if (!string.IsNullOrWhiteSpace(output.Line)) {
 				ZstdLogger.Debug("[Output] {Line}", output.Line);
 			}
 		}
-		
+
 		var process = new OneShotProcess(ZstdLogger, launcher);
 		process.OutputReceived += OnZstdOutput;
 		return await process.Run(cancellationToken);

Agent/Phantom.Agent.Services/Backups/BackupManager.cs

@@ -9,28 +9,28 @@ sealed class BackupManager : IDisposable {
 	private readonly string destinationBasePath;
 	private readonly string temporaryBasePath;
 	private readonly SemaphoreSlim compressionSemaphore;
-	
+
 	public BackupManager(AgentFolders agentFolders, int maxConcurrentCompressionTasks) {
 		this.destinationBasePath = agentFolders.BackupsFolderPath;
 		this.temporaryBasePath = Path.Combine(agentFolders.TemporaryFolderPath, "backups");
 		this.compressionSemaphore = new SemaphoreSlim(maxConcurrentCompressionTasks, maxConcurrentCompressionTasks);
 	}
-	
+
 	public Task<BackupCreationResult> CreateBackup(string loggerName, InstanceProcess process, CancellationToken cancellationToken) {
 		return new BackupCreator(this, loggerName, process, cancellationToken).CreateBackup();
 	}
-	
+
 	public void Dispose() {
 		compressionSemaphore.Dispose();
 	}
-	
+
 	private sealed class BackupCreator {
 		private readonly BackupManager manager;
 		private readonly string loggerName;
 		private readonly ILogger logger;
 		private readonly InstanceProcess process;
 		private readonly CancellationToken cancellationToken;
-		
+
 		public BackupCreator(BackupManager manager, string loggerName, InstanceProcess process, CancellationToken cancellationToken) {
 			this.manager = manager;
 			this.loggerName = loggerName;
@@ -38,7 +38,7 @@ sealed class BackupManager : IDisposable {
 			this.process = process;
 			this.cancellationToken = cancellationToken;
 		}
-		
+
 		public async Task<BackupCreationResult> CreateBackup() {
 			logger.Information("Backup started.");
 			
@@ -57,7 +57,7 @@ sealed class BackupManager : IDisposable {
 			LogBackupResult(result);
 			return result;
 		}
-		
+
 		private async Task<string?> CreateWorldArchive(BackupServerCommandDispatcher dispatcher, BackupCreationResult.Builder resultBuilder) {
 			try {
 				await dispatcher.DisableAutomaticSaving();
@@ -95,7 +95,7 @@ sealed class BackupManager : IDisposable {
 				logger.Information("Too many compression tasks running, waiting for one of them to complete...");
 				await manager.compressionSemaphore.WaitAsync(cancellationToken);
 			}
-			
+
 			logger.Information("Compressing backup...");
 			try {
 				var compressedFilePath = await BackupCompressor.Compress(filePath, cancellationToken);
@@ -106,7 +106,7 @@ sealed class BackupManager : IDisposable {
 				manager.compressionSemaphore.Release();
 			}
 		}
-		
+
 		private void LogBackupResult(BackupCreationResult result) {
 			if (result.Kind != BackupCreationResultKind.Success) {
 				logger.Warning("Backup failed: {Reason}", DescribeResult(result.Kind));
@@ -121,7 +121,7 @@ sealed class BackupManager : IDisposable {
 				logger.Information("Backup finished successfully.");
 			}
 		}
-		
+
 		private static string DescribeResult(BackupCreationResultKind kind) {
 			return kind switch {
 				BackupCreationResultKind.Success                            => "Backup created successfully.",
@@ -133,7 +133,7 @@ sealed class BackupManager : IDisposable {
 				BackupCreationResultKind.CouldNotCreateBackupFolder         => "Could not create backup folder.",
 				BackupCreationResultKind.CouldNotCopyWorldToTemporaryFolder => "Could not copy world to temporary folder.",
 				BackupCreationResultKind.CouldNotCreateWorldArchive         => "Could not create world archive.",
-				_                                                           => "Unknown error.",
+				_                                                           => "Unknown error."
 			};
 		}
 	}

Agent/Phantom.Agent.Services/Backups/BackupScheduler.cs

@@ -11,22 +11,22 @@ sealed class BackupScheduler : CancellableBackgroundTask {
 	private static readonly TimeSpan InitialDelay = TimeSpan.FromMinutes(2);
 	private static readonly TimeSpan BackupInterval = TimeSpan.FromMinutes(30);
 	private static readonly TimeSpan BackupFailureRetryDelay = TimeSpan.FromMinutes(5);
-	
+
 	private readonly BackupManager backupManager;
 	private readonly InstanceContext context;
-	private readonly SemaphoreSlim backupSemaphore = new (initialCount: 1, maxCount: 1);
+	private readonly SemaphoreSlim backupSemaphore = new (1, 1);
 	private readonly ManualResetEventSlim serverOutputWhileWaitingForOnlinePlayers = new ();
 	private readonly InstancePlayerCountTracker playerCountTracker;
 	
 	public event EventHandler<BackupCreationResult>? BackupCompleted;
-	
+
 	public BackupScheduler(InstanceContext context, InstancePlayerCountTracker playerCountTracker) : base(PhantomLogger.Create<BackupScheduler>(context.ShortName)) {
 		this.backupManager = context.Services.BackupManager;
 		this.context = context;
 		this.playerCountTracker = playerCountTracker;
 		Start();
 	}
-	
+
 	protected override async Task RunTask() {
 		await Task.Delay(InitialDelay, CancellationToken);
 		Logger.Information("Starting a new backup after server launched.");
@@ -46,7 +46,7 @@ sealed class BackupScheduler : CancellableBackgroundTask {
 			}
 		}
 	}
-	
+
 	private async Task<BackupCreationResult> CreateBackup() {
 		if (!await backupSemaphore.WaitAsync(TimeSpan.FromSeconds(1))) {
 			return new BackupCreationResult(BackupCreationResultKind.BackupAlreadyRunning);
@@ -61,7 +61,7 @@ sealed class BackupScheduler : CancellableBackgroundTask {
 			backupSemaphore.Release();
 		}
 	}
-	
+
 	private async Task WaitForOnlinePlayers() {
 		var task = playerCountTracker.WaitForOnlinePlayers(CancellationToken);
 		if (!task.IsCompleted) {
@@ -77,7 +77,7 @@ sealed class BackupScheduler : CancellableBackgroundTask {
 			Logger.Warning("Could not detect whether any players are online, starting a new backup.");
 		}
 	}
-	
+
 	protected override void Dispose() {
 		backupSemaphore.Dispose();
 		serverOutputWhileWaitingForOnlinePlayers.Dispose();

Agent/Phantom.Agent.Services/Backups/BackupServerCommandDispatcher.cs

@@ -28,54 +28,54 @@ sealed partial class BackupServerCommandDispatcher : IDisposable {
 		"Turned on world auto-saving",
 		"CONSOLE: Enabling level saving.."
 	);
-	
+
 	private readonly ILogger logger;
 	private readonly InstanceProcess process;
 	private readonly CancellationToken cancellationToken;
-	
+
 	private readonly TaskCompletionSource automaticSavingDisabled = AsyncTasks.CreateCompletionSource();
 	private readonly TaskCompletionSource savedTheGame = AsyncTasks.CreateCompletionSource();
 	private readonly TaskCompletionSource automaticSavingEnabled = AsyncTasks.CreateCompletionSource();
-	
+
 	public BackupServerCommandDispatcher(ILogger logger, InstanceProcess process, CancellationToken cancellationToken) {
 		this.logger = logger;
 		this.process = process;
 		this.cancellationToken = cancellationToken;
-		
+
 		this.process.AddOutputListener(OnOutput, maxLinesToReadFromHistory: 0);
 	}
-	
+
 	void IDisposable.Dispose() {
 		process.RemoveOutputListener(OnOutput);
 	}
-	
+
 	public async Task DisableAutomaticSaving() {
 		await process.SendCommand(MinecraftCommand.SaveOff, cancellationToken);
 		await automaticSavingDisabled.Task.WaitAsync(TimeSpan.FromSeconds(30), cancellationToken);
 	}
-	
+
 	public async Task SaveAllChunks() {
 		await process.SendCommand(MinecraftCommand.SaveAll(flush: true), cancellationToken);
 		await savedTheGame.Task.WaitAsync(TimeSpan.FromMinutes(1), cancellationToken);
 	}
-	
+
 	public async Task EnableAutomaticSaving() {
 		await process.SendCommand(MinecraftCommand.SaveOn, cancellationToken);
 		await automaticSavingEnabled.Task.WaitAsync(TimeSpan.FromMinutes(1), cancellationToken);
 	}
-	
+
 	private void OnOutput(object? sender, string? line) {
 		if (line == null) {
 			return;
 		}
-		
+
 		var match = ServerThreadInfoRegex().Match(line);
 		if (!match.Success) {
 			return;
 		}
-		
+
 		string info = match.Groups[1].Value;
-		
+
 		if (!automaticSavingDisabled.Task.IsCompleted) {
 			if (AutomaticSavingDisabledMessages.Contains(info)) {
 				logger.Debug("Detected that automatic saving is disabled.");

Agent/Phantom.Agent.Services/Instances/InstanceActor.cs

@@ -1,7 +1,6 @@
 using Phantom.Agent.Minecraft.Launcher;
 using Phantom.Agent.Services.Backups;
 using Phantom.Agent.Services.Instances.State;
-using Phantom.Agent.Services.Rpc;
 using Phantom.Common.Data.Backups;
 using Phantom.Common.Data.Instance;
 using Phantom.Common.Data.Minecraft;
@@ -15,40 +14,34 @@ namespace Phantom.Agent.Services.Instances;
 
 sealed class InstanceActor : ReceiveActor<InstanceActor.ICommand> {
 	public readonly record struct Init(AgentState AgentState, Guid InstanceGuid, string ShortName, InstanceServices InstanceServices, InstanceTicketManager InstanceTicketManager, CancellationToken ShutdownCancellationToken);
-	
+
 	public static Props<ICommand> Factory(Init init) {
 		return Props<ICommand>.Create(() => new InstanceActor(init), new ActorConfiguration { SupervisorStrategy = SupervisorStrategies.Resume, MailboxType = UnboundedJumpAheadMailbox.Name });
 	}
-	
+
 	private readonly AgentState agentState;
 	private readonly CancellationToken shutdownCancellationToken;
 	
 	private readonly Guid instanceGuid;
+	private readonly InstanceServices instanceServices;
 	private readonly InstanceTicketManager instanceTicketManager;
 	private readonly InstanceContext context;
 	
-	private readonly ControllerSendQueue<ReportInstanceStatusMessage> reportStatusQueue;
-	private readonly ControllerSendQueue<ReportInstanceEventMessage> reportEventsQueue;
-	
 	private readonly CancellationTokenSource actorCancellationTokenSource = new ();
-	
+
 	private IInstanceStatus currentStatus = InstanceStatus.NotRunning;
 	private InstanceRunningState? runningState = null;
-	
+
 	private InstanceActor(Init init) {
-		InstanceServices services = init.InstanceServices;
-		
 		this.agentState = init.AgentState;
 		this.instanceGuid = init.InstanceGuid;
+		this.instanceServices = init.InstanceServices;
 		this.instanceTicketManager = init.InstanceTicketManager;
 		this.shutdownCancellationToken = init.ShutdownCancellationToken;
 		
-		this.reportStatusQueue = new ControllerSendQueue<ReportInstanceStatusMessage>(services.ControllerConnection, init.ShortName + "-Status", capacity: 1, singleWriter: true);
-		this.reportEventsQueue = new ControllerSendQueue<ReportInstanceEventMessage>(services.ControllerConnection, init.ShortName + "-Events", capacity: 1000, singleWriter: true);
-		
 		var logger = PhantomLogger.Create<InstanceActor>(init.ShortName);
-		this.context = new InstanceContext(instanceGuid, init.ShortName, logger, services, reportEventsQueue, SelfTyped, actorCancellationTokenSource.Token);
+		this.context = new InstanceContext(instanceGuid, init.ShortName, logger, instanceServices, SelfTyped, actorCancellationTokenSource.Token);
-		
+
 		Receive<ReportInstanceStatusCommand>(ReportInstanceStatus);
 		ReceiveAsync<LaunchInstanceCommand>(LaunchInstance);
 		ReceiveAsync<StopInstanceCommand>(StopInstance);
@@ -57,29 +50,29 @@ sealed class InstanceActor : ReceiveActor<InstanceActor.ICommand> {
 		Receive<HandleProcessEndedCommand>(HandleProcessEnded);
 		ReceiveAsync<ShutdownCommand>(Shutdown);
 	}
-	
+
 	private void SetAndReportStatus(IInstanceStatus status) {
 		currentStatus = status;
 		ReportCurrentStatus();
 	}
-	
+
 	private void ReportCurrentStatus() {
 		agentState.UpdateInstance(new Instance(instanceGuid, currentStatus));
-		reportStatusQueue.Enqueue(new ReportInstanceStatusMessage(instanceGuid, currentStatus));
+		instanceServices.ControllerConnection.Send(new ReportInstanceStatusMessage(instanceGuid, currentStatus));
 	}
-	
+
 	private void TransitionState(InstanceRunningState? newState) {
 		if (runningState == newState) {
 			return;
 		}
-		
+
 		runningState?.Dispose();
 		runningState = newState;
 		runningState?.Initialize();
 	}
 	
-	public interface ICommand;
+	public interface ICommand {}
-	
+
 	public sealed record ReportInstanceStatusCommand : ICommand;
 	
 	public sealed record LaunchInstanceCommand(InstanceConfiguration Configuration, IServerLauncher Launcher, InstanceTicketManager.Ticket Ticket, bool IsRestarting) : ICommand;
@@ -93,7 +86,7 @@ sealed class InstanceActor : ReceiveActor<InstanceActor.ICommand> {
 	public sealed record HandleProcessEndedCommand(IInstanceStatus Status) : ICommand, IJumpAhead;
 	
 	public sealed record ShutdownCommand : ICommand;
-	
+
 	private void ReportInstanceStatus(ReportInstanceStatusCommand command) {
 		ReportCurrentStatus();
 	}
@@ -110,12 +103,12 @@ sealed class InstanceActor : ReceiveActor<InstanceActor.ICommand> {
 			TransitionState(newState);
 		}
 	}
-	
+
 	private async Task StopInstance(StopInstanceCommand command) {
 		if (runningState is null) {
 			return;
 		}
-		
+
 		IInstanceStatus oldStatus = currentStatus;
 		SetAndReportStatus(InstanceStatus.Stopping);
 		
@@ -127,7 +120,7 @@ sealed class InstanceActor : ReceiveActor<InstanceActor.ICommand> {
 			SetAndReportStatus(oldStatus);
 		}
 	}
-	
+
 	private async Task<SendCommandToInstanceResult> SendCommandToInstance(SendCommandToInstanceCommand command) {
 		if (runningState is null) {
 			return SendCommandToInstanceResult.InstanceNotRunning;
@@ -150,7 +143,7 @@ sealed class InstanceActor : ReceiveActor<InstanceActor.ICommand> {
 			}
 		}
 	}
-	
+
 	private void HandleProcessEnded(HandleProcessEndedCommand command) {
 		if (runningState is { Process.HasEnded: true }) {
 			SetAndReportStatus(command.Status);
@@ -159,16 +152,10 @@ sealed class InstanceActor : ReceiveActor<InstanceActor.ICommand> {
 			TransitionState(null);
 		}
 	}
-	
+
 	private async Task Shutdown(ShutdownCommand command) {
 		await StopInstance(new StopInstanceCommand(MinecraftStopStrategy.Instant));
 		await actorCancellationTokenSource.CancelAsync();
-		
-		await Task.WhenAll(
-			reportStatusQueue.Shutdown(TimeSpan.FromSeconds(5)),
-			reportEventsQueue.Shutdown(TimeSpan.FromSeconds(5))
-		);
-		
 		Context.Stop(Self);
 	}
 }

Agent/Phantom.Agent.Services/Instances/InstanceContext.cs

@@ -1,21 +1,12 @@
-using Phantom.Agent.Services.Rpc;
+using Phantom.Common.Data.Instance;
-using Phantom.Common.Data.Instance;
 using Phantom.Common.Messages.Agent.ToController;
 using Phantom.Utils.Actor;
 using Serilog;
 
 namespace Phantom.Agent.Services.Instances;
 
-sealed record InstanceContext(
+sealed record InstanceContext(Guid InstanceGuid, string ShortName, ILogger Logger, InstanceServices Services, ActorRef<InstanceActor.ICommand> Actor, CancellationToken ActorCancellationToken) {
-	Guid InstanceGuid,
-	string ShortName,
-	ILogger Logger,
-	InstanceServices Services,
-	ControllerSendQueue<ReportInstanceEventMessage> ReportEventQueue,
-	ActorRef<InstanceActor.ICommand> Actor,
-	CancellationToken ActorCancellationToken
-) {
 	public void ReportEvent(IInstanceEvent instanceEvent) {
-		ReportEventQueue.Enqueue(new ReportInstanceEventMessage(Guid.NewGuid(), DateTime.UtcNow, InstanceGuid, instanceEvent));
+		Services.ControllerConnection.Send(new ReportInstanceEventMessage(Guid.NewGuid(), DateTime.UtcNow, InstanceGuid, instanceEvent));
 	}
 }

Agent/Phantom.Agent.Services/Instances/InstanceManagerActor.cs

@@ -4,8 +4,8 @@ using Phantom.Agent.Minecraft.Launcher;
 using Phantom.Agent.Minecraft.Launcher.Types;
 using Phantom.Agent.Minecraft.Properties;
 using Phantom.Agent.Minecraft.Server;
+using Phantom.Agent.Rpc;
 using Phantom.Agent.Services.Backups;
-using Phantom.Agent.Services.Rpc;
 using Phantom.Common.Data;
 using Phantom.Common.Data.Instance;
 using Phantom.Common.Data.Minecraft;
@@ -19,34 +19,34 @@ namespace Phantom.Agent.Services.Instances;
 
 sealed class InstanceManagerActor : ReceiveActor<InstanceManagerActor.ICommand> {
 	private static readonly ILogger Logger = PhantomLogger.Create<InstanceManagerActor>();
-	
+
 	public readonly record struct Init(ControllerConnection ControllerConnection, AgentFolders AgentFolders, AgentState AgentState, JavaRuntimeRepository JavaRuntimeRepository, InstanceTicketManager InstanceTicketManager, BackupManager BackupManager);
-	
+
 	public static Props<ICommand> Factory(Init init) {
 		return Props<ICommand>.Create(() => new InstanceManagerActor(init), new ActorConfiguration { SupervisorStrategy = SupervisorStrategies.Resume });
 	}
 	
 	private readonly AgentState agentState;
 	private readonly string basePath;
-	
+
 	private readonly InstanceServices instanceServices;
 	private readonly InstanceTicketManager instanceTicketManager;
 	private readonly Dictionary<Guid, InstanceInfo> instances = new ();
-	
+
 	private readonly CancellationTokenSource shutdownCancellationTokenSource = new ();
 	private readonly CancellationToken shutdownCancellationToken;
-	
+
 	private uint instanceLoggerSequenceId = 0;
-	
+
 	private InstanceManagerActor(Init init) {
 		this.agentState = init.AgentState;
 		this.basePath = init.AgentFolders.InstancesFolderPath;
 		this.instanceTicketManager = init.InstanceTicketManager;
 		this.shutdownCancellationToken = shutdownCancellationTokenSource.Token;
-		
+
 		var minecraftServerExecutables = new MinecraftServerExecutables(init.AgentFolders.ServerExecutableFolderPath);
 		var launchServices = new LaunchServices(minecraftServerExecutables, init.JavaRuntimeRepository);
-		
+
 		this.instanceServices = new InstanceServices(init.ControllerConnection, init.BackupManager, launchServices);
 		
 		ReceiveAndReply<ConfigureInstanceCommand, Result<ConfigureInstanceResult, InstanceActionFailure>>(ConfigureInstance);
@@ -55,10 +55,15 @@ sealed class InstanceManagerActor : ReceiveActor<InstanceManagerActor.ICommand>
 		ReceiveAsyncAndReply<SendCommandToInstanceCommand, Result<SendCommandToInstanceResult, InstanceActionFailure>>(SendCommandToInstance);
 		ReceiveAsync<ShutdownCommand>(Shutdown);
 	}
-	
+
+	private string GetInstanceLoggerName(Guid guid) {
+		var prefix = guid.ToString();
+		return prefix[..prefix.IndexOf('-')] + "/" + Interlocked.Increment(ref instanceLoggerSequenceId);
+	}
+
 	private sealed record InstanceInfo(ActorRef<InstanceActor.ICommand> Actor, InstanceConfiguration Configuration, IServerLauncher Launcher);
 	
-	public interface ICommand;
+	public interface ICommand {}
 	
 	public sealed record ConfigureInstanceCommand(Guid InstanceGuid, InstanceConfiguration Configuration, InstanceLaunchProperties LaunchProperties, bool LaunchNow, bool AlwaysReportStatus) : ICommand, ICanReply<Result<ConfigureInstanceResult, InstanceActionFailure>>;
 	
@@ -69,20 +74,20 @@ sealed class InstanceManagerActor : ReceiveActor<InstanceManagerActor.ICommand>
 	public sealed record SendCommandToInstanceCommand(Guid InstanceGuid, string Command) : ICommand, ICanReply<Result<SendCommandToInstanceResult, InstanceActionFailure>>;
 	
 	public sealed record ShutdownCommand : ICommand;
-	
+
 	private Result<ConfigureInstanceResult, InstanceActionFailure> ConfigureInstance(ConfigureInstanceCommand command) {
 		var instanceGuid = command.InstanceGuid;
 		var configuration = command.Configuration;
-		
+
 		var instanceFolder = Path.Combine(basePath, instanceGuid.ToString());
 		Directories.Create(instanceFolder, Chmod.URWX_GRX);
-		
+
 		var heapMegabytes = configuration.MemoryAllocation.InMegabytes;
 		var jvmProperties = new JvmProperties(
 			InitialHeapMegabytes: heapMegabytes / 2,
 			MaximumHeapMegabytes: heapMegabytes
 		);
-		
+
 		var properties = new InstanceProperties(
 			instanceGuid,
 			configuration.JavaRuntimeGuid,
@@ -93,42 +98,42 @@ sealed class InstanceManagerActor : ReceiveActor<InstanceManagerActor.ICommand>
 			new ServerProperties(configuration.ServerPort, configuration.RconPort),
 			command.LaunchProperties
 		);
-		
+
 		IServerLauncher launcher = configuration.MinecraftServerKind switch {
 			MinecraftServerKind.Vanilla => new VanillaLauncher(properties),
 			MinecraftServerKind.Fabric  => new FabricLauncher(properties),
-			_                           => InvalidLauncher.Instance,
+			MinecraftServerKind.Forge   => new ForgeLauncher(properties),
+			_                           => InvalidLauncher.Instance
 		};
-		
+
 		if (instances.TryGetValue(instanceGuid, out var instance)) {
 			instances[instanceGuid] = instance with {
 				Configuration = configuration,
-				Launcher = launcher,
+				Launcher = launcher
 			};
-			
+				
 			Logger.Information("Reconfigured instance \"{Name}\" (GUID {Guid}).", configuration.InstanceName, instanceGuid);
-			
+
 			if (command.AlwaysReportStatus) {
 				instance.Actor.Tell(new InstanceActor.ReportInstanceStatusCommand());
 			}
 		}
 		else {
-			var instanceLoggerName = PhantomLogger.ShortenGuid(instanceGuid) + "/" + Interlocked.Increment(ref instanceLoggerSequenceId);
+			var instanceInit = new InstanceActor.Init(agentState, instanceGuid, GetInstanceLoggerName(instanceGuid), instanceServices, instanceTicketManager, shutdownCancellationToken);
-			var instanceInit = new InstanceActor.Init(agentState, instanceGuid, instanceLoggerName, instanceServices, instanceTicketManager, shutdownCancellationToken);
 			instances[instanceGuid] = instance = new InstanceInfo(Context.ActorOf(InstanceActor.Factory(instanceInit), "Instance-" + instanceGuid), configuration, launcher);
-			
+				
 			Logger.Information("Created instance \"{Name}\" (GUID {Guid}).", configuration.InstanceName, instanceGuid);
-			
+
 			instance.Actor.Tell(new InstanceActor.ReportInstanceStatusCommand());
 		}
-		
+
 		if (command.LaunchNow) {
 			LaunchInstance(new LaunchInstanceCommand(instanceGuid));
 		}
-		
+
 		return ConfigureInstanceResult.Success;
 	}
-	
+
 	private Result<LaunchInstanceResult, InstanceActionFailure> LaunchInstance(LaunchInstanceCommand command) {
 		var instanceGuid = command.InstanceGuid;
 		if (!instances.TryGetValue(instanceGuid, out var instanceInfo)) {
@@ -139,7 +144,7 @@ sealed class InstanceManagerActor : ReceiveActor<InstanceManagerActor.ICommand>
 		if (!ticket) {
 			return ticket.Error;
 		}
-		
+
 		if (agentState.InstancesByGuid.TryGetValue(instanceGuid, out var instance)) {
 			var status = instance.Status;
 			if (status.IsRunning()) {
@@ -153,13 +158,13 @@ sealed class InstanceManagerActor : ReceiveActor<InstanceManagerActor.ICommand>
 		instanceInfo.Actor.Tell(new InstanceActor.LaunchInstanceCommand(instanceInfo.Configuration, instanceInfo.Launcher, ticket.Value, IsRestarting: false));
 		return LaunchInstanceResult.LaunchInitiated;
 	}
-	
+
 	private Result<StopInstanceResult, InstanceActionFailure> StopInstance(StopInstanceCommand command) {
 		var instanceGuid = command.InstanceGuid;
 		if (!instances.TryGetValue(instanceGuid, out var instanceInfo)) {
 			return InstanceActionFailure.InstanceDoesNotExist;
 		}
-		
+        
 		if (agentState.InstancesByGuid.TryGetValue(instanceGuid, out var instance)) {
 			var status = instance.Status;
 			if (status.IsStopping()) {
@@ -169,24 +174,24 @@ sealed class InstanceManagerActor : ReceiveActor<InstanceManagerActor.ICommand>
 				return StopInstanceResult.InstanceAlreadyStopped;
 			}
 		}
-		
+			
 		instanceInfo.Actor.Tell(new InstanceActor.StopInstanceCommand(command.StopStrategy));
 		return StopInstanceResult.StopInitiated;
 	}
-	
+
 	private async Task<Result<SendCommandToInstanceResult, InstanceActionFailure>> SendCommandToInstance(SendCommandToInstanceCommand command) {
 		var instanceGuid = command.InstanceGuid;
 		if (!instances.TryGetValue(instanceGuid, out var instanceInfo)) {
 			return InstanceActionFailure.InstanceDoesNotExist;
 		}
-		
+
 		try {
 			return await instanceInfo.Actor.Request(new InstanceActor.SendCommandToInstanceCommand(command.Command), shutdownCancellationToken);
 		} catch (OperationCanceledException) {
 			return InstanceActionFailure.AgentShuttingDown;
 		}
 	}
-	
+
 	private async Task Shutdown(ShutdownCommand command) {
 		Logger.Information("Stopping all instances...");
 		

Agent/Phantom.Agent.Services/Instances/InstanceServices.cs

@@ -1,6 +1,6 @@
 using Phantom.Agent.Minecraft.Launcher;
+using Phantom.Agent.Rpc;
 using Phantom.Agent.Services.Backups;
-using Phantom.Agent.Services.Rpc;
 
 namespace Phantom.Agent.Services.Instances;
 

Agent/Phantom.Agent.Services/Instances/InstanceTicketManager.cs

@@ -1,23 +1,30 @@
-using Phantom.Agent.Services.Rpc;
+using Phantom.Agent.Rpc;
 using Phantom.Common.Data;
 using Phantom.Common.Data.Agent;
 using Phantom.Common.Data.Instance;
 using Phantom.Common.Data.Replies;
 using Phantom.Common.Messages.Agent.ToController;
 using Phantom.Utils.Logging;
+using Phantom.Utils.Tasks;
 using Serilog;
 
 namespace Phantom.Agent.Services.Instances;
 
-sealed class InstanceTicketManager(AgentInfo agentInfo, ControllerConnection controllerConnection) {
+sealed class InstanceTicketManager {
 	private static readonly ILogger Logger = PhantomLogger.Create<InstanceTicketManager>();
 	
-	private readonly ControllerSendQueue<ReportAgentStatusMessage> reportStatusQueue = new (controllerConnection, nameof(InstanceTicketManager), capacity: 1, singleWriter: true);
+	private readonly AgentInfo agentInfo;
+	private readonly ControllerConnection controllerConnection;
 	
-	private readonly HashSet<Guid> activeTicketGuids = [];
+	private readonly HashSet<Guid> activeTicketGuids = new ();
-	private readonly HashSet<ushort> usedPorts = [];
+	private readonly HashSet<ushort> usedPorts = new ();
 	private RamAllocationUnits usedMemory = new ();
-	
+
+	public InstanceTicketManager(AgentInfo agentInfo, ControllerConnection controllerConnection) {
+		this.agentInfo = agentInfo;
+		this.controllerConnection = controllerConnection;
+	}
+
 	public Result<Ticket, LaunchInstanceResult> Reserve(InstanceConfiguration configuration) {
 		var memoryAllocation = configuration.MemoryAllocation;
 		var serverPort = configuration.ServerPort;
@@ -26,7 +33,7 @@ sealed class InstanceTicketManager(AgentInfo agentInfo, ControllerConnection con
 		if (!agentInfo.AllowedServerPorts.Contains(serverPort)) {
 			return LaunchInstanceResult.ServerPortNotAllowed;
 		}
-		
+
 		if (!agentInfo.AllowedRconPorts.Contains(rconPort)) {
 			return LaunchInstanceResult.RconPortNotAllowed;
 		}
@@ -35,7 +42,7 @@ sealed class InstanceTicketManager(AgentInfo agentInfo, ControllerConnection con
 			if (activeTicketGuids.Count + 1 > agentInfo.MaxInstances) {
 				return LaunchInstanceResult.InstanceLimitExceeded;
 			}
-			
+
 			if (usedMemory + memoryAllocation > agentInfo.MaxMemory) {
 				return LaunchInstanceResult.MemoryLimitExceeded;
 			}
@@ -43,11 +50,11 @@ sealed class InstanceTicketManager(AgentInfo agentInfo, ControllerConnection con
 			if (usedPorts.Contains(serverPort)) {
 				return LaunchInstanceResult.ServerPortAlreadyInUse;
 			}
-			
+
 			if (usedPorts.Contains(rconPort)) {
 				return LaunchInstanceResult.RconPortAlreadyInUse;
 			}
-			
+
 			var ticket = new Ticket(Guid.NewGuid(), memoryAllocation, serverPort, rconPort);
 			
 			activeTicketGuids.Add(ticket.TicketGuid);
@@ -57,11 +64,11 @@ sealed class InstanceTicketManager(AgentInfo agentInfo, ControllerConnection con
 			
 			RefreshAgentStatus();
 			Logger.Debug("Reserved ticket {TicketGuid} (server port {ServerPort}, rcon port {RconPort}, memory allocation {MemoryAllocation} MB).", ticket.TicketGuid, ticket.ServerPort, ticket.RconPort, ticket.MemoryAllocation.InMegabytes);
-			
+
 			return ticket;
 		}
 	}
-	
+
 	public bool IsValid(Ticket ticket) {
 		lock (this) {
 			return activeTicketGuids.Contains(ticket.TicketGuid);
@@ -73,7 +80,7 @@ sealed class InstanceTicketManager(AgentInfo agentInfo, ControllerConnection con
 			if (!activeTicketGuids.Remove(ticket.TicketGuid)) {
 				return;
 			}
-			
+
 			usedMemory -= ticket.MemoryAllocation;
 			usedPorts.Remove(ticket.ServerPort);
 			usedPorts.Remove(ticket.RconPort);
@@ -85,13 +92,9 @@ sealed class InstanceTicketManager(AgentInfo agentInfo, ControllerConnection con
 	
 	public void RefreshAgentStatus() {
 		lock (this) {
-			reportStatusQueue.Enqueue(new ReportAgentStatusMessage(activeTicketGuids.Count, usedMemory));
+			controllerConnection.Send(new ReportAgentStatusMessage(activeTicketGuids.Count, usedMemory));
 		}
 	}
 	
-	public async Task Shutdown() {
-		await reportStatusQueue.Shutdown(TimeSpan.FromSeconds(5));
-	}
-	
 	public sealed record Ticket(Guid TicketGuid, RamAllocationUnits MemoryAllocation, ushort ServerPort, ushort RconPort);
 }

Agent/Phantom.Agent.Services/Instances/State/InstanceLaunchProcedure.cs

@@ -9,9 +9,9 @@ namespace Phantom.Agent.Services.Instances.State;
 static class InstanceLaunchProcedure {
 	public static async Task<InstanceRunningState?> Run(InstanceContext context, InstanceConfiguration configuration, IServerLauncher launcher, InstanceTicketManager ticketManager, InstanceTicketManager.Ticket ticket, Action<IInstanceStatus> reportStatus, CancellationToken cancellationToken) {
 		context.Logger.Information("Session starting...");
-		
+
 		Result<InstanceProcess, InstanceLaunchFailReason> result;
-		
+
 		if (ticketManager.IsValid(ticket)) {
 			try {
 				result = await LaunchInstance(context, launcher, reportStatus, cancellationToken);
@@ -27,7 +27,7 @@ static class InstanceLaunchProcedure {
 			context.Logger.Error("Attempted to launch instance with an invalid ticket!");
 			result = InstanceLaunchFailReason.UnknownError;
 		}
-		
+
 		if (result) {
 			reportStatus(InstanceStatus.Running);
 			context.ReportEvent(InstanceEvent.LaunchSucceeded);
@@ -39,45 +39,45 @@ static class InstanceLaunchProcedure {
 			return null;
 		}
 	}
-	
+
 	private static async Task<Result<InstanceProcess, InstanceLaunchFailReason>> LaunchInstance(InstanceContext context, IServerLauncher launcher, Action<IInstanceStatus> reportStatus, CancellationToken cancellationToken) {
 		cancellationToken.ThrowIfCancellationRequested();
-		
+
 		byte lastDownloadProgress = byte.MaxValue;
-		
+
 		void OnDownloadProgress(object? sender, DownloadProgressEventArgs args) {
-			byte progress = (byte) Math.Min(args.DownloadedBytes * 100 / args.TotalBytes, val2: 100);
+			byte progress = (byte) Math.Min(args.DownloadedBytes * 100 / args.TotalBytes, 100);
-			
+
 			if (lastDownloadProgress != progress) {
 				lastDownloadProgress = progress;
 				reportStatus(InstanceStatus.Downloading(progress));
 			}
 		}
-		
+
 		switch (await launcher.Launch(context.Logger, context.Services.LaunchServices, OnDownloadProgress, cancellationToken)) {
 			case LaunchResult.Success launchSuccess:
 				return launchSuccess.Process;
-			
+
 			case LaunchResult.InvalidJavaRuntime:
 				context.Logger.Error("Session failed to launch, invalid Java runtime.");
 				return InstanceLaunchFailReason.JavaRuntimeNotFound;
-			
+
 			case LaunchResult.CouldNotDownloadMinecraftServer:
 				context.Logger.Error("Session failed to launch, could not download Minecraft server.");
 				return InstanceLaunchFailReason.CouldNotDownloadMinecraftServer;
-			
+
 			case LaunchResult.CouldNotPrepareMinecraftServerLauncher:
 				context.Logger.Error("Session failed to launch, could not prepare Minecraft server launcher.");
 				return InstanceLaunchFailReason.CouldNotPrepareMinecraftServerLauncher;
-			
+
 			case LaunchResult.CouldNotConfigureMinecraftServer:
 				context.Logger.Error("Session failed to launch, could not configure Minecraft server.");
 				return InstanceLaunchFailReason.CouldNotConfigureMinecraftServer;
-			
+
 			case LaunchResult.CouldNotStartMinecraftServer:
 				context.Logger.Error("Session failed to launch, could not start Minecraft server.");
 				return InstanceLaunchFailReason.CouldNotStartMinecraftServer;
-			
+
 			default:
 				context.Logger.Error("Session failed to launch.");
 				return InstanceLaunchFailReason.UnknownError;

Agent/Phantom.Agent.Services/Instances/State/InstanceLogSender.cs

@@ -1,7 +1,6 @@
 using System.Collections.Immutable;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading.Channels;
-using Phantom.Agent.Services.Rpc;
+using Phantom.Agent.Rpc;
 using Phantom.Common.Messages.Agent.ToController;
 using Phantom.Utils.Logging;
 using Phantom.Utils.Tasks;
@@ -9,20 +8,20 @@ using Phantom.Utils.Tasks;
 namespace Phantom.Agent.Services.Instances.State;
 
 sealed class InstanceLogSender : CancellableBackgroundTask {
-	private static readonly BoundedChannelOptions BufferOptions = new (capacity: 200) {
+	private static readonly BoundedChannelOptions BufferOptions = new (capacity: 100) {
 		SingleReader = true,
 		SingleWriter = true,
-		FullMode = BoundedChannelFullMode.DropNewest,
+		FullMode = BoundedChannelFullMode.DropNewest
 	};
 	
 	private static readonly TimeSpan SendDelay = TimeSpan.FromMilliseconds(200);
-	
+
 	private readonly ControllerConnection controllerConnection;
 	private readonly Guid instanceGuid;
 	private readonly Channel<string> outputChannel;
 	
 	private int droppedLinesSinceLastSend;
-	
+
 	public InstanceLogSender(ControllerConnection controllerConnection, Guid instanceGuid, string loggerName) : base(PhantomLogger.Create<InstanceLogSender>(loggerName)) {
 		this.controllerConnection = controllerConnection;
 		this.instanceGuid = instanceGuid;
@@ -34,31 +33,19 @@ sealed class InstanceLogSender : CancellableBackgroundTask {
 		var lineReader = outputChannel.Reader;
 		var lineBuilder = ImmutableArray.CreateBuilder<string>();
 		
-		using var sendOutputCancellationTokenSource = new CancellationTokenSource();
-		
-		await using var sendOutputCancellationRegistration = CancellationToken.Register([SuppressMessage("ReSharper", "AccessToDisposedClosure")]() => {
-			sendOutputCancellationTokenSource.CancelAfter(TimeSpan.FromSeconds(10));
-		});
-		
-		var sendOutputCancellationToken = sendOutputCancellationTokenSource.Token;
-		
 		try {
 			while (await lineReader.WaitToReadAsync(CancellationToken)) {
 				await Task.Delay(SendDelay, CancellationToken);
-				await SendOutputToServer(ReadLinesFromChannel(lineReader, lineBuilder), sendOutputCancellationToken);
+				SendOutputToServer(ReadLinesFromChannel(lineReader, lineBuilder));
 			}
 		} catch (OperationCanceledException) {
 			// Ignore.
 		}
-		
+
 		// Flush remaining lines.
-		try {
+		SendOutputToServer(ReadLinesFromChannel(lineReader, lineBuilder));
-			await SendOutputToServer(ReadLinesFromChannel(lineReader, lineBuilder), sendOutputCancellationToken);
-		} catch (OperationCanceledException) {
-			// Ignore.
-		}
 	}
-	
+
 	private ImmutableArray<string> ReadLinesFromChannel(ChannelReader<string> reader, ImmutableArray<string>.Builder builder) {
 		builder.Clear();
 		
@@ -66,32 +53,29 @@ sealed class InstanceLogSender : CancellableBackgroundTask {
 			builder.Add(line);
 		}
 		
-		int droppedLines = Interlocked.Exchange(ref droppedLinesSinceLastSend, value: 0);
+		int droppedLines = Interlocked.Exchange(ref droppedLinesSinceLastSend, 0);
 		if (droppedLines > 0) {
 			builder.Add($"Dropped {droppedLines} {(droppedLines == 1 ? "line" : "lines")} due to buffer overflow.");
 		}
 		
 		return builder.ToImmutable();
 	}
-	
+
-	private ValueTask SendOutputToServer(ImmutableArray<string> lines, CancellationToken cancellationToken) {
+	private void SendOutputToServer(ImmutableArray<string> lines) {
-		if (lines.IsEmpty) {
+		if (!lines.IsEmpty) {
-			return ValueTask.CompletedTask;
+			controllerConnection.Send(new InstanceOutputMessage(instanceGuid, lines));
-		}
-		else {
-			return controllerConnection.Send(new InstanceOutputMessage(instanceGuid, lines), cancellationToken);
 		}
 	}
-	
+
 	private void OnLineDropped(string line) {
 		Logger.Warning("Buffer is full, dropped line: {Line}", line);
 		Interlocked.Increment(ref droppedLinesSinceLastSend);
 	}
-	
+
 	public void Enqueue(string line) {
 		outputChannel.Writer.TryWrite(line);
 	}
-	
+
 	protected override void Dispose() {
 		if (!outputChannel.Writer.TryComplete()) {
 			Logger.Error("Could not mark channel as completed.");

Agent/Phantom.Agent.Services/Instances/State/InstancePlayerCountTracker.cs

@@ -1,7 +1,6 @@
-using System.Net.Sockets;
+using Phantom.Agent.Minecraft.Instance;
-using Phantom.Agent.Minecraft.Instance;
 using Phantom.Agent.Minecraft.Server;
-using Phantom.Agent.Services.Rpc;
+using Phantom.Agent.Rpc;
 using Phantom.Common.Data.Instance;
 using Phantom.Common.Messages.Agent.ToController;
 using Phantom.Utils.Logging;
@@ -15,17 +14,38 @@ sealed class InstancePlayerCountTracker : CancellableBackgroundTask {
 	private readonly Guid instanceGuid;
 	private readonly ushort serverPort;
 	private readonly InstanceProcess process;
-	
+
 	private readonly TaskCompletionSource firstDetection = AsyncTasks.CreateCompletionSource();
 	private readonly ManualResetEventSlim serverOutputEvent = new ();
-	
+
-	private bool WaitingForFirstDetection => !firstDetection.Task.IsCompleted;
-	
 	private InstancePlayerCounts? playerCounts;
+
+	public InstancePlayerCounts? PlayerCounts {
+		get {
+			lock (this) {
+				return playerCounts;
+			}
+		}
+		private set {
+			EventHandler<int?>? onlinePlayerCountChanged;
+			lock (this) {
+				if (playerCounts == value) {
+					return;
+				}
+				
+				playerCounts = value;
+				onlinePlayerCountChanged = OnlinePlayerCountChanged;
+			}
+
+			onlinePlayerCountChanged?.Invoke(this, value?.Online);
+			controllerConnection.Send(new ReportInstancePlayerCountsMessage(instanceGuid, value));
+		}
+	}
+
 	private event EventHandler<int?>? OnlinePlayerCountChanged;
-	
+
 	private bool isDisposed = false;
-	
+
 	public InstancePlayerCountTracker(InstanceContext context, InstanceProcess process, ushort serverPort) : base(PhantomLogger.Create<InstancePlayerCountTracker>(context.ShortName)) {
 		this.controllerConnection = context.Services.ControllerConnection;
 		this.instanceGuid = context.InstanceGuid;
@@ -33,78 +53,48 @@ sealed class InstancePlayerCountTracker : CancellableBackgroundTask {
 		this.serverPort = serverPort;
 		Start();
 	}
-	
+
 	protected override async Task RunTask() {
 		// Give the server time to start accepting connections.
-		await Task.Delay(TimeSpan.FromSeconds(5), CancellationToken);
+		await Task.Delay(TimeSpan.FromSeconds(10), CancellationToken);
-		
+
 		serverOutputEvent.Set();
 		process.AddOutputListener(OnOutput, maxLinesToReadFromHistory: 0);
 		
-		while (CancellationToken.Check()) {
+		while (!CancellationToken.IsCancellationRequested) {
 			serverOutputEvent.Reset();
+
+			PlayerCounts = await TryGetPlayerCounts();
 			
-			InstancePlayerCounts? latestPlayerCounts = await TryGetPlayerCounts();
+			if (!firstDetection.Task.IsCompleted) {
-			UpdatePlayerCounts(latestPlayerCounts);
+				firstDetection.SetResult();
-			
-			if (latestPlayerCounts == null) {
-				await Task.Delay(WaitingForFirstDetection ? TimeSpan.FromSeconds(5) : TimeSpan.FromSeconds(10), CancellationToken);
-			}
-			else {
-				await Task.Delay(TimeSpan.FromSeconds(10), CancellationToken);
-				await serverOutputEvent.WaitHandle.WaitOneAsync(CancellationToken);
-				await Task.Delay(TimeSpan.FromSeconds(1), CancellationToken);
 			}
+
+			await Task.Delay(TimeSpan.FromSeconds(10), CancellationToken);
+			await serverOutputEvent.WaitHandle.WaitOneAsync(CancellationToken);
+			await Task.Delay(TimeSpan.FromSeconds(1), CancellationToken);
 		}
 	}
-	
+
 	private async Task<InstancePlayerCounts?> TryGetPlayerCounts() {
 		try {
-			return await ServerStatusProtocol.GetPlayerCounts(serverPort, CancellationToken);
+			var result = await ServerStatusProtocol.GetPlayerCounts(serverPort, CancellationToken);
+			Logger.Debug("Detected {OnlinePlayerCount} / {MaximumPlayerCount} online player(s).", result.Online, result.Maximum);
+			return result;
 		} catch (ServerStatusProtocol.ProtocolException e) {
-			Logger.Error("{Message}", e.Message);
+			Logger.Error(e.Message);
-			return null;
-		} catch (SocketException e) {
-			bool waitingForServerStart = e.SocketErrorCode == SocketError.ConnectionRefused && WaitingForFirstDetection;
-			if (!waitingForServerStart) {
-				Logger.Warning("Could not check online player count. Socket error {ErrorCode} ({ErrorCodeName}), reason: {ErrorMessage}", e.ErrorCode, e.SocketErrorCode, e.Message);
-			}
-			
 			return null;
 		} catch (Exception e) {
 			Logger.Error(e, "Caught exception while checking online player count.");
 			return null;
 		}
 	}
-	
+
-	private void UpdatePlayerCounts(InstancePlayerCounts? newPlayerCounts) {
-		if (newPlayerCounts is {} value) {
-			Logger.Debug("Detected {OnlinePlayerCount} / {MaximumPlayerCount} online player(s).", value.Online, value.Maximum);
-			firstDetection.TrySetResult();
-		}
-		
-		EventHandler<int?>? onlinePlayerCountChanged;
-		lock (this) {
-			if (playerCounts == newPlayerCounts) {
-				return;
-			}
-			
-			playerCounts = newPlayerCounts;
-			onlinePlayerCountChanged = OnlinePlayerCountChanged;
-		}
-		
-		onlinePlayerCountChanged?.Invoke(this, newPlayerCounts?.Online);
-		
-		if (!controllerConnection.TrySend(new ReportInstancePlayerCountsMessage(instanceGuid, newPlayerCounts))) {
-			Logger.Warning("Could not report online player count to Controller.");
-		}
-	}
-	
 	public async Task WaitForOnlinePlayers(CancellationToken cancellationToken) {
 		await firstDetection.Task.WaitAsync(cancellationToken);
-		
+
 		var onlinePlayersDetected = AsyncTasks.CreateCompletionSource();
-		
+
 		lock (this) {
 			if (playerCounts is { Online: > 0 }) {
 				return;
@@ -112,9 +102,9 @@ sealed class InstancePlayerCountTracker : CancellableBackgroundTask {
 			else if (playerCounts == null) {
 				throw new InvalidOperationException();
 			}
-			
+
 			OnlinePlayerCountChanged += OnOnlinePlayerCountChanged;
-			
+
 			void OnOnlinePlayerCountChanged(object? sender, int? newPlayerCount) {
 				if (newPlayerCount == null) {
 					onlinePlayersDetected.TrySetException(new InvalidOperationException());
@@ -126,10 +116,10 @@ sealed class InstancePlayerCountTracker : CancellableBackgroundTask {
 				}
 			}
 		}
-		
+
 		await onlinePlayersDetected.Task;
 	}
-	
+
 	private void OnOutput(object? sender, string? line) {
 		lock (this) {
 			if (!isDisposed) {
@@ -137,13 +127,13 @@ sealed class InstancePlayerCountTracker : CancellableBackgroundTask {
 			}
 		}
 	}
-	
+
 	protected override void Dispose() {
 		lock (this) {
 			isDisposed = true;
 			playerCounts = null;
 		}
-		
+
 		process.RemoveOutputListener(OnOutput);
 		serverOutputEvent.Dispose();
 	}

Agent/Phantom.Agent.Services/Instances/State/InstanceRunningState.cs

@@ -10,20 +10,20 @@ namespace Phantom.Agent.Services.Instances.State;
 sealed class InstanceRunningState : IDisposable {
 	public InstanceTicketManager.Ticket Ticket { get; }
 	public InstanceProcess Process { get; }
-	
+
 	internal bool IsStopping { get; set; }
-	
+
 	private readonly InstanceContext context;
 	private readonly InstanceConfiguration configuration;
 	private readonly IServerLauncher launcher;
 	private readonly CancellationToken cancellationToken;
-	
+
 	private readonly InstanceLogSender logSender;
 	private readonly InstancePlayerCountTracker playerCountTracker;
 	private readonly BackupScheduler backupScheduler;
-	
+
 	private bool isDisposed;
-	
+
 	public InstanceRunningState(InstanceContext context, InstanceConfiguration configuration, IServerLauncher launcher, InstanceTicketManager.Ticket ticket, InstanceProcess process, CancellationToken cancellationToken) {
 		this.context = context;
 		this.configuration = configuration;
@@ -31,17 +31,17 @@ sealed class InstanceRunningState : IDisposable {
 		this.Ticket = ticket;
 		this.Process = process;
 		this.cancellationToken = cancellationToken;
-		
+
 		this.logSender = new InstanceLogSender(context.Services.ControllerConnection, context.InstanceGuid, context.ShortName);
 		this.playerCountTracker = new InstancePlayerCountTracker(context, process, configuration.ServerPort);
-		
+
 		this.backupScheduler = new BackupScheduler(context, playerCountTracker);
 		this.backupScheduler.BackupCompleted += OnScheduledBackupCompleted;
 	}
-	
+
 	public void Initialize() {
 		Process.Ended += ProcessEnded;
-		
+
 		if (Process.HasEnded) {
 			if (TryDispose()) {
 				context.Logger.Warning("Session ended immediately after it was started.");
@@ -53,17 +53,17 @@ sealed class InstanceRunningState : IDisposable {
 			Process.AddOutputListener(SessionOutput);
 		}
 	}
-	
+
 	private void SessionOutput(object? sender, string line) {
 		context.Logger.Debug("[Server] {Line}", line);
 		logSender.Enqueue(line);
 	}
-	
+
 	private void ProcessEnded(object? sender, EventArgs e) {
 		if (!TryDispose()) {
 			return;
 		}
-		
+
 		if (cancellationToken.IsCancellationRequested) {
 			return;
 		}
@@ -77,11 +77,11 @@ sealed class InstanceRunningState : IDisposable {
 			context.Actor.Tell(new InstanceActor.LaunchInstanceCommand(configuration, launcher, Ticket, IsRestarting: true));
 		}
 	}
-	
+
 	private void OnScheduledBackupCompleted(object? sender, BackupCreationResult e) {
 		context.ReportEvent(new InstanceBackupCompletedEvent(e.Kind, e.Warnings));
 	}
-	
+
 	public async Task<SendCommandToInstanceResult> SendCommand(string command, CancellationToken cancellationToken) {
 		try {
 			context.Logger.Information("Sending command: {Command}", command);
@@ -94,7 +94,7 @@ sealed class InstanceRunningState : IDisposable {
 			return SendCommandToInstanceResult.UnknownError;
 		}
 	}
-	
+
 	public void OnStopInitiated() {
 		backupScheduler.Stop();
 		playerCountTracker.Stop();
@@ -105,10 +105,10 @@ sealed class InstanceRunningState : IDisposable {
 			if (isDisposed) {
 				return false;
 			}
-			
+
 			isDisposed = true;
 		}
-		
+
 		OnStopInitiated();
 		logSender.Stop();
 		
@@ -116,7 +116,7 @@ sealed class InstanceRunningState : IDisposable {
 		
 		return true;
 	}
-	
+
 	public void Dispose() {
 		TryDispose();
 	}

Agent/Phantom.Agent.Services/Instances/State/InstanceStopProcedure.cs

@@ -7,12 +7,12 @@ using Phantom.Common.Data.Minecraft;
 namespace Phantom.Agent.Services.Instances.State;
 
 static class InstanceStopProcedure {
-	private static readonly ushort[] Stops = [60, 30, 10, 5, 4, 3, 2, 1, 0];
+	private static readonly ushort[] Stops = { 60, 30, 10, 5, 4, 3, 2, 1, 0 };
-	
+
 	public static async Task<bool> Run(InstanceContext context, MinecraftStopStrategy stopStrategy, InstanceRunningState runningState, Action<IInstanceStatus> reportStatus, CancellationToken cancellationToken) {
 		var process = runningState.Process;
 		runningState.IsStopping = true;
-		
+
 		var seconds = stopStrategy.Seconds;
 		if (seconds > 0) {
 			try {
@@ -22,7 +22,7 @@ static class InstanceStopProcedure {
 				return false;
 			}
 		}
-		
+
 		try {
 			// Too late to cancel the stop procedure now.
 			runningState.OnStopInitiated();
@@ -36,19 +36,19 @@ static class InstanceStopProcedure {
 			reportStatus(InstanceStatus.NotRunning);
 			context.ReportEvent(InstanceEvent.Stopped);
 		}
-		
+
 		return true;
 	}
-	
+
 	private static async Task CountDownWithAnnouncements(InstanceContext context, InstanceProcess process, ushort seconds, CancellationToken cancellationToken) {
 		context.Logger.Information("Session stopping in {Seconds} seconds.", seconds);
-		
+
 		foreach (var stop in Stops) {
 			// TODO change to event-based cancellation
 			if (process.HasEnded) {
 				return;
 			}
-			
+
 			if (seconds > stop) {
 				await process.SendCommand(GetCountDownAnnouncementCommand(seconds), cancellationToken);
 				await Task.Delay(TimeSpan.FromSeconds(seconds - stop), cancellationToken);
@@ -56,19 +56,19 @@ static class InstanceStopProcedure {
 			}
 		}
 	}
-	
+
 	private static string GetCountDownAnnouncementCommand(ushort seconds) {
 		return MinecraftCommand.Say("Server shutting down in " + seconds + (seconds == 1 ? " second." : " seconds."));
 	}
-	
+
 	private static async Task DoStop(InstanceContext context, InstanceProcess process) {
 		context.Logger.Information("Sending stop command...");
 		await TrySendStopCommand(context, process);
-		
+
 		context.Logger.Information("Waiting for session to end...");
 		await WaitForSessionToEnd(context, process);
 	}
-	
+
 	private static async Task TrySendStopCommand(InstanceContext context, InstanceProcess process) {
 		using var timeout = new CancellationTokenSource(TimeSpan.FromSeconds(5));
 		try {
@@ -83,7 +83,7 @@ static class InstanceStopProcedure {
 			context.Logger.Warning(e, "Caught exception while sending stop command.");
 		}
 	}
-	
+
 	private static async Task WaitForSessionToEnd(InstanceContext context, InstanceProcess process) {
 		try {
 			await process.WaitForExit(TimeSpan.FromSeconds(55));

Agent/Phantom.Agent.Services/Phantom.Agent.Services.csproj

@@ -8,6 +8,7 @@
   <ItemGroup>
     <ProjectReference Include="..\..\Common\Phantom.Common.Messages.Agent\Phantom.Common.Messages.Agent.csproj" />
     <ProjectReference Include="..\Phantom.Agent.Minecraft\Phantom.Agent.Minecraft.csproj" />
+    <ProjectReference Include="..\Phantom.Agent.Rpc\Phantom.Agent.Rpc.csproj" />
   </ItemGroup>
 
 </Project>

Agent/Phantom.Agent.Services/Rpc/ControllerConnection.cs

@@ -1,19 +0,0 @@
-using Phantom.Common.Messages.Agent;
-using Phantom.Utils.Actor;
-using Phantom.Utils.Rpc.Message;
-
-namespace Phantom.Agent.Services.Rpc;
-
-public sealed class ControllerConnection(MessageSender<IMessageToController> sender) {
-	internal bool TrySend<TMessage>(TMessage message) where TMessage : IMessageToController {
-		return sender.TrySend(message);
-	}
-	
-	internal ValueTask Send<TMessage>(TMessage message, CancellationToken cancellationToken) where TMessage : IMessageToController {
-		return sender.Send(message, cancellationToken);
-	}
-	
-	internal Task<TReply> Send<TMessage, TReply>(TMessage message, TimeSpan waitForReplyTime, CancellationToken cancellationToken) where TMessage : IMessageToController, ICanReply<TReply> {
-		return sender.Send<TMessage, TReply>(message, waitForReplyTime, cancellationToken);
-	}
-}

Agent/Phantom.Agent.Services/Rpc/ControllerHandshake.cs

@@ -1,50 +0,0 @@
-using System.Collections.Immutable;
-using Phantom.Common.Messages.Agent.Handshake;
-using Phantom.Common.Messages.Agent.ToAgent;
-using Phantom.Utils.Logging;
-using Phantom.Utils.Rpc.Message;
-using Phantom.Utils.Rpc.Runtime;
-using Phantom.Utils.Rpc.Runtime.Client;
-using Serilog;
-
-namespace Phantom.Agent.Services.Rpc;
-
-public sealed class ControllerHandshake(AgentRegistration registration, AgentRegistrationHandler registrationHandler) : IRpcClientHandshake {
-	private const int MaxInstances = 100_000;
-	private const int MaxMessageBytes = 1024 * 1024 * 8;
-	
-	private readonly ILogger logger = PhantomLogger.Create<ControllerHandshake>();
-	
-	public async Task Perform(RpcStream stream, CancellationToken cancellationToken) {
-		logger.Information("Registering with the controller...");
-		
-		ReadOnlyMemory<byte> serializedRegistration = MessageSerialization.Serialize(registration);
-		await stream.WriteSignedInt(serializedRegistration.Length, cancellationToken);
-		await stream.WriteBytes(serializedRegistration, cancellationToken);
-		await stream.Flush(cancellationToken);
-		
-		if (await stream.ReadByte(cancellationToken) == 0) {
-			return;
-		}
-		
-		uint configureInstanceMessageCount = await stream.ReadUnsignedInt(cancellationToken);
-		if (configureInstanceMessageCount > MaxInstances) {
-			throw new InvalidOperationException("Trying to configure too many instances (" + configureInstanceMessageCount + " > " + MaxInstances + ").");
-		}
-		
-		var configureInstanceMessages = ImmutableArray.CreateBuilder<ConfigureInstanceMessage>();
-		
-		for (int index = 0; index < configureInstanceMessageCount; index++) {
-			int serializedMessageLength = await stream.ReadSignedInt(cancellationToken);
-			if (serializedMessageLength is < 0 or > MaxMessageBytes) {
-				throw new InvalidOperationException("Message must be between 0 and " + MaxMessageBytes + " bytes.");
-			}
-			
-			var serializedMessage = await stream.ReadBytes(serializedMessageLength, cancellationToken);
-			configureInstanceMessages.Add(MessageSerialization.Deserialize<ConfigureInstanceMessage>(serializedMessage));
-		}
-		
-		registrationHandler.OnRegistrationComplete(configureInstanceMessages.ToImmutable());
-		logger.Information("Registration complete.");
-	}
-}

Agent/Phantom.Agent.Services/Rpc/ControllerMessageHandlerActor.cs

@@ -1,43 +1,101 @@
 using Phantom.Agent.Services.Instances;
 using Phantom.Common.Data;
+using Phantom.Common.Data.Instance;
 using Phantom.Common.Data.Replies;
 using Phantom.Common.Messages.Agent;
+using Phantom.Common.Messages.Agent.BiDirectional;
 using Phantom.Common.Messages.Agent.ToAgent;
+using Phantom.Common.Messages.Agent.ToController;
 using Phantom.Utils.Actor;
+using Phantom.Utils.Logging;
+using Phantom.Utils.Rpc.Runtime;
+using Serilog;
 
 namespace Phantom.Agent.Services.Rpc;
 
 public sealed class ControllerMessageHandlerActor : ReceiveActor<IMessageToAgent> {
-	public readonly record struct Init(AgentServices Agent);
+	private static ILogger Logger { get; } = PhantomLogger.Create<ControllerMessageHandlerActor>();
+
+	public readonly record struct Init(RpcConnectionToServer<IMessageToController> Connection, AgentServices Agent, CancellationTokenSource ShutdownTokenSource);
 	
 	public static Props<IMessageToAgent> Factory(Init init) {
 		return Props<IMessageToAgent>.Create(() => new ControllerMessageHandlerActor(init), new ActorConfiguration { SupervisorStrategy = SupervisorStrategies.Resume });
 	}
 	
+	private readonly RpcConnectionToServer<IMessageToController> connection;
 	private readonly AgentServices agent;
-	
+	private readonly CancellationTokenSource shutdownTokenSource;
+
 	private ControllerMessageHandlerActor(Init init) {
+		this.connection = init.Connection;
 		this.agent = init.Agent;
+		this.shutdownTokenSource = init.ShutdownTokenSource;
 		
+		ReceiveAsync<RegisterAgentSuccessMessage>(HandleRegisterAgentSuccess);
+		Receive<RegisterAgentFailureMessage>(HandleRegisterAgentFailure);
 		ReceiveAndReplyLater<ConfigureInstanceMessage, Result<ConfigureInstanceResult, InstanceActionFailure>>(HandleConfigureInstance);
 		ReceiveAndReplyLater<LaunchInstanceMessage, Result<LaunchInstanceResult, InstanceActionFailure>>(HandleLaunchInstance);
 		ReceiveAndReplyLater<StopInstanceMessage, Result<StopInstanceResult, InstanceActionFailure>>(HandleStopInstance);
 		ReceiveAndReplyLater<SendCommandToInstanceMessage, Result<SendCommandToInstanceResult, InstanceActionFailure>>(HandleSendCommandToInstance);
+		Receive<ReplyMessage>(HandleReply);
+	}
+
+	private async Task HandleRegisterAgentSuccess(RegisterAgentSuccessMessage message) {
+		Logger.Information("Agent authentication successful.");
+
+		void ShutdownAfterConfigurationFailed(Guid instanceGuid, InstanceConfiguration configuration) {
+			Logger.Fatal("Unable to configure instance \"{Name}\" (GUID {Guid}), shutting down.", configuration.InstanceName, instanceGuid);
+			shutdownTokenSource.Cancel();
+		}
+		
+		foreach (var configureInstanceMessage in message.InitialInstanceConfigurations) {
+			var result = await HandleConfigureInstance(configureInstanceMessage, alwaysReportStatus: true);
+			if (!result.Is(ConfigureInstanceResult.Success)) {
+				ShutdownAfterConfigurationFailed(configureInstanceMessage.InstanceGuid, configureInstanceMessage.Configuration);
+				return;
+			}
+		}
+
+		connection.SetIsReady();
+		
+		await connection.Send(new AdvertiseJavaRuntimesMessage(agent.JavaRuntimeRepository.All));
+		agent.InstanceTicketManager.RefreshAgentStatus();
+	}
+
+	private void HandleRegisterAgentFailure(RegisterAgentFailureMessage message) {
+		string errorMessage = message.FailureKind switch {
+			RegisterAgentFailure.ConnectionAlreadyHasAnAgent => "This connection already has an associated agent.",
+			RegisterAgentFailure.InvalidToken                => "Invalid token.",
+			_                                                => "Unknown error " + (byte) message.FailureKind + "."
+		};
+
+		Logger.Fatal("Agent authentication failed: {Error}", errorMessage);
+		
+		PhantomLogger.Dispose();
+		Environment.Exit(1);
+	}
+	
+	private Task<Result<ConfigureInstanceResult, InstanceActionFailure>> HandleConfigureInstance(ConfigureInstanceMessage message, bool alwaysReportStatus) {
+		return agent.InstanceManager.Request(new InstanceManagerActor.ConfigureInstanceCommand(message.InstanceGuid, message.Configuration, message.LaunchProperties, message.LaunchNow, alwaysReportStatus));
 	}
 	
 	private async Task<Result<ConfigureInstanceResult, InstanceActionFailure>> HandleConfigureInstance(ConfigureInstanceMessage message) {
-		return await agent.InstanceManager.Request(new InstanceManagerActor.ConfigureInstanceCommand(message.InstanceGuid, message.Configuration, message.LaunchProperties, message.LaunchNow, AlwaysReportStatus: false));
+		return await HandleConfigureInstance(message, alwaysReportStatus: false);
 	}
-	
+
 	private async Task<Result<LaunchInstanceResult, InstanceActionFailure>> HandleLaunchInstance(LaunchInstanceMessage message) {
 		return await agent.InstanceManager.Request(new InstanceManagerActor.LaunchInstanceCommand(message.InstanceGuid));
 	}
-	
+
 	private async Task<Result<StopInstanceResult, InstanceActionFailure>> HandleStopInstance(StopInstanceMessage message) {
 		return await agent.InstanceManager.Request(new InstanceManagerActor.StopInstanceCommand(message.InstanceGuid, message.StopStrategy));
 	}
-	
+
 	private async Task<Result<SendCommandToInstanceResult, InstanceActionFailure>> HandleSendCommandToInstance(SendCommandToInstanceMessage message) {
 		return await agent.InstanceManager.Request(new InstanceManagerActor.SendCommandToInstanceCommand(message.InstanceGuid, message.Command));
 	}
+
+	private void HandleReply(ReplyMessage message) {
+		connection.Receive(message);
+	}
 }

Agent/Phantom.Agent.Services/Rpc/ControllerMessageReceiver.cs

@@ -1,11 +0,0 @@
-using Phantom.Common.Messages.Agent;
-using Phantom.Utils.Actor;
-using Phantom.Utils.Rpc.Message;
-
-namespace Phantom.Agent.Services.Rpc;
-
-public sealed class ControllerMessageReceiver(ActorRef<IMessageToAgent> actor, AgentRegistrationHandler agentRegistrationHandler) : IMessageReceiver<IMessageToAgent>.Actor(actor) {
-	public override void OnSessionRestarted() {
-		agentRegistrationHandler.OnNewSession();
-	}
-}

Agent/Phantom.Agent.Services/Rpc/ControllerSendQueue.cs

@@ -1,53 +0,0 @@
-using System.Threading.Channels;
-using Phantom.Common.Messages.Agent;
-using Phantom.Utils.Logging;
-using Serilog;
-
-namespace Phantom.Agent.Services.Rpc;
-
-sealed class ControllerSendQueue<TMessage> where TMessage : IMessageToController {
-	private readonly ILogger logger;
-	private readonly Channel<TMessage> channel;
-	private readonly Task sendTask;
-	private readonly CancellationTokenSource shutdownTokenSource = new ();
-	
-	public ControllerSendQueue(ControllerConnection controllerConnection, string loggerName, int capacity, bool singleWriter) {
-		this.logger = PhantomLogger.Create<ControllerSendQueue<TMessage>>(loggerName);
-		
-		this.channel = Channel.CreateBounded<TMessage>(new BoundedChannelOptions(capacity) {
-			AllowSynchronousContinuations = false,
-			FullMode = BoundedChannelFullMode.DropOldest,
-			SingleReader = true,
-			SingleWriter = singleWriter,
-		});
-		
-		this.sendTask = Send(controllerConnection, shutdownTokenSource.Token);
-	}
-	
-	private async Task Send(ControllerConnection controllerConnection, CancellationToken cancellationToken) {
-		await foreach (var message in channel.Reader.ReadAllAsync(cancellationToken)) {
-			await controllerConnection.Send(message, cancellationToken);
-		}
-	}
-	
-	public void Enqueue(TMessage message) {
-		channel.Writer.TryWrite(message);
-	}
-	
-	public async Task Shutdown(TimeSpan gracefulTimeout) {
-		channel.Writer.TryComplete();
-		
-		try {
-			await sendTask.WaitAsync(gracefulTimeout);
-		} catch (TimeoutException) {
-			logger.Warning("Timed out waiting for queue to finish processing.");
-		} catch (Exception) {
-			// Ignore.
-		}
-		
-		await shutdownTokenSource.CancelAsync();
-		await sendTask.ConfigureAwait(ConfigureAwaitOptions.SuppressThrowing);
-		
-		shutdownTokenSource.Dispose();
-	}
-}

Agent/Phantom.Agent/AgentKey.cs

@@ -1,4 +1,4 @@
-using System.Text;
+using NetMQ;
 using Phantom.Common.Data;
 using Phantom.Utils.Cryptography;
 using Phantom.Utils.IO;
@@ -9,8 +9,8 @@ namespace Phantom.Agent;
 
 static class AgentKey {
 	private static ILogger Logger { get; } = PhantomLogger.Create(nameof(AgentKey));
-	
+
-	public static Task<ConnectionKey?> Load(string? agentKeyToken, string? agentKeyFilePath) {
+	public static Task<(NetMQCertificate, AuthToken)?> Load(string? agentKeyToken, string? agentKeyFilePath) {
 		if (agentKeyFilePath != null) {
 			return LoadFromFile(agentKeyFilePath);
 		}
@@ -21,28 +21,27 @@ static class AgentKey {
 			throw new InvalidOperationException();
 		}
 	}
-	
+
-	private static async Task<ConnectionKey?> LoadFromFile(string agentKeyFilePath) {
+	private static async Task<(NetMQCertificate, AuthToken)?> LoadFromFile(string agentKeyFilePath) {
 		if (!File.Exists(agentKeyFilePath)) {
 			Logger.Fatal("Missing agent key file: {AgentKeyFilePath}", agentKeyFilePath);
 			return null;
 		}
-		
+
 		try {
-			Files.RequireMaximumFileSize(agentKeyFilePath, maximumBytes: 64);
+			Files.RequireMaximumFileSize(agentKeyFilePath, 64);
-			string[] lines = await File.ReadAllLinesAsync(agentKeyFilePath, Encoding.UTF8);
+			return LoadFromBytes(await File.ReadAllBytesAsync(agentKeyFilePath));
-			return LoadFromToken(lines[0]);
 		} catch (IOException e) {
 			Logger.Fatal("Error loading agent key from file: {AgentKeyFilePath}", agentKeyFilePath);
-			Logger.Fatal("{Message}", e.Message);
+			Logger.Fatal(e.Message);
 			return null;
 		} catch (Exception) {
 			Logger.Fatal("File does not contain a valid agent key: {AgentKeyFilePath}", agentKeyFilePath);
 			return null;
 		}
 	}
-	
+
-	private static ConnectionKey? LoadFromToken(string agentKey) {
+	private static (NetMQCertificate, AuthToken)? LoadFromToken(string agentKey) {
 		try {
 			return LoadFromBytes(TokenGenerator.DecodeBytes(agentKey));
 		} catch (Exception) {
@@ -50,10 +49,12 @@ static class AgentKey {
 			return null;
 		}
 	}
-	
+
-	private static ConnectionKey? LoadFromBytes(byte[] agentKey) {
+	private static (NetMQCertificate, AuthToken)? LoadFromBytes(byte[] agentKey) {
-		var connectionKey = ConnectionKey.FromBytes(agentKey);
+		var (publicKey, agentToken) = ConnectionCommonKey.FromBytes(agentKey);
+		var controllerCertificate = NetMQCertificate.FromPublicKey(publicKey);
+		
 		Logger.Information("Loaded agent key.");
-		return connectionKey;
+		return (controllerCertificate, agentToken);
 	}
 }

Agent/Phantom.Agent/GuidFile.cs

@@ -7,12 +7,12 @@ namespace Phantom.Agent;
 
 static class GuidFile {
 	private static ILogger Logger { get; } = PhantomLogger.Create(nameof(GuidFile));
-	
+
 	private const string GuidFileName = "agent.guid";
 	
 	public static async Task<Guid?> CreateOrLoad(string folderPath) {
 		string filePath = Path.Combine(folderPath, GuidFileName);
-		
+
 		if (File.Exists(filePath)) {
 			try {
 				var guid = await LoadGuidFromFile(filePath);
@@ -25,7 +25,7 @@ static class GuidFile {
 		}
 		
 		Logger.Information("Creating agent GUID file: {FilePath}", filePath);
-		
+
 		try {
 			var guid = Guid.NewGuid();
 			await File.WriteAllTextAsync(filePath, guid.ToString(), Encoding.ASCII);
@@ -37,7 +37,7 @@ static class GuidFile {
 	}
 	
 	private static async Task<Guid> LoadGuidFromFile(string filePath) {
-		Files.RequireMaximumFileSize(filePath, maximumBytes: 128);
+		Files.RequireMaximumFileSize(filePath, 128);
 		string contents = await File.ReadAllTextAsync(filePath, Encoding.ASCII);
 		return Guid.Parse(contents.Trim());
 	}

Agent/Phantom.Agent/Program.cs

@@ -1,16 +1,17 @@
 using System.Reflection;
+using NetMQ;
 using Phantom.Agent;
-using Phantom.Agent.Minecraft.Java;
+using Phantom.Agent.Rpc;
 using Phantom.Agent.Services;
 using Phantom.Agent.Services.Rpc;
 using Phantom.Common.Data.Agent;
 using Phantom.Common.Messages.Agent;
-using Phantom.Common.Messages.Agent.Handshake;
+using Phantom.Common.Messages.Agent.ToController;
 using Phantom.Utils.Actor;
 using Phantom.Utils.Logging;
-using Phantom.Utils.Rpc.Runtime.Client;
+using Phantom.Utils.Rpc;
+using Phantom.Utils.Rpc.Sockets;
 using Phantom.Utils.Runtime;
-using Phantom.Utils.Threading;
 
 const int ProtocolVersion = 1;
 
@@ -26,71 +27,56 @@ PosixSignals.RegisterCancellation(shutdownCancellationTokenSource, static () =>
 
 try {
 	var fullVersion = AssemblyAttributes.GetFullVersion(Assembly.GetExecutingAssembly());
-	
+
 	PhantomLogger.Root.InformationHeading("Initializing Phantom Panel agent...");
 	PhantomLogger.Root.Information("Agent version: {Version}", fullVersion);
-	
+
 	var (controllerHost, controllerPort, javaSearchPath, agentKeyToken, agentKeyFilePath, agentName, maxInstances, maxMemory, allowedServerPorts, allowedRconPorts, maxConcurrentBackupCompressionTasks) = Variables.LoadOrStop();
-	
+
 	var agentKey = await AgentKey.Load(agentKeyToken, agentKeyFilePath);
 	if (agentKey == null) {
 		return 1;
 	}
-	
+
 	var folders = new AgentFolders("./data", "./temp", javaSearchPath);
 	if (!folders.TryCreate()) {
 		return 1;
 	}
-	
+
 	var agentGuid = await GuidFile.CreateOrLoad(folders.DataFolderPath);
 	if (agentGuid == null) {
 		return 1;
 	}
-	
+
+	var (controllerCertificate, agentToken) = agentKey.Value;
 	var agentInfo = new AgentInfo(agentGuid.Value, agentName, ProtocolVersion, fullVersion, maxInstances, maxMemory, allowedServerPorts, allowedRconPorts);
-	var javaRuntimeRepository = await JavaRuntimeDiscovery.Scan(folders.JavaSearchFolderPath, shutdownCancellationToken);
 	
-	var agentRegistrationHandler = new AgentRegistrationHandler();
+	PhantomLogger.Root.InformationHeading("Launching Phantom Panel agent...");
-	var controllerHandshake = new ControllerHandshake(new AgentRegistration(agentInfo, javaRuntimeRepository.All), agentRegistrationHandler);
 	
-	var rpcClientConnectionParameters = new RpcClientConnectionParameters(
+	var rpcConfiguration = new RpcConfiguration("Agent", controllerHost, controllerPort, controllerCertificate);
-		Host: controllerHost,
+	var rpcSocket = RpcClientSocket.Connect(rpcConfiguration, AgentMessageRegistries.Definitions, new RegisterAgentMessage(agentToken, agentInfo));
-		Port: controllerPort,
+
-		DistinguishedName: "phantom-controller",
+	var agentServices = new AgentServices(agentInfo, folders, new AgentServiceConfiguration(maxConcurrentBackupCompressionTasks), new ControllerConnection(rpcSocket.Connection));
-		CertificateThumbprint: agentKey.Value.CertificateThumbprint,
+	await agentServices.Initialize();
-		AuthToken: agentKey.Value.AuthToken,
+
-		Handshake: controllerHandshake,
+	var rpcMessageHandlerInit = new ControllerMessageHandlerActor.Init(rpcSocket.Connection, agentServices, shutdownCancellationTokenSource);
-		MessageQueueCapacity: 250,
+	var rpcMessageHandlerActor = agentServices.ActorSystem.ActorOf(ControllerMessageHandlerActor.Factory(rpcMessageHandlerInit), "ControllerMessageHandler");
-		FrameQueueCapacity: 500,
-		MaxConcurrentlyHandledMessages: 50
-	);
-	
-	using var rpcClient = await RpcClient<IMessageToController, IMessageToAgent>.Connect("Controller", rpcClientConnectionParameters, AgentMessageRegistries.Registries, shutdownCancellationToken);
-	if (rpcClient == null) {
-		PhantomLogger.Root.Fatal("Could not connect to Phantom Controller, shutting down.");
-		return 1;
-	}
 	
+	var rpcDisconnectSemaphore = new SemaphoreSlim(0, 1);
+	var rpcTask = RpcClientRuntime.Launch(rpcSocket, rpcMessageHandlerActor, rpcDisconnectSemaphore, shutdownCancellationToken);
 	try {
-		PhantomLogger.Root.InformationHeading("Launching Phantom Panel agent...");
+		await rpcTask.WaitAsync(shutdownCancellationToken);
-		
-		var agentServices = new AgentServices(agentInfo, folders, new AgentServiceConfiguration(maxConcurrentBackupCompressionTasks), new ControllerConnection(rpcClient.MessageSender), javaRuntimeRepository);
-		
-		var rpcMessageHandlerInit = new ControllerMessageHandlerActor.Init(agentServices);
-		var rpcMessageHandlerActor = agentServices.ActorSystem.ActorOf(ControllerMessageHandlerActor.Factory(rpcMessageHandlerInit), "ControllerMessageHandler");
-		
-		rpcClient.StartListening(new ControllerMessageReceiver(rpcMessageHandlerActor, agentRegistrationHandler));
-		
-		if (await agentRegistrationHandler.Start(agentServices, shutdownCancellationToken)) {
-			PhantomLogger.Root.Information("Phantom Panel agent is ready.");
-			await shutdownCancellationToken.WaitHandle.WaitOneAsync();
-		}
-		
-		await agentServices.Shutdown();
 	} finally {
-		await rpcClient.Shutdown();
+		shutdownCancellationTokenSource.Cancel();
+		await agentServices.Shutdown();
+
+		rpcDisconnectSemaphore.Release();
+		await rpcTask;
+		rpcDisconnectSemaphore.Dispose();
+		
+		NetMQConfig.Cleanup();
 	}
-	
+
 	return 0;
 } catch (OperationCanceledException) {
 	return 0;
@@ -101,7 +87,7 @@ try {
 	return 1;
 } finally {
 	shutdownCancellationTokenSource.Dispose();
-	
+
 	PhantomLogger.Root.Information("Bye!");
 	PhantomLogger.Dispose();
 }

Agent/Phantom.Agent/Variables.cs

@@ -21,7 +21,7 @@ sealed record Variables(
 	private static Variables LoadOrThrow() {
 		var (agentKeyToken, agentKeyFilePath) = EnvironmentVariables.GetEitherString("AGENT_KEY", "AGENT_KEY_FILE").Require;
 		var javaSearchPath = EnvironmentVariables.GetString("JAVA_SEARCH_PATH").WithDefaultGetter(GetDefaultJavaSearchPath);
-		
+
 		return new Variables(
 			EnvironmentVariables.GetString("CONTROLLER_HOST").Require,
 			EnvironmentVariables.GetPortNumber("CONTROLLER_PORT").WithDefault(9401),
@@ -36,11 +36,11 @@ sealed record Variables(
 			(ushort) EnvironmentVariables.GetInteger("MAX_CONCURRENT_BACKUP_COMPRESSION_TASKS", min: 1, max: 10000).WithDefault(1)
 		);
 	}
-	
+
 	private static string GetDefaultJavaSearchPath() {
 		return JavaRuntimeDiscovery.GetSystemSearchPath() ?? throw new Exception("Could not automatically determine the path to Java installations on this system. Please set the JAVA_SEARCH_PATH environment variable to the folder containing Java installations.");
 	}
-	
+
 	public static Variables LoadOrStop() {
 		try {
 			return LoadOrThrow();

Common/Phantom.Common.Data.Tests/RamAllocationUnitsTests.cs

@@ -8,7 +8,7 @@ public sealed class RamAllocationUnitsTests {
 		private Action CallFromMegabytes(int value) {
 			return () => RamAllocationUnits.FromMegabytes(value);
 		}
-		
+
 		[TestCase(1)]
 		[TestCase(-1)]
 		[TestCase(255)]
@@ -24,13 +24,13 @@ public sealed class RamAllocationUnitsTests {
 		public void LessThan256MegabytesThrows(int value) {
 			Assert.That(CallFromMegabytes(value), Throws.Exception.TypeOf<ArgumentOutOfRangeException>().With.Message.StartsWith("Must be at least 0 MB."));
 		}
-		
+
 		[TestCase(16777216)]
 		[TestCase(int.MaxValue - 255)]
 		public void MoreThan16TerabytesThrows(int value) {
 			Assert.That(CallFromMegabytes(value), Throws.Exception.TypeOf<ArgumentOutOfRangeException>().With.Message.StartsWith("Must be at most " + (256 * 65535) + " MB."));
 		}
-		
+
 		[TestCase(0)]
 		[TestCase(256)]
 		[TestCase(512)]
@@ -41,17 +41,17 @@ public sealed class RamAllocationUnitsTests {
 			Assert.That(RamAllocationUnits.FromMegabytes(value).InMegabytes, Is.EqualTo(value));
 		}
 	}
-	
+
 	public sealed class FromString {
 		private Action CallFromString(string definition) {
 			return () => RamAllocationUnits.FromString(definition);
 		}
-		
+
 		[Test]
 		public void EmptyThrows() {
 			Assert.That(CallFromString(""), Throws.Exception.TypeOf<ArgumentOutOfRangeException>().With.Message.StartsWith("Must not be empty."));
 		}
-		
+
 		[Test]
 		public void MissingUnitThrows() {
 			Assert.That(CallFromString("256"), Throws.Exception.TypeOf<ArgumentOutOfRangeException>().With.Message.StartsWith("Must end with "));
@@ -66,23 +66,23 @@ public sealed class RamAllocationUnitsTests {
 		public void UnparseableValueThrows() {
 			Assert.That(CallFromString("123A5M"), Throws.Exception.TypeOf<ArgumentOutOfRangeException>().With.Message.StartsWith("Must begin with a number."));
 		}
-		
+
-		[TestCase("0m", arg2: 0)]
+		[TestCase("0m", 0)]
-		[TestCase("256m", arg2: 256)]
+		[TestCase("256m", 256)]
-		[TestCase("256M", arg2: 256)]
+		[TestCase("256M", 256)]
-		[TestCase("512M", arg2: 512)]
+		[TestCase("512M", 512)]
-		[TestCase("65536M", arg2: 65536)]
+		[TestCase("65536M", 65536)]
 		[TestCase("16776960M", 16777216 - 256)]
 		public void ValidDefinitionInMegabytesIsParsedCorrectly(string definition, int megabytes) {
 			Assert.That(RamAllocationUnits.FromString(definition).InMegabytes, Is.EqualTo(megabytes));
 		}
-		
+
-		[TestCase("0g", arg2: 0)]
+		[TestCase("0g", 0)]
-		[TestCase("1g", arg2: 1024)]
+		[TestCase("1g", 1024)]
-		[TestCase("1G", arg2: 1024)]
+		[TestCase("1G", 1024)]
-		[TestCase("8G", arg2: 8192)]
+		[TestCase("8G", 8192)]
-		[TestCase("64G", arg2: 65536)]
+		[TestCase("64G", 65536)]
-		[TestCase("16383G", arg2: 16776192)]
+		[TestCase("16383G", 16776192)]
 		public void ValidDefinitionInGigabytesIsParsedCorrectly(string definition, int megabytes) {
 			Assert.That(RamAllocationUnits.FromString(definition).InMegabytes, Is.EqualTo(megabytes));
 		}

Common/Phantom.Common.Data.Web/Agent/IAgentConnectionStatus.cs

@@ -3,10 +3,10 @@
 namespace Phantom.Common.Data.Web.Agent;
 
 [MemoryPackable]
-[MemoryPackUnion(tag: 0, typeof(AgentIsOffline))]
+[MemoryPackUnion(0, typeof(AgentIsOffline))]
-[MemoryPackUnion(tag: 1, typeof(AgentIsDisconnected))]
+[MemoryPackUnion(1, typeof(AgentIsDisconnected))]
-[MemoryPackUnion(tag: 2, typeof(AgentIsOnline))]
+[MemoryPackUnion(2, typeof(AgentIsOnline))]
-public partial interface IAgentConnectionStatus;
+public partial interface IAgentConnectionStatus {}
 
 [MemoryPackable(GenerateType.VersionTolerant)]
 public sealed partial record AgentIsOffline : IAgentConnectionStatus;
@@ -20,7 +20,7 @@ public sealed partial record AgentIsOnline : IAgentConnectionStatus;
 public static class AgentConnectionStatus {
 	public static readonly IAgentConnectionStatus Offline = new AgentIsOffline();
 	public static readonly IAgentConnectionStatus Online = new AgentIsOnline();
-	
+
 	public static IAgentConnectionStatus Disconnected(DateTimeOffset lastPingTime) {
 		return new AgentIsDisconnected(lastPingTime);
 	}

Common/Phantom.Common.Data.Web/AuditLog/AuditLogEventType.cs

@@ -13,7 +13,7 @@ public enum AuditLogEventType {
 	InstanceEdited,
 	InstanceLaunched,
 	InstanceStopped,
-	InstanceCommandExecuted,
+	InstanceCommandExecuted
 }
 
 public static class AuditLogEventTypeExtensions {
@@ -30,9 +30,9 @@ public static class AuditLogEventTypeExtensions {
 		{ AuditLogEventType.InstanceEdited,            AuditLogSubjectType.Instance },
 		{ AuditLogEventType.InstanceLaunched,          AuditLogSubjectType.Instance },
 		{ AuditLogEventType.InstanceStopped,           AuditLogSubjectType.Instance },
-		{ AuditLogEventType.InstanceCommandExecuted,   AuditLogSubjectType.Instance },
+		{ AuditLogEventType.InstanceCommandExecuted,   AuditLogSubjectType.Instance }
 	};
-	
+
 	static AuditLogEventTypeExtensions() {
 		foreach (var eventType in Enum.GetValues<AuditLogEventType>()) {
 			if (!SubjectTypes.ContainsKey(eventType)) {
@@ -40,7 +40,7 @@ public static class AuditLogEventTypeExtensions {
 			}
 		}
 	}
-	
+
 	public static AuditLogSubjectType GetSubjectType(this AuditLogEventType type) {
 		return SubjectTypes[type];
 	}

Common/Phantom.Common.Data.Web/AuditLog/AuditLogSubjectType.cs

@@ -2,5 +2,5 @@
 
 public enum AuditLogSubjectType {
 	User,
-	Instance,
+	Instance
 }

Common/Phantom.Common.Data.Web/EventLog/EventLogEventType.cs

@@ -7,7 +7,7 @@ public enum EventLogEventType {
 	InstanceStopped,
 	InstanceBackupSucceeded,
 	InstanceBackupSucceededWithWarnings,
-	InstanceBackupFailed,
+	InstanceBackupFailed
 }
 
 public static class EventLogEventTypeExtensions {
@@ -18,9 +18,9 @@ public static class EventLogEventTypeExtensions {
 		{ EventLogEventType.InstanceStopped, EventLogSubjectType.Instance },
 		{ EventLogEventType.InstanceBackupSucceeded, EventLogSubjectType.Instance },
 		{ EventLogEventType.InstanceBackupSucceededWithWarnings, EventLogSubjectType.Instance },
-		{ EventLogEventType.InstanceBackupFailed, EventLogSubjectType.Instance },
+		{ EventLogEventType.InstanceBackupFailed, EventLogSubjectType.Instance }
 	};
-	
+
 	static EventLogEventTypeExtensions() {
 		foreach (var eventType in Enum.GetValues<EventLogEventType>()) {
 			if (!SubjectTypes.ContainsKey(eventType)) {
@@ -28,7 +28,7 @@ public static class EventLogEventTypeExtensions {
 			}
 		}
 	}
-	
+
 	public static EventLogSubjectType GetSubjectType(this EventLogEventType type) {
 		return SubjectTypes[type];
 	}

Common/Phantom.Common.Data.Web/EventLog/EventLogSubjectType.cs

@@ -1,5 +1,5 @@
 namespace Phantom.Common.Data.Web.EventLog;
 
 public enum EventLogSubjectType {
-	Instance,
+	Instance
 }

Common/Phantom.Common.Data.Web/Instance/CreateOrUpdateInstanceResult.cs

@@ -6,7 +6,7 @@ public enum CreateOrUpdateInstanceResult : byte {
 	InstanceNameMustNotBeEmpty,
 	InstanceMemoryMustNotBeZero,
 	MinecraftVersionDownloadInfoNotFound,
-	AgentNotFound,
+	AgentNotFound
 }
 
 public static class CreateOrUpdateInstanceResultExtensions {
@@ -17,7 +17,7 @@ public static class CreateOrUpdateInstanceResultExtensions {
 			CreateOrUpdateInstanceResult.InstanceMemoryMustNotBeZero          => "Memory must not be 0 MB.",
 			CreateOrUpdateInstanceResult.MinecraftVersionDownloadInfoNotFound => "Could not find download information for the selected Minecraft version.",
 			CreateOrUpdateInstanceResult.AgentNotFound                        => "Agent not found.",
-			_                                                                 => "Unknown error.",
+			_                                                                 => "Unknown error."
 		};
 	}
 }

Common/Phantom.Common.Data.Web/Minecraft/JvmArgumentsHelper.cs

@@ -4,22 +4,22 @@ namespace Phantom.Common.Data.Web.Minecraft;
 
 public static class JvmArgumentsHelper {
 	public static ImmutableArray<string> Split(string arguments) {
-		return [..arguments.Split(separator: '\n', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries)];
+		return arguments.Split('\n', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries).ToImmutableArray();
 	}
-	
+
 	public static string Join(ImmutableArray<string> arguments) {
-		return string.Join(separator: '\n', arguments);
+		return string.Join('\n', arguments);
 	}
-	
+
 	public static ValidationError? Validate(string arguments) {
 		return Validate(Split(arguments));
 	}
-	
+
 	private static ValidationError? Validate(ImmutableArray<string> arguments) {
 		if (!arguments.All(static argument => argument.StartsWith('-'))) {
 			return ValidationError.InvalidFormat;
 		}
-		
+
 		// TODO not perfect, but good enough
 		if (arguments.Any(static argument => argument.Contains("-Xmx"))) {
 			return ValidationError.XmxNotAllowed;
@@ -31,10 +31,10 @@ public static class JvmArgumentsHelper {
 		
 		return null;
 	}
-	
+
 	public enum ValidationError {
 		InvalidFormat,
 		XmxNotAllowed,
-		XmsNotAllowed,
+		XmsNotAllowed
 	}
 }

Common/Phantom.Common.Data.Web/Phantom.Common.Data.Web.csproj

@@ -13,5 +13,5 @@
   <ItemGroup>
     <ProjectReference Include="..\Phantom.Common.Data\Phantom.Common.Data.csproj" />
   </ItemGroup>
-
+  
 </Project>

Common/Phantom.Common.Data.Web/Users/AddRoleError.cs

@@ -4,5 +4,5 @@ public enum AddRoleError : byte {
 	NameIsEmpty,
 	NameIsTooLong,
 	NameAlreadyExists,
-	UnknownError,
+	UnknownError
 }

Common/Phantom.Common.Data.Web/Users/AddUserError.cs

@@ -1,25 +1,28 @@
 using System.Collections.Immutable;
 using MemoryPack;
+using Phantom.Common.Data.Web.Users.AddUserErrors;
 
-namespace Phantom.Common.Data.Web.Users;
+namespace Phantom.Common.Data.Web.Users {
+	[MemoryPackable]
+	[MemoryPackUnion(0, typeof(NameIsInvalid))]
+	[MemoryPackUnion(1, typeof(PasswordIsInvalid))]
+	[MemoryPackUnion(2, typeof(NameAlreadyExists))]
+	[MemoryPackUnion(3, typeof(UnknownError))]
+	public abstract partial record AddUserError {
+		internal AddUserError() {}
+	}
+}
 
-[MemoryPackable]
+namespace Phantom.Common.Data.Web.Users.AddUserErrors {
-[MemoryPackUnion(tag: 0, typeof(NameIsInvalid))]
-[MemoryPackUnion(tag: 1, typeof(PasswordIsInvalid))]
-[MemoryPackUnion(tag: 2, typeof(NameAlreadyExists))]
-[MemoryPackUnion(tag: 3, typeof(UnknownError))]
-public abstract partial record AddUserError {
-	private AddUserError() {}
-	
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record NameIsInvalid([property: MemoryPackOrder(0)] UsernameRequirementViolation Violation) : AddUserError;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record PasswordIsInvalid([property: MemoryPackOrder(0)] ImmutableArray<PasswordRequirementViolation> Violations) : AddUserError;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record NameAlreadyExists : AddUserError;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record UnknownError : AddUserError;
 }

Common/Phantom.Common.Data.Web/Users/AuthenticatedUserInfo.cs

@@ -13,11 +13,11 @@ public sealed partial record AuthenticatedUserInfo(
 	public bool CheckPermission(Permission permission) {
 		return Permissions.Check(permission);
 	}
-	
+
 	public bool HasAccessToAgent(Guid agentGuid) {
 		return ManagedAgentGuids.Contains(agentGuid) || Permissions.Check(Permission.ManageAllAgents);
 	}
-	
+
 	public ImmutableHashSet<Guid> FilterAccessibleAgentGuids(ImmutableHashSet<Guid> agentGuids) {
 		return Permissions.Check(Permission.ManageAllAgents) ? agentGuids : agentGuids.Intersect(ManagedAgentGuids);
 	}

Common/Phantom.Common.Data.Web/Users/ChangeUserRolesResult.cs

@@ -1,7 +1,7 @@
 using System.Collections.Immutable;
 using MemoryPack;
 
-namespace Phantom.Common.Data.Web.Users;
+namespace Phantom.Common.Data.Web.Users; 
 
 [MemoryPackable(GenerateType.VersionTolerant)]
 public sealed partial record ChangeUserRolesResult(

Common/Phantom.Common.Data.Web/Users/CreateOrUpdateAdministratorUserResult.cs

@@ -1,28 +1,31 @@
 using MemoryPack;
+using Phantom.Common.Data.Web.Users.CreateOrUpdateAdministratorUserResults;
 
-namespace Phantom.Common.Data.Web.Users;
+namespace Phantom.Common.Data.Web.Users {
+	[MemoryPackable]
+	[MemoryPackUnion(0, typeof(Success))]
+	[MemoryPackUnion(1, typeof(CreationFailed))]
+	[MemoryPackUnion(2, typeof(UpdatingFailed))]
+	[MemoryPackUnion(3, typeof(AddingToRoleFailed))]
+	[MemoryPackUnion(4, typeof(UnknownError))]
+	public abstract partial record CreateOrUpdateAdministratorUserResult {
+		internal CreateOrUpdateAdministratorUserResult() {}
+	}
+}
 
-[MemoryPackable]
+namespace Phantom.Common.Data.Web.Users.CreateOrUpdateAdministratorUserResults {
-[MemoryPackUnion(tag: 0, typeof(Success))]
-[MemoryPackUnion(tag: 1, typeof(CreationFailed))]
-[MemoryPackUnion(tag: 2, typeof(UpdatingFailed))]
-[MemoryPackUnion(tag: 3, typeof(AddingToRoleFailed))]
-[MemoryPackUnion(tag: 4, typeof(UnknownError))]
-public abstract partial record CreateOrUpdateAdministratorUserResult {
-	private CreateOrUpdateAdministratorUserResult() {}
-	
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record Success([property: MemoryPackOrder(0)] UserInfo User) : CreateOrUpdateAdministratorUserResult;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record CreationFailed([property: MemoryPackOrder(0)] AddUserError Error) : CreateOrUpdateAdministratorUserResult;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record UpdatingFailed([property: MemoryPackOrder(0)] SetUserPasswordError Error) : CreateOrUpdateAdministratorUserResult;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record AddingToRoleFailed : CreateOrUpdateAdministratorUserResult;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record UnknownError : CreateOrUpdateAdministratorUserResult;
 }

Common/Phantom.Common.Data.Web/Users/CreateUserResult.cs

@@ -1,20 +1,23 @@
 using MemoryPack;
+using Phantom.Common.Data.Web.Users.CreateUserResults;
 
-namespace Phantom.Common.Data.Web.Users;
+namespace Phantom.Common.Data.Web.Users {
+	[MemoryPackable]
+	[MemoryPackUnion(0, typeof(Success))]
+	[MemoryPackUnion(1, typeof(CreationFailed))]
+	[MemoryPackUnion(2, typeof(UnknownError))]
+	public abstract partial record CreateUserResult {
+		internal CreateUserResult() {}
+	}
+}
 
-[MemoryPackable]
+namespace Phantom.Common.Data.Web.Users.CreateUserResults {
-[MemoryPackUnion(tag: 0, typeof(Success))]
-[MemoryPackUnion(tag: 1, typeof(CreationFailed))]
-[MemoryPackUnion(tag: 2, typeof(UnknownError))]
-public abstract partial record CreateUserResult {
-	private CreateUserResult() {}
-	
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record Success([property: MemoryPackOrder(0)] UserInfo User) : CreateUserResult;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record CreationFailed([property: MemoryPackOrder(0)] AddUserError Error) : CreateUserResult;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record UnknownError : CreateUserResult;
 }

Common/Phantom.Common.Data.Web/Users/DeleteUserResult.cs

@@ -3,5 +3,5 @@
 public enum DeleteUserResult : byte {
 	Deleted,
 	NotFound,
-	Failed,
+	Failed
 }

Common/Phantom.Common.Data.Web/Users/PasswordRequirementViolation.cs

@@ -1,24 +1,27 @@
 using MemoryPack;
+using Phantom.Common.Data.Web.Users.PasswordRequirementViolations;
 
-namespace Phantom.Common.Data.Web.Users;
+namespace Phantom.Common.Data.Web.Users {
+	[MemoryPackable]
+	[MemoryPackUnion(0, typeof(TooShort))]
+	[MemoryPackUnion(1, typeof(MustContainLowercaseLetter))]
+	[MemoryPackUnion(2, typeof(MustContainUppercaseLetter))]
+	[MemoryPackUnion(3, typeof(MustContainDigit))]
+	public abstract partial record PasswordRequirementViolation {
+		internal PasswordRequirementViolation() {}
+	}
+}
 
-[MemoryPackable]
+namespace Phantom.Common.Data.Web.Users.PasswordRequirementViolations {
-[MemoryPackUnion(tag: 0, typeof(TooShort))]
-[MemoryPackUnion(tag: 1, typeof(MustContainLowercaseLetter))]
-[MemoryPackUnion(tag: 2, typeof(MustContainUppercaseLetter))]
-[MemoryPackUnion(tag: 3, typeof(MustContainDigit))]
-public abstract partial record PasswordRequirementViolation {
-	private PasswordRequirementViolation() {}
-	
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record TooShort([property: MemoryPackOrder(0)] int MinimumLength) : PasswordRequirementViolation;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record MustContainLowercaseLetter : PasswordRequirementViolation;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record MustContainUppercaseLetter : PasswordRequirementViolation;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record MustContainDigit : PasswordRequirementViolation;
 }

Common/Phantom.Common.Data.Web/Users/Permission.cs

@@ -1,7 +1,7 @@
 namespace Phantom.Common.Data.Web.Users;
 
 public sealed record Permission(string Id, Permission? Parent) {
-	private static readonly List<Permission> AllPermissions = [];
+	private static readonly List<Permission> AllPermissions = new ();
 	public static IEnumerable<Permission> All => AllPermissions;
 	
 	private static Permission Register(string id, Permission? parent = null) {
@@ -9,11 +9,11 @@ public sealed record Permission(string Id, Permission? Parent) {
 		AllPermissions.Add(permission);
 		return permission;
 	}
-	
+
 	private Permission RegisterChild(string id) {
 		return Register(id, this);
 	}
-	
+
 	public const string ManageAllAgentsPolicy = "Agents.ManageAll";
 	public static readonly Permission ManageAllAgents = Register(ManageAllAgentsPolicy);
 	

Common/Phantom.Common.Data.Web/Users/PermissionSet.cs

@@ -10,20 +10,20 @@ public sealed partial class PermissionSet {
 	[MemoryPackOrder(0)]
 	[MemoryPackInclude]
 	private readonly ImmutableHashSet<string> permissionIds;
-	
+
 	public PermissionSet(ImmutableHashSet<string> permissionIds) {
 		this.permissionIds = permissionIds;
 	}
-	
+
 	public bool Check(Permission? permission) {
 		while (permission != null) {
 			if (!permissionIds.Contains(permission.Id)) {
 				return false;
 			}
-			
+
 			permission = permission.Parent;
 		}
-		
+
 		return true;
 	}
 }

Common/Phantom.Common.Data.Web/Users/SetUserPasswordError.cs

@@ -1,21 +1,24 @@
 using System.Collections.Immutable;
 using MemoryPack;
+using Phantom.Common.Data.Web.Users.SetUserPasswordErrors;
 
-namespace Phantom.Common.Data.Web.Users;
+namespace Phantom.Common.Data.Web.Users {
+	[MemoryPackable]
+	[MemoryPackUnion(0, typeof(UserNotFound))]
+	[MemoryPackUnion(1, typeof(PasswordIsInvalid))]
+	[MemoryPackUnion(2, typeof(UnknownError))]
+	public abstract partial record SetUserPasswordError {
+		internal SetUserPasswordError() {}
+	}
+}
 
-[MemoryPackable]
+namespace Phantom.Common.Data.Web.Users.SetUserPasswordErrors {
-[MemoryPackUnion(tag: 0, typeof(UserNotFound))]
-[MemoryPackUnion(tag: 1, typeof(PasswordIsInvalid))]
-[MemoryPackUnion(tag: 2, typeof(UnknownError))]
-public abstract partial record SetUserPasswordError {
-	private SetUserPasswordError() {}
-	
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record UserNotFound : SetUserPasswordError;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record PasswordIsInvalid([property: MemoryPackOrder(0)] ImmutableArray<PasswordRequirementViolation> Violations) : SetUserPasswordError;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record UnknownError : SetUserPasswordError;
 }

Common/Phantom.Common.Data.Web/Users/UserActionFailure.cs

@@ -1,5 +1,5 @@
 namespace Phantom.Common.Data.Web.Users;
 
 public enum UserActionFailure {
-	NotAuthorized,
+	NotAuthorized
 }

Common/Phantom.Common.Data.Web/Users/UserInstanceActionFailure.cs

@@ -4,22 +4,22 @@ using Phantom.Common.Data.Replies;
 namespace Phantom.Common.Data.Web.Users;
 
 [MemoryPackable]
-[MemoryPackUnion(tag: 0, typeof(User))]
+[MemoryPackUnion(0, typeof(OfUserActionFailure))]
-[MemoryPackUnion(tag: 1, typeof(Instance))]
+[MemoryPackUnion(1, typeof(OfInstanceActionFailure))]
 public abstract partial record UserInstanceActionFailure {
-	private UserInstanceActionFailure() {}
+	internal UserInstanceActionFailure() {}
-	
-	[MemoryPackable(GenerateType.VersionTolerant)]
-	public sealed partial record User([property: MemoryPackOrder(0)] UserActionFailure Failure) : UserInstanceActionFailure;
-	
-	[MemoryPackable(GenerateType.VersionTolerant)]
-	public sealed partial record Instance([property: MemoryPackOrder(0)] InstanceActionFailure Failure) : UserInstanceActionFailure;
 	
 	public static implicit operator UserInstanceActionFailure(UserActionFailure failure) {
-		return new User(failure);
+		return new OfUserActionFailure(failure);
 	}
 	
 	public static implicit operator UserInstanceActionFailure(InstanceActionFailure failure) {
-		return new Instance(failure);
+		return new OfInstanceActionFailure(failure);
 	}
 }
+
+[MemoryPackable(GenerateType.VersionTolerant)]
+public sealed partial record OfUserActionFailure([property: MemoryPackOrder(0)] UserActionFailure Failure) : UserInstanceActionFailure;
+
+[MemoryPackable(GenerateType.VersionTolerant)]
+public sealed partial record OfInstanceActionFailure([property: MemoryPackOrder(0)] InstanceActionFailure Failure) : UserInstanceActionFailure;

Common/Phantom.Common.Data.Web/Users/UserPasswords.cs

@@ -4,7 +4,7 @@ public static class UserPasswords {
 	public static string Hash(string password) {
 		return BCrypt.Net.BCrypt.HashPassword(password, workFactor: 12);
 	}
-	
+
 	public static bool Verify(string password, string hash) {
 		// TODO rehash
 		return BCrypt.Net.BCrypt.Verify(password, hash);

Common/Phantom.Common.Data.Web/Users/UsernameRequirementViolation.cs

@@ -1,16 +1,19 @@
 using MemoryPack;
+using Phantom.Common.Data.Web.Users.UsernameRequirementViolations;
 
-namespace Phantom.Common.Data.Web.Users;
+namespace Phantom.Common.Data.Web.Users {
+	[MemoryPackable]
+	[MemoryPackUnion(0, typeof(IsEmpty))]
+	[MemoryPackUnion(1, typeof(TooLong))]
+	public abstract partial record UsernameRequirementViolation {
+		internal UsernameRequirementViolation() {}
+	}
+}
 
-[MemoryPackable]
+namespace Phantom.Common.Data.Web.Users.UsernameRequirementViolations {
-[MemoryPackUnion(tag: 0, typeof(IsEmpty))]
-[MemoryPackUnion(tag: 1, typeof(TooLong))]
-public abstract partial record UsernameRequirementViolation {
-	private UsernameRequirementViolation() {}
-	
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record IsEmpty : UsernameRequirementViolation;
-	
+
 	[MemoryPackable(GenerateType.VersionTolerant)]
 	public sealed partial record TooLong([property: MemoryPackOrder(0)] int MaxLength) : UsernameRequirementViolation;
 }

Common/Phantom.Common.Data/AllowedPorts.cs

@@ -8,35 +8,35 @@ namespace Phantom.Common.Data;
 public sealed partial class AllowedPorts {
 	[MemoryPackOrder(0)]
 	[MemoryPackInclude]
-	private readonly ImmutableArray<PortRange> allDefinitions;
+	private	readonly ImmutableArray<PortRange> allDefinitions;
-	
+
 	private AllowedPorts(ImmutableArray<PortRange> allDefinitions) {
 		// TODO normalize and deduplicate ranges
 		this.allDefinitions = allDefinitions.Sort(static (def1, def2) => def1.FirstPort - def2.FirstPort);
 	}
-	
+
 	public bool Contains(ushort port) {
 		return allDefinitions.Any(definition => definition.Contains(port));
 	}
-	
+
 	public override string ToString() {
 		var builder = new StringBuilder();
-		
+
 		foreach (var definition in allDefinitions) {
 			definition.ToString(builder);
 			builder.Append(',');
 		}
-		
+
 		if (builder.Length > 0) {
 			builder.Length--;
 		}
-		
+
 		return builder.ToString();
 	}
-	
+
 	private static AllowedPorts FromString(ReadOnlySpan<char> definitions) {
-		List<PortRange> parsedDefinitions = [];
+		List<PortRange> parsedDefinitions = new ();
-		
+
 		while (!definitions.IsEmpty) {
 			int separatorIndex = definitions.IndexOf(',');
 			if (separatorIndex == -1) {
@@ -48,10 +48,10 @@ public sealed partial class AllowedPorts {
 				definitions = definitions[(separatorIndex + 1)..];
 			}
 		}
-		
+
-		return new AllowedPorts([..parsedDefinitions]);
+		return new AllowedPorts(parsedDefinitions.ToImmutableArray());
 	}
-	
+
 	public static AllowedPorts FromString(string definitions) {
 		return FromString(definitions.AsSpan());
 	}

Common/Phantom.Common.Data/AuthToken.cs

@@ -0,0 +1,37 @@
+using System.Diagnostics.CodeAnalysis;
+using System.Security.Cryptography;
+using MemoryPack;
+
+namespace Phantom.Common.Data;
+
+[MemoryPackable(GenerateType.VersionTolerant)]
+[SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+public sealed partial class AuthToken {
+	internal const int Length = 12;
+
+	[MemoryPackOrder(0)]
+	[MemoryPackInclude]
+	private readonly byte[] bytes;
+
+	internal AuthToken(byte[]? bytes) {
+		ArgumentNullException.ThrowIfNull(bytes);
+
+		if (bytes.Length != Length) {
+			throw new ArgumentOutOfRangeException(nameof(bytes), "Invalid token length: " + bytes.Length + ". Token length must be exactly " + Length + " bytes.");
+		}
+
+		this.bytes = bytes;
+	}
+
+	public bool FixedTimeEquals(AuthToken providedAuthToken) {
+		return CryptographicOperations.FixedTimeEquals(bytes, providedAuthToken.bytes);
+	}
+
+	internal void WriteTo(Span<byte> span) {
+		bytes.CopyTo(span);
+	}
+
+	public static AuthToken Generate() {
+		return new AuthToken(RandomNumberGenerator.GetBytes(Length));
+	}
+}

Common/Phantom.Common.Data/Backups/BackupCreationResultKind.cs

@@ -10,7 +10,7 @@ public enum BackupCreationResultKind : byte {
 	BackupFileAlreadyExists = 6,
 	CouldNotCreateBackupFolder = 7,
 	CouldNotCopyWorldToTemporaryFolder = 8,
-	CouldNotCreateWorldArchive = 9,
+	CouldNotCreateWorldArchive = 9
 }
 
 public static class BackupCreationResultSummaryExtensions {

Common/Phantom.Common.Data/Backups/BackupCreationWarnings.cs

@@ -7,14 +7,14 @@ public enum BackupCreationWarnings : byte {
 	None = 0,
 	CouldNotDeleteTemporaryFolder = 1 << 0,
 	CouldNotCompressWorldArchive = 1 << 1,
-	CouldNotRestoreAutomaticSaving = 1 << 2,
+	CouldNotRestoreAutomaticSaving = 1 << 2
 }
 
 public static class BackupCreationWarningsExtensions {
 	public static int Count(this BackupCreationWarnings warnings) {
 		return BitOperations.PopCount((byte) warnings);
 	}
-	
+
 	public static IEnumerable<BackupCreationWarnings> ListFlags(this BackupCreationWarnings warnings) {
 		return Enum.GetValues<BackupCreationWarnings>().Where(warning => warning != BackupCreationWarnings.None && warnings.HasFlag(warning));
 	}

Common/Phantom.Common.Data/ConnectionCommonKey.cs

@@ -0,0 +1,18 @@
+namespace Phantom.Common.Data;
+
+public readonly record struct ConnectionCommonKey(byte[] CertificatePublicKey, AuthToken AuthToken) {
+	private const byte TokenLength = AuthToken.Length;
+
+	public byte[] ToBytes() {
+		Span<byte> result = stackalloc byte[TokenLength + CertificatePublicKey.Length];
+		AuthToken.WriteTo(result[..TokenLength]);
+		CertificatePublicKey.CopyTo(result[TokenLength..]);
+		return result.ToArray();
+	}
+
+	public static ConnectionCommonKey FromBytes(byte[] agentKey) {
+		var authToken = new AuthToken(agentKey[..TokenLength]);
+		var certificatePublicKey = agentKey[TokenLength..];
+		return new ConnectionCommonKey(certificatePublicKey, authToken);
+	}
+}

Common/Phantom.Common.Data/ConnectionKey.cs

@@ -1,21 +0,0 @@
-using Phantom.Utils.Rpc;
-using Phantom.Utils.Rpc.Runtime.Tls;
-
-namespace Phantom.Common.Data;
-
-public readonly record struct ConnectionKey(RpcCertificateThumbprint CertificateThumbprint, AuthToken AuthToken) {
-	private const byte TokenLength = AuthToken.Length;
-
-	public byte[] ToBytes() {
-		Span<byte> result = stackalloc byte[TokenLength + CertificateThumbprint.Bytes.Length];
-		AuthToken.Bytes.CopyTo(result[..TokenLength]);
-		CertificateThumbprint.Bytes.CopyTo(result[TokenLength..]);
-		return result.ToArray();
-	}
-
-	public static ConnectionKey FromBytes(ReadOnlySpan<byte> data) {
-		var authToken = new AuthToken([..data[..TokenLength]]);
-		var certificateThumbprint = RpcCertificateThumbprint.From(data[TokenLength..]);
-		return new ConnectionKey(certificateThumbprint, authToken);
-	}
-}

Common/Phantom.Common.Data/Instance/IInstanceEvent.cs

@@ -4,11 +4,11 @@ using Phantom.Common.Data.Backups;
 namespace Phantom.Common.Data.Instance;
 
 [MemoryPackable]
-[MemoryPackUnion(tag: 0, typeof(InstanceLaunchSucceededEvent))]
+[MemoryPackUnion(0, typeof(InstanceLaunchSucceededEvent))]
-[MemoryPackUnion(tag: 1, typeof(InstanceLaunchFailedEvent))]
+[MemoryPackUnion(1, typeof(InstanceLaunchFailedEvent))]
-[MemoryPackUnion(tag: 2, typeof(InstanceCrashedEvent))]
+[MemoryPackUnion(2, typeof(InstanceCrashedEvent))]
-[MemoryPackUnion(tag: 3, typeof(InstanceStoppedEvent))]
+[MemoryPackUnion(3, typeof(InstanceStoppedEvent))]
-[MemoryPackUnion(tag: 4, typeof(InstanceBackupCompletedEvent))]
+[MemoryPackUnion(4, typeof(InstanceBackupCompletedEvent))]
 public partial interface IInstanceEvent {
 	void Accept(IInstanceEventVisitor visitor);
 }

Common/Phantom.Common.Data/Instance/IInstanceStatus.cs

@@ -3,17 +3,17 @@
 namespace Phantom.Common.Data.Instance;
 
 [MemoryPackable]
-[MemoryPackUnion(tag: 0, typeof(InstanceIsOffline))]
+[MemoryPackUnion(0, typeof(InstanceIsOffline))]
-[MemoryPackUnion(tag: 1, typeof(InstanceIsInvalid))]
+[MemoryPackUnion(1, typeof(InstanceIsInvalid))]
-[MemoryPackUnion(tag: 2, typeof(InstanceIsNotRunning))]
+[MemoryPackUnion(2, typeof(InstanceIsNotRunning))]
-[MemoryPackUnion(tag: 3, typeof(InstanceIsDownloading))]
+[MemoryPackUnion(3, typeof(InstanceIsDownloading))]
-[MemoryPackUnion(tag: 4, typeof(InstanceIsLaunching))]
+[MemoryPackUnion(4, typeof(InstanceIsLaunching))]
-[MemoryPackUnion(tag: 5, typeof(InstanceIsRunning))]
+[MemoryPackUnion(5, typeof(InstanceIsRunning))]
-[MemoryPackUnion(tag: 6, typeof(InstanceIsBackingUp))]
+[MemoryPackUnion(6, typeof(InstanceIsBackingUp))]
-[MemoryPackUnion(tag: 7, typeof(InstanceIsRestarting))]
+[MemoryPackUnion(7, typeof(InstanceIsRestarting))]
-[MemoryPackUnion(tag: 8, typeof(InstanceIsStopping))]
+[MemoryPackUnion(8, typeof(InstanceIsStopping))]
-[MemoryPackUnion(tag: 9, typeof(InstanceIsFailed))]
+[MemoryPackUnion(9, typeof(InstanceIsFailed))]
-public partial interface IInstanceStatus;
+public partial interface IInstanceStatus {}
 
 [MemoryPackable(GenerateType.VersionTolerant)]
 public sealed partial record InstanceIsOffline : IInstanceStatus;
@@ -57,11 +57,11 @@ public static class InstanceStatus {
 	public static IInstanceStatus Invalid(string reason) => new InstanceIsInvalid(reason);
 	public static IInstanceStatus Downloading(byte progress) => new InstanceIsDownloading(progress);
 	public static IInstanceStatus Failed(InstanceLaunchFailReason reason) => new InstanceIsFailed(reason);
-	
+
 	public static bool IsLaunching(this IInstanceStatus status) {
 		return status is InstanceIsDownloading or InstanceIsLaunching or InstanceIsRestarting;
 	}
-	
+
 	public static bool IsRunning(this IInstanceStatus status) {
 		return status is InstanceIsRunning or InstanceIsBackingUp;
 	}
@@ -73,11 +73,11 @@ public static class InstanceStatus {
 	public static bool CanLaunch(this IInstanceStatus status) {
 		return status is InstanceIsNotRunning or InstanceIsFailed;
 	}
-	
+
 	public static bool CanStop(this IInstanceStatus status) {
 		return status.IsRunning() || status.IsLaunching();
 	}
-	
+
 	public static bool CanSendCommand(this IInstanceStatus status) {
 		return status.IsRunning();
 	}

Common/Phantom.Common.Data/Instance/InstanceLaunchFailReason.cs

@@ -6,5 +6,5 @@ public enum InstanceLaunchFailReason : byte {
 	CouldNotDownloadMinecraftServer        = 6,
 	CouldNotConfigureMinecraftServer       = 7,
 	CouldNotPrepareMinecraftServerLauncher = 8,
-	CouldNotStartMinecraftServer           = 9,
+	CouldNotStartMinecraftServer           = 9
 }

Common/Phantom.Common.Data/Instance/InstancePlayerCounts.cs

@@ -3,7 +3,7 @@
 namespace Phantom.Common.Data.Instance;
 
 [MemoryPackable(GenerateType.VersionTolerant)]
-public sealed partial record InstancePlayerCounts(
+public readonly partial record struct InstancePlayerCounts(
 	[property: MemoryPackOrder(0)] int Online,
 	[property: MemoryPackOrder(1)] int Maximum
 );