1
0
mirror of https://github.com/chylex/Better-Controls.git synced 2025-08-21 07:54:09 +02:00

15 Commits

57 changed files with 768 additions and 567 deletions

50
Fabric/build.gradle.kts Normal file
View File

@@ -0,0 +1,50 @@
val modId: String by project
val minecraftVersion: String by project
val fabricVersion: String by project
plugins {
idea
id("fabric-loom") version "0.10-SNAPSHOT"
}
dependencies {
minecraft("com.mojang:minecraft:$minecraftVersion")
modImplementation("net.fabricmc:fabric-loader:$fabricVersion")
mappings(loom.officialMojangMappings())
}
loom {
runs {
named("client") {
configName = "Fabric Client"
client()
runDir("run")
ideConfigGenerated(true)
}
named("server") {
configName = "Fabric Server"
server()
runDir("run")
ideConfigGenerated(true)
}
}
mixin {
add(sourceSets.main.get(), "$modId.refmap.json")
}
}
tasks.processResources {
filesMatching("fabric.mod.json") {
expand(inputs.properties)
}
}
tasks.jar {
exclude("com/terraformersmc/modmenu/")
}
tasks.remapJar {
archiveVersion.set(tasks.jar.get().archiveVersion)
}

View File

@@ -4,8 +4,8 @@ import net.fabricmc.api.ClientModInitializer;
import net.fabricmc.loader.api.FabricLoader; import net.fabricmc.loader.api.FabricLoader;
public final class BetterControlsMod implements ClientModInitializer { public final class BetterControlsMod implements ClientModInitializer {
public static final BetterControlsConfig config = BetterControlsConfig.load(FabricLoader.getInstance().getConfigDir().resolve("BetterControls.json"));
@Override @Override
public void onInitializeClient() {} public void onInitializeClient() {
BetterControlsCommon.setConfig(BetterControlsConfig.load(FabricLoader.getInstance().getConfigDir().resolve("BetterControls.json")));
}
} }

View File

@@ -1,7 +1,7 @@
package chylex.bettercontrols.compatibility; package chylex.bettercontrols.compatibility;
import chylex.bettercontrols.gui.BetterControlsScreen; import chylex.bettercontrols.gui.BetterControlsScreen;
import io.github.prospector.modmenu.api.ConfigScreenFactory; import com.terraformersmc.modmenu.api.ConfigScreenFactory;
import io.github.prospector.modmenu.api.ModMenuApi; import com.terraformersmc.modmenu.api.ModMenuApi;
public class ModMenuSupport implements ModMenuApi { public class ModMenuSupport implements ModMenuApi {
@Override @Override

View File

@@ -1,8 +1,9 @@
package io.github.prospector.modmenu.api; package com.terraformersmc.modmenu.api;
import net.minecraft.client.gui.screens.Screen; import net.minecraft.client.gui.screens.Screen;
@SuppressWarnings("unused") @SuppressWarnings("unused")
@FunctionalInterface @FunctionalInterface
public interface ConfigScreenFactory<S extends Screen> { public interface ConfigScreenFactory<S extends Screen> {
S create(Screen var1); S create(Screen parent);
} }

View File

@@ -0,0 +1,8 @@
package com.terraformersmc.modmenu.api;
@SuppressWarnings("unused")
public interface ModMenuApi {
default ConfigScreenFactory<?> getModConfigScreenFactory() {
return screen -> null;
}
}

View File

Before

Width:  |  Height:  |  Size: 21 KiB

After

Width:  |  Height:  |  Size: 21 KiB

View File

@@ -0,0 +1,35 @@
{
"schemaVersion": 1,
"id": "${id}",
"name": "${name}",
"description": "${description}",
"version": "${version}",
"license": "${license}",
"icon": "assets/bettercontrols/icon.png",
"authors": [
"${author}"
],
"contact": {
"issues": "${issuesURL}",
"sources": "${sourcesURL}"
},
"environment": "client",
"entrypoints": {
"client": [ "chylex.bettercontrols.BetterControlsMod" ],
"modmenu": [ "chylex.bettercontrols.compatibility.ModMenuSupport" ]
},
"mixins": [{
"config": "${id}.mixins.json",
"environment": "client"
}],
"depends": {
"fabricloader": ">=0.7.4",
"minecraft": ">=1.17"
}
}

95
Forge/build.gradle.kts Normal file
View File

@@ -0,0 +1,95 @@
import net.minecraftforge.gradle.userdev.UserDevExtension
import org.gradle.api.file.DuplicatesStrategy.INCLUDE
import org.spongepowered.asm.gradle.plugins.MixinExtension
val modId: String by project
val minecraftVersion: String by project
val forgeVersion: String by project
val mixinVersion: String by project
buildscript {
repositories {
maven("https://maven.minecraftforge.net")
maven("https://repo.spongepowered.org/maven")
mavenCentral()
}
dependencies {
classpath(group = "net.minecraftforge.gradle", name = "ForgeGradle", version = "5.1.+") { isChanging = true }
classpath(group = "org.spongepowered", name = "mixingradle", version = "0.7-SNAPSHOT")
}
}
plugins {
java
eclipse
}
apply {
plugin("net.minecraftforge.gradle")
plugin("org.spongepowered.mixin")
}
dependencies {
"minecraft"("net.minecraftforge:forge:$minecraftVersion-$forgeVersion")
if (System.getProperty("idea.sync.active") != "true") {
annotationProcessor("org.spongepowered:mixin:$mixinVersion:processor")
}
}
configure<UserDevExtension> {
mappings("official", minecraftVersion)
runs {
create("client") {
taskName = "Client"
workingDirectory(rootProject.file("run"))
ideaModule("${rootProject.name}.${project.name}.main")
property("mixin.env.remapRefMap", "true")
property("mixin.env.refMapRemappingFile", "$projectDir/build/createSrgToMcp/output.srg")
arg("-mixin.config=$modId.mixins.json")
mods {
create(modId) {
source(sourceSets.main.get())
source(rootProject.sourceSets.main.get())
}
}
}
create("server") {
taskName = "Server"
workingDirectory(rootProject.file("run"))
ideaModule("${rootProject.name}.${project.name}.main")
property("mixin.env.remapRefMap", "true")
property("mixin.env.refMapRemappingFile", "$projectDir/build/createSrgToMcp/output.srg")
arg("-mixin.config=$modId.mixins.json")
mods {
create(modId) {
source(sourceSets.main.get())
source(rootProject.sourceSets.main.get())
}
}
}
}
}
configure<MixinExtension> {
add(sourceSets.main.get(), "$modId.refmap.json")
}
tasks.processResources {
from(sourceSets.main.get().resources.srcDirs) {
include("META-INF/mods.toml")
expand(inputs.properties)
duplicatesStrategy = INCLUDE
}
}
tasks.jar {
finalizedBy("reobfJar")
}

View File

@@ -0,0 +1,32 @@
package chylex.bettercontrols;
import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.gui.BetterControlsScreen;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.screens.Screen;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.client.ConfigGuiHandler.ConfigGuiFactory;
import net.minecraftforge.fml.DistExecutor;
import net.minecraftforge.fml.IExtensionPoint.DisplayTest;
import net.minecraftforge.fml.ModLoadingContext;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.loading.FMLPaths;
import net.minecraftforge.network.NetworkConstants;
@Mod("bettercontrols")
public final class BetterControlsMod {
public BetterControlsMod() {
BetterControlsCommon.setConfig(DistExecutor.safeCallWhenOn(Dist.CLIENT, () -> ClientLoader::loadConfig));
ModLoadingContext.get().registerExtensionPoint(ConfigGuiFactory.class, () -> new ConfigGuiFactory(ClientLoader::createScreen));
ModLoadingContext.get().registerExtensionPoint(DisplayTest.class, () -> new DisplayTest(() -> NetworkConstants.IGNORESERVERONLY, (a, b) -> true));
}
private static final class ClientLoader {
public static BetterControlsConfig loadConfig() {
return BetterControlsConfig.load(FMLPaths.CONFIGDIR.get().resolve("BetterControls.json"));
}
public static BetterControlsScreen createScreen(final Minecraft mc, final Screen parentScreen) {
return new BetterControlsScreen(parentScreen);
}
}
}

View File

@@ -0,0 +1,27 @@
modLoader = "javafml"
loaderVersion = "[37,)"
authors = "${author}"
license = "${license}"
issueTrackerURL = "${issuesURL}"
[[mods]]
modId = "${id}"
version = "${version}"
displayName = "${name}"
description = "${description}"
logoFile = "icon.png"
[[dependencies.${id}]]
modId = "minecraft"
mandatory = true
versionRange = "[1.17.1,)"
ordering = "NONE"
side = "BOTH"
[[dependencies.${id}]]
modId = "forge"
mandatory = true
versionRange = "[37,)"
ordering = "NONE"
side = "BOTH"

Binary file not shown.

After

Width:  |  Height:  |  Size: 21 KiB

View File

@@ -3,9 +3,9 @@ Better Controls
![Logo](https://raw.githubusercontent.com/chylex/Better-Controls/master/logo.png "Depiction of Zero Regrets") ![Logo](https://raw.githubusercontent.com/chylex/Better-Controls/master/logo.png "Depiction of Zero Regrets")
Better Controls is a reimagining of [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting) with even more customizability. It features several new keybindings and many configurable options for how sprinting, sneaking, and flying should behave. [Better Controls](https://www.curseforge.com/minecraft/mc-mods/better-controls) is a reimagining of [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting) with even more customizability. It features several new keybindings and many configurable options for how sprinting, sneaking, and flying should behave.
Better Controls only focuses on complementing vanilla mechanics rather than adding new mechanics (such as [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting)'s option to allow sprinting in all directions) that only work on client side and server owners must explicitly opt in to enable them. By not having such features in Better Controls, it significantly reduces complexity by not having a server side version of the mod, and not needing a way to completely disable the mod while the game is running. Better Controls only focuses on complementing vanilla mechanics, rather than adding new mechanics (such as [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting)'s option to allow sprinting in all directions) that only work on client side and server owners must explicitly opt in to enable them. By not having such features in Better Controls, it significantly reduces complexity by not having a server side version of the mod, and not needing a way to completely disable the mod while the game is running.
Another major difference is the amount and granularity of options. Better Controls could be considered an *advanced controls mod* - by default, none of the keybinds are bound, and all options are set to match vanilla behavior. To take full advantage, go into *Options - Controls - Better Controls*, check out all of the available options, and figure out the best configuration for you. Another major difference is the amount and granularity of options. Better Controls could be considered an *advanced controls mod* - by default, none of the keybinds are bound, and all options are set to match vanilla behavior. To take full advantage, go into *Options - Controls - Better Controls*, check out all of the available options, and figure out the best configuration for you.
@@ -54,7 +54,7 @@ While this is convenient, there is potential for bugs which can affect server pl
### Compatibility ### Compatibility
* Better Controls is a client-side mod, it will do nothing when installed on a server. * Better Controls is a client-side mod, it will do nothing when installed on a server.
* If you run into a conflict with another mod that modifies the *Controls* screen, hold Alt while opening *Controls* to prevent Better Controls from adding its button. If another mod prevents the button from appearing, you can install [Mod Menu](https://www.curseforge.com/minecraft/mc-mods/modmenu) which adds a mod list with configuration buttons for mods. * If you run into a conflict with another mod that modifies the *Controls* screen, hold Alt while opening *Controls* to prevent Better Controls from adding its button. If another mod prevents the button from appearing, a button to open the mod's configuration is available in the Mods menu (for Fabric, install [Mod Menu](https://www.curseforge.com/minecraft/mc-mods/modmenu)).
## Screenshot ## Screenshot
@@ -63,11 +63,15 @@ While this is convenient, there is potential for bugs which can affect server pl
Source Code Source Code
=========== ===========
The `main` branch includes the latest version for Fabric. Older versions and their Forge equivalents are in branches named `fabric/<version>` and `forge/<version>`. The `main` branch includes both the Fabric and Forge version in a single project. The project uses Mojang mappings. The root project contains common source code and resource files, and the `Fabric` and `Forge` folders are subprojects with loader-specific files.
The `main` branch always has the latest development version. Before updating to a new Minecraft version, a new branch is created from the `main` branch (for example, before the mod is updated to `1.18`, a branch named `1.17` will be created). Further development of older versions may continue in these branches in case backports or version-specific fixes are needed.
Older versions from before the merge of the Fabric and Forge versions can be found in branches named `fabric/<version>` and `forge/<version>`.
## Contributing ## Contributing
All contributions should target the `main` branch, unless the contribution is specifically made for older versions. Every feature must be portable to Forge to ensure parity, unless the feature adds integration with another mod that is only compatible with one mod loader. Integrations for Forge-only mods should target the most recent `forge/<version>` branch. All contributions should target the `main` branch and work in both Fabric and Forge, unless the contribution is specifically targeting older versions or a specific mod loader.
For any larger contributions, please [open an issue](https://github.com/chylex/Better-Controls/issues/new) first before you make a PR. For any larger contributions, please [open an issue](https://github.com/chylex/Better-Controls/issues/new) first before you make a PR.

View File

@@ -1,36 +0,0 @@
plugins {
id 'fabric-loom' version '0.9-SNAPSHOT'
id 'maven-publish'
}
sourceCompatibility = JavaVersion.VERSION_16
targetCompatibility = JavaVersion.VERSION_16
archivesBaseName = project.archives_base_name
version = 'v' + project.mod_version
group = project.maven_group
dependencies {
minecraft "com.mojang:minecraft:${project.minecraft_version}"
modImplementation "net.fabricmc:fabric-loader:${project.loader_version}"
mappings minecraft.officialMojangMappings()
compileOnly "com.google.code.findbugs:jsr305:3.0.2"
}
processResources {
inputs.property "version", project.mod_version
filesMatching("fabric.mod.json") {
expand "version": project.mod_version
}
}
tasks.withType(JavaCompile) {
options.encoding = "UTF-8"
options.release = 16
}
jar {
from "LICENSE"
exclude "io/github/prospector/"
}

173
build.gradle.kts Normal file
View File

@@ -0,0 +1,173 @@
import org.gradle.api.file.DuplicatesStrategy.EXCLUDE
import java.text.SimpleDateFormat
import java.util.Date
val modId: String by project
val modName: String by project
val modDescription: String by project
val modAuthor: String by project
val modVersion: String by project
val modLicense: String by project
val modSourcesURL: String by project
val modIssuesURL: String by project
val minecraftVersion: String by project
val mixinVersion: String by project
val modNameStripped = modName.replace(" ", "")
val jarVersion = "$minecraftVersion+v$modVersion"
buildscript {
repositories {
maven("https://repo.spongepowered.org/maven")
}
}
plugins {
`java-library`
idea
id("org.spongepowered.gradle.vanilla") version "0.2.1-SNAPSHOT"
}
idea {
module {
excludeDirs.add(file("gradle"))
excludeDirs.add(file("run"))
excludeDirs.add(file("Fabric/run"))
if (findProject(":Forge") == null) {
excludeDirs.add(file("Forge"))
}
if (findProject(":Fabric") == null) {
excludeDirs.add(file("Fabric"))
}
}
}
repositories {
maven("https://repo.spongepowered.org/maven")
mavenCentral()
}
dependencies {
implementation("org.spongepowered:mixin:$mixinVersion")
api("com.google.code.findbugs:jsr305:3.0.2")
}
base {
archivesName.set("$modNameStripped-Common")
}
minecraft {
version(minecraftVersion)
runs.clear()
}
allprojects {
group = "com.$modAuthor.$modId"
version = modVersion
apply(plugin = "java")
dependencies {
implementation("org.jetbrains:annotations:22.0.0")
}
extensions.getByType<JavaPluginExtension>().apply {
toolchain.languageVersion.set(JavaLanguageVersion.of(17))
}
tasks.withType<JavaCompile> {
options.encoding = "UTF-8"
options.release.set(17)
}
}
subprojects {
repositories {
maven("https://repo.spongepowered.org/maven")
}
dependencies {
implementation(rootProject)
}
base {
archivesName.set("$modNameStripped-${project.name}")
}
tasks.withType<JavaCompile> {
source({ rootProject.sourceSets.main.get().allSource })
}
tasks.processResources {
inputs.property("id", modId)
inputs.property("name", modName)
inputs.property("description", modDescription)
inputs.property("version", modVersion)
inputs.property("author", modAuthor)
inputs.property("license", modLicense)
inputs.property("sourcesURL", modSourcesURL)
inputs.property("issuesURL", modIssuesURL)
from(rootProject.sourceSets.main.get().resources) {
expand(inputs.properties)
}
}
tasks.jar {
archiveVersion.set(jarVersion)
from(rootProject.file("LICENSE"))
manifest {
attributes(
"Specification-Title" to modId,
"Specification-Vendor" to modAuthor,
"Specification-Version" to "1",
"Implementation-Title" to "$modNameStripped-${project.name}",
"Implementation-Vendor" to modAuthor,
"Implementation-Version" to modVersion,
"Implementation-Timestamp" to SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ").format(Date()),
"MixinConfigs" to "$modId.mixins.json"
)
}
}
tasks.test {
onlyIf { false }
}
}
tasks.register("setupIdea") {
group = "mod"
dependsOn(tasks.findByName("decompile"))
val forge = findProject(":Forge")
if (forge != null) {
dependsOn(forge.tasks.getByName("genIntellijRuns"))
}
val fabric = findProject(":Fabric")
if (fabric != null) {
dependsOn(fabric.tasks.getByName("genSources"))
}
}
val copyJars = tasks.register<Copy>("copyJars") {
group = "build"
duplicatesStrategy = EXCLUDE
for (subproject in subprojects) {
dependsOn(subproject.tasks.assemble)
from(subproject.base.libsDirectory.file("${subproject.base.archivesName.get()}-$jarVersion.jar"))
}
into(file("${project.buildDir}/dist"))
}
tasks.assemble {
finalizedBy(copyJars)
}

View File

@@ -1,13 +1,19 @@
# Done to increase the memory available to gradle. # Mod
org.gradle.jvmargs=-Xmx1G modId=bettercontrols
modName=Better Controls
modDescription=Adds many powerful key bindings and options to control your movement.\\n\\nThe features complement vanilla mechanics without giving unfair advantages, so server use should be fine.
modAuthor=chylex
modVersion=1.2.3
modLicense=MPL-2.0
modSourcesURL=https://github.com/chylex/Better-Controls
modIssuesURL=https://github.com/chylex/Better-Controls/issues
# Fabric Properties # Dependencies
minecraft_version=1.17 minecraftVersion=1.18
loader_version=0.11.3 forgeVersion=38.0.8
fabricVersion=0.12.8
mixinVersion=0.8.4
# Mod Properties # Gradle
mod_version=1.2.0 org.gradle.jvmargs=-Xmx3G
maven_group=chylex.bettercontrols org.gradle.daemon=false
archives_base_name=BetterControls-1.17+
# https://modmuss50.me/fabric.html

Binary file not shown.

View File

@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0-bin.zip distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip
zipStoreBase=GRADLE_USER_HOME zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists zipStorePath=wrapper/dists

20
gradlew vendored
View File

@@ -1,4 +1,4 @@
#!/usr/bin/env sh #!/usr/bin/env bash
# #
# Copyright 2015 the original author or authors. # Copyright 2015 the original author or authors.
@@ -72,7 +72,7 @@ case "`uname`" in
Darwin* ) Darwin* )
darwin=true darwin=true
;; ;;
MINGW* ) MSYS* | MINGW* )
msys=true msys=true
;; ;;
NONSTOP* ) NONSTOP* )
@@ -172,14 +172,12 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
esac esac
fi fi
# Escape application args ARGV=("$@")
save () { eval set -- $DEFAULT_JVM_OPTS
for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done
echo " "
}
APP_ARGS=`save "$@"`
# Collect all arguments for the java command, following the shell quoting and substitution rules IFS=$'
eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" ' read -rd '' -a JAVA_OPTS_ARR <<< "$(echo $JAVA_OPTS | xargs -n1)"
IFS=$'
' read -rd '' -a GRADLE_OPTS_ARR <<< "$(echo $GRADLE_OPTS | xargs -n1)"
exec "$JAVACMD" "$@" exec "$JAVACMD" "$@" "${JAVA_OPTS_ARR[@]}" "${GRADLE_OPTS_ARR[@]}" "-Dorg.gradle.appname=$APP_BASE_NAME" -classpath "$CLASSPATH" org.gradle.wrapper.GradleWrapperMain "${ARGV[@]}"

View File

@@ -1,9 +0,0 @@
pluginManagement {
repositories {
maven {
name = 'Fabric'
url = 'https://maven.fabricmc.net/'
}
gradlePluginPortal()
}
}

17
settings.gradle.kts Normal file
View File

@@ -0,0 +1,17 @@
rootProject.name = "Better-Controls"
pluginManagement {
repositories {
gradlePluginPortal()
maven(url = "https://maven.fabricmc.net/") { name = "Fabric" }
maven(url = "https://repo.spongepowered.org/repository/maven-public/") { name = "Sponge Snapshots" }
}
}
if (settings.extra.has("forgeVersion")) {
include("Forge")
}
if (settings.extra.has("fabricVersion")) {
include("Fabric")
}

View File

@@ -0,0 +1,17 @@
package chylex.bettercontrols;
import chylex.bettercontrols.config.BetterControlsConfig;
public final class BetterControlsCommon {
private static BetterControlsConfig config;
public static BetterControlsConfig getConfig() {
return config;
}
static void setConfig(final BetterControlsConfig config) {
BetterControlsCommon.config = config;
}
private BetterControlsCommon() {}
}

View File

@@ -1,8 +1,6 @@
package chylex.bettercontrols.gui; package chylex.bettercontrols.gui;
import chylex.bettercontrols.BetterControlsMod; import chylex.bettercontrols.BetterControlsCommon;
import chylex.bettercontrols.config.BetterControlsConfig; import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.gui.elements.BooleanValueWidget;
import chylex.bettercontrols.gui.elements.CycleButtonWidget;
import chylex.bettercontrols.gui.elements.DiscreteValueSliderWidget; import chylex.bettercontrols.gui.elements.DiscreteValueSliderWidget;
import chylex.bettercontrols.gui.elements.KeyBindingWidget; import chylex.bettercontrols.gui.elements.KeyBindingWidget;
import chylex.bettercontrols.gui.elements.Option; import chylex.bettercontrols.gui.elements.Option;
@@ -12,26 +10,30 @@ import chylex.bettercontrols.input.ModifierKey;
import chylex.bettercontrols.input.SprintMode; import chylex.bettercontrols.input.SprintMode;
import com.mojang.blaze3d.platform.InputConstants; import com.mojang.blaze3d.platform.InputConstants;
import com.mojang.blaze3d.vertex.PoseStack; import com.mojang.blaze3d.vertex.PoseStack;
import it.unimi.dsi.fastutil.booleans.BooleanConsumer;
import net.minecraft.client.KeyMapping; import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.components.Button; import net.minecraft.client.gui.components.Button;
import net.minecraft.client.gui.components.CycleButton;
import net.minecraft.client.gui.components.events.GuiEventListener; import net.minecraft.client.gui.components.events.GuiEventListener;
import net.minecraft.client.gui.screens.OptionsSubScreen; import net.minecraft.client.gui.screens.OptionsSubScreen;
import net.minecraft.client.gui.screens.Screen; import net.minecraft.client.gui.screens.Screen;
import net.minecraft.network.chat.CommonComponents; import net.minecraft.network.chat.CommonComponents;
import net.minecraft.network.chat.Component; import net.minecraft.network.chat.Component;
import net.minecraft.network.chat.TextComponent; import net.minecraft.network.chat.TextComponent;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.lwjgl.glfw.GLFW; import org.lwjgl.glfw.GLFW;
import javax.annotation.Nullable;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
import java.util.function.Consumer;
import static chylex.bettercontrols.gui.OptionListWidget.COL2_W; import static chylex.bettercontrols.gui.OptionListWidget.COL2_W;
import static chylex.bettercontrols.gui.OptionListWidget.COL4_W; import static chylex.bettercontrols.gui.OptionListWidget.COL4_W;
import static chylex.bettercontrols.gui.OptionListWidget.ROW_WIDTH; import static chylex.bettercontrols.gui.OptionListWidget.ROW_WIDTH;
import static chylex.bettercontrols.gui.OptionListWidget.col2; import static chylex.bettercontrols.gui.OptionListWidget.col2;
import static chylex.bettercontrols.gui.OptionListWidget.col4; import static chylex.bettercontrols.gui.OptionListWidget.col4;
import static chylex.bettercontrols.gui.elements.TextWidget.CENTER; import static chylex.bettercontrols.gui.elements.TextWidget.CENTER;
import static chylex.bettercontrols.util.Statics.OPTIONS;
public class BetterControlsScreen extends OptionsSubScreen { public class BetterControlsScreen extends OptionsSubScreen {
private static TextComponent text(final String text) { private static TextComponent text(final String text) {
@@ -54,46 +56,38 @@ public class BetterControlsScreen extends OptionsSubScreen {
// Options // Options
private int generateSprintingOptions(int y, final List<GuiEventListener> elements) { private int generateSprintingOptions(int y, final List<GuiEventListener> elements) {
final BetterControlsConfig cfg = BetterControlsMod.config; final BetterControlsConfig cfg = BetterControlsCommon.getConfig();
generateKeyBindingWithModifierOption(y, elements, text("Toggle Sprint"), cfg.keyToggleSprint);
generateKeyBindingWithModifierRow(y, elements, text("Toggle Sprint"), cfg.keyToggleSprint);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Sprint Key Mode")); generateCycleOptionRow(y, elements, text("Sprint Key Mode"), SPRINT_MODE_OPTIONS, cfg.sprintMode, value -> cfg.sprintMode = value);
elements.add(new CycleButtonWidget<>(col2(1), y, COL2_W, SPRINT_MODE_OPTIONS, cfg.sprintMode, value -> cfg.sprintMode = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Double Tap 'Walk Forwards' To Sprint")); generateBooleanOptionRow(y, elements, text("Double Tap 'Walk Forwards' To Sprint"), cfg.doubleTapForwardToSprint, value -> cfg.doubleTapForwardToSprint = value);
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.doubleTapForwardToSprint, value -> cfg.doubleTapForwardToSprint = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Resume Sprinting After Hitting Obstacle")); generateBooleanOptionRow(y, elements, text("Resume Sprinting After Hitting Obstacle"), cfg.resumeSprintingAfterHittingObstacle, value -> cfg.resumeSprintingAfterHittingObstacle = value);
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.resumeSprintingAfterHittingObstacle, value -> cfg.resumeSprintingAfterHittingObstacle = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
return y; return y;
} }
private int generateSneakingOptions(int y, final List<GuiEventListener> elements) { private int generateSneakingOptions(int y, final List<GuiEventListener> elements) {
final BetterControlsConfig cfg = BetterControlsMod.config; final BetterControlsConfig cfg = BetterControlsCommon.getConfig();
generateKeyBindingWithModifierOption(y, elements, text("Toggle Sneak"), cfg.keyToggleSneak);
generateKeyBindingWithModifierRow(y, elements, text("Toggle Sneak"), cfg.keyToggleSneak);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Move Camera Smoothly")); generateBooleanOptionRow(y, elements, text("Move Camera Smoothly"), cfg.sneakingMovesCameraSmoothly, value -> cfg.sneakingMovesCameraSmoothly = value);
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.sneakingMovesCameraSmoothly, value -> cfg.sneakingMovesCameraSmoothly = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
return y; return y;
} }
@SuppressWarnings({ "AutoBoxing", "AutoUnboxing" }) @SuppressWarnings({ "AutoBoxing", "AutoUnboxing" })
private int generateFlightOptions(int y, final List<GuiEventListener> elements) { private int generateFlightOptions(int y, final List<GuiEventListener> elements) {
final BetterControlsConfig cfg = BetterControlsMod.config; final BetterControlsConfig cfg = BetterControlsCommon.getConfig();
final List<Option<Float>> flightSpeedOptions = Arrays.asList( final List<Option<Float>> flightSpeedOptions = Arrays.asList(
new Option<>(Float.valueOf(0.25F), text("0.25x")), new Option<>(Float.valueOf(0.25F), text("0.25x")),
@@ -122,79 +116,64 @@ public class BetterControlsScreen extends OptionsSubScreen {
new Option<>(Float.valueOf(3.00F), text("+300%")) new Option<>(Float.valueOf(3.00F), text("+300%"))
); );
generateKeyBindingWithModifierOption(y, elements, text("Toggle Flight (Creative)"), cfg.keyToggleFlight); generateKeyBindingWithModifierRow(y, elements, text("Toggle Flight (Creative)"), cfg.keyToggleFlight);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Double Tap 'Jump' To Fly (Creative)")); generateBooleanOptionRow(y, elements, text("Double Tap 'Jump' To Fly (Creative)"), cfg.doubleTapJumpToToggleFlight, value -> cfg.doubleTapJumpToToggleFlight = value);
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.doubleTapJumpToToggleFlight, value -> cfg.doubleTapJumpToToggleFlight = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Disable Flight Inertia")); generateBooleanOptionRow(y, elements, text("Disable Flight Inertia"), cfg.disableFlightInertia, value -> cfg.disableFlightInertia = value);
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.disableFlightInertia, value -> cfg.disableFlightInertia = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Disable Field Of View Changing")); generateBooleanOptionRow(y, elements, text("Disable Field Of View Changing"), cfg.disableChangingFovWhileFlying, value -> cfg.disableChangingFovWhileFlying = value);
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.disableChangingFovWhileFlying, value -> cfg.disableChangingFovWhileFlying = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Fly On Ground (Creative Mode)")); generateBooleanOptionRow(y, elements, text("Fly On Ground (Creative Mode)"), cfg.flyOnGroundInCreative, value -> cfg.flyOnGroundInCreative = value);
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.flyOnGroundInCreative, value -> cfg.flyOnGroundInCreative = value)); y += ROW_HEIGHT;
y += ROW_HEIGHT * 4 / 3;
y += ROW_HEIGHT / 3;
elements.add(new TextWidget(col4(2), y, COL4_W - TEXT_PADDING_RIGHT, text("Creative"), CENTER)); elements.add(new TextWidget(col4(2), y, COL4_W - TEXT_PADDING_RIGHT, text("Creative"), CENTER));
elements.add(new TextWidget(col4(3), y, COL4_W - TEXT_PADDING_RIGHT, text("Spectator"), CENTER)); elements.add(new TextWidget(col4(3), y, COL4_W - TEXT_PADDING_RIGHT, text("Spectator"), CENTER));
y += ROW_HEIGHT * 7 / 8; y += ROW_HEIGHT * 7 / 8;
generateLeftSideText(y, elements, text("Speed Multiplier (Default)")); generateLeftSideText(y, elements, text("Speed Multiplier (Default)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpCreativeDefault, value -> cfg.flightSpeedMpCreativeDefault = value)); elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Speed Multiplier in Creative Mode"), flightSpeedOptions, cfg.flightSpeedMpCreativeDefault, value -> cfg.flightSpeedMpCreativeDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpSpectatorDefault, value -> cfg.flightSpeedMpSpectatorDefault = value)); elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Speed Multiplier in Spectator Mode"), flightSpeedOptions, cfg.flightSpeedMpSpectatorDefault, value -> cfg.flightSpeedMpSpectatorDefault = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Speed Multiplier (Sprinting)")); generateLeftSideText(y, elements, text("Speed Multiplier (Sprinting)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpCreativeSprinting, value -> cfg.flightSpeedMpCreativeSprinting = value)); elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Speed Multiplier when Sprinting in Creative Mode"), flightSpeedOptions, cfg.flightSpeedMpCreativeSprinting, value -> cfg.flightSpeedMpCreativeSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpSpectatorSprinting, value -> cfg.flightSpeedMpSpectatorSprinting = value)); elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Speed Multiplier when Sprinting in Spectator Mode"), flightSpeedOptions, cfg.flightSpeedMpSpectatorSprinting, value -> cfg.flightSpeedMpSpectatorSprinting = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Vertical Speed Boost (Default)")); generateLeftSideText(y, elements, text("Vertical Speed Boost (Default)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeDefault, value -> cfg.flightVerticalBoostCreativeDefault = value)); elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Vertical Speed Boost in Creative Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeDefault, value -> cfg.flightVerticalBoostCreativeDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorDefault, value -> cfg.flightVerticalBoostSpectatorDefault = value)); elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Vertical Speed Boost in Spectator Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorDefault, value -> cfg.flightVerticalBoostSpectatorDefault = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Vertical Speed Boost (Sprinting)")); generateLeftSideText(y, elements, text("Vertical Speed Boost (Sprinting)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeSprinting, value -> cfg.flightVerticalBoostCreativeSprinting = value)); elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Vertical Speed Boost when Sprinting in Creative Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeSprinting, value -> cfg.flightVerticalBoostCreativeSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorSprinting, value -> cfg.flightVerticalBoostSpectatorSprinting = value)); elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Vertical Speed Boost when Sprinting in Spectator Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorSprinting, value -> cfg.flightVerticalBoostSpectatorSprinting = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
return y; return y;
} }
private int generateMiscellaneousOptions(int y, final List<GuiEventListener> elements) { private int generateMiscellaneousOptions(int y, final List<GuiEventListener> elements) {
final BetterControlsConfig cfg = BetterControlsMod.config; final BetterControlsConfig cfg = BetterControlsCommon.getConfig();
generateKeyBindingWithModifierOption(y, elements, text("Toggle Walk Forwards"), cfg.keyToggleWalkForward);
generateKeyBindingWithModifierRow(y, elements, text("Toggle Walk Forwards"), cfg.keyToggleWalkForward);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateKeyBindingWithModifierOption(y, elements, text("Toggle Jump"), cfg.keyToggleJump); generateKeyBindingWithModifierRow(y, elements, text("Toggle Jump"), cfg.keyToggleJump);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateKeyBindingWithModifierOption(y, elements, text("Reset All Toggles"), cfg.keyResetAllToggles); generateKeyBindingWithModifierRow(y, elements, text("Reset All Toggles"), cfg.keyResetAllToggles);
y += ROW_HEIGHT * 4 / 3; y += ROW_HEIGHT * 4 / 3;
generateKeyBindingWithModifierOption(y, elements, text("Open Better Controls Menu"), cfg.keyOpenMenu); generateKeyBindingWithModifierRow(y, elements, text("Open Better Controls Menu"), cfg.keyOpenMenu);
y += ROW_HEIGHT; y += ROW_HEIGHT;
return y; return y;
} }
@@ -207,9 +186,9 @@ public class BetterControlsScreen extends OptionsSubScreen {
new Option<>(ModifierKey.ALT, text("Alt")) new Option<>(ModifierKey.ALT, text("Alt"))
); );
private void generateKeyBindingWithModifierOption(final int y, final List<GuiEventListener> elements, final Component text, final KeyBindingWithModifier binding) { private void generateKeyBindingWithModifierRow(final int y, final List<GuiEventListener> elements, final Component text, final KeyBindingWithModifier binding) {
final CycleButtonWidget<ModifierKey> modifierButton = new CycleButtonWidget<>(col4(2), y, COL4_W, MODIFIER_OPTIONS, binding.getModifier(), binding::setModifier); final var modifierButton = Option.button(col4(2), y, COL4_W, text.plainCopy().append(" Modifier"), MODIFIER_OPTIONS, binding.getModifier(), binding::setModifier);
final KeyBindingWidget bindingButton = new KeyBindingWidget(col4(3), y, COL4_W, text, binding, this::startEditingKeyBinding); final var bindingButton = new KeyBindingWidget(col4(3), y, COL4_W, text, binding, this::startEditingKeyBinding);
bindingButton.linkButtonToBoundState(modifierButton); bindingButton.linkButtonToBoundState(modifierButton);
generateLeftSideText(y, elements, text); generateLeftSideText(y, elements, text);
@@ -218,6 +197,19 @@ public class BetterControlsScreen extends OptionsSubScreen {
allKeyBindings.add(bindingButton); allKeyBindings.add(bindingButton);
} }
private static <T> void generateCycleOptionRow(final int y, final List<GuiEventListener> elements, final Component text, final List<Option<T>> options, final T initialValue, final Consumer<T> onValueChanged) {
generateLeftSideText(y, elements, text);
elements.add(Option.button(col2(1), y, COL2_W, text, options, initialValue, onValueChanged));
}
private static void generateBooleanOptionRow(final int y, final List<GuiEventListener> elements, final Component text, final boolean initialValue, final BooleanConsumer onValueChanged) {
generateLeftSideText(y, elements, text);
elements.add(CycleButton.onOffBuilder()
.displayOnlyValue()
.withInitialValue(Boolean.valueOf(initialValue))
.create(col2(1), y, COL2_W, 20, text, (btn, newValue) -> onValueChanged.accept(newValue.booleanValue())));
}
private static void generateLeftSideText(final int y, final List<GuiEventListener> elements, final Component text) { private static void generateLeftSideText(final int y, final List<GuiEventListener> elements, final Component text) {
elements.add(new TextWidget(col2(0), y, COL2_W - TEXT_PADDING_RIGHT, text)); elements.add(new TextWidget(col2(0), y, COL2_W - TEXT_PADDING_RIGHT, text));
} }
@@ -229,7 +221,7 @@ public class BetterControlsScreen extends OptionsSubScreen {
private final List<KeyBindingWidget> allKeyBindings = new ArrayList<>(); private final List<KeyBindingWidget> allKeyBindings = new ArrayList<>();
public BetterControlsScreen(@Nullable final Screen parentScreen) { public BetterControlsScreen(@Nullable final Screen parentScreen) {
super(parentScreen, OPTIONS, TITLE); super(parentScreen, Minecraft.getInstance().options, TITLE);
} }
@Override @Override
@@ -257,11 +249,11 @@ public class BetterControlsScreen extends OptionsSubScreen {
@Override @Override
public void removed() { public void removed() {
BetterControlsMod.config.save(); BetterControlsCommon.getConfig().save();
} }
@Override @Override
public void render(final PoseStack matrices, final int mouseX, final int mouseY, final float delta) { public void render(final @NotNull PoseStack matrices, final int mouseX, final int mouseY, final float delta) {
renderBackground(matrices); renderBackground(matrices);
optionsWidget.render(matrices, mouseX, mouseY, delta); optionsWidget.render(matrices, mouseX, mouseY, delta);
drawCenteredString(matrices, font, title, width / 2, 8, (255 << 16) | (255 << 8) | 255); drawCenteredString(matrices, font, title, width / 2, 8, (255 << 16) | (255 << 8) | 255);

View File

@@ -1,18 +1,19 @@
package chylex.bettercontrols.gui; package chylex.bettercontrols.gui;
import chylex.bettercontrols.gui.OptionListWidget.Entry; import chylex.bettercontrols.gui.OptionListWidget.Entry;
import com.mojang.blaze3d.vertex.PoseStack; import com.mojang.blaze3d.vertex.PoseStack;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.components.AbstractWidget; import net.minecraft.client.gui.components.AbstractWidget;
import net.minecraft.client.gui.components.ContainerObjectSelectionList; import net.minecraft.client.gui.components.ContainerObjectSelectionList;
import net.minecraft.client.gui.components.Widget; import net.minecraft.client.gui.components.Widget;
import net.minecraft.client.gui.components.events.GuiEventListener; import net.minecraft.client.gui.components.events.GuiEventListener;
import net.minecraft.client.gui.narration.NarratableEntry; import net.minecraft.client.gui.narration.NarratableEntry;
import org.jetbrains.annotations.NotNull;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collections; import java.util.Collections;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.function.Function; import java.util.function.Function;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
public final class OptionListWidget extends ContainerObjectSelectionList<Entry> { public final class OptionListWidget extends ContainerObjectSelectionList<Entry> {
public static final int ROW_WIDTH = 408; public static final int ROW_WIDTH = 408;
@@ -30,11 +31,11 @@ public final class OptionListWidget extends ContainerObjectSelectionList<Entry>
} }
private static Offset getElementOffset(final GuiEventListener element) { private static Offset getElementOffset(final GuiEventListener element) {
if (element instanceof OptionWidget) { if (element instanceof final OptionWidget widget) {
return new Offset(((OptionWidget)element).getX(), ((OptionWidget)element).getY()); return new Offset(widget.getX(), widget.getY());
} }
else if (element instanceof AbstractWidget) { else if (element instanceof final AbstractWidget widget) {
return new Offset(((AbstractWidget)element).x, ((AbstractWidget)element).y); return new Offset(widget.x, widget.y);
} }
else { else {
return new Offset(0, 0); return new Offset(0, 0);
@@ -48,18 +49,10 @@ public final class OptionListWidget extends ContainerObjectSelectionList<Entry>
void setY(int y); void setY(int y);
} }
private static final class Offset { private record Offset(int x, int y) {}
public final int x;
public final int y;
private Offset(final int x, final int y) {
this.x = x;
this.y = y;
}
}
public OptionListWidget(final int top, final int bottom, final int width, final int height, final List<GuiEventListener> widgets, final int innerHeight) { public OptionListWidget(final int top, final int bottom, final int width, final int height, final List<GuiEventListener> widgets, final int innerHeight) {
super(MINECRAFT, width, height, top, bottom, innerHeight); super(Minecraft.getInstance(), width, height, top, bottom, innerHeight);
addEntry(new Entry(widgets)); addEntry(new Entry(widgets));
} }
@@ -90,33 +83,31 @@ public final class OptionListWidget extends ContainerObjectSelectionList<Entry>
} }
@Override @Override
public List<? extends GuiEventListener> children() { public @NotNull List<? extends GuiEventListener> children() {
return Collections.unmodifiableList(elements); return Collections.unmodifiableList(elements);
} }
@Override @Override
public List<? extends NarratableEntry> narratables() { public @NotNull List<? extends NarratableEntry> narratables() {
return Collections.unmodifiableList(narratables); return Collections.unmodifiableList(narratables);
} }
@Override @Override
public void render(final PoseStack matrices, final int index, final int y, final int x, final int entryWidth, final int entryHeight, final int mouseX, final int mouseY, final boolean hovered, final float tickDelta) { public void render(final @NotNull PoseStack matrices, final int index, final int y, final int x, final int entryWidth, final int entryHeight, final int mouseX, final int mouseY, final boolean hovered, final float tickDelta) {
for (final GuiEventListener element : elements) { for (final GuiEventListener element : elements) {
final Offset offset = offsets.get(element); final Offset offset = offsets.get(element);
if (element instanceof AbstractWidget) { if (element instanceof final AbstractWidget widget) {
final AbstractWidget button = (AbstractWidget)element; widget.x = x + offset.x;
button.x = x + offset.x; widget.y = y + offset.y;
button.y = y + offset.y;
} }
else if (element instanceof OptionWidget) { else if (element instanceof final OptionWidget widget) {
final OptionWidget widget = (OptionWidget)element;
widget.setX(x + offset.x); widget.setX(x + offset.x);
widget.setY(y + offset.y); widget.setY(y + offset.y);
} }
if (element instanceof Widget) { if (element instanceof final Widget widget) {
((Widget)element).render(matrices, mouseX, mouseY, tickDelta); widget.render(matrices, mouseX, mouseY, tickDelta);
} }
} }
} }

View File

@@ -1,61 +0,0 @@
package chylex.bettercontrols.gui;
import chylex.bettercontrols.mixin.AccessCycleButtonFields;
import chylex.bettercontrols.mixin.AccessOptionFields;
import chylex.bettercontrols.mixin.AccessScreenButtons;
import net.minecraft.client.Option;
import net.minecraft.client.gui.components.Button;
import net.minecraft.client.gui.components.CycleButton;
import net.minecraft.client.gui.components.events.ContainerEventHandler;
import net.minecraft.client.gui.components.events.GuiEventListener;
import net.minecraft.client.gui.screens.AccessibilityOptionsScreen;
import net.minecraft.client.gui.screens.controls.ControlsScreen;
import java.util.List;
import java.util.Optional;
import java.util.function.Consumer;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
public final class ScreenPatcher {
private ScreenPatcher() {}
public static void onControlsScreenOpened(final ControlsScreen screen) {
final AccessScreenButtons accessor = (AccessScreenButtons)screen;
final List<? extends GuiEventListener> children = screen.children();
final CycleButton<?> autoJump = children.stream().flatMap(it -> getOptionButton(it, Option.AUTO_JUMP).stream()).findAny().orElse(null);
if (autoJump != null) {
final Button widget = new Button(autoJump.x, autoJump.y, autoJump.getWidth(), autoJump.getHeight(), BetterControlsScreen.TITLE.plainCopy().append("..."), btn -> {
MINECRAFT.setScreen(new BetterControlsScreen(screen));
});
accessor.callRemoveWidget(autoJump);
accessor.callAddRenderableWidget(widget);
}
}
public static void onAccessibilityScreenOpened(final AccessibilityOptionsScreen screen) {
walkChildren(screen.children(), it -> {
getOptionButton(it, Option.TOGGLE_SPRINT).ifPresent(button -> button.active = false);
getOptionButton(it, Option.TOGGLE_CROUCH).ifPresent(button -> button.active = false);
});
}
private static void walkChildren(final List<? extends GuiEventListener> elements, final Consumer<GuiEventListener> callback) {
for (final GuiEventListener element : elements) {
callback.accept(element);
if (element instanceof ContainerEventHandler) {
walkChildren(((ContainerEventHandler)element).children(), callback);
}
}
}
private static Optional<CycleButton<?>> getOptionButton(final GuiEventListener element, final Option option) {
if (element instanceof CycleButton<?> && ((AccessOptionFields)option).getCaption().equals(((AccessCycleButtonFields)element).getName())) {
return Optional.of((CycleButton<?>)element);
}
else {
return Optional.empty();
}
}
}

View File

@@ -1,27 +0,0 @@
package chylex.bettercontrols.gui.elements;
import it.unimi.dsi.fastutil.booleans.BooleanConsumer;
import net.minecraft.client.gui.components.Button;
import net.minecraft.network.chat.CommonComponents;
public final class BooleanValueWidget extends Button {
private final BooleanConsumer onChanged;
private boolean value;
public BooleanValueWidget(final int x, final int y, final int width, final int height, final boolean currentValue, final BooleanConsumer onChanged) {
super(x, y, width, height, currentValue ? CommonComponents.OPTION_ON : CommonComponents.OPTION_OFF, ignore -> {});
this.value = currentValue;
this.onChanged = onChanged;
}
public BooleanValueWidget(final int x, final int y, final int width, final boolean currentValue, final BooleanConsumer onChanged) {
this(x, y, width, 20, currentValue, onChanged);
}
@Override
public void onPress() {
super.onPress();
value = !value;
setMessage(value ? CommonComponents.OPTION_ON : CommonComponents.OPTION_OFF);
onChanged.accept(value);
}
}

View File

@@ -1,36 +0,0 @@
package chylex.bettercontrols.gui.elements;
import net.minecraft.client.gui.components.Button;
import java.util.List;
import java.util.function.Consumer;
public class CycleButtonWidget<T> extends Button {
private final List<Option<T>> options;
private final Consumer<T> onChanged;
private T selectedValue;
public CycleButtonWidget(final int x, final int y, final int width, final int height, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) {
super(x, y, width, height, Option.find(options, selectedValue).getText(), btn -> {});
this.options = options;
this.selectedValue = selectedValue;
this.onChanged = onChanged;
}
public CycleButtonWidget(final int x, final int y, final int width, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) {
this(x, y, width, 20, options, selectedValue, onChanged);
}
@Override
public void onPress() {
int nextIndex = options.indexOf(Option.find(options, selectedValue)) + 1;
if (nextIndex >= options.size()) {
nextIndex = 0;
}
final Option<T> newSelectedOption = options.get(nextIndex);
selectedValue = newSelectedOption.getValue();
onChanged.accept(selectedValue);
setMessage(newSelectedOption.getText());
}
}

View File

@@ -1,23 +1,29 @@
package chylex.bettercontrols.gui.elements; package chylex.bettercontrols.gui.elements;
import net.minecraft.client.gui.components.AbstractSliderButton; import net.minecraft.client.gui.components.AbstractSliderButton;
import net.minecraft.network.chat.Component;
import net.minecraft.network.chat.MutableComponent;
import net.minecraft.network.chat.TranslatableComponent;
import net.minecraft.util.Mth; import net.minecraft.util.Mth;
import org.jetbrains.annotations.NotNull;
import java.util.List; import java.util.List;
import java.util.function.Consumer; import java.util.function.Consumer;
public final class DiscreteValueSliderWidget<T> extends AbstractSliderButton { public final class DiscreteValueSliderWidget<T> extends AbstractSliderButton {
private final Component narration;
private final List<Option<T>> options; private final List<Option<T>> options;
private final Consumer<T> onChanged; private final Consumer<T> onChanged;
private T selectedValue; private T selectedValue;
public DiscreteValueSliderWidget(final int x, final int y, final int width, final int height, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) { public DiscreteValueSliderWidget(final int x, final int y, final int width, final int height, final Component narration, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) {
super(x, y, width, height, Option.find(options, selectedValue).getText(), options.indexOf(Option.find(options, selectedValue)) / (options.size() - 1.0)); super(x, y, width, height, Option.find(options, selectedValue).text(), options.indexOf(Option.find(options, selectedValue)) / (options.size() - 1.0));
this.narration = narration;
this.options = options; this.options = options;
this.selectedValue = selectedValue; this.selectedValue = selectedValue;
this.onChanged = onChanged; this.onChanged = onChanged;
} }
public DiscreteValueSliderWidget(final int x, final int y, final int width, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) { public DiscreteValueSliderWidget(final int x, final int y, final int width, final Component narration, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) {
this(x, y, width, 20, options, selectedValue, onChanged); this(x, y, width, 20, narration, options, selectedValue, onChanged);
} }
public Option<T> getSelectedOption() { public Option<T> getSelectedOption() {
@@ -26,16 +32,21 @@ public final class DiscreteValueSliderWidget<T> extends AbstractSliderButton {
@Override @Override
protected void updateMessage() { protected void updateMessage() {
setMessage(getSelectedOption().getText()); setMessage(getSelectedOption().text());
} }
@Override @Override
protected void applyValue() { protected void applyValue() {
final T newSelectedValue = getSelectedOption().getValue(); final T newSelectedValue = getSelectedOption().value();
if (selectedValue != newSelectedValue) { if (selectedValue != newSelectedValue) {
selectedValue = newSelectedValue; selectedValue = newSelectedValue;
onChanged.accept(newSelectedValue); onChanged.accept(newSelectedValue);
} }
} }
@Override
protected @NotNull MutableComponent createNarrationMessage() {
return new TranslatableComponent("gui.narrate.slider", narration.plainCopy().append(" ").append(getMessage()));
}
} }

View File

@@ -2,16 +2,17 @@ package chylex.bettercontrols.gui.elements;
import com.mojang.blaze3d.platform.InputConstants; import com.mojang.blaze3d.platform.InputConstants;
import net.minecraft.ChatFormatting; import net.minecraft.ChatFormatting;
import net.minecraft.client.KeyMapping; import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.components.AbstractButton; import net.minecraft.client.gui.components.AbstractButton;
import net.minecraft.client.gui.components.Button; import net.minecraft.client.gui.components.Button;
import net.minecraft.network.chat.Component; import net.minecraft.network.chat.Component;
import net.minecraft.network.chat.MutableComponent; import net.minecraft.network.chat.MutableComponent;
import net.minecraft.network.chat.TextComponent; import net.minecraft.network.chat.TextComponent;
import net.minecraft.network.chat.TranslatableComponent; import net.minecraft.network.chat.TranslatableComponent;
import org.jetbrains.annotations.NotNull;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.function.Consumer; import java.util.function.Consumer;
import static chylex.bettercontrols.util.Statics.OPTIONS;
public final class KeyBindingWidget extends Button { public final class KeyBindingWidget extends Button {
private final KeyMapping binding; private final KeyMapping binding;
@@ -40,7 +41,7 @@ public final class KeyBindingWidget extends Button {
} }
@Override @Override
protected MutableComponent createNarrationMessage() { protected @NotNull MutableComponent createNarrationMessage() {
return binding.isUnbound() ? new TranslatableComponent("narrator.controls.unbound", bindingName) : new TranslatableComponent("narrator.controls.bound", bindingName, super.createNarrationMessage()); return binding.isUnbound() ? new TranslatableComponent("narrator.controls.unbound", bindingName) : new TranslatableComponent("narrator.controls.bound", bindingName, super.createNarrationMessage());
} }
@@ -69,8 +70,8 @@ public final class KeyBindingWidget extends Button {
boolean hasConflict = false; boolean hasConflict = false;
if (!binding.isUnbound()) { if (!binding.isUnbound()) {
for (final KeyMapping other : OPTIONS.keyMappings) { for (final KeyMapping other : Minecraft.getInstance().options.keyMappings) {
if (binding != other && binding.equals(other)) { if (binding != other && binding.same(other)) {
hasConflict = true; hasConflict = true;
break; break;
} }

View File

@@ -1,26 +1,20 @@
package chylex.bettercontrols.gui.elements; package chylex.bettercontrols.gui.elements;
import net.minecraft.client.gui.components.CycleButton;
import net.minecraft.network.chat.Component; import net.minecraft.network.chat.Component;
import java.util.List; import java.util.List;
import java.util.Objects; import java.util.Objects;
import java.util.function.Consumer;
public final class Option<T> { public record Option<T>(T value, Component text) {
private final T value;
private final Component text;
public Option(final T value, final Component text) {
this.value = value;
this.text = text;
}
public T getValue() {
return value;
}
public Component getText() {
return text;
}
public static <T> Option<T> find(final List<Option<T>> options, final T value) { public static <T> Option<T> find(final List<Option<T>> options, final T value) {
return options.stream().filter(it -> Objects.equals(it.value, value)).findFirst().orElseGet(() -> options.get(0)); return options.stream().filter(it -> Objects.equals(it.value, value)).findFirst().orElseGet(() -> options.get(0));
} }
public static <T> CycleButton<Option<T>> button(final int x, final int y, final int width, final Component text, final List<Option<T>> options, final T initialValue, final Consumer<T> onValueChanged) {
return CycleButton.<Option<T>>builder(Option::text)
.displayOnlyValue()
.withValues(options)
.withInitialValue(find(options, initialValue))
.create(x, y, width, 20, text, (btn, newValue) -> onValueChanged.accept(newValue.value()));
}
} }

View File

@@ -1,12 +1,13 @@
package chylex.bettercontrols.gui.elements; package chylex.bettercontrols.gui.elements;
import chylex.bettercontrols.gui.OptionListWidget.OptionWidget; import chylex.bettercontrols.gui.OptionListWidget.OptionWidget;
import com.mojang.blaze3d.vertex.PoseStack; import com.mojang.blaze3d.vertex.PoseStack;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.Font; import net.minecraft.client.gui.Font;
import net.minecraft.client.gui.GuiComponent; import net.minecraft.client.gui.GuiComponent;
import net.minecraft.network.chat.Component; import net.minecraft.network.chat.Component;
import net.minecraft.util.FormattedCharSequence; import net.minecraft.util.FormattedCharSequence;
import org.jetbrains.annotations.NotNull;
import java.util.List; import java.util.List;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
public final class TextWidget extends GuiComponent implements OptionWidget { public final class TextWidget extends GuiComponent implements OptionWidget {
public static final int LEFT = 0; public static final int LEFT = 0;
@@ -57,8 +58,8 @@ public final class TextWidget extends GuiComponent implements OptionWidget {
} }
@Override @Override
public void render(final PoseStack matrices, final int mouseX, final int mouseY, final float delta) { public void render(final @NotNull PoseStack matrices, final int mouseX, final int mouseY, final float delta) {
final Font textRenderer = MINECRAFT.font; final Font textRenderer = Minecraft.getInstance().font;
final List<FormattedCharSequence> lines = textRenderer.split(text, width); final List<FormattedCharSequence> lines = textRenderer.split(text, width);
final int lineHeight = textRenderer.lineHeight + 1; final int lineHeight = textRenderer.lineHeight + 1;

View File

@@ -1,17 +1,11 @@
package chylex.bettercontrols.input; package chylex.bettercontrols.input;
import com.mojang.blaze3d.platform.InputConstants.Type; import com.mojang.blaze3d.platform.InputConstants.Type;
import net.minecraft.client.KeyMapping; import net.minecraft.client.KeyMapping;
import net.minecraft.network.chat.Component; import org.jetbrains.annotations.Nullable;
import net.minecraft.network.chat.TranslatableComponent;
import javax.annotation.Nullable;
public class KeyBindingWithModifier extends KeyMapping { public class KeyBindingWithModifier extends KeyMapping {
public static final String CATEGORY = "key.categories.bettercontrols"; public static final String CATEGORY = "key.categories.bettercontrols";
public static boolean checkCategoryMatches(final Component text) {
return text instanceof TranslatableComponent && CATEGORY.equals(((TranslatableComponent)text).getKey());
}
@Nullable @Nullable
private ModifierKey modifier = null; private ModifierKey modifier = null;

View File

@@ -5,6 +5,6 @@ import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(Camera.class) @Mixin(Camera.class)
public interface AccessCameraFields { public interface AccessCameraFields {
@Accessor("eyeHeight") @Accessor
void setCameraY(float y); void setEyeHeight(float y);
} }

View File

@@ -5,6 +5,6 @@ import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(LocalPlayer.class) @Mixin(LocalPlayer.class)
public interface AccessClientPlayerFields { public interface AccessClientPlayerFields {
@Accessor("sprintTriggerTime") @Accessor
void setTicksLeftToDoubleTapSprint(int value); void setSprintTriggerTime(int value);
} }

View File

@@ -1,11 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.screens.controls.ControlList.CategoryEntry;
import net.minecraft.network.chat.Component;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(CategoryEntry.class)
public interface AccessControlsListCategory {
@Accessor("name")
Component getText();
}

View File

@@ -1,11 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.KeyMapping;
import net.minecraft.client.gui.screens.controls.ControlList.KeyEntry;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(KeyEntry.class)
public interface AccessControlsListKeyBinding {
@Accessor("key")
KeyMapping getBinding();
}

View File

@@ -1,12 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.components.CycleButton;
import net.minecraft.network.chat.Component;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(CycleButton.class)
public interface AccessCycleButtonFields {
@Accessor("name")
Component getName();
}

View File

@@ -1,12 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.Option;
import net.minecraft.network.chat.Component;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(Option.class)
public interface AccessOptionFields {
@Accessor("caption")
Component getCaption();
}

View File

@@ -5,6 +5,6 @@ import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(Player.class) @Mixin(Player.class)
public interface AccessPlayerFields { public interface AccessPlayerFields {
@Accessor("jumpTriggerTime") @Accessor
void setTicksLeftToDoubleTapFlight(int value); void setJumpTriggerTime(int value);
} }

View File

@@ -1,16 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.components.Widget;
import net.minecraft.client.gui.components.events.GuiEventListener;
import net.minecraft.client.gui.narration.NarratableEntry;
import net.minecraft.client.gui.screens.Screen;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Invoker;
@Mixin(Screen.class)
public interface AccessScreenButtons {
@Invoker
<T extends GuiEventListener & Widget & NarratableEntry> T callAddRenderableWidget(T widget);
@Invoker
void callRemoveWidget(GuiEventListener widget);
}

View File

@@ -7,10 +7,10 @@ import java.util.function.BooleanSupplier;
@Mixin(ToggleKeyMapping.class) @Mixin(ToggleKeyMapping.class)
public interface AccessStickyKeyBindingStateGetter { public interface AccessStickyKeyBindingStateGetter {
@Accessor("needsToggle") @Accessor
BooleanSupplier getToggleGetter(); BooleanSupplier getNeedsToggle();
@Accessor("needsToggle") @Accessor
@Mutable @Mutable
void setToggleGetter(final BooleanSupplier toggleGetter); void setNeedsToggle(final BooleanSupplier toggleGetter);
} }

View File

@@ -1,15 +1,14 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import chylex.bettercontrols.player.PlayerTicker; import chylex.bettercontrols.player.PlayerTicker;
import net.minecraft.client.Minecraft;
import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.player.AbstractClientPlayer;
import net.minecraft.client.player.LocalPlayer; import net.minecraft.client.player.LocalPlayer;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect; import org.spongepowered.asm.mixin.injection.Redirect;
import org.spongepowered.asm.mixin.injection.Slice; import org.spongepowered.asm.mixin.injection.Slice;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
@SuppressWarnings("MethodMayBeStatic")
@Mixin(AbstractClientPlayer.class) @Mixin(AbstractClientPlayer.class)
public abstract class HookClientPlayerFOV { public abstract class HookClientPlayerFOV {
@Redirect( @Redirect(
@@ -21,7 +20,7 @@ public abstract class HookClientPlayerFOV {
) )
) )
private boolean resetFOV(final float movementSpeed) { private boolean resetFOV(final float movementSpeed) {
final LocalPlayer player = MINECRAFT.player; final LocalPlayer player = Minecraft.getInstance().player;
return (player != null && PlayerTicker.get(player).shouldResetFOV(player)) || Float.isNaN(movementSpeed); return (player != null && PlayerTicker.get(player).shouldResetFOV(player)) || Float.isNaN(movementSpeed);
} }
} }

View File

@@ -1,5 +1,6 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import chylex.bettercontrols.player.PlayerTicker; import chylex.bettercontrols.player.PlayerTicker;
import net.minecraft.client.Minecraft;
import net.minecraft.client.player.Input; import net.minecraft.client.player.Input;
import net.minecraft.client.player.KeyboardInput; import net.minecraft.client.player.KeyboardInput;
import net.minecraft.client.player.LocalPlayer; import net.minecraft.client.player.LocalPlayer;
@@ -7,15 +8,15 @@ import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject; import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
import static org.spongepowered.asm.mixin.injection.At.Shift.AFTER; import static org.spongepowered.asm.mixin.injection.At.Shift.AFTER;
@Mixin(KeyboardInput.class) @Mixin(KeyboardInput.class)
public abstract class HookClientPlayerInputTick { public abstract class HookClientPlayerInputTick {
@Inject(method = "tick(Z)V", at = @At(value = "FIELD", target = "Lnet/minecraft/client/player/KeyboardInput;up:Z", ordinal = 0, shift = AFTER)) @Inject(method = "tick(Z)V", at = @At(value = "FIELD", target = "Lnet/minecraft/client/player/KeyboardInput;up:Z", ordinal = 0, shift = AFTER))
private void afterInputTick(final CallbackInfo info) { private void afterInputTick(final CallbackInfo info) {
@SuppressWarnings("ConstantConditions")
final Input input = (Input)(Object)this; final Input input = (Input)(Object)this;
final LocalPlayer player = MINECRAFT.player; final LocalPlayer player = Minecraft.getInstance().player;
if (player != null) { if (player != null) {
PlayerTicker.get(player).afterInputAssignsPressingForward(input); PlayerTicker.get(player).afterInputAssignsPressingForward(input);

View File

@@ -18,18 +18,21 @@ public abstract class HookClientPlayerTick extends AbstractClientPlayer {
@Inject(method = "aiStep()V", at = @At("HEAD")) @Inject(method = "aiStep()V", at = @At("HEAD"))
private void atHead(final CallbackInfo info) { private void atHead(final CallbackInfo info) {
@SuppressWarnings("ConstantConditions")
final LocalPlayer player = (LocalPlayer)(Object)this; final LocalPlayer player = (LocalPlayer)(Object)this;
PlayerTicker.get(player).atHead(player); PlayerTicker.get(player).atHead(player);
} }
@Inject(method = "aiStep()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/Input;tick(Z)V", ordinal = 0, shift = AFTER)) @Inject(method = "aiStep()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/Input;tick(Z)V", ordinal = 0, shift = AFTER))
private void afterInputTick(final CallbackInfo info) { private void afterInputTick(final CallbackInfo info) {
@SuppressWarnings("ConstantConditions")
final LocalPlayer player = (LocalPlayer)(Object)this; final LocalPlayer player = (LocalPlayer)(Object)this;
PlayerTicker.get(player).afterInputTick(player); PlayerTicker.get(player).afterInputTick(player);
} }
@Inject(method = "aiStep()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/AbstractClientPlayer;aiStep()V", ordinal = 0, shift = AFTER)) @Inject(method = "aiStep()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/AbstractClientPlayer;aiStep()V", ordinal = 0, shift = AFTER))
private void afterSuperCall(final CallbackInfo info) { private void afterSuperCall(final CallbackInfo info) {
@SuppressWarnings("ConstantConditions")
final LocalPlayer player = (LocalPlayer)(Object)this; final LocalPlayer player = (LocalPlayer)(Object)this;
PlayerTicker.get(player).afterSuperCall(player); PlayerTicker.get(player).afterSuperCall(player);
} }

View File

@@ -1,37 +1,24 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import chylex.bettercontrols.BetterControlsMod; import chylex.bettercontrols.BetterControlsCommon;
import chylex.bettercontrols.input.KeyBindingWithModifier; import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft; import net.minecraft.client.Minecraft;
import net.minecraft.client.Options;
import net.minecraft.client.gui.components.ContainerObjectSelectionList; import net.minecraft.client.gui.components.ContainerObjectSelectionList;
import net.minecraft.client.gui.screens.controls.ControlList; import net.minecraft.client.gui.screens.controls.KeyBindsList;
import net.minecraft.client.gui.screens.controls.ControlList.CategoryEntry; import net.minecraft.client.gui.screens.controls.KeyBindsList.Entry;
import net.minecraft.client.gui.screens.controls.ControlList.Entry;
import net.minecraft.client.gui.screens.controls.ControlList.KeyEntry;
import net.minecraft.client.gui.screens.controls.ControlsScreen;
import org.apache.commons.lang3.ArrayUtils; import org.apache.commons.lang3.ArrayUtils;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject; import org.spongepowered.asm.mixin.injection.Redirect;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
@Mixin(ControlList.class) @Mixin(KeyBindsList.class)
public abstract class HookControlsListWidget extends ContainerObjectSelectionList<Entry> { public abstract class HookControlsListWidget extends ContainerObjectSelectionList<Entry> {
public HookControlsListWidget(final Minecraft client, final int width, final int height, final int top, final int bottom, final int itemHeight) { public HookControlsListWidget(final Minecraft client, final int width, final int height, final int top, final int bottom, final int itemHeight) {
super(client, width, height, top, bottom, itemHeight); super(client, width, height, top, bottom, itemHeight);
} }
@Inject(method = "<init>", at = @At("TAIL")) @Redirect(method = "<init>", at = @At(value = "FIELD", target = "Lnet/minecraft/client/Options;keyMappings:[Lnet/minecraft/client/KeyMapping;"))
public void init(final ControlsScreen parent, final Minecraft client, final CallbackInfo ci) { private KeyMapping[] excludeOwnKeyBindings(final Options options) {
children().removeIf(it -> { return ArrayUtils.removeElements(options.keyMappings, BetterControlsCommon.getConfig().getAllKeyBindings());
if (it instanceof CategoryEntry && KeyBindingWithModifier.checkCategoryMatches(((AccessControlsListCategory)it).getText())) {
return true;
}
if (it instanceof KeyEntry && ArrayUtils.contains(BetterControlsMod.config.getAllKeyBindings(), ((AccessControlsListKeyBinding)it).getBinding())) {
return true;
}
return false;
});
} }
} }

View File

@@ -0,0 +1,61 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.gui.BetterControlsScreen;
import net.minecraft.client.Minecraft;
import net.minecraft.client.Options;
import net.minecraft.client.gui.components.AbstractWidget;
import net.minecraft.client.gui.components.Button;
import net.minecraft.client.gui.components.events.GuiEventListener;
import net.minecraft.client.gui.screens.OptionsSubScreen;
import net.minecraft.client.gui.screens.Screen;
import net.minecraft.client.gui.screens.controls.ControlsScreen;
import net.minecraft.network.chat.Component;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
@Mixin(ControlsScreen.class)
public abstract class HookControlsScreen extends OptionsSubScreen {
public HookControlsScreen(final Screen parentScreen, final Options options, final Component title) {
super(parentScreen, options, title);
}
@Inject(method = "init", at = @At("RETURN"))
public void afterInit(final CallbackInfo ci) {
@SuppressWarnings("ConstantConditions")
final ControlsScreen screen = (ControlsScreen)(Object)this;
final int center = width / 2;
int leftBottomY = 0;
int rightBottomY = 0;
for (final GuiEventListener child : children()) {
if (!(child instanceof AbstractWidget widget)) {
continue;
}
final int bottomY = widget.y + widget.getHeight();
if (widget.x + widget.getWidth() < center) {
leftBottomY = Math.max(leftBottomY, bottomY);
}
if (widget.x >= center) {
rightBottomY = Math.max(rightBottomY, bottomY);
}
}
final int x, y;
if (leftBottomY < rightBottomY) {
x = center - 155;
y = leftBottomY + 4;
}
else {
x = center + 5;
y = rightBottomY + 4;
}
addRenderableWidget(new Button(x, y, 150, 20, BetterControlsScreen.TITLE.plainCopy().append("..."), btn -> Minecraft.getInstance().setScreen(new BetterControlsScreen(screen))));
}
}

View File

@@ -1,5 +1,6 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import chylex.bettercontrols.BetterControlsMod; import chylex.bettercontrols.BetterControlsCommon;
import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.input.KeyBindingWithModifier; import chylex.bettercontrols.input.KeyBindingWithModifier;
import net.minecraft.client.KeyMapping; import net.minecraft.client.KeyMapping;
import net.minecraft.client.Options; import net.minecraft.client.Options;
@@ -27,8 +28,13 @@ public abstract class HookLoadGameOptions {
return; return;
} }
final BetterControlsConfig config = BetterControlsCommon.getConfig();
if (config == null) {
return;
}
hasLoaded = true; hasLoaded = true;
keyMappings = ArrayUtils.addAll(keyMappings, BetterControlsMod.config.getAllKeyBindings()); keyMappings = ArrayUtils.addAll(keyMappings, config.getAllKeyBindings());
AccessKeyBindingFields.getCategoryOrderMap().put(KeyBindingWithModifier.CATEGORY, Integer.valueOf(Integer.MAX_VALUE)); AccessKeyBindingFields.getCategoryOrderMap().put(KeyBindingWithModifier.CATEGORY, Integer.valueOf(Integer.MAX_VALUE));
} }
} }

View File

@@ -1,29 +0,0 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.gui.ScreenPatcher;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.screens.AccessibilityOptionsScreen;
import net.minecraft.client.gui.screens.Screen;
import net.minecraft.client.gui.screens.controls.ControlsScreen;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
@SuppressWarnings("MethodMayBeStatic")
@Mixin(value = Minecraft.class, priority = 100)
public abstract class HookOpenScreen {
@Inject(method = "setScreen", at = @At("TAIL"))
private void openScreen(final Screen ignore, final CallbackInfo ci) {
final Screen screen = MINECRAFT.screen;
if (screen != null && !Screen.hasAltDown()) {
if (screen.getClass() == ControlsScreen.class) {
ScreenPatcher.onControlsScreenOpened((ControlsScreen)screen);
}
else if (screen.getClass() == AccessibilityOptionsScreen.class) {
ScreenPatcher.onAccessibilityScreenOpened((AccessibilityOptionsScreen)screen);
}
}
}
}

View File

@@ -8,7 +8,7 @@ import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect; import org.spongepowered.asm.mixin.injection.Redirect;
import org.spongepowered.asm.mixin.injection.Slice; import org.spongepowered.asm.mixin.injection.Slice;
@SuppressWarnings("MethodMayBeStatic") @SuppressWarnings("SameReturnValue")
@Mixin(Player.class) @Mixin(Player.class)
public abstract class HookPlayerFlightSpeed extends LivingEntity { public abstract class HookPlayerFlightSpeed extends LivingEntity {
protected HookPlayerFlightSpeed(final EntityType<? extends LivingEntity> type, final Level world) { protected HookPlayerFlightSpeed(final EntityType<? extends LivingEntity> type, final Level world) {

View File

@@ -0,0 +1,23 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.CycleOption;
import net.minecraft.client.Option;
import net.minecraft.client.Options;
import net.minecraft.client.gui.components.AbstractWidget;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
@Mixin(CycleOption.class)
public abstract class HookToggleOptionButtons {
@Inject(method = "createButton", at = @At("RETURN"))
private void disableToggleOptions(final Options options, final int x, final int y, final int width, final CallbackInfoReturnable<AbstractWidget> ci) {
@SuppressWarnings("ConstantConditions")
final CycleOption<?> me = (CycleOption<?>)(Object)this;
if (me == Option.TOGGLE_CROUCH || me == Option.TOGGLE_SPRINT) {
ci.getReturnValue().active = false;
}
}
}

View File

@@ -1,5 +1,5 @@
package chylex.bettercontrols.player; package chylex.bettercontrols.player;
import chylex.bettercontrols.BetterControlsMod; import chylex.bettercontrols.BetterControlsCommon;
import chylex.bettercontrols.config.BetterControlsConfig; import chylex.bettercontrols.config.BetterControlsConfig;
import net.minecraft.client.player.LocalPlayer; import net.minecraft.client.player.LocalPlayer;
@@ -10,7 +10,7 @@ final class FlightHelper {
private static final float BASE_VERTICAL_VELOCITY = 3F; private static final float BASE_VERTICAL_VELOCITY = 3F;
private static BetterControlsConfig cfg() { private static BetterControlsConfig cfg() {
return BetterControlsMod.config; return BetterControlsCommon.getConfig();
} }
static boolean isFlyingCreativeOrSpectator(final LocalPlayer player) { static boolean isFlyingCreativeOrSpectator(final LocalPlayer player) {

View File

@@ -1,5 +1,5 @@
package chylex.bettercontrols.player; package chylex.bettercontrols.player;
import chylex.bettercontrols.BetterControlsMod; import chylex.bettercontrols.BetterControlsCommon;
import chylex.bettercontrols.config.BetterControlsConfig; import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.gui.BetterControlsScreen; import chylex.bettercontrols.gui.BetterControlsScreen;
import chylex.bettercontrols.input.SprintMode; import chylex.bettercontrols.input.SprintMode;
@@ -10,18 +10,23 @@ import chylex.bettercontrols.mixin.AccessClientPlayerFields;
import chylex.bettercontrols.mixin.AccessPlayerFields; import chylex.bettercontrols.mixin.AccessPlayerFields;
import chylex.bettercontrols.mixin.AccessStickyKeyBindingStateGetter; import chylex.bettercontrols.mixin.AccessStickyKeyBindingStateGetter;
import net.minecraft.client.Camera; import net.minecraft.client.Camera;
import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft;
import net.minecraft.client.Options;
import net.minecraft.client.player.Input; import net.minecraft.client.player.Input;
import net.minecraft.client.player.LocalPlayer; import net.minecraft.client.player.LocalPlayer;
import java.lang.ref.WeakReference; import java.lang.ref.WeakReference;
import java.util.function.BooleanSupplier; import java.util.function.BooleanSupplier;
import static chylex.bettercontrols.util.Statics.KEY_FORWARD;
import static chylex.bettercontrols.util.Statics.KEY_JUMP;
import static chylex.bettercontrols.util.Statics.KEY_SNEAK;
import static chylex.bettercontrols.util.Statics.KEY_SPRINT;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
import static chylex.bettercontrols.util.Statics.OPTIONS;
public final class PlayerTicker { public final class PlayerTicker {
private static final Minecraft MINECRAFT = Minecraft.getInstance();
private static final Options OPTIONS = MINECRAFT.options;
private static final KeyMapping KEY_SPRINT = OPTIONS.keySprint;
private static final KeyMapping KEY_SNEAK = OPTIONS.keyShift;
private static final KeyMapping KEY_FORWARD = OPTIONS.keyUp;
private static final KeyMapping KEY_JUMP = OPTIONS.keyJump;
private static PlayerTicker ticker = new PlayerTicker(null); private static PlayerTicker ticker = new PlayerTicker(null);
public static PlayerTicker get(final LocalPlayer player) { public static PlayerTicker get(final LocalPlayer player) {
@@ -33,7 +38,7 @@ public final class PlayerTicker {
} }
private static BetterControlsConfig cfg() { private static BetterControlsConfig cfg() {
return BetterControlsMod.config; return BetterControlsCommon.getConfig();
} }
private final WeakReference<LocalPlayer> ref; private final WeakReference<LocalPlayer> ref;
@@ -63,13 +68,13 @@ public final class PlayerTicker {
private void setup() { private void setup() {
final AccessStickyKeyBindingStateGetter sprint = (AccessStickyKeyBindingStateGetter)KEY_SPRINT; final AccessStickyKeyBindingStateGetter sprint = (AccessStickyKeyBindingStateGetter)KEY_SPRINT;
BooleanSupplier getter = sprint.getToggleGetter(); BooleanSupplier getter = sprint.getNeedsToggle();
if (getter instanceof SprintPressGetter) { if (getter instanceof final SprintPressGetter g) {
getter = ((SprintPressGetter)getter).getWrapped(); getter = g.wrapped();
} }
sprint.setToggleGetter(new SprintPressGetter(getter, () -> temporarySprintTimer > 0)); sprint.setNeedsToggle(new SprintPressGetter(getter, () -> temporarySprintTimer > 0));
} }
public void atHead(final LocalPlayer player) { public void atHead(final LocalPlayer player) {
@@ -78,11 +83,11 @@ public final class PlayerTicker {
} }
if (!cfg().doubleTapForwardToSprint) { if (!cfg().doubleTapForwardToSprint) {
((AccessClientPlayerFields)player).setTicksLeftToDoubleTapSprint(0); ((AccessClientPlayerFields)player).setSprintTriggerTime(0);
} }
if (!cfg().doubleTapJumpToToggleFlight) { if (!cfg().doubleTapJumpToToggleFlight) {
((AccessPlayerFields)player).setTicksLeftToDoubleTapFlight(0); ((AccessPlayerFields)player).setJumpTriggerTime(0);
} }
final SprintMode sprintMode = cfg().sprintMode; final SprintMode sprintMode = cfg().sprintMode;
@@ -282,7 +287,7 @@ public final class PlayerTicker {
final Camera camera = MINECRAFT.gameRenderer.getMainCamera(); final Camera camera = MINECRAFT.gameRenderer.getMainCamera();
if (camera.getEntity() == player) { if (camera.getEntity() == player) {
((AccessCameraFields)camera).setCameraY(player.getEyeHeight()); ((AccessCameraFields)camera).setEyeHeight(player.getEyeHeight());
} }
} }

View File

@@ -1,19 +1,7 @@
package chylex.bettercontrols.player; package chylex.bettercontrols.player;
import java.util.function.BooleanSupplier; import java.util.function.BooleanSupplier;
final class SprintPressGetter implements BooleanSupplier { record SprintPressGetter(BooleanSupplier wrapped, BooleanSupplier or) implements BooleanSupplier {
private final BooleanSupplier wrapped;
private final BooleanSupplier or;
public SprintPressGetter(final BooleanSupplier wrapped, final BooleanSupplier or) {
this.wrapped = wrapped;
this.or = or;
}
public BooleanSupplier getWrapped() {
return wrapped;
}
@Override @Override
public boolean getAsBoolean() { public boolean getAsBoolean() {
return wrapped.getAsBoolean() || or.getAsBoolean(); return wrapped.getAsBoolean() || or.getAsBoolean();

View File

@@ -1,16 +0,0 @@
package chylex.bettercontrols.util;
import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft;
import net.minecraft.client.Options;
public final class Statics {
private Statics() {}
public static final Minecraft MINECRAFT = Minecraft.getInstance();
public static final Options OPTIONS = MINECRAFT.options;
public static final KeyMapping KEY_SPRINT = OPTIONS.keySprint;
public static final KeyMapping KEY_SNEAK = OPTIONS.keyShift;
public static final KeyMapping KEY_FORWARD = OPTIONS.keyUp;
public static final KeyMapping KEY_JUMP = OPTIONS.keyJump;
}

View File

@@ -1,14 +0,0 @@
package io.github.prospector.modmenu.api;
import com.google.common.collect.ImmutableMap;
import java.util.Map;
@SuppressWarnings("unused")
public interface ModMenuApi {
default ConfigScreenFactory<?> getModConfigScreenFactory() {
return ignore -> null;
}
default Map<String, ConfigScreenFactory<?>> getProvidedConfigScreenFactories() {
return ImmutableMap.of();
}
}

View File

@@ -2,26 +2,23 @@
"required": true, "required": true,
"minVersion": "0.8", "minVersion": "0.8",
"package": "chylex.bettercontrols.mixin", "package": "chylex.bettercontrols.mixin",
"compatibilityLevel": "JAVA_16", "refmap": "bettercontrols.refmap.json",
"compatibilityLevel": "JAVA_17",
"client": [ "client": [
"AccessCameraFields", "AccessCameraFields",
"AccessClientPlayerFields", "AccessClientPlayerFields",
"AccessControlsListCategory",
"AccessControlsListKeyBinding",
"AccessCycleButtonFields",
"AccessKeyBindingFields", "AccessKeyBindingFields",
"AccessOptionFields",
"AccessPlayerFields", "AccessPlayerFields",
"AccessScreenButtons",
"AccessStickyKeyBindingStateGetter", "AccessStickyKeyBindingStateGetter",
"HookClientPlayerFOV", "HookClientPlayerFOV",
"HookClientPlayerInputTick", "HookClientPlayerInputTick",
"HookClientPlayerTick", "HookClientPlayerTick",
"HookControlsListWidget", "HookControlsListWidget",
"HookControlsScreen",
"HookLoadGameOptions", "HookLoadGameOptions",
"HookOpenScreen",
"HookPlayerFlightSpeed", "HookPlayerFlightSpeed",
"HookStickyKeyBindingState" "HookStickyKeyBindingState",
"HookToggleOptionButtons"
], ],
"injectors": { "injectors": {
"defaultRequire": 1 "defaultRequire": 1

View File

@@ -1,33 +0,0 @@
{
"schemaVersion": 1,
"id": "bettercontrols",
"version": "${version}",
"name": "Better Controls",
"description": "Adds many powerful key bindings and options to control your movement.\nThe features complement vanilla mechanics without giving unfair advantages, so server use should be fine.",
"icon": "assets/bettercontrols/icon.png",
"license": "MPL-2.0",
"authors": [ "chylex" ],
"contact": {
"homepage": "",
"sources": "https://github.com/chylex/Better-Controls",
"issues": "https://github.com/chylex/Better-Controls/issues"
},
"environment": "client",
"entrypoints": {
"client": [ "chylex.bettercontrols.BetterControlsMod" ],
"modmenu": [ "chylex.bettercontrols.compatibility.ModMenuSupport" ]
},
"mixins": [{
"config": "bettercontrols.mixins.json",
"environment": "client"
}],
"depends": {
"fabricloader": ">=0.7.4",
"minecraft": ">=1.17"
}
}

View File

@@ -0,0 +1,7 @@
{
"pack": {
"description": "${name}",
"pack_format": 7,
"_comment": ""
}
}