1
0
mirror of https://github.com/chylex/Better-Controls.git synced 2025-08-18 10:31:48 +02:00

37 Commits

Author SHA1 Message Date
449ee5b435 Release v1.2.1 for Minecraft 1.17+ 2021-10-05 14:08:12 +02:00
7fba750e35 Tweak JAR file names 2021-10-05 14:07:55 +02:00
c234946265 Fix narrator not reading names of options 2021-10-04 21:22:12 +02:00
edf97c834a Fix broken mixins in runtime environment 2021-10-03 20:53:48 +02:00
cbe3fa6a71 Simplify mixins 2021-10-03 18:07:59 +02:00
0d1dfdee87 Minor refactoring 2021-10-03 15:13:16 +02:00
d7d0bf072a Update README 2021-10-03 13:34:11 +02:00
4e12f8b43c Fix not showing key binding conflicts since 1.17 2021-10-03 12:04:30 +02:00
6c2bf71472 Merge Fabric & Forge codebases 2021-10-03 11:44:02 +02:00
a875ae2255 Unify with Forge codebase 2021-10-02 15:38:34 +02:00
f0214983e5 Fix narration of key bindings 2021-10-02 15:22:28 +02:00
0400dd3b36 Remove some utility classes 2021-10-02 15:13:24 +02:00
7f8065fa97 Migrate to Mojang mappings 2021-10-02 15:13:24 +02:00
de07ba881b Release v1.2.0 for Minecraft 1.17+ 2021-06-14 20:13:15 +02:00
239a2a7494 Update Gradle to 7.0 2021-06-14 17:13:39 +02:00
a0dce54b00 Update README 2020-12-10 06:10:51 +01:00
24e4df4a49 Release v1.2.0 for Minecraft 1.16.2+ 2020-12-10 05:50:36 +01:00
f60b23ecdc Fix tapping sneak to stop flying on ground not working when flight inertia is disabled 2020-12-10 05:50:36 +01:00
b23d1ebca5 Add option to disable double tapping 'Jump' key to flight
Fixes #6
2020-12-09 12:17:10 +01:00
76387252c0 Change flight to 'Hold to Sprint' mode at all times & fix not boost unless flying forward 2020-12-09 06:47:28 +01:00
b1fd62dd91 Add option to disable flight inertia after releasing movement keys
Fixes #2
2020-12-09 05:46:37 +01:00
dae0eb4b25 Fix unreleased refactor breaking keybind serialization 2020-12-09 05:19:54 +01:00
a2c9fd3c4b Minor code tweaks 2020-12-09 04:57:20 +01:00
933d62585b Add README 2020-12-09 04:04:29 +01:00
b7d4af6182 Fix compile error in 1.16.4 (apparently override visibility is forwards compatible so 1.16.2+ build still works) 2020-11-03 01:04:35 +01:00
0c2eb63a24 Refactor code to make porting easier 2020-10-30 17:41:08 +01:00
2b1a032295 Release v1.1.0 for Minecraft 1.16.2+ 2020-10-27 17:14:07 +01:00
5f5c3da988 Avoid sudden FOV jump when starting to fly with disabled FOV changing 2020-10-27 17:03:15 +01:00
b511727be9 Add options for vertical flight speed boost in creative/spectator and default/sprinting modes 2020-10-27 16:37:13 +01:00
fa82145530 Add more flight speed options (5x and 7x) 2020-10-26 22:23:21 +01:00
ebd522dca7 Add option to prevent FOV changing while flying 2020-10-26 21:30:23 +01:00
90c3379d57 Add key binding to reset all toggles at once 2020-10-26 21:12:26 +01:00
04c789a50e Implement third sprinting mode (hold key to sprint) & option to change sprinting mode when flying 2020-10-26 21:12:26 +01:00
a79871b690 Release v1.0.1 for Minecraft 1.16.2+ 2020-10-19 21:12:33 +02:00
c537e037b5 Avoid wobble sprinting when resuming sprinting after hitting an obstacle, by simulating holding sprint for multiple ticks 2020-10-19 21:11:38 +02:00
c0e9c92197 Release v1.0.0 for Minecraft 1.16.2+ 2020-10-18 16:47:35 +02:00
e55cef95b3 Fix sprinting not stopping when untoggling sometimes 2020-10-18 16:02:15 +02:00
68 changed files with 1109 additions and 1017 deletions

1
.gitignore vendored
View File

@@ -27,3 +27,4 @@ bin/
# fabric
run/
logs/

50
Fabric/build.gradle.kts Normal file
View File

@@ -0,0 +1,50 @@
val modId: String by project
val minecraftVersion: String by project
val fabricVersion: String by project
plugins {
idea
id("fabric-loom") version "0.9-SNAPSHOT"
}
dependencies {
minecraft("com.mojang:minecraft:$minecraftVersion")
modImplementation("net.fabricmc:fabric-loader:$fabricVersion")
mappings(loom.officialMojangMappings())
}
loom {
runs {
named("client") {
configName = "Fabric Client"
client()
runDir("run")
ideConfigGenerated(true)
}
named("server") {
configName = "Fabric Server"
server()
runDir("run")
ideConfigGenerated(true)
}
}
mixin {
add(sourceSets.main.get(), "$modId.refmap.json")
}
}
tasks.processResources {
filesMatching("fabric.mod.json") {
expand(inputs.properties)
}
}
tasks.jar {
exclude("io/github/prospector/")
}
tasks.remapJar {
archiveVersion.set(tasks.jar.get().archiveVersion)
}

View File

@@ -4,8 +4,8 @@ import net.fabricmc.api.ClientModInitializer;
import net.fabricmc.loader.api.FabricLoader;
public final class BetterControlsMod implements ClientModInitializer {
public static final BetterControlsConfig config = BetterControlsConfig.load(FabricLoader.getInstance().getConfigDir().resolve("BetterControls.json"));
@Override
public void onInitializeClient(){}
public void onInitializeClient() {
BetterControlsCommon.setConfig(BetterControlsConfig.load(FabricLoader.getInstance().getConfigDir().resolve("BetterControls.json")));
}
}

View File

@@ -4,11 +4,6 @@ import io.github.prospector.modmenu.api.ConfigScreenFactory;
import io.github.prospector.modmenu.api.ModMenuApi;
public class ModMenuSupport implements ModMenuApi {
@Override
public String getModId(){
return "bettercontrols";
}
@Override
public ConfigScreenFactory<?> getModConfigScreenFactory() {
return BetterControlsScreen::new;

View File

@@ -1,5 +1,5 @@
package io.github.prospector.modmenu.api;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.screens.Screen;
@SuppressWarnings("unused")
@FunctionalInterface

View File

@@ -4,8 +4,6 @@ import java.util.Map;
@SuppressWarnings("unused")
public interface ModMenuApi {
String getModId();
default ConfigScreenFactory<?> getModConfigScreenFactory() {
return ignore -> null;
}

View File

Before

Width:  |  Height:  |  Size: 21 KiB

After

Width:  |  Height:  |  Size: 21 KiB

View File

@@ -3,7 +3,7 @@
"id": "bettercontrols",
"version": "${version}",
"name": "Better Controls",
"name": "${name}",
"description": "Adds many powerful key bindings and options to control your movement.\nThe features complement vanilla mechanics without giving unfair advantages, so server use should be fine.",
"icon": "assets/bettercontrols/icon.png",
"license": "MPL-2.0",
@@ -28,6 +28,6 @@
"depends": {
"fabricloader": ">=0.7.4",
"minecraft": "1.15.x"
"minecraft": ">=1.17"
}
}

95
Forge/build.gradle.kts Normal file
View File

@@ -0,0 +1,95 @@
import net.minecraftforge.gradle.userdev.UserDevExtension
import org.gradle.api.file.DuplicatesStrategy.INCLUDE
import org.spongepowered.asm.gradle.plugins.MixinExtension
val modId: String by project
val minecraftVersion: String by project
val forgeVersion: String by project
val mixinVersion: String by project
buildscript {
repositories {
maven("https://maven.minecraftforge.net")
maven("https://repo.spongepowered.org/maven")
mavenCentral()
}
dependencies {
classpath(group = "net.minecraftforge.gradle", name = "ForgeGradle", version = "5.1.+") { isChanging = true }
classpath(group = "org.spongepowered", name = "mixingradle", version = "0.7-SNAPSHOT")
}
}
plugins {
java
eclipse
}
apply {
plugin("net.minecraftforge.gradle")
plugin("org.spongepowered.mixin")
}
dependencies {
"minecraft"("net.minecraftforge:forge:$minecraftVersion-$forgeVersion")
if (System.getProperty("idea.sync.active") != "true") {
annotationProcessor("org.spongepowered:mixin:$mixinVersion:processor")
}
}
configure<UserDevExtension> {
mappings("official", minecraftVersion)
runs {
create("client") {
taskName = "Client"
workingDirectory(rootProject.file("run"))
ideaModule("${rootProject.name}.${project.name}.main")
property("mixin.env.remapRefMap", "true")
property("mixin.env.refMapRemappingFile", "$projectDir/build/createSrgToMcp/output.srg")
arg("-mixin.config=$modId.mixins.json")
mods {
create(modId) {
source(sourceSets.main.get())
source(rootProject.sourceSets.main.get())
}
}
}
create("server") {
taskName = "Server"
workingDirectory(rootProject.file("run"))
ideaModule("${rootProject.name}.${project.name}.main")
property("mixin.env.remapRefMap", "true")
property("mixin.env.refMapRemappingFile", "$projectDir/build/createSrgToMcp/output.srg")
arg("-mixin.config=$modId.mixins.json")
mods {
create(modId) {
source(sourceSets.main.get())
source(rootProject.sourceSets.main.get())
}
}
}
}
}
configure<MixinExtension> {
add(sourceSets.main.get(), "$modId.refmap.json")
}
tasks.processResources {
from(sourceSets.main.get().resources.srcDirs) {
include("META-INF/mods.toml")
expand(inputs.properties)
duplicatesStrategy = INCLUDE
}
}
tasks.jar {
finalizedBy("reobfJar")
}

View File

@@ -0,0 +1,32 @@
package chylex.bettercontrols;
import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.gui.BetterControlsScreen;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.screens.Screen;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.fml.DistExecutor;
import net.minecraftforge.fml.IExtensionPoint.DisplayTest;
import net.minecraftforge.fml.ModLoadingContext;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.loading.FMLPaths;
import net.minecraftforge.fmlclient.ConfigGuiHandler.ConfigGuiFactory;
import net.minecraftforge.fmllegacy.network.FMLNetworkConstants;
@Mod("bettercontrols")
public final class BetterControlsMod {
public BetterControlsMod() {
BetterControlsCommon.setConfig(DistExecutor.safeCallWhenOn(Dist.CLIENT, () -> ClientLoader::loadConfig));
ModLoadingContext.get().registerExtensionPoint(ConfigGuiFactory.class, () -> new ConfigGuiFactory(ClientLoader::createScreen));
ModLoadingContext.get().registerExtensionPoint(DisplayTest.class, () -> new DisplayTest(() -> FMLNetworkConstants.IGNORESERVERONLY, (a, b) -> true));
}
private static final class ClientLoader {
public static BetterControlsConfig loadConfig() {
return BetterControlsConfig.load(FMLPaths.CONFIGDIR.get().resolve("BetterControls.json"));
}
public static BetterControlsScreen createScreen(final Minecraft mc, final Screen parentScreen) {
return new BetterControlsScreen(parentScreen);
}
}
}

View File

@@ -0,0 +1,30 @@
modLoader = "javafml"
loaderVersion = "[37,)"
authors = "chylex"
license = "MPL-2.0"
issueTrackerURL = "https://github.com/chylex/Better-Controls/issues"
[[mods]]
modId = "bettercontrols"
version = "${version}"
displayName = "${name}"
logoFile = "icon.png"
description = '''
Adds many powerful key bindings and options to control your movement.
The features complement vanilla mechanics without giving unfair advantages, so server use should be fine.
'''
[[dependencies.bettercontrols]]
modId = "minecraft"
mandatory = true
versionRange = "[1.17.1,)"
ordering = "NONE"
side = "BOTH"
[[dependencies.bettercontrols]]
modId = "forge"
mandatory = true
versionRange = "[37,)"
ordering = "NONE"
side = "BOTH"

Binary file not shown.

After

Width:  |  Height:  |  Size: 21 KiB

View File

@@ -3,9 +3,9 @@ Better Controls
![Logo](https://raw.githubusercontent.com/chylex/Better-Controls/master/logo.png "Depiction of Zero Regrets")
Better Controls is a reimagining of [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting) with even more customizability. It features several new keybindings and many configurable options for how sprinting, sneaking, and flying should behave.
[Better Controls](https://www.curseforge.com/minecraft/mc-mods/better-controls) is a reimagining of [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting) with even more customizability. It features several new keybindings and many configurable options for how sprinting, sneaking, and flying should behave.
Better Controls only focuses on complementing vanilla mechanics rather than adding new mechanics (such as [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting)'s option to allow sprinting in all directions) that only work on client side and server owners must explicitly opt in to enable them. By not having such features in Better Controls, it significantly reduces complexity by not having a server side version of the mod, and not needing a way to completely disable the mod while the game is running.
Better Controls only focuses on complementing vanilla mechanics, rather than adding new mechanics (such as [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting)'s option to allow sprinting in all directions) that only work on client side and server owners must explicitly opt in to enable them. By not having such features in Better Controls, it significantly reduces complexity by not having a server side version of the mod, and not needing a way to completely disable the mod while the game is running.
Another major difference is the amount and granularity of options. Better Controls could be considered an *advanced controls mod* - by default, none of the keybinds are bound, and all options are set to match vanilla behavior. To take full advantage, go into *Options - Controls - Better Controls*, check out all of the available options, and figure out the best configuration for you.
@@ -27,12 +27,15 @@ You can also bind a key that resets all **Toggle Keybinds** at once. That makes
#### Flying
* **Sprint Key Mode While Flying** changes how the Sprint key behaves during flight.
* **Double Tap 'Jump' To Fly** can be turned off to prevent accidental flight toggling.
* **Disable Flight Inertia** stops you instantly when you stop holding movement keys.
* **Disable Field Of View Changing** prevents sprinting, potions, and other factors from changing the FOV while flying in creative and spectator mode.
* **Fly On Ground** lets you fly while touching the ground in creative mode (and also lets you stop flying by tapping Sneak while touching the ground).
* **Flight Speed Multiplier** (0.25x - 8x) changes how fast you fly in creative and spectator mode.
* **Vertical Speed Boost** (up to +300%) adds additional vertical speed boost while flying in creative and spectator mode.
Both speed boosts can be configured separately for sprinting, which will be active when the Sprint key is held. Unlike in vanilla, the sprinting flight boost works in all directions.
## Installation
The following mod loaders are supported:
@@ -51,7 +54,7 @@ While this is convenient, there is potential for bugs which can affect server pl
### Compatibility
* Better Controls is a client-side mod, it will do nothing when installed on a server.
* If you run into a conflict with another mod that modifies the *Controls* screen, hold Alt while opening *Controls* to prevent Better Controls from adding its button. If another mod prevents the button from appearing, you can install [Mod Menu](https://www.curseforge.com/minecraft/mc-mods/modmenu) which adds a mod list with configuration buttons for mods.
* If you run into a conflict with another mod that modifies the *Controls* screen, hold Alt while opening *Controls* to prevent Better Controls from adding its button. If another mod prevents the button from appearing, a button to open the mod's configuration is available in the Mods menu (for Fabric, install [Mod Menu](https://www.curseforge.com/minecraft/mc-mods/modmenu)).
## Screenshot
@@ -60,11 +63,15 @@ While this is convenient, there is potential for bugs which can affect server pl
Source Code
===========
The `main` branch includes the latest version for Fabric. Older versions and their Forge equivalents are in branches named `fabric/<version>` and `forge/<version>`.
The `main` branch includes both the Fabric and Forge version in a single project. The project uses Mojang mappings. The root project contains common source code and resource files, and the `Fabric` and `Forge` folders are subprojects with loader-specific files.
The `main` branch always has the latest development version. Before updating to a new Minecraft version, a new branch is created from the `main` branch (for example, before the mod is updated to `1.18`, a branch named `1.17` will be created). Further development of older versions may continue in these branches in case backports or version-specific fixes are needed.
Older versions from before the merge of the Fabric and Forge versions can be found in branches named `fabric/<version>` and `forge/<version>`.
## Contributing
All contributions should target the `main` branch, unless the contribution is specifically made for older versions. Every feature must be portable to Forge to ensure parity, unless the feature adds integration with another mod that is only compatible with one mod loader. Integrations for Forge-only mods should target the most recent `forge/<version>` branch.
All contributions should target the `main` branch and work in both Fabric and Forge, unless the contribution is specifically targeting older versions or a specific mod loader.
For any larger contributions, please [open an issue](https://github.com/chylex/Better-Controls/issues/new) first before you make a PR.

View File

@@ -1,41 +0,0 @@
plugins {
id 'fabric-loom' version '0.5-SNAPSHOT'
id 'maven-publish'
}
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
archivesBaseName = project.archives_base_name
version = project.mod_version
group = project.maven_group
dependencies {
minecraft "com.mojang:minecraft:${project.minecraft_version}"
mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2"
modImplementation "net.fabricmc:fabric-loader:${project.loader_version}"
}
processResources {
inputs.property "version", project.version
from(sourceSets.main.resources.srcDirs) {
include "fabric.mod.json"
expand "version": project.version
}
from(sourceSets.main.resources.srcDirs) {
exclude "fabric.mod.json"
}
}
tasks.withType(JavaCompile) {
options.encoding = "UTF-8"
}
version = 'v' + version
jar {
from "LICENSE"
exclude "io/github/prospector/"
}

129
build.gradle.kts Normal file
View File

@@ -0,0 +1,129 @@
import org.gradle.api.file.DuplicatesStrategy.EXCLUDE
import java.text.SimpleDateFormat
import java.util.Date
val modId: String by project
val modName: String by project
val modAuthor: String by project
val modVersion: String by project
val minecraftVersion: String by project
val mixinVersion: String by project
val modNameStripped = modName.replace(" ", "")
val jarVersion = "$minecraftVersion+v$modVersion"
buildscript {
repositories {
maven("https://repo.spongepowered.org/maven")
}
}
plugins {
`java-library`
idea
id("org.spongepowered.gradle.vanilla") version "0.2.1-SNAPSHOT"
}
idea {
module {
excludeDirs.add(project.file("run"))
}
}
repositories {
maven("https://repo.spongepowered.org/maven")
mavenCentral()
}
dependencies {
implementation("org.spongepowered:mixin:$mixinVersion")
api("com.google.code.findbugs:jsr305:3.0.2")
}
base {
archivesName.set("$modNameStripped-Common")
}
minecraft {
version(minecraftVersion)
runs.clear()
}
allprojects {
group = "com.$modAuthor.$modId"
version = modVersion
apply(plugin = "java")
dependencies {
implementation("org.jetbrains:annotations:22.0.0")
}
extensions.getByType<JavaPluginExtension>().apply {
toolchain.languageVersion.set(JavaLanguageVersion.of(16))
}
tasks.withType<JavaCompile> {
options.encoding = "UTF-8"
options.release.set(16)
}
}
subprojects {
repositories {
maven("https://repo.spongepowered.org/maven")
}
dependencies {
implementation(rootProject)
}
base {
archivesName.set("$modNameStripped-${project.name}")
}
tasks.withType<JavaCompile> {
source({ rootProject.sourceSets.main.get().allSource })
}
tasks.processResources {
from(rootProject.sourceSets.main.get().resources)
inputs.property("name", modName)
inputs.property("version", modVersion)
}
tasks.jar {
archiveVersion.set(jarVersion)
from(rootProject.file("LICENSE"))
manifest {
attributes(
"Specification-Title" to modId,
"Specification-Vendor" to modAuthor,
"Specification-Version" to "1",
"Implementation-Title" to "$modNameStripped-${project.name}",
"Implementation-Vendor" to modAuthor,
"Implementation-Version" to modVersion,
"Implementation-Timestamp" to SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ").format(Date()),
"MixinConfigs" to "$modId.mixins.json"
)
}
}
}
val copyJars = tasks.register<Copy>("copyJars") {
duplicatesStrategy = EXCLUDE
for (subproject in subprojects) {
dependsOn(subproject.tasks.build)
from(subproject.base.libsDirectory.file("${subproject.base.archivesName.get()}-$jarVersion.jar"))
}
into(file("${project.buildDir}/dist"))
}
tasks.build {
finalizedBy(copyJars)
}

View File

@@ -1,15 +1,15 @@
# Done to increase the memory available to gradle.
org.gradle.jvmargs=-Xmx1G
# Mod
modId=bettercontrols
modName=Better Controls
modAuthor=chylex
modVersion=1.2.1
# Fabric Properties
minecraft_version=1.15.2
yarn_mappings=1.15.2+build.17
loader_version=0.10.2+build.210
# Dependencies
minecraftVersion=1.17.1
forgeVersion=37.0.75
fabricVersion=0.11.7
mixinVersion=0.8.4
# Mod Properties
mod_version=1.2.0
maven_group=chylex.bettercontrols
archives_base_name=BetterControls-1.15.x
# https://fabricmc.net/use
# https://maven.fabricmc.net/net/fabricmc/fabric-api/fabric-api
# Gradle
org.gradle.jvmargs=-Xmx3G
org.gradle.daemon=false

Binary file not shown.

View File

@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

20
gradlew vendored
View File

@@ -1,4 +1,4 @@
#!/usr/bin/env sh
#!/usr/bin/env bash
#
# Copyright 2015 the original author or authors.
@@ -72,7 +72,7 @@ case "`uname`" in
Darwin* )
darwin=true
;;
MINGW* )
MSYS* | MINGW* )
msys=true
;;
NONSTOP* )
@@ -172,14 +172,12 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
esac
fi
# Escape application args
save () {
for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done
echo " "
}
APP_ARGS=`save "$@"`
ARGV=("$@")
eval set -- $DEFAULT_JVM_OPTS
# Collect all arguments for the java command, following the shell quoting and substitution rules
eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS"
IFS=$'
' read -rd '' -a JAVA_OPTS_ARR <<< "$(echo $JAVA_OPTS | xargs -n1)"
IFS=$'
' read -rd '' -a GRADLE_OPTS_ARR <<< "$(echo $GRADLE_OPTS | xargs -n1)"
exec "$JAVACMD" "$@"
exec "$JAVACMD" "$@" "${JAVA_OPTS_ARR[@]}" "${GRADLE_OPTS_ARR[@]}" "-Dorg.gradle.appname=$APP_BASE_NAME" -classpath "$CLASSPATH" org.gradle.wrapper.GradleWrapperMain "${ARGV[@]}"

21
gradlew.bat vendored
View File

@@ -40,7 +40,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome
set JAVA_EXE=java.exe
%JAVA_EXE% -version >NUL 2>&1
if "%ERRORLEVEL%" == "0" goto init
if "%ERRORLEVEL%" == "0" goto execute
echo.
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
@@ -54,7 +54,7 @@ goto fail
set JAVA_HOME=%JAVA_HOME:"=%
set JAVA_EXE=%JAVA_HOME%/bin/java.exe
if exist "%JAVA_EXE%" goto init
if exist "%JAVA_EXE%" goto execute
echo.
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
@@ -64,21 +64,6 @@ echo location of your Java installation.
goto fail
:init
@rem Get command-line arguments, handling Windows variants
if not "%OS%" == "Windows_NT" goto win9xME_args
:win9xME_args
@rem Slurp the command line arguments.
set CMD_LINE_ARGS=
set _SKIP=2
:win9xME_args_slurp
if "x%~1" == "x" goto execute
set CMD_LINE_ARGS=%*
:execute
@rem Setup the command line
@@ -86,7 +71,7 @@ set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
@rem Execute Gradle
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS%
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %*
:end
@rem End local scope for the variables with windows NT shell

View File

@@ -1,10 +0,0 @@
pluginManagement {
repositories {
jcenter()
maven {
name = 'Fabric'
url = 'https://maven.fabricmc.net/'
}
gradlePluginPortal()
}
}

17
settings.gradle.kts Normal file
View File

@@ -0,0 +1,17 @@
rootProject.name = "Better-Controls"
pluginManagement {
repositories {
gradlePluginPortal()
maven(url = "https://maven.fabricmc.net/") { name = "Fabric" }
maven(url = "https://repo.spongepowered.org/repository/maven-public/") { name = "Sponge Snapshots" }
}
}
if (settings.extra.has("forgeVersion")) {
include("Forge")
}
if (settings.extra.has("fabricVersion")) {
include("Fabric")
}

View File

@@ -0,0 +1,17 @@
package chylex.bettercontrols;
import chylex.bettercontrols.config.BetterControlsConfig;
public final class BetterControlsCommon {
private static BetterControlsConfig config;
public static BetterControlsConfig getConfig() {
return config;
}
static void setConfig(final BetterControlsConfig config) {
BetterControlsCommon.config = config;
}
private BetterControlsCommon() {}
}

View File

@@ -1,8 +1,8 @@
package chylex.bettercontrols.config;
import chylex.bettercontrols.input.KeyBindingWithModifier;
import chylex.bettercontrols.input.ModifierKey;
import chylex.bettercontrols.util.Key;
import com.google.gson.JsonObject;
import com.mojang.blaze3d.platform.InputConstants;
final class Json {
private Json() {}
@@ -52,7 +52,7 @@ final class Json{
private static final String MOD_SUFFIX = ".Mod";
static void writeKeyBinding(final JsonObject obj, final String key, final KeyBindingWithModifier keyBinding) {
obj.addProperty(key + KEY_SUFFIX, Key.writeBinding(keyBinding));
obj.addProperty(key + KEY_SUFFIX, keyBinding.saveString());
if (keyBinding.getModifier() != null) {
obj.addProperty(key + MOD_SUFFIX, Integer.valueOf(keyBinding.getModifier().id));
@@ -61,7 +61,11 @@ final class Json{
static void readKeyBinding(final JsonObject obj, final String key, final KeyBindingWithModifier keyBinding) {
if (obj.has(key + KEY_SUFFIX)) {
Key.readBinding(keyBinding, obj.get(key + KEY_SUFFIX).getAsString());
try {
keyBinding.setKey(InputConstants.getKey(obj.get(key + KEY_SUFFIX).getAsString()));
} catch (final IllegalArgumentException e) {
e.printStackTrace(); // let's not crash if the config file has garbage, okay?
}
}
if (obj.has(key + MOD_SUFFIX)) {

View File

@@ -1,8 +1,6 @@
package chylex.bettercontrols.gui;
import chylex.bettercontrols.BetterControlsMod;
import chylex.bettercontrols.BetterControlsCommon;
import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.gui.elements.BooleanValueWidget;
import chylex.bettercontrols.gui.elements.CycleButtonWidget;
import chylex.bettercontrols.gui.elements.DiscreteValueSliderWidget;
import chylex.bettercontrols.gui.elements.KeyBindingWidget;
import chylex.bettercontrols.gui.elements.Option;
@@ -10,30 +8,39 @@ import chylex.bettercontrols.gui.elements.TextWidget;
import chylex.bettercontrols.input.KeyBindingWithModifier;
import chylex.bettercontrols.input.ModifierKey;
import chylex.bettercontrols.input.SprintMode;
import chylex.bettercontrols.util.Key;
import chylex.bettercontrols.util.LiteralText;
import net.minecraft.client.gui.Element;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.screen.options.GameOptionsScreen;
import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.resource.language.I18n;
import net.minecraft.client.util.InputUtil;
import com.mojang.blaze3d.platform.InputConstants;
import com.mojang.blaze3d.vertex.PoseStack;
import it.unimi.dsi.fastutil.booleans.BooleanConsumer;
import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.components.Button;
import net.minecraft.client.gui.components.CycleButton;
import net.minecraft.client.gui.components.events.GuiEventListener;
import net.minecraft.client.gui.screens.OptionsSubScreen;
import net.minecraft.client.gui.screens.Screen;
import net.minecraft.network.chat.CommonComponents;
import net.minecraft.network.chat.Component;
import net.minecraft.network.chat.TextComponent;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.lwjgl.glfw.GLFW;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.function.Consumer;
import static chylex.bettercontrols.gui.OptionListWidget.COL2_W;
import static chylex.bettercontrols.gui.OptionListWidget.COL4_W;
import static chylex.bettercontrols.gui.OptionListWidget.ROW_WIDTH;
import static chylex.bettercontrols.gui.OptionListWidget.col2;
import static chylex.bettercontrols.gui.OptionListWidget.col4;
import static chylex.bettercontrols.gui.elements.TextWidget.CENTER;
import static chylex.bettercontrols.util.LiteralText.text;
import static chylex.bettercontrols.util.Statics.OPTIONS;
public class BetterControlsScreen extends GameOptionsScreen{
public static final LiteralText TITLE = text("Better Controls");
public class BetterControlsScreen extends OptionsSubScreen {
private static TextComponent text(final String text) {
return new TextComponent(text);
}
public static final Component TITLE = text("Better Controls");
private static final int BOTTOM_PADDING = 3;
private static final int TEXT_PADDING_RIGHT = 4;
@@ -48,47 +55,39 @@ public class BetterControlsScreen extends GameOptionsScreen{
// Options
private int generateSprintingOptions(int y, final List<Element> elements){
final BetterControlsConfig cfg = BetterControlsMod.config;
generateKeyBindingWithModifierOption(y, elements, text("Toggle Sprint"), cfg.keyToggleSprint);
private int generateSprintingOptions(int y, final List<GuiEventListener> elements) {
final BetterControlsConfig cfg = BetterControlsCommon.getConfig();
generateKeyBindingWithModifierRow(y, elements, text("Toggle Sprint"), cfg.keyToggleSprint);
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Sprint Key Mode"));
elements.add(new CycleButtonWidget<>(col2(1), y, COL2_W, SPRINT_MODE_OPTIONS, cfg.sprintMode, value -> cfg.sprintMode = value));
generateCycleOptionRow(y, elements, text("Sprint Key Mode"), SPRINT_MODE_OPTIONS, cfg.sprintMode, value -> cfg.sprintMode = value);
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Double Tap 'Walk Forwards' To Sprint"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.doubleTapForwardToSprint, value -> cfg.doubleTapForwardToSprint = value));
generateBooleanOptionRow(y, elements, text("Double Tap 'Walk Forwards' To Sprint"), cfg.doubleTapForwardToSprint, value -> cfg.doubleTapForwardToSprint = value);
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Resume Sprinting After Hitting Obstacle"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.resumeSprintingAfterHittingObstacle, value -> cfg.resumeSprintingAfterHittingObstacle = value));
generateBooleanOptionRow(y, elements, text("Resume Sprinting After Hitting Obstacle"), cfg.resumeSprintingAfterHittingObstacle, value -> cfg.resumeSprintingAfterHittingObstacle = value);
y += ROW_HEIGHT;
return y;
}
private int generateSneakingOptions(int y, final List<Element> elements){
final BetterControlsConfig cfg = BetterControlsMod.config;
generateKeyBindingWithModifierOption(y, elements, text("Toggle Sneak"), cfg.keyToggleSneak);
private int generateSneakingOptions(int y, final List<GuiEventListener> elements) {
final BetterControlsConfig cfg = BetterControlsCommon.getConfig();
generateKeyBindingWithModifierRow(y, elements, text("Toggle Sneak"), cfg.keyToggleSneak);
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Move Camera Smoothly"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.sneakingMovesCameraSmoothly, value -> cfg.sneakingMovesCameraSmoothly = value));
generateBooleanOptionRow(y, elements, text("Move Camera Smoothly"), cfg.sneakingMovesCameraSmoothly, value -> cfg.sneakingMovesCameraSmoothly = value);
y += ROW_HEIGHT;
return y;
}
@SuppressWarnings({ "AutoBoxing", "AutoUnboxing" })
private int generateFlightOptions(int y, final List<Element> elements){
final BetterControlsConfig cfg = BetterControlsMod.config;
private int generateFlightOptions(int y, final List<GuiEventListener> elements) {
final BetterControlsConfig cfg = BetterControlsCommon.getConfig();
final List<Option<Float>> flightSpeedOptions = Arrays.asList(
new Option<>(Float.valueOf(0.25F), text("0.25x")),
@@ -117,79 +116,64 @@ public class BetterControlsScreen extends GameOptionsScreen{
new Option<>(Float.valueOf(3.00F), text("+300%"))
);
generateKeyBindingWithModifierOption(y, elements, text("Toggle Flight (Creative)"), cfg.keyToggleFlight);
generateKeyBindingWithModifierRow(y, elements, text("Toggle Flight (Creative)"), cfg.keyToggleFlight);
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Double Tap 'Jump' To Fly (Creative)"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.doubleTapJumpToToggleFlight, value -> cfg.doubleTapJumpToToggleFlight = value));
generateBooleanOptionRow(y, elements, text("Double Tap 'Jump' To Fly (Creative)"), cfg.doubleTapJumpToToggleFlight, value -> cfg.doubleTapJumpToToggleFlight = value);
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Disable Flight Inertia"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.disableFlightInertia, value -> cfg.disableFlightInertia = value));
generateBooleanOptionRow(y, elements, text("Disable Flight Inertia"), cfg.disableFlightInertia, value -> cfg.disableFlightInertia = value);
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Disable Field Of View Changing"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.disableChangingFovWhileFlying, value -> cfg.disableChangingFovWhileFlying = value));
generateBooleanOptionRow(y, elements, text("Disable Field Of View Changing"), cfg.disableChangingFovWhileFlying, value -> cfg.disableChangingFovWhileFlying = value);
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Fly On Ground (Creative Mode)"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.flyOnGroundInCreative, value -> cfg.flyOnGroundInCreative = value));
y += ROW_HEIGHT * 4 / 3;
generateBooleanOptionRow(y, elements, text("Fly On Ground (Creative Mode)"), cfg.flyOnGroundInCreative, value -> cfg.flyOnGroundInCreative = value);
y += ROW_HEIGHT;
y += ROW_HEIGHT / 3;
elements.add(new TextWidget(col4(2), y, COL4_W - TEXT_PADDING_RIGHT, text("Creative"), CENTER));
elements.add(new TextWidget(col4(3), y, COL4_W - TEXT_PADDING_RIGHT, text("Spectator"), CENTER));
y += ROW_HEIGHT * 7 / 8;
generateLeftSideText(y, elements, text("Speed Multiplier (Default)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpCreativeDefault, value -> cfg.flightSpeedMpCreativeDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpSpectatorDefault, value -> cfg.flightSpeedMpSpectatorDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Speed Multiplier in Creative Mode"), flightSpeedOptions, cfg.flightSpeedMpCreativeDefault, value -> cfg.flightSpeedMpCreativeDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Speed Multiplier in Spectator Mode"), flightSpeedOptions, cfg.flightSpeedMpSpectatorDefault, value -> cfg.flightSpeedMpSpectatorDefault = value));
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Speed Multiplier (Sprinting)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpCreativeSprinting, value -> cfg.flightSpeedMpCreativeSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpSpectatorSprinting, value -> cfg.flightSpeedMpSpectatorSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Speed Multiplier when Sprinting in Creative Mode"), flightSpeedOptions, cfg.flightSpeedMpCreativeSprinting, value -> cfg.flightSpeedMpCreativeSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Speed Multiplier when Sprinting in Spectator Mode"), flightSpeedOptions, cfg.flightSpeedMpSpectatorSprinting, value -> cfg.flightSpeedMpSpectatorSprinting = value));
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Vertical Speed Boost (Default)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeDefault, value -> cfg.flightVerticalBoostCreativeDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorDefault, value -> cfg.flightVerticalBoostSpectatorDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Vertical Speed Boost in Creative Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeDefault, value -> cfg.flightVerticalBoostCreativeDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Vertical Speed Boost in Spectator Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorDefault, value -> cfg.flightVerticalBoostSpectatorDefault = value));
y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Vertical Speed Boost (Sprinting)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeSprinting, value -> cfg.flightVerticalBoostCreativeSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorSprinting, value -> cfg.flightVerticalBoostSpectatorSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Vertical Speed Boost when Sprinting in Creative Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeSprinting, value -> cfg.flightVerticalBoostCreativeSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Vertical Speed Boost when Sprinting in Spectator Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorSprinting, value -> cfg.flightVerticalBoostSpectatorSprinting = value));
y += ROW_HEIGHT;
return y;
}
private int generateMiscellaneousOptions(int y, final List<Element> elements){
final BetterControlsConfig cfg = BetterControlsMod.config;
generateKeyBindingWithModifierOption(y, elements, text("Toggle Walk Forwards"), cfg.keyToggleWalkForward);
private int generateMiscellaneousOptions(int y, final List<GuiEventListener> elements) {
final BetterControlsConfig cfg = BetterControlsCommon.getConfig();
generateKeyBindingWithModifierRow(y, elements, text("Toggle Walk Forwards"), cfg.keyToggleWalkForward);
y += ROW_HEIGHT;
generateKeyBindingWithModifierOption(y, elements, text("Toggle Jump"), cfg.keyToggleJump);
generateKeyBindingWithModifierRow(y, elements, text("Toggle Jump"), cfg.keyToggleJump);
y += ROW_HEIGHT;
generateKeyBindingWithModifierOption(y, elements, text("Reset All Toggles"), cfg.keyResetAllToggles);
generateKeyBindingWithModifierRow(y, elements, text("Reset All Toggles"), cfg.keyResetAllToggles);
y += ROW_HEIGHT * 4 / 3;
generateKeyBindingWithModifierOption(y, elements, text("Open Better Controls Menu"), cfg.keyOpenMenu);
generateKeyBindingWithModifierRow(y, elements, text("Open Better Controls Menu"), cfg.keyOpenMenu);
y += ROW_HEIGHT;
return y;
}
@@ -202,9 +186,9 @@ public class BetterControlsScreen extends GameOptionsScreen{
new Option<>(ModifierKey.ALT, text("Alt"))
);
private void generateKeyBindingWithModifierOption(final int y, final List<Element> elements, final LiteralText text, final KeyBindingWithModifier binding){
final CycleButtonWidget<ModifierKey> modifierButton = new CycleButtonWidget<>(col4(2), y, COL4_W, MODIFIER_OPTIONS, binding.getModifier(), binding::setModifier);
final KeyBindingWidget bindingButton = new KeyBindingWidget(col4(3), y, COL4_W, binding, this::startEditingKeyBinding);
private void generateKeyBindingWithModifierRow(final int y, final List<GuiEventListener> elements, final Component text, final KeyBindingWithModifier binding) {
final var modifierButton = Option.button(col4(2), y, COL4_W, text.plainCopy().append(" Modifier"), MODIFIER_OPTIONS, binding.getModifier(), binding::setModifier);
final var bindingButton = new KeyBindingWidget(col4(3), y, COL4_W, text, binding, this::startEditingKeyBinding);
bindingButton.linkButtonToBoundState(modifierButton);
generateLeftSideText(y, elements, text);
@@ -213,7 +197,20 @@ public class BetterControlsScreen extends GameOptionsScreen{
allKeyBindings.add(bindingButton);
}
private static void generateLeftSideText(final int y, final List<Element> elements, final LiteralText text){
private static <T> void generateCycleOptionRow(final int y, final List<GuiEventListener> elements, final Component text, final List<Option<T>> options, final T initialValue, final Consumer<T> onValueChanged) {
generateLeftSideText(y, elements, text);
elements.add(Option.button(col2(1), y, COL2_W, text, options, initialValue, onValueChanged));
}
private static void generateBooleanOptionRow(final int y, final List<GuiEventListener> elements, final Component text, final boolean initialValue, final BooleanConsumer onValueChanged) {
generateLeftSideText(y, elements, text);
elements.add(CycleButton.onOffBuilder()
.displayOnlyValue()
.withInitialValue(Boolean.valueOf(initialValue))
.create(col2(1), y, COL2_W, 20, text, (btn, newValue) -> onValueChanged.accept(newValue.booleanValue())));
}
private static void generateLeftSideText(final int y, final List<GuiEventListener> elements, final Component text) {
elements.add(new TextWidget(col2(0), y, COL2_W - TEXT_PADDING_RIGHT, text));
}
@@ -223,15 +220,15 @@ public class BetterControlsScreen extends GameOptionsScreen{
private KeyBindingWidget editingKeyBinding;
private final List<KeyBindingWidget> allKeyBindings = new ArrayList<>();
public BetterControlsScreen(final Screen parentScreen){
super(parentScreen, OPTIONS, TITLE);
public BetterControlsScreen(@Nullable final Screen parentScreen) {
super(parentScreen, Minecraft.getInstance().options, TITLE);
}
@Override
public void init() {
allKeyBindings.clear();
final List<Element> elements = new ArrayList<>();
final List<GuiEventListener> elements = new ArrayList<>();
int y = 0;
elements.add(new TextWidget(0, y, ROW_WIDTH, ROW_HEIGHT, text("Sprinting"), CENTER));
@@ -246,21 +243,21 @@ public class BetterControlsScreen extends GameOptionsScreen{
elements.add(new TextWidget(0, y, ROW_WIDTH, ROW_HEIGHT, text("Miscellaneous"), CENTER));
y = generateMiscellaneousOptions(y + ROW_HEIGHT, elements) + TITLE_MARGIN_TOP;
addButton(new ButtonWidget(width / 2 - 99, height - 29, 200, 20, I18n.translate("gui.done"), btn -> minecraft.openScreen(parent)));
children.add(optionsWidget = new OptionListWidget(21, height - 32, width, height, elements, y - TITLE_MARGIN_TOP + BOTTOM_PADDING));
addRenderableWidget(new Button(width / 2 - 99, height - 29, 200, 20, CommonComponents.GUI_DONE, btn -> minecraft.setScreen(lastScreen)));
addWidget(optionsWidget = new OptionListWidget(21, height - 32, width, height, elements, y - TITLE_MARGIN_TOP + BOTTOM_PADDING));
}
@Override
public void removed() {
BetterControlsMod.config.save();
BetterControlsCommon.getConfig().save();
}
@Override
public void render(final int mouseX, final int mouseY, final float delta){
renderBackground();
optionsWidget.render(mouseX, mouseY, delta);
drawCenteredString(font, title.asFormattedString(), width / 2, 8, (255 << 16) | (255 << 8) | 255);
super.render(mouseX, mouseY, delta);
public void render(final @NotNull PoseStack matrices, final int mouseX, final int mouseY, final float delta) {
renderBackground(matrices);
optionsWidget.render(matrices, mouseX, mouseY, delta);
drawCenteredString(matrices, font, title, width / 2, 8, (255 << 16) | (255 << 8) | 255);
super.render(matrices, mouseX, mouseY, delta);
}
private void startEditingKeyBinding(final KeyBindingWidget widget) {
@@ -274,7 +271,7 @@ public class BetterControlsScreen extends GameOptionsScreen{
@Override
public boolean mouseClicked(final double mouseX, final double mouseY, final int button) {
if (editingKeyBinding != null) {
editingKeyBinding.bindAndStopEditing(Key.inputFromMouse(button));
editingKeyBinding.bindAndStopEditing(InputConstants.Type.MOUSE.getOrCreate(button));
onKeyBindingEditingFinished();
return true;
}
@@ -287,10 +284,10 @@ public class BetterControlsScreen extends GameOptionsScreen{
public boolean keyPressed(final int keyCode, final int scanCode, final int modifiers) {
if (editingKeyBinding != null) {
if (keyCode == GLFW.GLFW_KEY_ESCAPE) {
editingKeyBinding.bindAndStopEditing(Key.INVALID);
editingKeyBinding.bindAndStopEditing(InputConstants.UNKNOWN);
}
else {
editingKeyBinding.bindAndStopEditing(Key.inputFromKeyboard(keyCode, scanCode));
editingKeyBinding.bindAndStopEditing(InputConstants.getKey(keyCode, scanCode));
}
onKeyBindingEditingFinished();
@@ -303,7 +300,7 @@ public class BetterControlsScreen extends GameOptionsScreen{
private void onKeyBindingEditingFinished() {
editingKeyBinding = null;
KeyBinding.updateKeysByCode();
KeyMapping.resetMapping();
for (final KeyBindingWidget widget : allKeyBindings) {
widget.updateKeyBindingText();

View File

@@ -1,18 +1,21 @@
package chylex.bettercontrols.gui;
import chylex.bettercontrols.gui.OptionListWidget.Entry;
import net.minecraft.client.gui.Drawable;
import net.minecraft.client.gui.Element;
import net.minecraft.client.gui.widget.AbstractButtonWidget;
import net.minecraft.client.gui.widget.ElementListWidget;
import com.mojang.blaze3d.vertex.PoseStack;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.components.AbstractWidget;
import net.minecraft.client.gui.components.ContainerObjectSelectionList;
import net.minecraft.client.gui.components.Widget;
import net.minecraft.client.gui.components.events.GuiEventListener;
import net.minecraft.client.gui.narration.NarratableEntry;
import org.jetbrains.annotations.NotNull;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.function.Function;
import java.util.stream.Collectors;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
public final class OptionListWidget extends ElementListWidget<Entry>{
public final class OptionListWidget extends ContainerObjectSelectionList<Entry> {
public static final int ROW_WIDTH = 408;
public static final int ROW_PADDING = 2;
@@ -27,42 +30,34 @@ public final class OptionListWidget extends ElementListWidget<Entry>{
return (column * ROW_WIDTH) / 4;
}
private static Offset getElementOffset(final Element element){
if (element instanceof Widget){
return new Offset(((Widget)element).getX(), ((Widget)element).getY());
private static Offset getElementOffset(final GuiEventListener element) {
if (element instanceof final OptionWidget widget) {
return new Offset(widget.getX(), widget.getY());
}
else if (element instanceof AbstractButtonWidget){
return new Offset(((AbstractButtonWidget)element).x, ((AbstractButtonWidget)element).y);
else if (element instanceof final AbstractWidget widget) {
return new Offset(widget.x, widget.y);
}
else {
return new Offset(0, 0);
}
}
public interface Widget extends Element, Drawable{
public interface OptionWidget extends GuiEventListener, Widget {
int getX();
int getY();
void setX(int x);
void setY(int y);
}
private static final class Offset{
public final int x;
public final int y;
private record Offset(int x, int y) {}
private Offset(final int x, final int y){
this.x = x;
this.y = y;
}
}
public OptionListWidget(final int top, final int bottom, final int width, final int height, final List<Element> widgets, final int innerHeight){
super(MINECRAFT, width, height, top, bottom, innerHeight);
public OptionListWidget(final int top, final int bottom, final int width, final int height, final List<GuiEventListener> widgets, final int innerHeight) {
super(Minecraft.getInstance(), width, height, top, bottom, innerHeight);
addEntry(new Entry(widgets));
}
@Override
protected int getRowLeft(){
public int getRowLeft() {
return super.getRowLeft() - ROW_PADDING;
}
@@ -76,38 +71,43 @@ public final class OptionListWidget extends ElementListWidget<Entry>{
return (width + ROW_WIDTH) / 2 + 4;
}
protected static final class Entry extends ElementListWidget.Entry<Entry>{
private final List<Element> elements;
private final Map<Element, Offset> offsets;
protected static final class Entry extends ContainerObjectSelectionList.Entry<Entry> {
private final List<GuiEventListener> elements;
private final List<NarratableEntry> narratables;
private final Map<GuiEventListener, Offset> offsets;
public Entry(final List<Element> elements){
public Entry(final List<GuiEventListener> elements) {
this.elements = new ArrayList<>(elements);
this.narratables = elements.stream().filter(e -> e instanceof NarratableEntry).map(e -> (NarratableEntry)e).collect(Collectors.toList());
this.offsets = elements.stream().collect(Collectors.toMap(Function.identity(), OptionListWidget::getElementOffset));
}
@Override
public List<? extends Element> children(){
public @NotNull List<? extends GuiEventListener> children() {
return Collections.unmodifiableList(elements);
}
@Override
public void render(final int index, final int y, final int x, final int entryWidth, final int entryHeight, final int mouseX, final int mouseY, final boolean hovered, final float tickDelta){
for(final Element element : elements){
public @NotNull List<? extends NarratableEntry> narratables() {
return Collections.unmodifiableList(narratables);
}
@Override
public void render(final @NotNull PoseStack matrices, final int index, final int y, final int x, final int entryWidth, final int entryHeight, final int mouseX, final int mouseY, final boolean hovered, final float tickDelta) {
for (final GuiEventListener element : elements) {
final Offset offset = offsets.get(element);
if (element instanceof AbstractButtonWidget){
final AbstractButtonWidget button = (AbstractButtonWidget)element;
button.x = x + offset.x;
button.y = y + offset.y;
if (element instanceof final AbstractWidget widget) {
widget.x = x + offset.x;
widget.y = y + offset.y;
}
else if (element instanceof Widget){
final Widget widget = (Widget)element;
else if (element instanceof final OptionWidget widget) {
widget.setX(x + offset.x);
widget.setY(y + offset.y);
}
if (element instanceof Drawable){
((Drawable)element).render(mouseX, mouseY, tickDelta);
if (element instanceof final Widget widget) {
widget.render(matrices, mouseX, mouseY, tickDelta);
}
}
}

View File

@@ -1,63 +0,0 @@
package chylex.bettercontrols.gui;
import chylex.bettercontrols.mixin.AccessOptionButtonWidgetOption;
import chylex.bettercontrols.mixin.AccessScreenButtons;
import net.minecraft.client.gui.Element;
import net.minecraft.client.gui.ParentElement;
import net.minecraft.client.gui.screen.options.AccessibilityScreen;
import net.minecraft.client.gui.screen.options.ControlsOptionsScreen;
import net.minecraft.client.gui.widget.AbstractButtonWidget;
import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.gui.widget.OptionButtonWidget;
import net.minecraft.client.options.Option;
import java.util.List;
import java.util.function.Consumer;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
public final class ScreenPatcher{
private ScreenPatcher(){}
public static void onControlsScreenOpened(final ControlsOptionsScreen screen){
final AccessScreenButtons accessor = (AccessScreenButtons)screen;
final List<? extends Element> children = screen.children();
final List<AbstractButtonWidget> buttons = accessor.getButtons();
final AbstractButtonWidget autoJump = buttons
.stream()
.filter(it -> it instanceof OptionButtonWidget && ((AccessOptionButtonWidgetOption)it).getOption() == Option.AUTO_JUMP)
.findAny()
.orElse(null);
if (autoJump != null){
children.remove(autoJump);
buttons.remove(autoJump);
accessor.callAddButton(new ButtonWidget(autoJump.x, autoJump.y, autoJump.getWidth(), 20, BetterControlsScreen.TITLE.copy().append("...").asFormattedString(), btn -> {
MINECRAFT.openScreen(new BetterControlsScreen(screen));
}));
}
}
public static void onAccessibilityScreenOpened(final AccessibilityScreen screen){
walkChildren(screen.children(), it -> {
if (it instanceof OptionButtonWidget){
final OptionButtonWidget button = (OptionButtonWidget)it;
final Option option = ((AccessOptionButtonWidgetOption)button).getOption();
if (option == Option.SPRINT_TOGGLED || option == Option.SNEAK_TOGGLED){
button.active = false;
}
}
});
}
private static void walkChildren(final List<? extends Element> elements, final Consumer<Element> callback){
for(final Element element : elements){
callback.accept(element);
if (element instanceof ParentElement){
walkChildren(((ParentElement)element).children(), callback);
}
}
}
}

View File

@@ -1,27 +0,0 @@
package chylex.bettercontrols.gui.elements;
import it.unimi.dsi.fastutil.booleans.BooleanConsumer;
import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.resource.language.I18n;
public final class BooleanValueWidget extends ButtonWidget{
private final BooleanConsumer onChanged;
private boolean value;
public BooleanValueWidget(final int x, final int y, final int width, final int height, final boolean currentValue, final BooleanConsumer onChanged){
super(x, y, width, height, I18n.translate(currentValue ? "options.on" : "options.off"), ignore -> {});
this.value = currentValue;
this.onChanged = onChanged;
}
public BooleanValueWidget(final int x, final int y, final int width, final boolean currentValue, final BooleanConsumer onChanged){
this(x, y, width, 20, currentValue, onChanged);
}
@Override
public void onPress(){
super.onPress();
value = !value;
setMessage(I18n.translate(value ? "options.on" : "options.off"));
onChanged.accept(value);
}
}

View File

@@ -1,36 +0,0 @@
package chylex.bettercontrols.gui.elements;
import net.minecraft.client.gui.widget.ButtonWidget;
import java.util.List;
import java.util.function.Consumer;
public class CycleButtonWidget<T> extends ButtonWidget{
private final List<Option<T>> options;
private final Consumer<T> onChanged;
private T selectedValue;
public CycleButtonWidget(final int x, final int y, final int width, final int height, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged){
super(x, y, width, height, Option.find(options, selectedValue).getText().asFormattedString(), btn -> {});
this.options = options;
this.selectedValue = selectedValue;
this.onChanged = onChanged;
}
public CycleButtonWidget(final int x, final int y, final int width, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged){
this(x, y, width, 20, options, selectedValue, onChanged);
}
@Override
public void onPress(){
int nextIndex = options.indexOf(Option.find(options, selectedValue)) + 1;
if (nextIndex >= options.size()){
nextIndex = 0;
}
final Option<T> newSelectedOption = options.get(nextIndex);
selectedValue = newSelectedOption.getValue();
onChanged.accept(selectedValue);
setMessage(newSelectedOption.getText().asFormattedString());
}
}

View File

@@ -1,42 +1,52 @@
package chylex.bettercontrols.gui.elements;
import net.minecraft.client.gui.widget.SliderWidget;
import net.minecraft.util.math.MathHelper;
import net.minecraft.client.gui.components.AbstractSliderButton;
import net.minecraft.network.chat.Component;
import net.minecraft.network.chat.MutableComponent;
import net.minecraft.network.chat.TranslatableComponent;
import net.minecraft.util.Mth;
import org.jetbrains.annotations.NotNull;
import java.util.List;
import java.util.function.Consumer;
public final class DiscreteValueSliderWidget<T> extends SliderWidget{
public final class DiscreteValueSliderWidget<T> extends AbstractSliderButton {
private final Component narration;
private final List<Option<T>> options;
private final Consumer<T> onChanged;
private T selectedValue;
public DiscreteValueSliderWidget(final int x, final int y, final int width, final int height, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged){
super(x, y, width, height, options.indexOf(Option.find(options, selectedValue)) / (options.size() - 1.0));
public DiscreteValueSliderWidget(final int x, final int y, final int width, final int height, final Component narration, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) {
super(x, y, width, height, Option.find(options, selectedValue).text(), options.indexOf(Option.find(options, selectedValue)) / (options.size() - 1.0));
this.narration = narration;
this.options = options;
this.selectedValue = selectedValue;
this.onChanged = onChanged;
updateMessage();
}
public DiscreteValueSliderWidget(final int x, final int y, final int width, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged){
this(x, y, width, 20, options, selectedValue, onChanged);
public DiscreteValueSliderWidget(final int x, final int y, final int width, final Component narration, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) {
this(x, y, width, 20, narration, options, selectedValue, onChanged);
}
public Option<T> getSelectedOption() {
return options.get(MathHelper.floor(MathHelper.clampedLerp(0.0, options.size() - 1.0, value)));
return options.get(Mth.floor(Mth.clampedLerp(0.0, options.size() - 1.0, value)));
}
@Override
protected void updateMessage() {
setMessage(getSelectedOption().getText().asFormattedString());
setMessage(getSelectedOption().text());
}
@Override
protected void applyValue() {
final T newSelectedValue = getSelectedOption().getValue();
final T newSelectedValue = getSelectedOption().value();
if (selectedValue != newSelectedValue) {
selectedValue = newSelectedValue;
onChanged.accept(newSelectedValue);
}
}
@Override
protected @NotNull MutableComponent createNarrationMessage() {
return new TranslatableComponent("gui.narrate.slider", narration.plainCopy().append(" ").append(getMessage()));
}
}

View File

@@ -1,45 +1,48 @@
package chylex.bettercontrols.gui.elements;
import chylex.bettercontrols.util.Key;
import net.minecraft.client.gui.widget.AbstractButtonWidget;
import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.resource.language.I18n;
import net.minecraft.client.util.InputUtil;
import net.minecraft.util.Formatting;
import com.mojang.blaze3d.platform.InputConstants;
import net.minecraft.ChatFormatting;
import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.components.AbstractButton;
import net.minecraft.client.gui.components.Button;
import net.minecraft.network.chat.Component;
import net.minecraft.network.chat.MutableComponent;
import net.minecraft.network.chat.TextComponent;
import net.minecraft.network.chat.TranslatableComponent;
import org.jetbrains.annotations.NotNull;
import java.util.ArrayList;
import java.util.List;
import java.util.function.Consumer;
import static chylex.bettercontrols.util.Statics.OPTIONS;
public final class KeyBindingWidget extends ButtonWidget{
private final KeyBinding binding;
private final String bindingName;
public final class KeyBindingWidget extends Button {
private final KeyMapping binding;
private final Component bindingName;
private final List<AbstractButtonWidget> linkedButtons = new ArrayList<>(1);
private final List<AbstractButton> linkedButtons = new ArrayList<>(1);
private final Consumer<KeyBindingWidget> onEditingStarted;
private boolean isEditing;
public KeyBindingWidget(final int x, final int y, final int width, final int height, final KeyBinding binding, final Consumer<KeyBindingWidget> onEditingStarted){
super(x, y, width, height, "", btn -> {});
public KeyBindingWidget(final int x, final int y, final int width, final int height, final Component bindingName, final KeyMapping binding, final Consumer<KeyBindingWidget> onEditingStarted) {
super(x, y, width, height, TextComponent.EMPTY, btn -> {});
this.binding = binding;
this.bindingName = I18n.translate(binding.getId());
this.bindingName = bindingName;
this.onEditingStarted = onEditingStarted;
updateKeyBindingText();
}
public KeyBindingWidget(final int x, final int y, final int width, final KeyBinding binding, final Consumer<KeyBindingWidget> onEditingStarted){
this(x, y, width, 20, binding, onEditingStarted);
public KeyBindingWidget(final int x, final int y, final int width, final Component bindingName, final KeyMapping binding, final Consumer<KeyBindingWidget> onEditingStarted) {
this(x, y, width, 20, bindingName, binding, onEditingStarted);
}
public void linkButtonToBoundState(final AbstractButtonWidget button){
public void linkButtonToBoundState(final AbstractButton button) {
linkedButtons.add(button);
button.active = !Key.isUnbound(binding);
button.active = !binding.isUnbound();
}
@Override
protected String getNarrationMessage(){
return Key.isUnbound(binding) ? I18n.translate("narrator.controls.unbound", bindingName) : I18n.translate("narrator.controls.bound", bindingName, super.getNarrationMessage());
protected @NotNull MutableComponent createNarrationMessage() {
return binding.isUnbound() ? new TranslatableComponent("narrator.controls.unbound", bindingName) : new TranslatableComponent("narrator.controls.bound", bindingName, super.createNarrationMessage());
}
@Override
@@ -49,12 +52,12 @@ public final class KeyBindingWidget extends ButtonWidget{
updateKeyBindingText();
}
public void bindAndStopEditing(final InputUtil.KeyCode key){
Key.bind(binding, key);
public void bindAndStopEditing(final InputConstants.Key key) {
binding.setKey(key);
stopEditing();
for(final AbstractButtonWidget button : linkedButtons){
button.active = !Key.isUnbound(binding);
for (final AbstractButton button : linkedButtons) {
button.active = !binding.isUnbound();
}
}
@@ -66,9 +69,9 @@ public final class KeyBindingWidget extends ButtonWidget{
public void updateKeyBindingText() {
boolean hasConflict = false;
if (!Key.isUnbound(binding)){
for(final KeyBinding other : OPTIONS.keysAll){
if (binding != other && binding.equals(other)){
if (!binding.isUnbound()) {
for (final KeyMapping other : Minecraft.getInstance().options.keyMappings) {
if (binding != other && binding.same(other)) {
hasConflict = true;
break;
}
@@ -76,13 +79,13 @@ public final class KeyBindingWidget extends ButtonWidget{
}
if (isEditing) {
setMessage(Formatting.WHITE + "> " + Formatting.YELLOW + binding.getLocalizedName() + Formatting.WHITE + " <");
setMessage((new TextComponent("> ")).append(binding.getTranslatedKeyMessage().copy().withStyle(ChatFormatting.YELLOW)).append(" <").withStyle(ChatFormatting.YELLOW));
}
else if (hasConflict) {
setMessage(Formatting.RED + Key.getBoundKeyText(binding));
setMessage(binding.getTranslatedKeyMessage().copy().withStyle(ChatFormatting.RED));
}
else {
setMessage(Key.isUnbound(binding) ? "(No Binding)" : Key.getBoundKeyText(binding));
setMessage(binding.isUnbound() ? new TextComponent("(No Binding)") : binding.getTranslatedKeyMessage());
}
}
}

View File

@@ -1,26 +1,20 @@
package chylex.bettercontrols.gui.elements;
import chylex.bettercontrols.util.LiteralText;
import net.minecraft.client.gui.components.CycleButton;
import net.minecraft.network.chat.Component;
import java.util.List;
import java.util.Objects;
import java.util.function.Consumer;
public final class Option<T>{
private final T value;
private final LiteralText text;
public Option(final T value, final LiteralText text){
this.value = value;
this.text = text;
}
public T getValue(){
return value;
}
public LiteralText getText(){
return text;
}
public record Option<T>(T value, Component text) {
public static <T> Option<T> find(final List<Option<T>> options, final T value) {
return options.stream().filter(it -> Objects.equals(it.value, value)).findFirst().orElseGet(() -> options.get(0));
}
public static <T> CycleButton<Option<T>> button(final int x, final int y, final int width, final Component text, final List<Option<T>> options, final T initialValue, final Consumer<T> onValueChanged) {
return CycleButton.<Option<T>>builder(Option::text)
.displayOnlyValue()
.withValues(options)
.withInitialValue(find(options, initialValue))
.create(x, y, width, 20, text, (btn, newValue) -> onValueChanged.accept(newValue.value()));
}
}

View File

@@ -1,23 +1,26 @@
package chylex.bettercontrols.gui.elements;
import chylex.bettercontrols.gui.OptionListWidget.Widget;
import chylex.bettercontrols.util.LiteralText;
import net.minecraft.client.MinecraftClient;
import net.minecraft.client.font.TextRenderer;
import net.minecraft.client.gui.DrawableHelper;
import chylex.bettercontrols.gui.OptionListWidget.OptionWidget;
import com.mojang.blaze3d.vertex.PoseStack;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.Font;
import net.minecraft.client.gui.GuiComponent;
import net.minecraft.network.chat.Component;
import net.minecraft.util.FormattedCharSequence;
import org.jetbrains.annotations.NotNull;
import java.util.List;
public final class TextWidget extends DrawableHelper implements Widget{
public final class TextWidget extends GuiComponent implements OptionWidget {
public static final int LEFT = 0;
public static final int CENTER = 1;
private final LiteralText text;
private final Component text;
private int x;
private int y;
private final int width;
private final int height;
private final int align;
public TextWidget(final int x, final int y, final int width, final int height, final LiteralText text, final int align){
public TextWidget(final int x, final int y, final int width, final int height, final Component text, final int align) {
this.x = x;
this.y = y;
this.width = width;
@@ -26,11 +29,11 @@ public final class TextWidget extends DrawableHelper implements Widget{
this.align = align;
}
public TextWidget(final int x, final int y, final int width, final LiteralText text, final int align){
public TextWidget(final int x, final int y, final int width, final Component text, final int align) {
this(x, y, width, 20, text, align);
}
public TextWidget(final int x, final int y, final int width, final LiteralText text){
public TextWidget(final int x, final int y, final int width, final Component text) {
this(x, y, width, 20, text, LEFT);
}
@@ -55,17 +58,17 @@ public final class TextWidget extends DrawableHelper implements Widget{
}
@Override
public void render(final int mouseX, final int mouseY, final float delta){
final TextRenderer textRenderer = MinecraftClient.getInstance().textRenderer;
final List<String> lines = textRenderer.wrapStringToWidthAsList(text.asFormattedString(), width);
final int lineHeight = textRenderer.fontHeight + 1;
public void render(final @NotNull PoseStack matrices, final int mouseX, final int mouseY, final float delta) {
final Font textRenderer = Minecraft.getInstance().font;
final List<FormattedCharSequence> lines = textRenderer.split(text, width);
final int lineHeight = textRenderer.lineHeight + 1;
final int finalX = align == CENTER ? x + (width / 2) - (lines.stream().mapToInt(textRenderer::getStringWidth).max().orElse(0) / 2) : x;
final int finalX = align == CENTER ? x + (width / 2) - (lines.stream().mapToInt(textRenderer::width).max().orElse(0) / 2) : x;
final int finalY = y + (height / 2) - (lineHeight * lines.size() / 2) + 1;
for (int i = 0; i < lines.size(); i++) {
final String line = lines.get(i);
textRenderer.drawWithShadow(line, finalX, finalY + (i * lineHeight), (255 << 16) | (255 << 8) | 255);
final FormattedCharSequence line = lines.get(i);
textRenderer.drawShadow(matrices, line, finalX, finalY + (i * lineHeight), (255 << 16) | (255 << 8) | 255);
}
}
}

View File

@@ -1,16 +1,11 @@
package chylex.bettercontrols.input;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.resource.language.I18n;
import net.minecraft.client.util.InputUtil.Type;
import com.mojang.blaze3d.platform.InputConstants.Type;
import net.minecraft.client.KeyMapping;
import org.jetbrains.annotations.Nullable;
public class KeyBindingWithModifier extends KeyBinding{
public class KeyBindingWithModifier extends KeyMapping {
public static final String CATEGORY = "key.categories.bettercontrols";
public static boolean checkCategoryMatches(final String name){
return I18n.translate(CATEGORY).equals(name);
}
@Nullable
private ModifierKey modifier = null;
@@ -28,12 +23,12 @@ public class KeyBindingWithModifier extends KeyBinding{
}
@Override
public boolean isPressed(){
return super.isPressed() && (modifier == null || modifier.isPressed());
public boolean isDown() {
return super.isDown() && (modifier == null || modifier.isPressed());
}
@Override
public boolean wasPressed(){
return super.wasPressed() && (modifier == null || modifier.isPressed());
public boolean consumeClick() {
return super.consumeClick() && (modifier == null || modifier.isPressed());
}
}

View File

@@ -1,5 +1,5 @@
package chylex.bettercontrols.input;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.screens.Screen;
public enum ModifierKey {
CONTROL(0) {
@@ -32,11 +32,11 @@ public enum ModifierKey{
public abstract boolean isPressed();
public static ModifierKey getById(final int id) {
switch(id){
case 0: return CONTROL;
case 1: return SHIFT;
case 2: return ALT;
default: return null;
}
return switch (id) {
case 0 -> CONTROL;
case 1 -> SHIFT;
case 2 -> ALT;
default -> null;
};
}
}

View File

@@ -1,10 +1,9 @@
package chylex.bettercontrols.input;
import chylex.bettercontrols.util.Key;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.KeyMapping;
public class ToggleTracker {
protected final KeyBinding bindingToggle;
protected final KeyBinding bindingReset;
protected final KeyMapping bindingToggle;
protected final KeyMapping bindingReset;
protected boolean isToggled;
@@ -12,7 +11,7 @@ public class ToggleTracker{
private boolean hasToggledWhileHoldingReset;
private boolean skipNextToggle;
public ToggleTracker(final KeyBinding bindingToggle, final KeyBinding bindingReset){
public ToggleTracker(final KeyMapping bindingToggle, final KeyMapping bindingReset) {
this.bindingToggle = bindingToggle;
this.bindingReset = bindingReset;
}
@@ -44,7 +43,7 @@ public class ToggleTracker{
public boolean tick() {
final boolean isHoldingReset = isResetKeyPressed();
if (Key.isPressed(bindingToggle)){
if (bindingToggle.isDown()) {
if (!waitForRelease) {
if (skipNextToggle) {
skipNextToggle = false;
@@ -79,7 +78,7 @@ public class ToggleTracker{
}
protected boolean isResetKeyPressed() {
return Key.isPressed(bindingReset);
return bindingReset.isDown();
}
public void reset() {

View File

@@ -1,20 +1,20 @@
package chylex.bettercontrols.input;
import chylex.bettercontrols.mixin.AccessKeyBindingFields;
import it.unimi.dsi.fastutil.booleans.BooleanConsumer;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.KeyMapping;
import java.util.HashSet;
import java.util.Set;
public final class ToggleTrackerForStickyKey extends ToggleTracker {
private static final Set<KeyBinding> enabledOverrides = new HashSet<>();
private static final Set<KeyMapping> enabledOverrides = new HashSet<>();
public static boolean isOverrideEnabled(final KeyBinding binding){
public static boolean isOverrideEnabled(final KeyMapping binding) {
return enabledOverrides.contains(binding);
}
private final BooleanConsumer setToggleState;
public ToggleTrackerForStickyKey(final KeyBinding bindingToggle, final KeyBinding bindingStickyReset, final BooleanConsumer setToggleState){
public ToggleTrackerForStickyKey(final KeyMapping bindingToggle, final KeyMapping bindingStickyReset, final BooleanConsumer setToggleState) {
super(bindingToggle, bindingStickyReset);
this.setToggleState = setToggleState;
this.setToggleState.accept(false);

View File

@@ -1,14 +1,10 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.render.Camera;
import net.minecraft.entity.Entity;
import net.minecraft.client.Camera;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(Camera.class)
public interface AccessCameraFields {
@Accessor
Entity getFocusedEntity();
@Accessor
void setCameraY(float y);
void setEyeHeight(float y);
}

View File

@@ -1,10 +1,10 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.network.ClientPlayerEntity;
import net.minecraft.client.player.LocalPlayer;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(ClientPlayerEntity.class)
@Mixin(LocalPlayer.class)
public interface AccessClientPlayerFields {
@Accessor("field_3935")
void setTicksLeftToDoubleTapSprint(int value);
@Accessor
void setSprintTriggerTime(int value);
}

View File

@@ -1,10 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.screen.options.ControlsListWidget.CategoryEntry;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(CategoryEntry.class)
public interface AccessControlsListCategory{
@Accessor
String getName();
}

View File

@@ -1,11 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.screen.options.ControlsListWidget.KeyBindingEntry;
import net.minecraft.client.options.KeyBinding;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(KeyBindingEntry.class)
public interface AccessControlsListKeyBinding{
@Accessor
KeyBinding getBinding();
}

View File

@@ -1,10 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.render.GameRenderer;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(GameRenderer.class)
public interface AccessGameRendererFields{
@Accessor
void setMovementFovMultiplier(float value);
}

View File

@@ -1,19 +1,19 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.KeyMapping;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
import java.util.Map;
@Mixin(KeyBinding.class)
@Mixin(KeyMapping.class)
public interface AccessKeyBindingFields {
@Accessor
@Accessor("CATEGORY_SORT_ORDER")
static Map<String, Integer> getCategoryOrderMap() {
throw new AssertionError();
}
@Accessor("pressed")
@Accessor("isDown")
boolean isPressedField();
@Accessor("pressed")
@Accessor("isDown")
void setPressedField(boolean value);
}

View File

@@ -1,11 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.widget.OptionButtonWidget;
import net.minecraft.client.options.Option;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(OptionButtonWidget.class)
public interface AccessOptionButtonWidgetOption{
@Accessor
Option getOption();
}

View File

@@ -1,10 +1,10 @@
package chylex.bettercontrols.mixin;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.world.entity.player.Player;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(PlayerEntity.class)
@Mixin(Player.class)
public interface AccessPlayerFields {
@Accessor("field_7489")
void setTicksLeftToDoubleTapFlight(int value);
@Accessor
void setJumpTriggerTime(int value);
}

View File

@@ -1,16 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.widget.AbstractButtonWidget;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
import org.spongepowered.asm.mixin.gen.Invoker;
import java.util.List;
@Mixin(Screen.class)
public interface AccessScreenButtons{
@Accessor
List<AbstractButtonWidget> getButtons();
@Invoker
<T extends AbstractButtonWidget> T callAddButton(T button);
}

View File

@@ -1,16 +1,16 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.options.StickyKeyBinding;
import net.minecraft.client.ToggleKeyMapping;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Mutable;
import org.spongepowered.asm.mixin.gen.Accessor;
import java.util.function.BooleanSupplier;
@Mixin(StickyKeyBinding.class)
@Mixin(ToggleKeyMapping.class)
public interface AccessStickyKeyBindingStateGetter {
@Accessor
BooleanSupplier getToggleGetter();
BooleanSupplier getNeedsToggle();
@Accessor
@Mutable
void setToggleGetter(final BooleanSupplier toggleGetter);
void setNeedsToggle(final BooleanSupplier toggleGetter);
}

View File

@@ -0,0 +1,26 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.player.PlayerTicker;
import net.minecraft.client.Minecraft;
import net.minecraft.client.player.AbstractClientPlayer;
import net.minecraft.client.player.LocalPlayer;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect;
import org.spongepowered.asm.mixin.injection.Slice;
@Mixin(AbstractClientPlayer.class)
public abstract class HookClientPlayerFOV {
@Redirect(
method = "getFieldOfViewModifier",
at = @At(value = "INVOKE", target = "Ljava/lang/Float;isNaN(F)Z"),
slice = @Slice(
from = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/player/Abilities;getWalkingSpeed()F"),
to = @At(value = "INVOKE", target = "Ljava/lang/Float;isInfinite(F)Z")
)
)
private boolean resetFOV(final float movementSpeed) {
final LocalPlayer player = Minecraft.getInstance().player;
return (player != null && PlayerTicker.get(player).shouldResetFOV(player)) || Float.isNaN(movementSpeed);
}
}

View File

@@ -1,20 +1,22 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.player.PlayerTicker;
import net.minecraft.client.input.KeyboardInput;
import net.minecraft.client.network.ClientPlayerEntity;
import net.minecraft.client.Minecraft;
import net.minecraft.client.player.Input;
import net.minecraft.client.player.KeyboardInput;
import net.minecraft.client.player.LocalPlayer;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
import static org.spongepowered.asm.mixin.injection.At.Shift.AFTER;
@Mixin(KeyboardInput.class)
public abstract class HookClientPlayerInputTick {
@Inject(method = "tick(Z)V", at = @At(value = "FIELD", target = "Lnet/minecraft/client/input/KeyboardInput;pressingForward:Z", ordinal = 0, shift = AFTER))
@Inject(method = "tick(Z)V", at = @At(value = "FIELD", target = "Lnet/minecraft/client/player/KeyboardInput;up:Z", ordinal = 0, shift = AFTER))
private void afterInputTick(final CallbackInfo info) {
final KeyboardInput input = (KeyboardInput)(Object)this;
final ClientPlayerEntity player = MINECRAFT.player;
@SuppressWarnings("ConstantConditions")
final Input input = (Input)(Object)this;
final LocalPlayer player = Minecraft.getInstance().player;
if (player != null) {
PlayerTicker.get(player).afterInputAssignsPressingForward(input);

View File

@@ -1,36 +1,39 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.player.PlayerTicker;
import com.mojang.authlib.GameProfile;
import net.minecraft.client.network.AbstractClientPlayerEntity;
import net.minecraft.client.network.ClientPlayerEntity;
import net.minecraft.client.world.ClientWorld;
import net.minecraft.client.multiplayer.ClientLevel;
import net.minecraft.client.player.AbstractClientPlayer;
import net.minecraft.client.player.LocalPlayer;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import static org.spongepowered.asm.mixin.injection.At.Shift.AFTER;
@Mixin(ClientPlayerEntity.class)
public abstract class HookClientPlayerTick extends AbstractClientPlayerEntity{
protected HookClientPlayerTick(final ClientWorld world, final GameProfile profile){
@Mixin(LocalPlayer.class)
public abstract class HookClientPlayerTick extends AbstractClientPlayer {
protected HookClientPlayerTick(final ClientLevel world, final GameProfile profile) {
super(world, profile);
}
@Inject(method = "tickMovement()V", at = @At("HEAD"))
@Inject(method = "aiStep()V", at = @At("HEAD"))
private void atHead(final CallbackInfo info) {
final ClientPlayerEntity player = (ClientPlayerEntity)(Object)this;
@SuppressWarnings("ConstantConditions")
final LocalPlayer player = (LocalPlayer)(Object)this;
PlayerTicker.get(player).atHead(player);
}
@Inject(method = "tickMovement()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/input/Input;tick(Z)V", ordinal = 0, shift = AFTER))
@Inject(method = "aiStep()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/Input;tick(Z)V", ordinal = 0, shift = AFTER))
private void afterInputTick(final CallbackInfo info) {
final ClientPlayerEntity player = (ClientPlayerEntity)(Object)this;
@SuppressWarnings("ConstantConditions")
final LocalPlayer player = (LocalPlayer)(Object)this;
PlayerTicker.get(player).afterInputTick(player);
}
@Inject(method = "tickMovement()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/network/AbstractClientPlayerEntity;tickMovement()V", ordinal = 0, shift = AFTER))
@Inject(method = "aiStep()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/AbstractClientPlayer;aiStep()V", ordinal = 0, shift = AFTER))
private void afterSuperCall(final CallbackInfo info) {
final ClientPlayerEntity player = (ClientPlayerEntity)(Object)this;
@SuppressWarnings("ConstantConditions")
final LocalPlayer player = (LocalPlayer)(Object)this;
PlayerTicker.get(player).afterSuperCall(player);
}
}

View File

@@ -1,37 +1,24 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.BetterControlsMod;
import chylex.bettercontrols.input.KeyBindingWithModifier;
import net.minecraft.client.MinecraftClient;
import net.minecraft.client.gui.screen.options.ControlsListWidget;
import net.minecraft.client.gui.screen.options.ControlsListWidget.CategoryEntry;
import net.minecraft.client.gui.screen.options.ControlsListWidget.Entry;
import net.minecraft.client.gui.screen.options.ControlsListWidget.KeyBindingEntry;
import net.minecraft.client.gui.screen.options.ControlsOptionsScreen;
import net.minecraft.client.gui.widget.ElementListWidget;
import chylex.bettercontrols.BetterControlsCommon;
import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft;
import net.minecraft.client.Options;
import net.minecraft.client.gui.components.ContainerObjectSelectionList;
import net.minecraft.client.gui.screens.controls.ControlList;
import net.minecraft.client.gui.screens.controls.ControlList.Entry;
import org.apache.commons.lang3.ArrayUtils;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import org.spongepowered.asm.mixin.injection.Redirect;
@Mixin(ControlsListWidget.class)
public abstract class HookControlsListWidget extends ElementListWidget<Entry>{
public HookControlsListWidget(final MinecraftClient client, final int width, final int height, final int top, final int bottom, final int itemHeight){
@Mixin(ControlList.class)
public abstract class HookControlsListWidget extends ContainerObjectSelectionList<Entry> {
public HookControlsListWidget(final Minecraft client, final int width, final int height, final int top, final int bottom, final int itemHeight) {
super(client, width, height, top, bottom, itemHeight);
}
@Inject(method = "<init>", at = @At("TAIL"))
public void init(final ControlsOptionsScreen parent, final MinecraftClient client, final CallbackInfo ci){
children().removeIf(it -> {
if (it instanceof CategoryEntry && KeyBindingWithModifier.checkCategoryMatches(((AccessControlsListCategory)it).getName())){
return true;
}
if (it instanceof KeyBindingEntry && ArrayUtils.contains(BetterControlsMod.config.getAllKeyBindings(), ((AccessControlsListKeyBinding)it).getBinding())){
return true;
}
return false;
});
@Redirect(method = "<init>", at = @At(value = "FIELD", target = "Lnet/minecraft/client/Options;keyMappings:[Lnet/minecraft/client/KeyMapping;"))
private KeyMapping[] excludeOwnKeyBindings(final Options options) {
return ArrayUtils.removeElements(options.keyMappings, BetterControlsCommon.getConfig().getAllKeyBindings());
}
}

View File

@@ -0,0 +1,28 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.gui.BetterControlsScreen;
import net.minecraft.client.CycleOption;
import net.minecraft.client.Minecraft;
import net.minecraft.client.Option;
import net.minecraft.client.Options;
import net.minecraft.client.gui.components.AbstractWidget;
import net.minecraft.client.gui.components.Button;
import net.minecraft.client.gui.screens.Screen;
import net.minecraft.client.gui.screens.controls.ControlsScreen;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect;
@Mixin(ControlsScreen.class)
public abstract class HookControlsScreen {
@Redirect(method = "init", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/CycleOption;createButton(Lnet/minecraft/client/Options;III)Lnet/minecraft/client/gui/components/AbstractWidget;"))
private AbstractWidget replaceAutoJumpButton(final CycleOption<?> option, final Options options, final int x, final int y, final int width) {
if (option == Option.AUTO_JUMP && !Screen.hasAltDown()) {
@SuppressWarnings("ConstantConditions")
final ControlsScreen screen = (ControlsScreen)(Object)this;
return new Button(x, y, width, 20, BetterControlsScreen.TITLE.plainCopy().append("..."), btn -> Minecraft.getInstance().setScreen(new BetterControlsScreen(screen)));
}
return option.createButton(options, x, y, width);
}
}

View File

@@ -1,8 +1,9 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.BetterControlsMod;
import chylex.bettercontrols.BetterControlsCommon;
import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.input.KeyBindingWithModifier;
import net.minecraft.client.options.GameOptions;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.KeyMapping;
import net.minecraft.client.Options;
import org.apache.commons.lang3.ArrayUtils;
import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Mixin;
@@ -12,14 +13,14 @@ import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
@Mixin(GameOptions.class)
@Mixin(Options.class)
public abstract class HookLoadGameOptions {
private boolean hasLoaded = false;
@Mutable
@Final
@Shadow
public KeyBinding[] keysAll;
public KeyMapping[] keyMappings;
@Inject(method = "load()V", at = @At("HEAD"))
private void load(final CallbackInfo info) {
@@ -27,8 +28,13 @@ public abstract class HookLoadGameOptions{
return;
}
final BetterControlsConfig config = BetterControlsCommon.getConfig();
if (config == null) {
return;
}
hasLoaded = true;
keysAll = ArrayUtils.addAll(keysAll, BetterControlsMod.config.getAllKeyBindings());
keyMappings = ArrayUtils.addAll(keyMappings, config.getAllKeyBindings());
AccessKeyBindingFields.getCategoryOrderMap().put(KeyBindingWithModifier.CATEGORY, Integer.valueOf(Integer.MAX_VALUE));
}
}

View File

@@ -1,28 +0,0 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.gui.ScreenPatcher;
import net.minecraft.client.MinecraftClient;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.screen.options.AccessibilityScreen;
import net.minecraft.client.gui.screen.options.ControlsOptionsScreen;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
@Mixin(value = MinecraftClient.class, priority = 100)
public abstract class HookOpenScreen{
@Inject(method = "openScreen(Lnet/minecraft/client/gui/screen/Screen;)V", at = @At("TAIL"))
private void openScreen(final Screen ignore, final CallbackInfo ci){
final Screen screen = MINECRAFT.currentScreen;
if (screen != null && !Screen.hasAltDown()){
if (screen.getClass() == ControlsOptionsScreen.class){
ScreenPatcher.onControlsScreenOpened((ControlsOptionsScreen)screen);
}
else if (screen.getClass() == AccessibilityScreen.class){
ScreenPatcher.onAccessibilityScreenOpened((AccessibilityScreen)screen);
}
}
}
}

View File

@@ -1,25 +1,26 @@
package chylex.bettercontrols.mixin;
import net.minecraft.entity.EntityType;
import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.world.World;
import net.minecraft.world.entity.EntityType;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.level.Level;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect;
import org.spongepowered.asm.mixin.injection.Slice;
@Mixin(PlayerEntity.class)
@SuppressWarnings("SameReturnValue")
@Mixin(Player.class)
public abstract class HookPlayerFlightSpeed extends LivingEntity {
protected HookPlayerFlightSpeed(final EntityType<? extends LivingEntity> type, final World world){
protected HookPlayerFlightSpeed(final EntityType<? extends LivingEntity> type, final Level world) {
super(type, world);
}
@Redirect(
method = "travel",
at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/player/PlayerEntity;isSprinting()Z"),
slice = @Slice(from = @At(value = "INVOKE", target = "Lnet/minecraft/entity/player/PlayerAbilities;getFlySpeed()F"))
at = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/player/Player;isSprinting()Z"),
slice = @Slice(from = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/player/Abilities;getFlyingSpeed()F"))
)
private boolean disableVanillaSprintBoost(final PlayerEntity player){
private boolean disableVanillaSprintBoost(final Player player) {
return false;
}
}

View File

@@ -1,7 +1,7 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.input.ToggleTrackerForStickyKey;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.options.StickyKeyBinding;
import net.minecraft.client.KeyMapping;
import net.minecraft.client.ToggleKeyMapping;
import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
@@ -10,17 +10,17 @@ import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import java.util.function.BooleanSupplier;
@Mixin(StickyKeyBinding.class)
public abstract class HookStickyKeyBindingState extends KeyBinding{
@Mixin(ToggleKeyMapping.class)
public abstract class HookStickyKeyBindingState extends KeyMapping {
@Shadow
@Final
private BooleanSupplier toggleGetter;
private BooleanSupplier needsToggle;
public HookStickyKeyBindingState(final String translationKey, final int code, final String category) {
super(translationKey, code, category);
}
@Inject(method = "setPressed(Z)V", at = @At("HEAD"), cancellable = true)
@Inject(method = "setDown", at = @At("HEAD"), cancellable = true)
public void setPressed(final boolean pressed, final CallbackInfo info) {
if (ToggleTrackerForStickyKey.isOverrideEnabled(this)) {
((AccessKeyBindingFields)this).setPressedField(pressed);
@@ -29,7 +29,7 @@ public abstract class HookStickyKeyBindingState extends KeyBinding{
}
@Override
public boolean isPressed(){
return super.isPressed() || (ToggleTrackerForStickyKey.isOverrideEnabled(this) && toggleGetter.getAsBoolean());
public boolean isDown() {
return super.isDown() || (ToggleTrackerForStickyKey.isOverrideEnabled(this) && needsToggle.getAsBoolean());
}
}

View File

@@ -0,0 +1,23 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.CycleOption;
import net.minecraft.client.Option;
import net.minecraft.client.Options;
import net.minecraft.client.gui.components.AbstractWidget;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
@Mixin(CycleOption.class)
public abstract class HookToggleOptionButtons {
@Inject(method = "createButton", at = @At("RETURN"))
private void disableToggleOptions(final Options options, final int x, final int y, final int width, final CallbackInfoReturnable<AbstractWidget> ci) {
@SuppressWarnings("ConstantConditions")
final CycleOption<?> me = (CycleOption<?>)(Object)this;
if (me == Option.TOGGLE_CROUCH || me == Option.TOGGLE_SPRINT) {
ci.getReturnValue().active = false;
}
}
}

View File

@@ -1,7 +1,7 @@
package chylex.bettercontrols.player;
import chylex.bettercontrols.BetterControlsMod;
import chylex.bettercontrols.BetterControlsCommon;
import chylex.bettercontrols.config.BetterControlsConfig;
import net.minecraft.client.network.ClientPlayerEntity;
import net.minecraft.client.player.LocalPlayer;
final class FlightHelper {
private FlightHelper() {}
@@ -10,18 +10,18 @@ final class FlightHelper{
private static final float BASE_VERTICAL_VELOCITY = 3F;
private static BetterControlsConfig cfg() {
return BetterControlsMod.config;
return BetterControlsCommon.getConfig();
}
static boolean isFlyingCreativeOrSpectator(final ClientPlayerEntity player){
return player.abilities.flying && (player.isCreative() || player.isSpectator());
static boolean isFlyingCreativeOrSpectator(final LocalPlayer player) {
return player.getAbilities().flying && (player.isCreative() || player.isSpectator());
}
static boolean shouldFlyOnGround(final ClientPlayerEntity player){
return cfg().flyOnGroundInCreative && player.isCreative() && player.abilities.flying;
static boolean shouldFlyOnGround(final LocalPlayer player) {
return cfg().flyOnGroundInCreative && player.isCreative() && player.getAbilities().flying;
}
static float getFlightSpeed(final ClientPlayerEntity player, final boolean boost){
static float getFlightSpeed(final LocalPlayer player, final boolean boost) {
if (player.isCreative()) {
if (boost) {
return BASE_FLIGHT_SPEED * cfg().flightSpeedMpCreativeSprinting;
@@ -43,7 +43,7 @@ final class FlightHelper{
}
}
static float getExtraVerticalVelocity(final ClientPlayerEntity player, final boolean isSprinting){
static float getExtraVerticalVelocity(final LocalPlayer player, final boolean isSprinting) {
if (player.isCreative()) {
if (isSprinting) {
return BASE_VERTICAL_VELOCITY * cfg().flightVerticalBoostCreativeSprinting;

View File

@@ -1,5 +1,5 @@
package chylex.bettercontrols.player;
import chylex.bettercontrols.BetterControlsMod;
import chylex.bettercontrols.BetterControlsCommon;
import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.gui.BetterControlsScreen;
import chylex.bettercontrols.input.SprintMode;
@@ -7,26 +7,29 @@ import chylex.bettercontrols.input.ToggleTracker;
import chylex.bettercontrols.input.ToggleTrackerForStickyKey;
import chylex.bettercontrols.mixin.AccessCameraFields;
import chylex.bettercontrols.mixin.AccessClientPlayerFields;
import chylex.bettercontrols.mixin.AccessGameRendererFields;
import chylex.bettercontrols.mixin.AccessPlayerFields;
import chylex.bettercontrols.mixin.AccessStickyKeyBindingStateGetter;
import chylex.bettercontrols.util.Key;
import net.minecraft.client.input.Input;
import net.minecraft.client.input.KeyboardInput;
import net.minecraft.client.network.ClientPlayerEntity;
import net.minecraft.client.Camera;
import net.minecraft.client.KeyMapping;
import net.minecraft.client.Minecraft;
import net.minecraft.client.Options;
import net.minecraft.client.player.Input;
import net.minecraft.client.player.LocalPlayer;
import java.lang.ref.WeakReference;
import java.util.function.BooleanSupplier;
import static chylex.bettercontrols.util.Statics.KEY_FORWARD;
import static chylex.bettercontrols.util.Statics.KEY_JUMP;
import static chylex.bettercontrols.util.Statics.KEY_SNEAK;
import static chylex.bettercontrols.util.Statics.KEY_SPRINT;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
import static chylex.bettercontrols.util.Statics.OPTIONS;
public final class PlayerTicker {
private static final Minecraft MINECRAFT = Minecraft.getInstance();
private static final Options OPTIONS = MINECRAFT.options;
private static final KeyMapping KEY_SPRINT = OPTIONS.keySprint;
private static final KeyMapping KEY_SNEAK = OPTIONS.keyShift;
private static final KeyMapping KEY_FORWARD = OPTIONS.keyUp;
private static final KeyMapping KEY_JUMP = OPTIONS.keyJump;
private static PlayerTicker ticker = new PlayerTicker(null);
public static PlayerTicker get(final ClientPlayerEntity player){
public static PlayerTicker get(final LocalPlayer player) {
if (ticker.ref.get() != player) {
ticker = new PlayerTicker(player);
}
@@ -35,20 +38,20 @@ public final class PlayerTicker{
}
private static BetterControlsConfig cfg() {
return BetterControlsMod.config;
return BetterControlsCommon.getConfig();
}
private final WeakReference<ClientPlayerEntity> ref;
private final WeakReference<LocalPlayer> ref;
private PlayerTicker(final ClientPlayerEntity player){
private PlayerTicker(final LocalPlayer player) {
this.ref = new WeakReference<>(player);
setup();
}
// Logic
private final ToggleTracker toggleSprint = new ToggleTrackerForStickyKey(cfg().keyToggleSprint, KEY_SPRINT, toggled -> OPTIONS.sprintToggled = toggled);
private final ToggleTracker toggleSneak = new ToggleTrackerForStickyKey(cfg().keyToggleSneak, KEY_SNEAK, toggled -> OPTIONS.sneakToggled = toggled);
private final ToggleTracker toggleSprint = new ToggleTrackerForStickyKey(cfg().keyToggleSprint, KEY_SPRINT, toggled -> OPTIONS.toggleSprint = toggled);
private final ToggleTracker toggleSneak = new ToggleTrackerForStickyKey(cfg().keyToggleSneak, KEY_SNEAK, toggled -> OPTIONS.toggleCrouch = toggled);
private final ToggleTracker toggleWalkForward = new ToggleTracker(cfg().keyToggleWalkForward, KEY_FORWARD);
private final ToggleTracker toggleJump = new ToggleTracker(cfg().keyToggleJump, KEY_JUMP);
@@ -65,30 +68,30 @@ public final class PlayerTicker{
private void setup() {
final AccessStickyKeyBindingStateGetter sprint = (AccessStickyKeyBindingStateGetter)KEY_SPRINT;
BooleanSupplier getter = sprint.getToggleGetter();
BooleanSupplier getter = sprint.getNeedsToggle();
if (getter instanceof SprintPressGetter){
getter = ((SprintPressGetter)getter).getWrapped();
if (getter instanceof final SprintPressGetter g) {
getter = g.wrapped();
}
sprint.setToggleGetter(new SprintPressGetter(getter, () -> temporarySprintTimer > 0));
sprint.setNeedsToggle(new SprintPressGetter(getter, () -> temporarySprintTimer > 0));
}
public void atHead(final ClientPlayerEntity player){
public void atHead(final LocalPlayer player) {
if (FlightHelper.shouldFlyOnGround(player)) {
player.onGround = false;
player.setOnGround(false);
}
if (!cfg().doubleTapForwardToSprint) {
((AccessClientPlayerFields)player).setTicksLeftToDoubleTapSprint(0);
((AccessClientPlayerFields)player).setSprintTriggerTime(0);
}
if (!cfg().doubleTapJumpToToggleFlight) {
((AccessPlayerFields)player).setTicksLeftToDoubleTapFlight(0);
((AccessPlayerFields)player).setJumpTriggerTime(0);
}
final SprintMode sprintMode = cfg().sprintMode;
final boolean wasSprintToggled = OPTIONS.sprintToggled;
final boolean wasSprintToggled = OPTIONS.toggleSprint;
final boolean isSprintToggled = toggleSprint.tick();
if (temporarySprintTimer > 0) {
@@ -98,7 +101,7 @@ public final class PlayerTicker{
final int nextTemporarySprintTimer = temporarySprintTimer - 1;
temporarySprintTimer = 0;
if (!Key.isPressed(KEY_SPRINT) && Key.isPressed(KEY_FORWARD)){
if (!KEY_SPRINT.isDown() && KEY_FORWARD.isDown()) {
temporarySprintTimer = nextTemporarySprintTimer;
}
else if (sprintMode == SprintMode.TAP_TO_TOGGLE) {
@@ -115,7 +118,7 @@ public final class PlayerTicker{
waitingForSprintKeyRelease = true;
}
else if (sprintMode == SprintMode.TAP_TO_TOGGLE) {
if (Key.isPressed(KEY_SPRINT)){
if (KEY_SPRINT.isDown()) {
if (!waitingForSprintKeyRelease) {
waitingForSprintKeyRelease = true;
stopSprintingAfterReleasingSprintKey = player.isSprinting();
@@ -130,12 +133,12 @@ public final class PlayerTicker{
}
}
else if (sprintMode == SprintMode.HOLD) {
if (Key.isPressed(KEY_SPRINT)){
if (KEY_SPRINT.isDown()) {
stopSprintingAfterReleasingSprintKey = true;
}
}
if (stopSprintingAfterReleasingSprintKey && !Key.isPressed(KEY_SPRINT)){
if (stopSprintingAfterReleasingSprintKey && !KEY_SPRINT.isDown()) {
stopSprintingAfterReleasingSprintKey = false;
waitingForSprintKeyRelease = false;
player.setSprinting(false);
@@ -144,32 +147,32 @@ public final class PlayerTicker{
toggleSneak.tick();
}
public void afterInputAssignsPressingForward(final KeyboardInput input){
if (MINECRAFT.currentScreen == null){
input.pressingForward |= toggleWalkForward.tick();
public void afterInputAssignsPressingForward(final Input input) {
if (MINECRAFT.screen == null) {
input.up |= toggleWalkForward.tick();
}
}
public void afterInputTick(final ClientPlayerEntity player){
public void afterInputTick(final LocalPlayer player) {
final Input input = player.input;
if (MINECRAFT.currentScreen == null && !player.abilities.flying){
if (MINECRAFT.screen == null && !player.getAbilities().flying) {
input.jumping |= toggleJump.tick();
}
if (FlightHelper.isFlyingCreativeOrSpectator(player)) {
final boolean boost = Key.isPressed(KEY_SPRINT);
final boolean boost = KEY_SPRINT.isDown();
final float flightSpeed = FlightHelper.getFlightSpeed(player, boost);
final float verticalVelocity = FlightHelper.getExtraVerticalVelocity(player, boost);
if (flightSpeed > 0F) {
player.abilities.setFlySpeed(flightSpeed);
player.getAbilities().setFlyingSpeed(flightSpeed);
}
if (Math.abs(verticalVelocity) > 1E-5F && player == MINECRAFT.getCameraEntity()) {
int direction = 0;
if (input.sneaking){
if (input.shiftKeyDown) {
--direction;
}
@@ -178,7 +181,7 @@ public final class PlayerTicker{
}
if (direction != 0) {
player.setVelocity(player.getVelocity().add(0D, flightSpeed * verticalVelocity * direction, 0D));
player.setDeltaMovement(player.getDeltaMovement().add(0D, flightSpeed * verticalVelocity * direction, 0D));
}
}
}
@@ -186,7 +189,7 @@ public final class PlayerTicker{
if (cfg().resumeSprintingAfterHittingObstacle) {
if (wasHittingObstacle != player.horizontalCollision) {
if (!wasHittingObstacle) {
wasSprintingBeforeHittingObstacle = player.isSprinting() || Key.isPressed(KEY_SPRINT);
wasSprintingBeforeHittingObstacle = player.isSprinting() || KEY_SPRINT.isDown();
}
else if (wasSprintingBeforeHittingObstacle) {
wasSprintingBeforeHittingObstacle = false;
@@ -201,16 +204,12 @@ public final class PlayerTicker{
wasHittingObstacle = player.horizontalCollision;
wasSprintingBeforeHittingObstacle = false;
}
if (cfg().disableChangingFovWhileFlying && FlightHelper.isFlyingCreativeOrSpectator(player)){
((AccessGameRendererFields)MINECRAFT.gameRenderer).setMovementFovMultiplier(1F);
}
}
public void afterSuperCall(final ClientPlayerEntity player){
public void afterSuperCall(final LocalPlayer player) {
if (FlightHelper.shouldFlyOnGround(player)) {
final boolean isSneaking = player.isSneaking();
final boolean isOnGround = player.onGround;
final boolean isSneaking = player.isShiftKeyDown();
final boolean isOnGround = player.isOnGround();
if (!isSneaking) {
wasSneakingBeforeTouchingGround = false;
@@ -230,14 +229,14 @@ public final class PlayerTicker{
holdingSneakWhileTouchingGround = true;
}
else if (holdingSneakWhileTouchingGround) {
player.abilities.flying = false;
player.sendAbilitiesUpdate();
player.getAbilities().flying = false;
player.onUpdateAbilities();
cancelLanding = false;
}
}
if (cancelLanding) {
player.onGround = false;
player.setOnGround(false);
}
}
}
@@ -249,21 +248,21 @@ public final class PlayerTicker{
if (FlightHelper.isFlyingCreativeOrSpectator(player) && cfg().disableFlightInertia) {
final Input input = player.input;
if (input.movementForward == 0F && input.movementSideways == 0F){
player.setVelocity(player.getVelocity().multiply(0.0, 1.0, 0.0));
if (input.forwardImpulse == 0F && input.leftImpulse == 0F) {
player.setDeltaMovement(player.getDeltaMovement().multiply(0.0, 1.0, 0.0));
}
if (!input.jumping && !input.sneaking){
player.setVelocity(player.getVelocity().multiply(1.0, 0.0, 1.0));
if (!input.jumping && !input.shiftKeyDown) {
player.setDeltaMovement(player.getDeltaMovement().multiply(1.0, 0.0, 1.0));
}
}
if (player.isCreative()) {
if (Key.wasPressed(cfg().keyToggleFlight)){
final boolean isFlying = !player.abilities.flying;
if (cfg().keyToggleFlight.consumeClick()) {
final boolean isFlying = !player.getAbilities().flying;
player.abilities.flying = isFlying;
player.sendAbilitiesUpdate();
player.getAbilities().flying = isFlying;
player.onUpdateAbilities();
if (isFlying) {
temporaryFlyOnGroundTimer = 10;
@@ -271,12 +270,12 @@ public final class PlayerTicker{
}
if (temporaryFlyOnGroundTimer > 0) {
if (player.isSneaking()){
if (player.isShiftKeyDown()) {
temporaryFlyOnGroundTimer = 0;
}
else {
--temporaryFlyOnGroundTimer;
player.onGround = false;
player.setOnGround(false);
}
}
}
@@ -285,22 +284,26 @@ public final class PlayerTicker{
}
if (!cfg().sneakingMovesCameraSmoothly) {
final AccessCameraFields camera = (AccessCameraFields)MINECRAFT.gameRenderer.getCamera();
final Camera camera = MINECRAFT.gameRenderer.getMainCamera();
if (camera.getFocusedEntity() == player){
camera.setCameraY(player.getStandingEyeHeight());
if (camera.getEntity() == player) {
((AccessCameraFields)camera).setEyeHeight(player.getEyeHeight());
}
}
if (Key.wasPressed(cfg().keyResetAllToggles)){
if (cfg().keyResetAllToggles.consumeClick()) {
toggleSprint.reset();
toggleSneak.reset();
toggleWalkForward.reset();
toggleJump.reset();
}
if (Key.isPressed(cfg().keyOpenMenu)){
MINECRAFT.openScreen(new BetterControlsScreen(null));
if (cfg().keyOpenMenu.isDown()) {
MINECRAFT.setScreen(new BetterControlsScreen(null));
}
}
public boolean shouldResetFOV(final LocalPlayer player) {
return cfg().disableChangingFovWhileFlying && FlightHelper.isFlyingCreativeOrSpectator(player);
}
}

View File

@@ -1,19 +1,7 @@
package chylex.bettercontrols.player;
import java.util.function.BooleanSupplier;
final class SprintPressGetter implements BooleanSupplier{
private final BooleanSupplier wrapped;
private final BooleanSupplier or;
public SprintPressGetter(final BooleanSupplier wrapped, final BooleanSupplier or){
this.wrapped = wrapped;
this.or = or;
}
public BooleanSupplier getWrapped(){
return wrapped;
}
record SprintPressGetter(BooleanSupplier wrapped, BooleanSupplier or) implements BooleanSupplier {
@Override
public boolean getAsBoolean() {
return wrapped.getAsBoolean() || or.getAsBoolean();

View File

@@ -1,45 +0,0 @@
package chylex.bettercontrols.util;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.util.InputUtil;
public final class Key{
private Key(){}
public static final InputUtil.KeyCode INVALID = InputUtil.UNKNOWN_KEYCODE;
public static boolean isUnbound(final KeyBinding binding){
return binding.isNotBound();
}
public static boolean isPressed(final KeyBinding binding){
return binding.isPressed();
}
public static boolean wasPressed(final KeyBinding binding){
return binding.wasPressed();
}
public static String getBoundKeyText(final KeyBinding binding){
return binding.getLocalizedName();
}
public static void bind(final KeyBinding binding, final InputUtil.KeyCode input){
binding.setKeyCode(input);
}
public static String writeBinding(final KeyBinding binding){
return binding.getName();
}
public static void readBinding(final KeyBinding binding, final String serialized){
bind(binding, InputUtil.fromName(serialized));
}
public static InputUtil.KeyCode inputFromMouse(final int button){
return InputUtil.Type.MOUSE.createFromCode(button);
}
public static InputUtil.KeyCode inputFromKeyboard(final int keyCode, final int scanCode){
return InputUtil.getKeyCode(keyCode, scanCode);
}
}

View File

@@ -1,11 +0,0 @@
package chylex.bettercontrols.util;
public final class LiteralText extends net.minecraft.text.LiteralText{
public static LiteralText text(final String text){
return new LiteralText(text);
}
public LiteralText(final String msg){
super(msg);
}
}

View File

@@ -1,16 +0,0 @@
package chylex.bettercontrols.util;
import net.minecraft.client.MinecraftClient;
import net.minecraft.client.options.GameOptions;
import net.minecraft.client.options.KeyBinding;
public final class Statics{
private Statics(){}
public static final MinecraftClient MINECRAFT = MinecraftClient.getInstance();
public static final GameOptions OPTIONS = MINECRAFT.options;
public static final KeyBinding KEY_SPRINT = OPTIONS.keySprint;
public static final KeyBinding KEY_SNEAK = OPTIONS.keySneak;
public static final KeyBinding KEY_FORWARD = OPTIONS.keyForward;
public static final KeyBinding KEY_JUMP = OPTIONS.keyJump;
}

View File

@@ -2,25 +2,23 @@
"required": true,
"minVersion": "0.8",
"package": "chylex.bettercontrols.mixin",
"compatibilityLevel": "JAVA_8",
"mixins": [
"refmap": "bettercontrols.refmap.json",
"compatibilityLevel": "JAVA_16",
"client": [
"AccessCameraFields",
"AccessClientPlayerFields",
"AccessControlsListCategory",
"AccessControlsListKeyBinding",
"AccessGameRendererFields",
"AccessKeyBindingFields",
"AccessOptionButtonWidgetOption",
"AccessPlayerFields",
"AccessScreenButtons",
"AccessStickyKeyBindingStateGetter",
"HookClientPlayerFOV",
"HookClientPlayerInputTick",
"HookClientPlayerTick",
"HookControlsListWidget",
"HookControlsScreen",
"HookLoadGameOptions",
"HookOpenScreen",
"HookPlayerFlightSpeed",
"HookStickyKeyBindingState"
"HookStickyKeyBindingState",
"HookToggleOptionButtons"
],
"injectors": {
"defaultRequire": 1

View File

@@ -0,0 +1,7 @@
{
"pack": {
"description": "Better Controls",
"pack_format": 7,
"_comment": ""
}
}