1
0
mirror of https://github.com/chylex/Better-Controls.git synced 2025-08-18 10:31:48 +02:00

22 Commits

Author SHA1 Message Date
d416883dbb Release v1.2.0 for Minecraft 1.15.x 2020-12-10 05:52:43 +01:00
681fd75997 Fix tapping sneak to stop flying on ground not working when flight inertia is disabled 2020-12-10 05:52:22 +01:00
04408ddfb1 Add option to disable double tapping 'Jump' key to flight
Fixes #6
2020-12-09 17:23:54 +01:00
15e314eb73 Change flight to 'Hold to Sprint' mode at all times & fix not boost unless flying forward 2020-12-09 17:13:46 +01:00
b292a3b621 Add option to disable flight inertia after releasing movement keys
Fixes #2
2020-12-09 17:13:17 +01:00
4248293230 Minor code tweaks 2020-12-09 17:12:50 +01:00
9634c33ca2 Add README 2020-12-09 17:12:06 +01:00
54a6b4ea56 Refactor code to make porting easier 2020-12-09 17:04:36 +01:00
9437932b97 Release v1.1.0 for Minecraft 1.15.x 2020-10-27 17:28:37 +01:00
50c035bb91 Fix compile error after cherry-pick 2020-10-27 17:28:13 +01:00
81e135469e Avoid sudden FOV jump when starting to fly with disabled FOV changing 2020-10-27 17:25:39 +01:00
188f66b4d3 Add options for vertical flight speed boost in creative/spectator and default/sprinting modes 2020-10-27 17:25:39 +01:00
ab4fa452f7 Add more flight speed options (5x and 7x) 2020-10-27 17:22:07 +01:00
116bbe241d Add option to prevent FOV changing while flying 2020-10-27 17:21:23 +01:00
9baa7c4460 Add key binding to reset all toggles at once 2020-10-27 17:20:11 +01:00
7f258966de Implement third sprinting mode (hold key to sprint) & option to change sprinting mode when flying 2020-10-27 17:20:11 +01:00
9af10ad04c Release v1.0.1 for Minecraft 1.15.x 2020-10-19 21:15:32 +02:00
6e316eff89 Avoid wobble sprinting when resuming sprinting after hitting an obstacle, by simulating holding sprint for multiple ticks 2020-10-19 21:14:56 +02:00
21ee424cef Fix not removing custom category from Controls screen 2020-10-18 16:54:40 +02:00
c7c5b67c3b Fix sprinting not stopping when untoggling sometimes 2020-10-18 16:02:42 +02:00
06b2782372 Fix Mod Menu support 2020-10-18 15:37:12 +02:00
83b2dfdfa5 Backport to 1.15.x 2020-10-18 15:04:04 +02:00
72 changed files with 1081 additions and 1299 deletions

1
.gitignore vendored
View File

@@ -27,4 +27,3 @@ bin/
# fabric # fabric
run/ run/
logs/

View File

@@ -1,50 +0,0 @@
val modId: String by project
val minecraftVersion: String by project
val fabricVersion: String by project
plugins {
idea
id("fabric-loom")
}
dependencies {
minecraft("com.mojang:minecraft:$minecraftVersion")
modImplementation("net.fabricmc:fabric-loader:$fabricVersion")
mappings(loom.officialMojangMappings())
}
loom {
runs {
named("client") {
configName = "Fabric Client"
client()
runDir("run")
ideConfigGenerated(true)
}
named("server") {
configName = "Fabric Server"
server()
runDir("run")
ideConfigGenerated(true)
}
}
mixin {
add(sourceSets.main.get(), "$modId.refmap.json")
}
}
tasks.processResources {
filesMatching("fabric.mod.json") {
expand(inputs.properties)
}
}
tasks.jar {
exclude("com/terraformersmc/modmenu/")
}
tasks.remapJar {
archiveVersion.set(tasks.jar.get().archiveVersion)
}

View File

@@ -1,11 +0,0 @@
package chylex.bettercontrols.compatibility;
import chylex.bettercontrols.gui.BetterControlsScreen;
import com.terraformersmc.modmenu.api.ConfigScreenFactory;
import com.terraformersmc.modmenu.api.ModMenuApi;
public class ModMenuSupport implements ModMenuApi {
@Override
public ConfigScreenFactory<?> getModConfigScreenFactory() {
return BetterControlsScreen::new;
}
}

View File

@@ -1,9 +0,0 @@
package com.terraformersmc.modmenu.api;
import net.minecraft.client.gui.screens.Screen;
@SuppressWarnings("unused")
@FunctionalInterface
public interface ConfigScreenFactory<S extends Screen> {
S create(Screen parent);
}

View File

@@ -1,8 +0,0 @@
package com.terraformersmc.modmenu.api;
@SuppressWarnings("unused")
public interface ModMenuApi {
default ConfigScreenFactory<?> getModConfigScreenFactory() {
return screen -> null;
}
}

View File

@@ -1,35 +0,0 @@
{
"schemaVersion": 1,
"id": "${id}",
"name": "${name}",
"description": "${description}",
"version": "${version}",
"license": "${license}",
"icon": "assets/bettercontrols/icon.png",
"authors": [
"${author}"
],
"contact": {
"issues": "${issuesURL}",
"sources": "${sourcesURL}"
},
"environment": "client",
"entrypoints": {
"client": [ "chylex.bettercontrols.BetterControlsMod" ],
"modmenu": [ "chylex.bettercontrols.compatibility.ModMenuSupport" ]
},
"mixins": [{
"config": "${id}.mixins.json",
"environment": "client"
}],
"depends": {
"fabricloader": ">=${minimumFabricVersion}",
"minecraft": ">=${minimumMinecraftVersion}"
}
}

View File

@@ -1,95 +0,0 @@
import net.minecraftforge.gradle.userdev.UserDevExtension
import org.gradle.api.file.DuplicatesStrategy.INCLUDE
import org.spongepowered.asm.gradle.plugins.MixinExtension
val modId: String by project
val minecraftVersion: String by project
val forgeVersion: String by project
val mixinVersion: String by project
buildscript {
repositories {
maven("https://maven.minecraftforge.net")
maven("https://repo.spongepowered.org/maven")
mavenCentral()
}
dependencies {
classpath(group = "net.minecraftforge.gradle", name = "ForgeGradle", version = "5.1.+") { isChanging = true }
classpath(group = "org.spongepowered", name = "mixingradle", version = "0.7-SNAPSHOT")
}
}
plugins {
java
eclipse
}
apply {
plugin("net.minecraftforge.gradle")
plugin("org.spongepowered.mixin")
}
dependencies {
"minecraft"("net.minecraftforge:forge:$minecraftVersion-$forgeVersion")
if (System.getProperty("idea.sync.active") != "true") {
annotationProcessor("org.spongepowered:mixin:$mixinVersion:processor")
}
}
configure<UserDevExtension> {
mappings("official", minecraftVersion)
runs {
create("client") {
taskName = "Client"
workingDirectory(rootProject.file("run"))
ideaModule("${rootProject.name}.${project.name}.main")
property("mixin.env.remapRefMap", "true")
property("mixin.env.refMapRemappingFile", "$projectDir/build/createSrgToMcp/output.srg")
arg("-mixin.config=$modId.mixins.json")
mods {
create(modId) {
source(sourceSets.main.get())
source(rootProject.sourceSets.main.get())
}
}
}
create("server") {
taskName = "Server"
workingDirectory(rootProject.file("run"))
ideaModule("${rootProject.name}.${project.name}.main")
property("mixin.env.remapRefMap", "true")
property("mixin.env.refMapRemappingFile", "$projectDir/build/createSrgToMcp/output.srg")
arg("-mixin.config=$modId.mixins.json")
mods {
create(modId) {
source(sourceSets.main.get())
source(rootProject.sourceSets.main.get())
}
}
}
}
}
configure<MixinExtension> {
add(sourceSets.main.get(), "$modId.refmap.json")
}
tasks.processResources {
from(sourceSets.main.get().resources.srcDirs) {
include("META-INF/mods.toml")
expand(inputs.properties)
duplicatesStrategy = INCLUDE
}
}
tasks.jar {
finalizedBy("reobfJar")
}

View File

@@ -1,32 +0,0 @@
package chylex.bettercontrols;
import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.gui.BetterControlsScreen;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.screens.Screen;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.client.ConfigScreenHandler.ConfigScreenFactory;
import net.minecraftforge.fml.DistExecutor;
import net.minecraftforge.fml.IExtensionPoint.DisplayTest;
import net.minecraftforge.fml.ModLoadingContext;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.loading.FMLPaths;
import net.minecraftforge.network.NetworkConstants;
@Mod("bettercontrols")
public final class BetterControlsMod {
public BetterControlsMod() {
BetterControlsCommon.setConfig(DistExecutor.safeCallWhenOn(Dist.CLIENT, () -> ClientLoader::loadConfig));
ModLoadingContext.get().registerExtensionPoint(ConfigScreenFactory.class, () -> new ConfigScreenFactory(ClientLoader::createScreen));
ModLoadingContext.get().registerExtensionPoint(DisplayTest.class, () -> new DisplayTest(() -> NetworkConstants.IGNORESERVERONLY, (a, b) -> true));
}
private static final class ClientLoader {
public static BetterControlsConfig loadConfig() {
return BetterControlsConfig.load(FMLPaths.CONFIGDIR.get().resolve("BetterControls.json"));
}
public static BetterControlsScreen createScreen(final Minecraft mc, final Screen parentScreen) {
return new BetterControlsScreen(parentScreen);
}
}
}

View File

@@ -1,27 +0,0 @@
modLoader = "javafml"
loaderVersion = "[0,)"
license = "${license}"
issueTrackerURL = "${issuesURL}"
[[mods]]
modId = "${id}"
displayName = "${name}"
description = "${description}"
authors = "${author}"
version = "${version}"
logoFile = "icon.png"
[[dependencies.${id}]]
modId = "minecraft"
mandatory = true
versionRange = "[${minimumMinecraftVersion},)"
ordering = "NONE"
side = "BOTH"
[[dependencies.${id}]]
modId = "forge"
mandatory = true
versionRange = "[${minimumForgeVersion},)"
ordering = "NONE"
side = "BOTH"

Binary file not shown.

Before

Width:  |  Height:  |  Size: 21 KiB

View File

@@ -3,9 +3,9 @@ Better Controls
![Logo](https://raw.githubusercontent.com/chylex/Better-Controls/master/logo.png "Depiction of Zero Regrets") ![Logo](https://raw.githubusercontent.com/chylex/Better-Controls/master/logo.png "Depiction of Zero Regrets")
[Better Controls](https://www.curseforge.com/minecraft/mc-mods/better-controls) is a reimagining of [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting) with even more customizability. It features several new keybindings and many configurable options for how sprinting, sneaking, and flying should behave. Better Controls is a reimagining of [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting) with even more customizability. It features several new keybindings and many configurable options for how sprinting, sneaking, and flying should behave.
Better Controls only focuses on complementing vanilla mechanics, rather than adding new mechanics (such as [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting)'s option to allow sprinting in all directions) that only work on client side and server owners must explicitly opt in to enable them. By not having such features in Better Controls, it significantly reduces complexity by not having a server side version of the mod, and not needing a way to completely disable the mod while the game is running. Better Controls only focuses on complementing vanilla mechanics rather than adding new mechanics (such as [Better Sprinting](https://www.curseforge.com/minecraft/mc-mods/better-sprinting)'s option to allow sprinting in all directions) that only work on client side and server owners must explicitly opt in to enable them. By not having such features in Better Controls, it significantly reduces complexity by not having a server side version of the mod, and not needing a way to completely disable the mod while the game is running.
Another major difference is the amount and granularity of options. Better Controls could be considered an *advanced controls mod* - by default, none of the keybinds are bound, and all options are set to match vanilla behavior. To take full advantage, go into *Options - Controls - Better Controls*, check out all of the available options, and figure out the best configuration for you. Another major difference is the amount and granularity of options. Better Controls could be considered an *advanced controls mod* - by default, none of the keybinds are bound, and all options are set to match vanilla behavior. To take full advantage, go into *Options - Controls - Better Controls*, check out all of the available options, and figure out the best configuration for you.
@@ -27,15 +27,12 @@ You can also bind a key that resets all **Toggle Keybinds** at once. That makes
#### Flying #### Flying
* **Double Tap 'Jump' To Fly** can be turned off to prevent accidental flight toggling. * **Sprint Key Mode While Flying** changes how the Sprint key behaves during flight.
* **Disable Flight Inertia** stops you instantly when you stop holding movement keys.
* **Disable Field Of View Changing** prevents sprinting, potions, and other factors from changing the FOV while flying in creative and spectator mode. * **Disable Field Of View Changing** prevents sprinting, potions, and other factors from changing the FOV while flying in creative and spectator mode.
* **Fly On Ground** lets you fly while touching the ground in creative mode (and also lets you stop flying by tapping Sneak while touching the ground). * **Fly On Ground** lets you fly while touching the ground in creative mode (and also lets you stop flying by tapping Sneak while touching the ground).
* **Flight Speed Multiplier** (0.25x - 8x) changes how fast you fly in creative and spectator mode. * **Flight Speed Multiplier** (0.25x - 8x) changes how fast you fly in creative and spectator mode.
* **Vertical Speed Boost** (up to +300%) adds additional vertical speed boost while flying in creative and spectator mode. * **Vertical Speed Boost** (up to +300%) adds additional vertical speed boost while flying in creative and spectator mode.
Both speed boosts can be configured separately for sprinting, which will be active when the Sprint key is held. Unlike in vanilla, the sprinting flight boost works in all directions.
## Installation ## Installation
The following mod loaders are supported: The following mod loaders are supported:
@@ -54,7 +51,7 @@ While this is convenient, there is potential for bugs which can affect server pl
### Compatibility ### Compatibility
* Better Controls is a client-side mod, it will do nothing when installed on a server. * Better Controls is a client-side mod, it will do nothing when installed on a server.
* If you run into a conflict with another mod that modifies the *Controls* screen, hold Alt while opening *Controls* to prevent Better Controls from adding its button. If another mod prevents the button from appearing, a button to open the mod's configuration is available in the Mods menu (for Fabric, install [Mod Menu](https://www.curseforge.com/minecraft/mc-mods/modmenu)). * If you run into a conflict with another mod that modifies the *Controls* screen, hold Alt while opening *Controls* to prevent Better Controls from adding its button. If another mod prevents the button from appearing, you can install [Mod Menu](https://www.curseforge.com/minecraft/mc-mods/modmenu) which adds a mod list with configuration buttons for mods.
## Screenshot ## Screenshot
@@ -63,15 +60,11 @@ While this is convenient, there is potential for bugs which can affect server pl
Source Code Source Code
=========== ===========
The `main` branch includes both the Fabric and Forge version in a single project. The project uses Mojang mappings. The root project contains common source code and resource files, and the `Fabric` and `Forge` folders are subprojects with loader-specific files. The `main` branch includes the latest version for Fabric. Older versions and their Forge equivalents are in branches named `fabric/<version>` and `forge/<version>`.
The `main` branch always has the latest development version. Before updating to a new Minecraft version, a new branch is created from the `main` branch (for example, before the mod is updated to `1.18`, a branch named `1.17` will be created). Further development of older versions may continue in these branches in case backports or version-specific fixes are needed.
Older versions from before the merge of the Fabric and Forge versions can be found in branches named `fabric/<version>` and `forge/<version>`.
## Contributing ## Contributing
All contributions should target the `main` branch and work in both Fabric and Forge, unless the contribution is specifically targeting older versions or a specific mod loader. All contributions should target the `main` branch, unless the contribution is specifically made for older versions. Every feature must be portable to Forge to ensure parity, unless the feature adds integration with another mod that is only compatible with one mod loader. Integrations for Forge-only mods should target the most recent `forge/<version>` branch.
For any larger contributions, please [open an issue](https://github.com/chylex/Better-Controls/issues/new) first before you make a PR. For any larger contributions, please [open an issue](https://github.com/chylex/Better-Controls/issues/new) first before you make a PR.

41
build.gradle Normal file
View File

@@ -0,0 +1,41 @@
plugins {
id 'fabric-loom' version '0.5-SNAPSHOT'
id 'maven-publish'
}
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
archivesBaseName = project.archives_base_name
version = project.mod_version
group = project.maven_group
dependencies {
minecraft "com.mojang:minecraft:${project.minecraft_version}"
mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2"
modImplementation "net.fabricmc:fabric-loader:${project.loader_version}"
}
processResources {
inputs.property "version", project.version
from(sourceSets.main.resources.srcDirs) {
include "fabric.mod.json"
expand "version": project.version
}
from(sourceSets.main.resources.srcDirs) {
exclude "fabric.mod.json"
}
}
tasks.withType(JavaCompile) {
options.encoding = "UTF-8"
}
version = 'v' + version
jar {
from "LICENSE"
exclude "io/github/prospector/"
}

View File

@@ -1,180 +0,0 @@
import org.gradle.api.file.DuplicatesStrategy.EXCLUDE
import java.text.SimpleDateFormat
import java.util.Date
val modId: String by project
val modName: String by project
val modDescription: String by project
val modAuthor: String by project
val modVersion: String by project
val modLicense: String by project
val modSourcesURL: String by project
val modIssuesURL: String by project
val minecraftVersion: String by project
val mixinVersion: String by project
val minimumMinecraftVersion: String by project
val minimumForgeVersion: String by project
val minimumFabricVersion: String by project
val modNameStripped = modName.replace(" ", "")
val jarVersion = "$minecraftVersion+v$modVersion"
buildscript {
repositories {
maven("https://repo.spongepowered.org/maven")
}
}
plugins {
`java-library`
idea
id("org.spongepowered.gradle.vanilla") version "0.2.1-SNAPSHOT"
}
idea {
module {
excludeDirs.add(file("gradle"))
excludeDirs.add(file("run"))
excludeDirs.add(file("Fabric/run"))
if (findProject(":Forge") == null) {
excludeDirs.add(file("Forge"))
}
if (findProject(":Fabric") == null) {
excludeDirs.add(file("Fabric"))
}
}
}
repositories {
maven("https://repo.spongepowered.org/maven")
mavenCentral()
}
dependencies {
implementation("org.spongepowered:mixin:$mixinVersion")
api("com.google.code.findbugs:jsr305:3.0.2")
}
base {
archivesName.set("$modNameStripped-Common")
}
minecraft {
version(minecraftVersion)
runs.clear()
}
allprojects {
group = "com.$modAuthor.$modId"
version = modVersion
apply(plugin = "java")
dependencies {
implementation("org.jetbrains:annotations:22.0.0")
}
extensions.getByType<JavaPluginExtension>().apply {
toolchain.languageVersion.set(JavaLanguageVersion.of(17))
}
tasks.withType<JavaCompile> {
options.encoding = "UTF-8"
options.release.set(17)
}
}
subprojects {
repositories {
maven("https://repo.spongepowered.org/maven")
}
dependencies {
implementation(rootProject)
}
base {
archivesName.set("$modNameStripped-${project.name}")
}
tasks.withType<JavaCompile> {
source({ rootProject.sourceSets.main.get().allSource })
}
tasks.processResources {
inputs.property("id", modId)
inputs.property("name", modName)
inputs.property("description", modDescription)
inputs.property("version", modVersion)
inputs.property("author", modAuthor)
inputs.property("license", modLicense)
inputs.property("sourcesURL", modSourcesURL)
inputs.property("issuesURL", modIssuesURL)
inputs.property("minimumMinecraftVersion", minimumMinecraftVersion)
inputs.property("minimumForgeVersion", minimumForgeVersion)
inputs.property("minimumFabricVersion", minimumFabricVersion)
from(rootProject.sourceSets.main.get().resources) {
expand(inputs.properties)
}
}
tasks.jar {
archiveVersion.set(jarVersion)
from(rootProject.file("LICENSE"))
manifest {
attributes(
"Specification-Title" to modId,
"Specification-Vendor" to modAuthor,
"Specification-Version" to "1",
"Implementation-Title" to "$modNameStripped-${project.name}",
"Implementation-Vendor" to modAuthor,
"Implementation-Version" to modVersion,
"Implementation-Timestamp" to SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ").format(Date()),
"MixinConfigs" to "$modId.mixins.json"
)
}
}
tasks.test {
onlyIf { false }
}
}
tasks.register("setupIdea") {
group = "mod"
dependsOn(tasks.findByName("decompile"))
val forge = findProject(":Forge")
if (forge != null) {
dependsOn(forge.tasks.getByName("genIntellijRuns"))
}
val fabric = findProject(":Fabric")
if (fabric != null) {
dependsOn(fabric.tasks.getByName("genSources"))
}
}
val copyJars = tasks.register<Copy>("copyJars") {
group = "build"
duplicatesStrategy = EXCLUDE
for (subproject in subprojects) {
dependsOn(subproject.tasks.assemble)
from(subproject.base.libsDirectory.file("${subproject.base.archivesName.get()}-$jarVersion.jar"))
}
into(file("${project.buildDir}/dist"))
}
tasks.assemble {
finalizedBy(copyJars)
}

View File

@@ -1,25 +1,15 @@
# Mod # Done to increase the memory available to gradle.
modId=bettercontrols org.gradle.jvmargs=-Xmx1G
modName=Better Controls
modDescription=Adds many powerful key bindings and options to control your movement.\\n\\nThe features complement vanilla mechanics without giving unfair advantages, so server use should be fine.
modAuthor=chylex
modVersion=1.2.4
modLicense=MPL-2.0
modSourcesURL=https://github.com/chylex/Better-Controls
modIssuesURL=https://github.com/chylex/Better-Controls/issues
# Dependencies # Fabric Properties
minecraftVersion=1.19.4 minecraft_version=1.15.2
forgeVersion=45.0.6 yarn_mappings=1.15.2+build.17
fabricVersion=0.14.17 loader_version=0.10.2+build.210
loomVersion=0.12
mixinVersion=0.8.5
# Constraints # Mod Properties
minimumMinecraftVersion=1.19.4 mod_version=1.2.0
minimumForgeVersion=45.0.0 maven_group=chylex.bettercontrols
minimumFabricVersion=0.7.4 archives_base_name=BetterControls-1.15.x
# Gradle # https://fabricmc.net/use
org.gradle.jvmargs=-Xmx3G # https://maven.fabricmc.net/net/fabricmc/fabric-api/fabric-api
org.gradle.daemon=false

Binary file not shown.

View File

@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip
zipStoreBase=GRADLE_USER_HOME zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists zipStorePath=wrapper/dists

22
gradlew vendored
View File

@@ -1,4 +1,4 @@
#!/usr/bin/env bash #!/usr/bin/env sh
# #
# Copyright 2015 the original author or authors. # Copyright 2015 the original author or authors.
@@ -72,7 +72,7 @@ case "`uname`" in
Darwin* ) Darwin* )
darwin=true darwin=true
;; ;;
MSYS* | MINGW* ) MINGW* )
msys=true msys=true
;; ;;
NONSTOP* ) NONSTOP* )
@@ -130,7 +130,7 @@ fi
if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
APP_HOME=`cygpath --path --mixed "$APP_HOME"` APP_HOME=`cygpath --path --mixed "$APP_HOME"`
CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` CLASSPATH=`cygpath --path --mixed "$CLASSPATH"`
JAVACMD=`cygpath --unix "$JAVACMD"` JAVACMD=`cygpath --unix "$JAVACMD"`
# We build the pattern for arguments to be converted via cygpath # We build the pattern for arguments to be converted via cygpath
@@ -172,12 +172,14 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
esac esac
fi fi
ARGV=("$@") # Escape application args
eval set -- $DEFAULT_JVM_OPTS save () {
for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done
echo " "
}
APP_ARGS=`save "$@"`
IFS=$' # Collect all arguments for the java command, following the shell quoting and substitution rules
' read -rd '' -a JAVA_OPTS_ARR <<< "$(echo $JAVA_OPTS | xargs -n1)" eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS"
IFS=$'
' read -rd '' -a GRADLE_OPTS_ARR <<< "$(echo $GRADLE_OPTS | xargs -n1)"
exec "$JAVACMD" "$@" "${JAVA_OPTS_ARR[@]}" "${GRADLE_OPTS_ARR[@]}" "-Dorg.gradle.appname=$APP_BASE_NAME" -classpath "$CLASSPATH" org.gradle.wrapper.GradleWrapperMain "${ARGV[@]}" exec "$JAVACMD" "$@"

21
gradlew.bat vendored
View File

@@ -40,7 +40,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome
set JAVA_EXE=java.exe set JAVA_EXE=java.exe
%JAVA_EXE% -version >NUL 2>&1 %JAVA_EXE% -version >NUL 2>&1
if "%ERRORLEVEL%" == "0" goto execute if "%ERRORLEVEL%" == "0" goto init
echo. echo.
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
@@ -54,7 +54,7 @@ goto fail
set JAVA_HOME=%JAVA_HOME:"=% set JAVA_HOME=%JAVA_HOME:"=%
set JAVA_EXE=%JAVA_HOME%/bin/java.exe set JAVA_EXE=%JAVA_HOME%/bin/java.exe
if exist "%JAVA_EXE%" goto execute if exist "%JAVA_EXE%" goto init
echo. echo.
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
@@ -64,6 +64,21 @@ echo location of your Java installation.
goto fail goto fail
:init
@rem Get command-line arguments, handling Windows variants
if not "%OS%" == "Windows_NT" goto win9xME_args
:win9xME_args
@rem Slurp the command line arguments.
set CMD_LINE_ARGS=
set _SKIP=2
:win9xME_args_slurp
if "x%~1" == "x" goto execute
set CMD_LINE_ARGS=%*
:execute :execute
@rem Setup the command line @rem Setup the command line
@@ -71,7 +86,7 @@ set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
@rem Execute Gradle @rem Execute Gradle
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %* "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS%
:end :end
@rem End local scope for the variables with windows NT shell @rem End local scope for the variables with windows NT shell

10
settings.gradle Normal file
View File

@@ -0,0 +1,10 @@
pluginManagement {
repositories {
jcenter()
maven {
name = 'Fabric'
url = 'https://maven.fabricmc.net/'
}
gradlePluginPortal()
}
}

View File

@@ -1,23 +0,0 @@
rootProject.name = "Better-Controls"
pluginManagement {
repositories {
gradlePluginPortal()
maven(url = "https://maven.fabricmc.net/") { name = "Fabric" }
maven(url = "https://repo.spongepowered.org/repository/maven-public/") { name = "Sponge Snapshots" }
}
plugins {
if (settings.extra.has("loomVersion")) {
id("fabric-loom") version "${settings.extra["loomVersion"]}-SNAPSHOT"
}
}
}
if (settings.extra.has("forgeVersion")) {
include("Forge")
}
if (settings.extra.has("fabricVersion")) {
include("Fabric")
}

View File

@@ -1,17 +0,0 @@
package chylex.bettercontrols;
import chylex.bettercontrols.config.BetterControlsConfig;
public final class BetterControlsCommon {
private static BetterControlsConfig config;
public static BetterControlsConfig getConfig() {
return config;
}
static void setConfig(final BetterControlsConfig config) {
BetterControlsCommon.config = config;
}
private BetterControlsCommon() {}
}

View File

@@ -3,9 +3,9 @@ import chylex.bettercontrols.config.BetterControlsConfig;
import net.fabricmc.api.ClientModInitializer; import net.fabricmc.api.ClientModInitializer;
import net.fabricmc.loader.api.FabricLoader; import net.fabricmc.loader.api.FabricLoader;
public final class BetterControlsMod implements ClientModInitializer { public final class BetterControlsMod implements ClientModInitializer{
public static final BetterControlsConfig config = BetterControlsConfig.load(FabricLoader.getInstance().getConfigDir().resolve("BetterControls.json"));
@Override @Override
public void onInitializeClient() { public void onInitializeClient(){}
BetterControlsCommon.setConfig(BetterControlsConfig.load(FabricLoader.getInstance().getConfigDir().resolve("BetterControls.json")));
}
} }

View File

@@ -0,0 +1,16 @@
package chylex.bettercontrols.compatibility;
import chylex.bettercontrols.gui.BetterControlsScreen;
import io.github.prospector.modmenu.api.ConfigScreenFactory;
import io.github.prospector.modmenu.api.ModMenuApi;
public class ModMenuSupport implements ModMenuApi{
@Override
public String getModId(){
return "bettercontrols";
}
@Override
public ConfigScreenFactory<?> getModConfigScreenFactory(){
return BetterControlsScreen::new;
}
}

View File

@@ -3,8 +3,8 @@ import chylex.bettercontrols.input.KeyBindingWithModifier;
import chylex.bettercontrols.input.SprintMode; import chylex.bettercontrols.input.SprintMode;
import java.nio.file.Path; import java.nio.file.Path;
public final class BetterControlsConfig { public final class BetterControlsConfig{
public static BetterControlsConfig load(final Path path) { public static BetterControlsConfig load(final Path path){
return ConfigSerializer.deserialize(path).setPath(path); return ConfigSerializer.deserialize(path).setPath(path);
} }
@@ -37,15 +37,15 @@ public final class BetterControlsConfig {
public final KeyBindingWithModifier keyResetAllToggles = new KeyBindingWithModifier("key.bettercontrols.reset_all_toggles"); public final KeyBindingWithModifier keyResetAllToggles = new KeyBindingWithModifier("key.bettercontrols.reset_all_toggles");
public final KeyBindingWithModifier keyOpenMenu = new KeyBindingWithModifier("key.bettercontrols.open_menu"); public final KeyBindingWithModifier keyOpenMenu = new KeyBindingWithModifier("key.bettercontrols.open_menu");
BetterControlsConfig() {} BetterControlsConfig(){}
private BetterControlsConfig setPath(final Path path) { private BetterControlsConfig setPath(final Path path){
this.path = path; this.path = path;
return this; return this;
} }
public KeyBindingWithModifier[] getAllKeyBindings() { public KeyBindingWithModifier[] getAllKeyBindings(){
return new KeyBindingWithModifier[] { return new KeyBindingWithModifier[]{
keyToggleSprint, keyToggleSprint,
keyToggleSneak, keyToggleSneak,
keyToggleFlight, keyToggleFlight,
@@ -56,7 +56,7 @@ public final class BetterControlsConfig {
}; };
} }
public void save() { public void save(){
ConfigSerializer.serialize(path, this); ConfigSerializer.serialize(path, this);
} }
} }

View File

@@ -21,14 +21,14 @@ import java.nio.file.Files;
import java.nio.file.NoSuchFileException; import java.nio.file.NoSuchFileException;
import java.nio.file.Path; import java.nio.file.Path;
final class ConfigSerializer implements JsonSerializer<BetterControlsConfig>, JsonDeserializer<BetterControlsConfig> { final class ConfigSerializer implements JsonSerializer<BetterControlsConfig>, JsonDeserializer<BetterControlsConfig>{
private static final Logger logger = LogManager.getLogger(); private static final Logger logger = LogManager.getLogger();
private static final Gson gson = new GsonBuilder().registerTypeAdapter(BetterControlsConfig.class, new ConfigSerializer()).setPrettyPrinting().create(); private static final Gson gson = new GsonBuilder().registerTypeAdapter(BetterControlsConfig.class, new ConfigSerializer()).setPrettyPrinting().create();
private ConfigSerializer() {} private ConfigSerializer(){}
@Override @Override
public JsonElement serialize(final BetterControlsConfig cfg, final Type typeOfSrc, final JsonSerializationContext context) { public JsonElement serialize(final BetterControlsConfig cfg, final Type typeOfSrc, final JsonSerializationContext context){
final JsonObject obj = new JsonObject(); final JsonObject obj = new JsonObject();
Json.writeKeyBinding(obj, "Sprint.KeyToggle", cfg.keyToggleSprint); Json.writeKeyBinding(obj, "Sprint.KeyToggle", cfg.keyToggleSprint);
@@ -62,11 +62,11 @@ final class ConfigSerializer implements JsonSerializer<BetterControlsConfig>, Js
} }
@Override @Override
public BetterControlsConfig deserialize(final JsonElement json, final Type typeOfT, final JsonDeserializationContext context) throws JsonParseException { public BetterControlsConfig deserialize(final JsonElement json, final Type typeOfT, final JsonDeserializationContext context) throws JsonParseException{
final BetterControlsConfig cfg = new BetterControlsConfig(); final BetterControlsConfig cfg = new BetterControlsConfig();
final JsonObject obj = json.getAsJsonObject(); final JsonObject obj = json.getAsJsonObject();
if (obj.has("Sprint.TapToStop") && obj.get("Sprint.TapToStop").getAsBoolean()) { if (obj.has("Sprint.TapToStop") && obj.get("Sprint.TapToStop").getAsBoolean()){
cfg.sprintMode = SprintMode.TAP_TO_TOGGLE; cfg.sprintMode = SprintMode.TAP_TO_TOGGLE;
} }
@@ -100,19 +100,19 @@ final class ConfigSerializer implements JsonSerializer<BetterControlsConfig>, Js
return cfg; return cfg;
} }
static void serialize(final Path path, final BetterControlsConfig config) { static void serialize(final Path path, final BetterControlsConfig config){
try (final JsonWriter writer = gson.newJsonWriter(Files.newBufferedWriter(path, StandardCharsets.UTF_8))) { try(final JsonWriter writer = gson.newJsonWriter(Files.newBufferedWriter(path, StandardCharsets.UTF_8))){
gson.getAdapter(BetterControlsConfig.class).write(writer, config); gson.getAdapter(BetterControlsConfig.class).write(writer, config);
} catch (final IOException e) { }catch(final IOException e){
logger.error("Error saving BetterControls configuration file!", e); logger.error("Error saving BetterControls configuration file!", e);
} }
} }
static BetterControlsConfig deserialize(final Path path) { static BetterControlsConfig deserialize(final Path path){
try (final JsonReader jsonReader = new JsonReader(Files.newBufferedReader(path, StandardCharsets.UTF_8))) { try(final JsonReader jsonReader = new JsonReader(Files.newBufferedReader(path, StandardCharsets.UTF_8))){
return gson.getAdapter(BetterControlsConfig.class).read(jsonReader); return gson.getAdapter(BetterControlsConfig.class).read(jsonReader);
} catch (final FileNotFoundException | NoSuchFileException ignored) { }catch(final FileNotFoundException | NoSuchFileException ignored){
} catch (final IOException e) { }catch(final IOException e){
logger.error("Error reading BetterControls configuration file!", e); logger.error("Error reading BetterControls configuration file!", e);
} }

View File

@@ -1,47 +1,45 @@
package chylex.bettercontrols.config; package chylex.bettercontrols.config;
import chylex.bettercontrols.input.KeyBindingWithModifier; import chylex.bettercontrols.input.KeyBindingWithModifier;
import chylex.bettercontrols.input.ModifierKey; import chylex.bettercontrols.input.ModifierKey;
import chylex.bettercontrols.util.Key;
import com.google.gson.JsonObject; import com.google.gson.JsonObject;
import com.mojang.blaze3d.platform.InputConstants;
final class Json { final class Json{
private Json() {} private Json(){}
static void setFloat(final JsonObject obj, final String key, final float value) { static void setFloat(final JsonObject obj, final String key, final float value){
obj.addProperty(key, Float.valueOf(value)); obj.addProperty(key, Float.valueOf(value));
} }
static float getFloat(final JsonObject obj, final String key, final float defaultValue, final float minValue, final float maxValue) { static float getFloat(final JsonObject obj, final String key, final float defaultValue, final float minValue, final float maxValue){
final float value = obj.has(key) ? obj.get(key).getAsFloat() : defaultValue; final float value = obj.has(key) ? obj.get(key).getAsFloat() : defaultValue;
return Math.max(minValue, Math.min(maxValue, value)); return Math.max(minValue, Math.min(maxValue, value));
} }
static void setBool(final JsonObject obj, final String key, final boolean value) { static void setBool(final JsonObject obj, final String key, final boolean value){
obj.addProperty(key, Boolean.valueOf(value)); obj.addProperty(key, Boolean.valueOf(value));
} }
static boolean getBool(final JsonObject obj, final String key, final boolean defaultValue) { static boolean getBool(final JsonObject obj, final String key, final boolean defaultValue){
return obj.has(key) ? obj.get(key).getAsBoolean() : defaultValue; return obj.has(key) ? obj.get(key).getAsBoolean() : defaultValue;
} }
@SuppressWarnings("SameParameterValue") static <T extends Enum<T>> void setEnum(final JsonObject obj, final String key, final T value){
static <T extends Enum<T>> void setEnum(final JsonObject obj, final String key, final T value) {
obj.addProperty(key, value.name()); obj.addProperty(key, value.name());
} }
@SuppressWarnings("SameParameterValue") static <T extends Enum<T>> T getEnum(final JsonObject obj, final String key, final T defaultValue, final Class<T> enumClass){
static <T extends Enum<T>> T getEnum(final JsonObject obj, final String key, final T defaultValue, final Class<T> enumClass) { if (!obj.has(key)){
if (!obj.has(key)) {
return defaultValue; return defaultValue;
} }
final T[] constants = enumClass.getEnumConstants(); final T[] constants = enumClass.getEnumConstants();
if (constants != null) { if (constants != null){
final String value = obj.get(key).getAsString(); final String value = obj.get(key).getAsString();
for (final T constant : constants) { for(final T constant : constants){
if (constant.name().equalsIgnoreCase(value)) { if (constant.name().equalsIgnoreCase(value)){
return constant; return constant;
} }
} }
@@ -53,24 +51,20 @@ final class Json {
private static final String KEY_SUFFIX = ".Key"; private static final String KEY_SUFFIX = ".Key";
private static final String MOD_SUFFIX = ".Mod"; private static final String MOD_SUFFIX = ".Mod";
static void writeKeyBinding(final JsonObject obj, final String key, final KeyBindingWithModifier keyBinding) { static void writeKeyBinding(final JsonObject obj, final String key, final KeyBindingWithModifier keyBinding){
obj.addProperty(key + KEY_SUFFIX, keyBinding.saveString()); obj.addProperty(key + KEY_SUFFIX, Key.writeBinding(keyBinding));
if (keyBinding.getModifier() != null) { if (keyBinding.getModifier() != null){
obj.addProperty(key + MOD_SUFFIX, Integer.valueOf(keyBinding.getModifier().id)); obj.addProperty(key + MOD_SUFFIX, Integer.valueOf(keyBinding.getModifier().id));
} }
} }
static void readKeyBinding(final JsonObject obj, final String key, final KeyBindingWithModifier keyBinding) { static void readKeyBinding(final JsonObject obj, final String key, final KeyBindingWithModifier keyBinding){
if (obj.has(key + KEY_SUFFIX)) { if (obj.has(key + KEY_SUFFIX)){
try { Key.readBinding(keyBinding, obj.get(key + KEY_SUFFIX).getAsString());
keyBinding.setKey(InputConstants.getKey(obj.get(key + KEY_SUFFIX).getAsString()));
} catch (final IllegalArgumentException e) {
e.printStackTrace(); // let's not crash if the config file has garbage, okay?
}
} }
if (obj.has(key + MOD_SUFFIX)) { if (obj.has(key + MOD_SUFFIX)){
keyBinding.setModifier(ModifierKey.getById(obj.get(key + MOD_SUFFIX).getAsInt())); keyBinding.setModifier(ModifierKey.getById(obj.get(key + MOD_SUFFIX).getAsInt()));
} }
} }

View File

@@ -1,6 +1,8 @@
package chylex.bettercontrols.gui; package chylex.bettercontrols.gui;
import chylex.bettercontrols.BetterControlsCommon; import chylex.bettercontrols.BetterControlsMod;
import chylex.bettercontrols.config.BetterControlsConfig; import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.gui.elements.BooleanValueWidget;
import chylex.bettercontrols.gui.elements.CycleButtonWidget;
import chylex.bettercontrols.gui.elements.DiscreteValueSliderWidget; import chylex.bettercontrols.gui.elements.DiscreteValueSliderWidget;
import chylex.bettercontrols.gui.elements.KeyBindingWidget; import chylex.bettercontrols.gui.elements.KeyBindingWidget;
import chylex.bettercontrols.gui.elements.Option; import chylex.bettercontrols.gui.elements.Option;
@@ -8,40 +10,30 @@ import chylex.bettercontrols.gui.elements.TextWidget;
import chylex.bettercontrols.input.KeyBindingWithModifier; import chylex.bettercontrols.input.KeyBindingWithModifier;
import chylex.bettercontrols.input.ModifierKey; import chylex.bettercontrols.input.ModifierKey;
import chylex.bettercontrols.input.SprintMode; import chylex.bettercontrols.input.SprintMode;
import com.google.common.collect.ImmutableList; import chylex.bettercontrols.util.Key;
import com.mojang.blaze3d.platform.InputConstants; import chylex.bettercontrols.util.LiteralText;
import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.gui.Element;
import it.unimi.dsi.fastutil.booleans.BooleanConsumer; import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.KeyMapping; import net.minecraft.client.gui.screen.options.GameOptionsScreen;
import net.minecraft.client.Minecraft; import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.gui.components.Button; import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.gui.components.CycleButton; import net.minecraft.client.resource.language.I18n;
import net.minecraft.client.gui.components.events.GuiEventListener; import net.minecraft.client.util.InputUtil;
import net.minecraft.client.gui.screens.OptionsSubScreen;
import net.minecraft.client.gui.screens.Screen;
import net.minecraft.network.chat.CommonComponents;
import net.minecraft.network.chat.Component;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.lwjgl.glfw.GLFW; import org.lwjgl.glfw.GLFW;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
import java.util.function.Consumer;
import static chylex.bettercontrols.gui.OptionListWidget.COL2_W; import static chylex.bettercontrols.gui.OptionListWidget.COL2_W;
import static chylex.bettercontrols.gui.OptionListWidget.COL4_W; import static chylex.bettercontrols.gui.OptionListWidget.COL4_W;
import static chylex.bettercontrols.gui.OptionListWidget.ROW_WIDTH; import static chylex.bettercontrols.gui.OptionListWidget.ROW_WIDTH;
import static chylex.bettercontrols.gui.OptionListWidget.col2; import static chylex.bettercontrols.gui.OptionListWidget.col2;
import static chylex.bettercontrols.gui.OptionListWidget.col4; import static chylex.bettercontrols.gui.OptionListWidget.col4;
import static chylex.bettercontrols.gui.elements.TextWidget.CENTER; import static chylex.bettercontrols.gui.elements.TextWidget.CENTER;
import static net.minecraft.network.chat.Component.literal; import static chylex.bettercontrols.util.LiteralText.text;
import static chylex.bettercontrols.util.Statics.OPTIONS;
public class BetterControlsScreen extends OptionsSubScreen { public class BetterControlsScreen extends GameOptionsScreen{
private static Component text(final String text) { public static final LiteralText TITLE = text("Better Controls");
return literal(text);
}
public static final Component TITLE = text("Better Controls");
private static final int BOTTOM_PADDING = 3; private static final int BOTTOM_PADDING = 3;
private static final int TEXT_PADDING_RIGHT = 4; private static final int TEXT_PADDING_RIGHT = 4;
@@ -56,40 +48,49 @@ public class BetterControlsScreen extends OptionsSubScreen {
// Options // Options
private int generateSprintingOptions(int y, final List<GuiEventListener> elements) { private int generateSprintingOptions(int y, final List<Element> elements){
final BetterControlsConfig cfg = BetterControlsCommon.getConfig(); final BetterControlsConfig cfg = BetterControlsMod.config;
generateKeyBindingWithModifierOption(y, elements, text("Toggle Sprint"), cfg.keyToggleSprint);
generateKeyBindingWithModifierRow(y, elements, text("Toggle Sprint"), cfg.keyToggleSprint);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateCycleOptionRow(y, elements, text("Sprint Key Mode"), SPRINT_MODE_OPTIONS, cfg.sprintMode, value -> cfg.sprintMode = value); generateLeftSideText(y, elements, text("Sprint Key Mode"));
elements.add(new CycleButtonWidget<>(col2(1), y, COL2_W, SPRINT_MODE_OPTIONS, cfg.sprintMode, value -> cfg.sprintMode = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateBooleanOptionRow(y, elements, text("Double Tap 'Walk Forwards' To Sprint"), cfg.doubleTapForwardToSprint, value -> cfg.doubleTapForwardToSprint = value); generateLeftSideText(y, elements, text("Double Tap 'Walk Forwards' To Sprint"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.doubleTapForwardToSprint, value -> cfg.doubleTapForwardToSprint = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateBooleanOptionRow(y, elements, text("Resume Sprinting After Hitting Obstacle"), cfg.resumeSprintingAfterHittingObstacle, value -> cfg.resumeSprintingAfterHittingObstacle = value); generateLeftSideText(y, elements, text("Resume Sprinting After Hitting Obstacle"));
y += ROW_HEIGHT; elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.resumeSprintingAfterHittingObstacle, value -> cfg.resumeSprintingAfterHittingObstacle = value));
y += ROW_HEIGHT;
return y; return y;
} }
private int generateSneakingOptions(int y, final List<GuiEventListener> elements) { private int generateSneakingOptions(int y, final List<Element> elements){
final BetterControlsConfig cfg = BetterControlsCommon.getConfig(); final BetterControlsConfig cfg = BetterControlsMod.config;
generateKeyBindingWithModifierOption(y, elements, text("Toggle Sneak"), cfg.keyToggleSneak);
generateKeyBindingWithModifierRow(y, elements, text("Toggle Sneak"), cfg.keyToggleSneak);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateBooleanOptionRow(y, elements, text("Move Camera Smoothly"), cfg.sneakingMovesCameraSmoothly, value -> cfg.sneakingMovesCameraSmoothly = value); generateLeftSideText(y, elements, text("Move Camera Smoothly"));
y += ROW_HEIGHT; elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.sneakingMovesCameraSmoothly, value -> cfg.sneakingMovesCameraSmoothly = value));
y += ROW_HEIGHT;
return y; return y;
} }
private int generateFlightOptions(int y, final List<GuiEventListener> elements) { @SuppressWarnings({ "AutoBoxing", "AutoUnboxing" })
final BetterControlsConfig cfg = BetterControlsCommon.getConfig(); private int generateFlightOptions(int y, final List<Element> elements){
final BetterControlsConfig cfg = BetterControlsMod.config;
final ImmutableList<Option<Float>> flightSpeedOptions = ImmutableList.of( final List<Option<Float>> flightSpeedOptions = Arrays.asList(
new Option<>(Float.valueOf(0.25F), text("0.25x")), new Option<>(Float.valueOf(0.25F), text("0.25x")),
new Option<>(Float.valueOf(0.50F), text("0.5x")), new Option<>(Float.valueOf(0.50F), text("0.5x")),
new Option<>(Float.valueOf(0.75F), text("0.75x")), new Option<>(Float.valueOf(0.75F), text("0.75x")),
@@ -104,7 +105,7 @@ public class BetterControlsScreen extends OptionsSubScreen {
new Option<>(Float.valueOf(8.00F), text("8x")) new Option<>(Float.valueOf(8.00F), text("8x"))
); );
final ImmutableList<Option<Float>> flightVerticalBoostOptions = ImmutableList.of( final List<Option<Float>> flightVerticalBoostOptions = Arrays.asList(
new Option<>(Float.valueOf(0.00F), text("None")), new Option<>(Float.valueOf(0.00F), text("None")),
new Option<>(Float.valueOf(0.25F), text("+25%")), new Option<>(Float.valueOf(0.25F), text("+25%")),
new Option<>(Float.valueOf(0.50F), text("+50%")), new Option<>(Float.valueOf(0.50F), text("+50%")),
@@ -116,64 +117,79 @@ public class BetterControlsScreen extends OptionsSubScreen {
new Option<>(Float.valueOf(3.00F), text("+300%")) new Option<>(Float.valueOf(3.00F), text("+300%"))
); );
generateKeyBindingWithModifierRow(y, elements, text("Toggle Flight (Creative)"), cfg.keyToggleFlight); generateKeyBindingWithModifierOption(y, elements, text("Toggle Flight (Creative)"), cfg.keyToggleFlight);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateBooleanOptionRow(y, elements, text("Double Tap 'Jump' To Fly (Creative)"), cfg.doubleTapJumpToToggleFlight, value -> cfg.doubleTapJumpToToggleFlight = value); generateLeftSideText(y, elements, text("Double Tap 'Jump' To Fly (Creative)"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.doubleTapJumpToToggleFlight, value -> cfg.doubleTapJumpToToggleFlight = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateBooleanOptionRow(y, elements, text("Disable Flight Inertia"), cfg.disableFlightInertia, value -> cfg.disableFlightInertia = value); generateLeftSideText(y, elements, text("Disable Flight Inertia"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.disableFlightInertia, value -> cfg.disableFlightInertia = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateBooleanOptionRow(y, elements, text("Disable Field Of View Changing"), cfg.disableChangingFovWhileFlying, value -> cfg.disableChangingFovWhileFlying = value); generateLeftSideText(y, elements, text("Disable Field Of View Changing"));
elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.disableChangingFovWhileFlying, value -> cfg.disableChangingFovWhileFlying = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateBooleanOptionRow(y, elements, text("Fly On Ground (Creative Mode)"), cfg.flyOnGroundInCreative, value -> cfg.flyOnGroundInCreative = value); generateLeftSideText(y, elements, text("Fly On Ground (Creative Mode)"));
y += ROW_HEIGHT; elements.add(new BooleanValueWidget(col2(1), y, COL2_W, cfg.flyOnGroundInCreative, value -> cfg.flyOnGroundInCreative = value));
y += ROW_HEIGHT * 4 / 3;
y += ROW_HEIGHT / 3;
elements.add(new TextWidget(col4(2), y, COL4_W - TEXT_PADDING_RIGHT, text("Creative"), CENTER)); elements.add(new TextWidget(col4(2), y, COL4_W - TEXT_PADDING_RIGHT, text("Creative"), CENTER));
elements.add(new TextWidget(col4(3), y, COL4_W - TEXT_PADDING_RIGHT, text("Spectator"), CENTER)); elements.add(new TextWidget(col4(3), y, COL4_W - TEXT_PADDING_RIGHT, text("Spectator"), CENTER));
y += ROW_HEIGHT * 7 / 8; y += ROW_HEIGHT * 7 / 8;
generateLeftSideText(y, elements, text("Speed Multiplier (Default)")); generateLeftSideText(y, elements, text("Speed Multiplier (Default)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Speed Multiplier in Creative Mode"), flightSpeedOptions, cfg.flightSpeedMpCreativeDefault, value -> cfg.flightSpeedMpCreativeDefault = value)); elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpCreativeDefault, value -> cfg.flightSpeedMpCreativeDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Speed Multiplier in Spectator Mode"), flightSpeedOptions, cfg.flightSpeedMpSpectatorDefault, value -> cfg.flightSpeedMpSpectatorDefault = value)); elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpSpectatorDefault, value -> cfg.flightSpeedMpSpectatorDefault = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Speed Multiplier (Sprinting)")); generateLeftSideText(y, elements, text("Speed Multiplier (Sprinting)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Speed Multiplier when Sprinting in Creative Mode"), flightSpeedOptions, cfg.flightSpeedMpCreativeSprinting, value -> cfg.flightSpeedMpCreativeSprinting = value)); elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpCreativeSprinting, value -> cfg.flightSpeedMpCreativeSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Speed Multiplier when Sprinting in Spectator Mode"), flightSpeedOptions, cfg.flightSpeedMpSpectatorSprinting, value -> cfg.flightSpeedMpSpectatorSprinting = value)); elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightSpeedOptions, cfg.flightSpeedMpSpectatorSprinting, value -> cfg.flightSpeedMpSpectatorSprinting = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Vertical Speed Boost (Default)")); generateLeftSideText(y, elements, text("Vertical Speed Boost (Default)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Vertical Speed Boost in Creative Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeDefault, value -> cfg.flightVerticalBoostCreativeDefault = value)); elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeDefault, value -> cfg.flightVerticalBoostCreativeDefault = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Vertical Speed Boost in Spectator Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorDefault, value -> cfg.flightVerticalBoostSpectatorDefault = value)); elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorDefault, value -> cfg.flightVerticalBoostSpectatorDefault = value));
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateLeftSideText(y, elements, text("Vertical Speed Boost (Sprinting)")); generateLeftSideText(y, elements, text("Vertical Speed Boost (Sprinting)"));
elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, text("Vertical Speed Boost when Sprinting in Creative Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeSprinting, value -> cfg.flightVerticalBoostCreativeSprinting = value)); elements.add(new DiscreteValueSliderWidget<>(col4(2), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostCreativeSprinting, value -> cfg.flightVerticalBoostCreativeSprinting = value));
elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, text("Vertical Speed Boost when Sprinting in Spectator Mode"), flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorSprinting, value -> cfg.flightVerticalBoostSpectatorSprinting = value)); elements.add(new DiscreteValueSliderWidget<>(col4(3), y, COL4_W, flightVerticalBoostOptions, cfg.flightVerticalBoostSpectatorSprinting, value -> cfg.flightVerticalBoostSpectatorSprinting = value));
y += ROW_HEIGHT;
y += ROW_HEIGHT;
return y; return y;
} }
private int generateMiscellaneousOptions(int y, final List<GuiEventListener> elements) { private int generateMiscellaneousOptions(int y, final List<Element> elements){
final BetterControlsConfig cfg = BetterControlsCommon.getConfig(); final BetterControlsConfig cfg = BetterControlsMod.config;
generateKeyBindingWithModifierOption(y, elements, text("Toggle Walk Forwards"), cfg.keyToggleWalkForward);
generateKeyBindingWithModifierRow(y, elements, text("Toggle Walk Forwards"), cfg.keyToggleWalkForward);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateKeyBindingWithModifierRow(y, elements, text("Toggle Jump"), cfg.keyToggleJump); generateKeyBindingWithModifierOption(y, elements, text("Toggle Jump"), cfg.keyToggleJump);
y += ROW_HEIGHT; y += ROW_HEIGHT;
generateKeyBindingWithModifierRow(y, elements, text("Reset All Toggles"), cfg.keyResetAllToggles); generateKeyBindingWithModifierOption(y, elements, text("Reset All Toggles"), cfg.keyResetAllToggles);
y += ROW_HEIGHT * 4 / 3; y += ROW_HEIGHT * 4 / 3;
generateKeyBindingWithModifierRow(y, elements, text("Open Better Controls Menu"), cfg.keyOpenMenu); generateKeyBindingWithModifierOption(y, elements, text("Open Better Controls Menu"), cfg.keyOpenMenu);
y += ROW_HEIGHT;
y += ROW_HEIGHT;
return y; return y;
} }
@@ -186,9 +202,9 @@ public class BetterControlsScreen extends OptionsSubScreen {
new Option<>(ModifierKey.ALT, text("Alt")) new Option<>(ModifierKey.ALT, text("Alt"))
); );
private void generateKeyBindingWithModifierRow(final int y, final List<GuiEventListener> elements, final Component text, final KeyBindingWithModifier binding) { private void generateKeyBindingWithModifierOption(final int y, final List<Element> elements, final LiteralText text, final KeyBindingWithModifier binding){
final var modifierButton = Option.button(col4(2), y, COL4_W, text.plainCopy().append(" Modifier"), MODIFIER_OPTIONS, binding.getModifier(), binding::setModifier); final CycleButtonWidget<ModifierKey> modifierButton = new CycleButtonWidget<>(col4(2), y, COL4_W, MODIFIER_OPTIONS, binding.getModifier(), binding::setModifier);
final var bindingButton = new KeyBindingWidget(col4(3), y, COL4_W, text, binding, this::startEditingKeyBinding); final KeyBindingWidget bindingButton = new KeyBindingWidget(col4(3), y, COL4_W, binding, this::startEditingKeyBinding);
bindingButton.linkButtonToBoundState(modifierButton); bindingButton.linkButtonToBoundState(modifierButton);
generateLeftSideText(y, elements, text); generateLeftSideText(y, elements, text);
@@ -197,20 +213,7 @@ public class BetterControlsScreen extends OptionsSubScreen {
allKeyBindings.add(bindingButton); allKeyBindings.add(bindingButton);
} }
private static <T> void generateCycleOptionRow(final int y, final List<GuiEventListener> elements, final Component text, final List<Option<T>> options, final T initialValue, final Consumer<T> onValueChanged) { private static void generateLeftSideText(final int y, final List<Element> elements, final LiteralText text){
generateLeftSideText(y, elements, text);
elements.add(Option.button(col2(1), y, COL2_W, text, options, initialValue, onValueChanged));
}
private static void generateBooleanOptionRow(final int y, final List<GuiEventListener> elements, final Component text, final boolean initialValue, final BooleanConsumer onValueChanged) {
generateLeftSideText(y, elements, text);
elements.add(CycleButton.onOffBuilder()
.displayOnlyValue()
.withInitialValue(Boolean.valueOf(initialValue))
.create(col2(1), y, COL2_W, 20, text, (btn, newValue) -> onValueChanged.accept(newValue.booleanValue())));
}
private static void generateLeftSideText(final int y, final List<GuiEventListener> elements, final Component text) {
elements.add(new TextWidget(col2(0), y, COL2_W - TEXT_PADDING_RIGHT, text)); elements.add(new TextWidget(col2(0), y, COL2_W - TEXT_PADDING_RIGHT, text));
} }
@@ -220,16 +223,15 @@ public class BetterControlsScreen extends OptionsSubScreen {
private KeyBindingWidget editingKeyBinding; private KeyBindingWidget editingKeyBinding;
private final List<KeyBindingWidget> allKeyBindings = new ArrayList<>(); private final List<KeyBindingWidget> allKeyBindings = new ArrayList<>();
@SuppressWarnings("DataFlowIssue") public BetterControlsScreen(final Screen parentScreen){
public BetterControlsScreen(@Nullable final Screen parentScreen) { super(parentScreen, OPTIONS, TITLE);
super(parentScreen, Minecraft.getInstance().options, TITLE);
} }
@Override @Override
public void init() { public void init(){
allKeyBindings.clear(); allKeyBindings.clear();
final List<GuiEventListener> elements = new ArrayList<>(); final List<Element> elements = new ArrayList<>();
int y = 0; int y = 0;
elements.add(new TextWidget(0, y, ROW_WIDTH, ROW_HEIGHT, text("Sprinting"), CENTER)); elements.add(new TextWidget(0, y, ROW_WIDTH, ROW_HEIGHT, text("Sprinting"), CENTER));
@@ -244,27 +246,25 @@ public class BetterControlsScreen extends OptionsSubScreen {
elements.add(new TextWidget(0, y, ROW_WIDTH, ROW_HEIGHT, text("Miscellaneous"), CENTER)); elements.add(new TextWidget(0, y, ROW_WIDTH, ROW_HEIGHT, text("Miscellaneous"), CENTER));
y = generateMiscellaneousOptions(y + ROW_HEIGHT, elements) + TITLE_MARGIN_TOP; y = generateMiscellaneousOptions(y + ROW_HEIGHT, elements) + TITLE_MARGIN_TOP;
//noinspection DataFlowIssue addButton(new ButtonWidget(width / 2 - 99, height - 29, 200, 20, I18n.translate("gui.done"), btn -> minecraft.openScreen(parent)));
addRenderableWidget(Button.builder(CommonComponents.GUI_DONE, btn -> minecraft.setScreen(lastScreen)).pos(width / 2 - 99, height - 29).size(200, 20).build()); children.add(optionsWidget = new OptionListWidget(21, height - 32, width, height, elements, y - TITLE_MARGIN_TOP + BOTTOM_PADDING));
addWidget(optionsWidget = new OptionListWidget(21, height - 32, width, height, elements, y - TITLE_MARGIN_TOP + BOTTOM_PADDING));
} }
@Override @Override
public void removed() { public void removed(){
BetterControlsCommon.getConfig().save(); BetterControlsMod.config.save();
} }
@Override @Override
public void render(final @NotNull PoseStack matrices, final int mouseX, final int mouseY, final float delta) { public void render(final int mouseX, final int mouseY, final float delta){
renderBackground(matrices); renderBackground();
optionsWidget.render(matrices, mouseX, mouseY, delta); optionsWidget.render(mouseX, mouseY, delta);
drawCenteredString(matrices, font, title, width / 2, 8, (255 << 16) | (255 << 8) | 255); drawCenteredString(font, title.asFormattedString(), width / 2, 8, (255 << 16) | (255 << 8) | 255);
super.render(matrices, mouseX, mouseY, delta); super.render(mouseX, mouseY, delta);
} }
private void startEditingKeyBinding(final KeyBindingWidget widget) { private void startEditingKeyBinding(final KeyBindingWidget widget){
if (editingKeyBinding != null) { if (editingKeyBinding != null){
editingKeyBinding.stopEditing(); editingKeyBinding.stopEditing();
} }
@@ -272,40 +272,40 @@ public class BetterControlsScreen extends OptionsSubScreen {
} }
@Override @Override
public boolean mouseClicked(final double mouseX, final double mouseY, final int button) { public boolean mouseClicked(final double mouseX, final double mouseY, final int button){
if (editingKeyBinding != null) { if (editingKeyBinding != null){
editingKeyBinding.bindAndStopEditing(InputConstants.Type.MOUSE.getOrCreate(button)); editingKeyBinding.bindAndStopEditing(Key.inputFromMouse(button));
onKeyBindingEditingFinished(); onKeyBindingEditingFinished();
return true; return true;
} }
else { else{
return super.mouseClicked(mouseX, mouseY, button); return super.mouseClicked(mouseX, mouseY, button);
} }
} }
@Override @Override
public boolean keyPressed(final int keyCode, final int scanCode, final int modifiers) { public boolean keyPressed(final int keyCode, final int scanCode, final int modifiers){
if (editingKeyBinding != null) { if (editingKeyBinding != null){
if (keyCode == GLFW.GLFW_KEY_ESCAPE) { if (keyCode == GLFW.GLFW_KEY_ESCAPE){
editingKeyBinding.bindAndStopEditing(InputConstants.UNKNOWN); editingKeyBinding.bindAndStopEditing(Key.INVALID);
} }
else { else{
editingKeyBinding.bindAndStopEditing(InputConstants.getKey(keyCode, scanCode)); editingKeyBinding.bindAndStopEditing(Key.inputFromKeyboard(keyCode, scanCode));
} }
onKeyBindingEditingFinished(); onKeyBindingEditingFinished();
return true; return true;
} }
else { else{
return super.keyPressed(keyCode, scanCode, modifiers); return super.keyPressed(keyCode, scanCode, modifiers);
} }
} }
private void onKeyBindingEditingFinished() { private void onKeyBindingEditingFinished(){
editingKeyBinding = null; editingKeyBinding = null;
KeyMapping.resetMapping(); KeyBinding.updateKeysByCode();
for (final KeyBindingWidget widget : allKeyBindings) { for(final KeyBindingWidget widget : allKeyBindings){
widget.updateKeyBindingText(); widget.updateKeyBindingText();
} }
} }

View File

@@ -1,115 +1,113 @@
package chylex.bettercontrols.gui; package chylex.bettercontrols.gui;
import chylex.bettercontrols.gui.OptionListWidget.Entry; import chylex.bettercontrols.gui.OptionListWidget.Entry;
import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.gui.Drawable;
import net.minecraft.client.Minecraft; import net.minecraft.client.gui.Element;
import net.minecraft.client.gui.components.AbstractWidget; import net.minecraft.client.gui.widget.AbstractButtonWidget;
import net.minecraft.client.gui.components.ContainerObjectSelectionList; import net.minecraft.client.gui.widget.ElementListWidget;
import net.minecraft.client.gui.components.Renderable;
import net.minecraft.client.gui.components.events.GuiEventListener;
import net.minecraft.client.gui.narration.NarratableEntry;
import org.jetbrains.annotations.NotNull;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collections; import java.util.Collections;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.function.Function; import java.util.function.Function;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
public final class OptionListWidget extends ContainerObjectSelectionList<Entry> { public final class OptionListWidget extends ElementListWidget<Entry>{
public static final int ROW_WIDTH = 408; public static final int ROW_WIDTH = 408;
public static final int ROW_PADDING = 2; public static final int ROW_PADDING = 2;
public static final int COL2_W = (ROW_WIDTH / 2) - ROW_PADDING; public static final int COL2_W = (ROW_WIDTH / 2) - ROW_PADDING;
public static final int COL4_W = (ROW_WIDTH / 4) - ROW_PADDING; public static final int COL4_W = (ROW_WIDTH / 4) - ROW_PADDING;
public static int col2(final int column) { public static int col2(final int column){
return (column * ROW_WIDTH) / 2; return (column * ROW_WIDTH) / 2;
} }
public static int col4(final int column) { public static int col4(final int column){
return (column * ROW_WIDTH) / 4; return (column * ROW_WIDTH) / 4;
} }
private static Offset getElementOffset(final GuiEventListener element) { private static Offset getElementOffset(final Element element){
if (element instanceof final OptionWidget widget) { if (element instanceof Widget){
return new Offset(widget.getX(), widget.getY()); return new Offset(((Widget)element).getX(), ((Widget)element).getY());
} }
else if (element instanceof final AbstractWidget widget) { else if (element instanceof AbstractButtonWidget){
return new Offset(widget.getX(), widget.getY()); return new Offset(((AbstractButtonWidget)element).x, ((AbstractButtonWidget)element).y);
} }
else { else{
return new Offset(0, 0); return new Offset(0, 0);
} }
} }
public interface OptionWidget extends GuiEventListener, Renderable { public interface Widget extends Element, Drawable{
int getX(); int getX();
int getY(); int getY();
void setX(int x); void setX(int x);
void setY(int y); void setY(int y);
} }
private record Offset(int x, int y) {} private static final class Offset{
public final int x;
public final int y;
private Offset(final int x, final int y){
this.x = x;
this.y = y;
}
}
public OptionListWidget(final int top, final int bottom, final int width, final int height, final List<GuiEventListener> widgets, final int innerHeight) { public OptionListWidget(final int top, final int bottom, final int width, final int height, final List<Element> widgets, final int innerHeight){
super(Minecraft.getInstance(), width, height, top, bottom, innerHeight); super(MINECRAFT, width, height, top, bottom, innerHeight);
addEntry(new Entry(widgets)); addEntry(new Entry(widgets));
} }
@Override @Override
public int getRowLeft() { protected int getRowLeft(){
return super.getRowLeft() - ROW_PADDING; return super.getRowLeft() - ROW_PADDING;
} }
@Override @Override
public int getRowWidth() { public int getRowWidth(){
return ROW_WIDTH; return ROW_WIDTH;
} }
@Override @Override
protected int getScrollbarPosition() { protected int getScrollbarPosition(){
return (width + ROW_WIDTH) / 2 + 4; return (width + ROW_WIDTH) / 2 + 4;
} }
protected static final class Entry extends ContainerObjectSelectionList.Entry<Entry> { protected static final class Entry extends ElementListWidget.Entry<Entry>{
private final List<GuiEventListener> elements; private final List<Element> elements;
private final List<NarratableEntry> narratables; private final Map<Element, Offset> offsets;
private final Map<GuiEventListener, Offset> offsets;
public Entry(final List<GuiEventListener> elements) { public Entry(final List<Element> elements){
this.elements = new ArrayList<>(elements); this.elements = new ArrayList<>(elements);
this.narratables = elements.stream().filter(e -> e instanceof NarratableEntry).map(e -> (NarratableEntry)e).collect(Collectors.toList());
this.offsets = elements.stream().collect(Collectors.toMap(Function.identity(), OptionListWidget::getElementOffset)); this.offsets = elements.stream().collect(Collectors.toMap(Function.identity(), OptionListWidget::getElementOffset));
} }
@NotNull
@Override @Override
public List<? extends GuiEventListener> children() { public List<? extends Element> children(){
return Collections.unmodifiableList(elements); return Collections.unmodifiableList(elements);
} }
@NotNull
@Override @Override
public List<? extends NarratableEntry> narratables() { public void render(final int index, final int y, final int x, final int entryWidth, final int entryHeight, final int mouseX, final int mouseY, final boolean hovered, final float tickDelta){
return Collections.unmodifiableList(narratables); for(final Element element : elements){
}
@Override
public void render(final @NotNull PoseStack matrices, final int index, final int y, final int x, final int entryWidth, final int entryHeight, final int mouseX, final int mouseY, final boolean hovered, final float tickDelta) {
for (final GuiEventListener element : elements) {
final Offset offset = offsets.get(element); final Offset offset = offsets.get(element);
if (element instanceof final AbstractWidget widget) { if (element instanceof AbstractButtonWidget){
widget.setX(x + offset.x); final AbstractButtonWidget button = (AbstractButtonWidget)element;
widget.setY(y + offset.y); button.x = x + offset.x;
button.y = y + offset.y;
} }
else if (element instanceof final OptionWidget widget) { else if (element instanceof Widget){
final Widget widget = (Widget)element;
widget.setX(x + offset.x); widget.setX(x + offset.x);
widget.setY(y + offset.y); widget.setY(y + offset.y);
} }
if (element instanceof final Renderable renderable) { if (element instanceof Drawable){
renderable.render(matrices, mouseX, mouseY, tickDelta); ((Drawable)element).render(mouseX, mouseY, tickDelta);
} }
} }
} }

View File

@@ -0,0 +1,63 @@
package chylex.bettercontrols.gui;
import chylex.bettercontrols.mixin.AccessOptionButtonWidgetOption;
import chylex.bettercontrols.mixin.AccessScreenButtons;
import net.minecraft.client.gui.Element;
import net.minecraft.client.gui.ParentElement;
import net.minecraft.client.gui.screen.options.AccessibilityScreen;
import net.minecraft.client.gui.screen.options.ControlsOptionsScreen;
import net.minecraft.client.gui.widget.AbstractButtonWidget;
import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.gui.widget.OptionButtonWidget;
import net.minecraft.client.options.Option;
import java.util.List;
import java.util.function.Consumer;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
public final class ScreenPatcher{
private ScreenPatcher(){}
public static void onControlsScreenOpened(final ControlsOptionsScreen screen){
final AccessScreenButtons accessor = (AccessScreenButtons)screen;
final List<? extends Element> children = screen.children();
final List<AbstractButtonWidget> buttons = accessor.getButtons();
final AbstractButtonWidget autoJump = buttons
.stream()
.filter(it -> it instanceof OptionButtonWidget && ((AccessOptionButtonWidgetOption)it).getOption() == Option.AUTO_JUMP)
.findAny()
.orElse(null);
if (autoJump != null){
children.remove(autoJump);
buttons.remove(autoJump);
accessor.callAddButton(new ButtonWidget(autoJump.x, autoJump.y, autoJump.getWidth(), 20, BetterControlsScreen.TITLE.copy().append("...").asFormattedString(), btn -> {
MINECRAFT.openScreen(new BetterControlsScreen(screen));
}));
}
}
public static void onAccessibilityScreenOpened(final AccessibilityScreen screen){
walkChildren(screen.children(), it -> {
if (it instanceof OptionButtonWidget){
final OptionButtonWidget button = (OptionButtonWidget)it;
final Option option = ((AccessOptionButtonWidgetOption)button).getOption();
if (option == Option.SPRINT_TOGGLED || option == Option.SNEAK_TOGGLED){
button.active = false;
}
}
});
}
private static void walkChildren(final List<? extends Element> elements, final Consumer<Element> callback){
for(final Element element : elements){
callback.accept(element);
if (element instanceof ParentElement){
walkChildren(((ParentElement)element).children(), callback);
}
}
}
}

View File

@@ -0,0 +1,27 @@
package chylex.bettercontrols.gui.elements;
import it.unimi.dsi.fastutil.booleans.BooleanConsumer;
import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.resource.language.I18n;
public final class BooleanValueWidget extends ButtonWidget{
private final BooleanConsumer onChanged;
private boolean value;
public BooleanValueWidget(final int x, final int y, final int width, final int height, final boolean currentValue, final BooleanConsumer onChanged){
super(x, y, width, height, I18n.translate(currentValue ? "options.on" : "options.off"), ignore -> {});
this.value = currentValue;
this.onChanged = onChanged;
}
public BooleanValueWidget(final int x, final int y, final int width, final boolean currentValue, final BooleanConsumer onChanged){
this(x, y, width, 20, currentValue, onChanged);
}
@Override
public void onPress(){
super.onPress();
value = !value;
setMessage(I18n.translate(value ? "options.on" : "options.off"));
onChanged.accept(value);
}
}

View File

@@ -0,0 +1,36 @@
package chylex.bettercontrols.gui.elements;
import net.minecraft.client.gui.widget.ButtonWidget;
import java.util.List;
import java.util.function.Consumer;
public class CycleButtonWidget<T> extends ButtonWidget{
private final List<Option<T>> options;
private final Consumer<T> onChanged;
private T selectedValue;
public CycleButtonWidget(final int x, final int y, final int width, final int height, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged){
super(x, y, width, height, Option.find(options, selectedValue).getText().asFormattedString(), btn -> {});
this.options = options;
this.selectedValue = selectedValue;
this.onChanged = onChanged;
}
public CycleButtonWidget(final int x, final int y, final int width, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged){
this(x, y, width, 20, options, selectedValue, onChanged);
}
@Override
public void onPress(){
int nextIndex = options.indexOf(Option.find(options, selectedValue)) + 1;
if (nextIndex >= options.size()){
nextIndex = 0;
}
final Option<T> newSelectedOption = options.get(nextIndex);
selectedValue = newSelectedOption.getValue();
onChanged.accept(selectedValue);
setMessage(newSelectedOption.getText().asFormattedString());
}
}

View File

@@ -1,52 +1,42 @@
package chylex.bettercontrols.gui.elements; package chylex.bettercontrols.gui.elements;
import com.google.common.collect.ImmutableList; import net.minecraft.client.gui.widget.SliderWidget;
import net.minecraft.client.gui.components.AbstractSliderButton; import net.minecraft.util.math.MathHelper;
import net.minecraft.network.chat.Component; import java.util.List;
import net.minecraft.network.chat.MutableComponent;
import net.minecraft.util.Mth;
import org.jetbrains.annotations.NotNull;
import java.util.function.Consumer; import java.util.function.Consumer;
public final class DiscreteValueSliderWidget<T> extends AbstractSliderButton { public final class DiscreteValueSliderWidget<T> extends SliderWidget{
private final Component narration; private final List<Option<T>> options;
private final ImmutableList<Option<T>> options;
private final Consumer<T> onChanged; private final Consumer<T> onChanged;
private T selectedValue; private T selectedValue;
public DiscreteValueSliderWidget(final int x, final int y, final int width, final int height, final Component narration, final ImmutableList<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) { public DiscreteValueSliderWidget(final int x, final int y, final int width, final int height, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged){
super(x, y, width, height, Option.find(options, selectedValue).text(), options.indexOf(Option.find(options, selectedValue)) / (options.size() - 1.0)); super(x, y, width, height, options.indexOf(Option.find(options, selectedValue)) / (options.size() - 1.0));
this.narration = narration;
this.options = options; this.options = options;
this.selectedValue = selectedValue; this.selectedValue = selectedValue;
this.onChanged = onChanged; this.onChanged = onChanged;
updateMessage();
} }
public DiscreteValueSliderWidget(final int x, final int y, final int width, final Component narration, final ImmutableList<Option<T>> options, final T selectedValue, final Consumer<T> onChanged) { public DiscreteValueSliderWidget(final int x, final int y, final int width, final List<Option<T>> options, final T selectedValue, final Consumer<T> onChanged){
this(x, y, width, 20, narration, options, selectedValue, onChanged); this(x, y, width, 20, options, selectedValue, onChanged);
} }
public Option<T> getSelectedOption() { public Option<T> getSelectedOption(){
return options.get(Mth.floor(Mth.clampedLerp(0.0, options.size() - 1.0, value))); return options.get(MathHelper.floor(MathHelper.clampedLerp(0.0, options.size() - 1.0, value)));
} }
@Override @Override
protected void updateMessage() { protected void updateMessage(){
setMessage(getSelectedOption().text()); setMessage(getSelectedOption().getText().asFormattedString());
} }
@Override @Override
protected void applyValue() { protected void applyValue(){
final T newSelectedValue = getSelectedOption().value(); final T newSelectedValue = getSelectedOption().getValue();
if (selectedValue != newSelectedValue) { if (selectedValue != newSelectedValue){
selectedValue = newSelectedValue; selectedValue = newSelectedValue;
onChanged.accept(newSelectedValue); onChanged.accept(newSelectedValue);
} }
} }
@NotNull
@Override
protected MutableComponent createNarrationMessage() {
return Component.translatable("gui.narrate.slider", narration.plainCopy().append(" ").append(getMessage()));
}
} }

View File

@@ -1,90 +1,88 @@
package chylex.bettercontrols.gui.elements; package chylex.bettercontrols.gui.elements;
import com.mojang.blaze3d.platform.InputConstants; import chylex.bettercontrols.util.Key;
import net.minecraft.ChatFormatting; import net.minecraft.client.gui.widget.AbstractButtonWidget;
import net.minecraft.client.KeyMapping; import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.Minecraft; import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.gui.components.AbstractButton; import net.minecraft.client.resource.language.I18n;
import net.minecraft.client.gui.components.Button; import net.minecraft.client.util.InputUtil;
import net.minecraft.network.chat.Component; import net.minecraft.util.Formatting;
import net.minecraft.network.chat.MutableComponent;
import org.jetbrains.annotations.NotNull;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.function.Consumer; import java.util.function.Consumer;
import static chylex.bettercontrols.util.Statics.OPTIONS;
public final class KeyBindingWidget extends Button { public final class KeyBindingWidget extends ButtonWidget{
private final KeyMapping binding; private final KeyBinding binding;
private final Component bindingName; private final String bindingName;
private final List<AbstractButton> linkedButtons = new ArrayList<>(1); private final List<AbstractButtonWidget> linkedButtons = new ArrayList<>(1);
private final Consumer<KeyBindingWidget> onEditingStarted; private final Consumer<KeyBindingWidget> onEditingStarted;
private boolean isEditing; private boolean isEditing;
public KeyBindingWidget(final int x, final int y, final int width, final int height, final Component bindingName, final KeyMapping binding, final Consumer<KeyBindingWidget> onEditingStarted) { public KeyBindingWidget(final int x, final int y, final int width, final int height, final KeyBinding binding, final Consumer<KeyBindingWidget> onEditingStarted){
super(x, y, width, height, Component.empty(), btn -> {}, DEFAULT_NARRATION); super(x, y, width, height, "", btn -> {});
this.binding = binding; this.binding = binding;
this.bindingName = bindingName; this.bindingName = I18n.translate(binding.getId());
this.onEditingStarted = onEditingStarted; this.onEditingStarted = onEditingStarted;
updateKeyBindingText(); updateKeyBindingText();
} }
public KeyBindingWidget(final int x, final int y, final int width, final Component bindingName, final KeyMapping binding, final Consumer<KeyBindingWidget> onEditingStarted) { public KeyBindingWidget(final int x, final int y, final int width, final KeyBinding binding, final Consumer<KeyBindingWidget> onEditingStarted){
this(x, y, width, 20, bindingName, binding, onEditingStarted); this(x, y, width, 20, binding, onEditingStarted);
} }
public void linkButtonToBoundState(final AbstractButton button) { public void linkButtonToBoundState(final AbstractButtonWidget button){
linkedButtons.add(button); linkedButtons.add(button);
button.active = !binding.isUnbound(); button.active = !Key.isUnbound(binding);
}
@NotNull
@Override
protected MutableComponent createNarrationMessage() {
return binding.isUnbound() ? Component.translatable("narrator.controls.unbound", bindingName) : Component.translatable("narrator.controls.bound", bindingName, super.createNarrationMessage());
} }
@Override @Override
public void onPress() { protected String getNarrationMessage(){
return Key.isUnbound(binding) ? I18n.translate("narrator.controls.unbound", bindingName) : I18n.translate("narrator.controls.bound", bindingName, super.getNarrationMessage());
}
@Override
public void onPress(){
isEditing = true; isEditing = true;
onEditingStarted.accept(this); onEditingStarted.accept(this);
updateKeyBindingText(); updateKeyBindingText();
} }
public void bindAndStopEditing(final InputConstants.Key key) { public void bindAndStopEditing(final InputUtil.KeyCode key){
binding.setKey(key); Key.bind(binding, key);
stopEditing(); stopEditing();
for (final AbstractButton button : linkedButtons) { for(final AbstractButtonWidget button : linkedButtons){
button.active = !binding.isUnbound(); button.active = !Key.isUnbound(binding);
} }
} }
public void stopEditing() { public void stopEditing(){
isEditing = false; isEditing = false;
updateKeyBindingText(); updateKeyBindingText();
} }
public void updateKeyBindingText() { public void updateKeyBindingText(){
boolean hasConflict = false; boolean hasConflict = false;
if (!binding.isUnbound()) { if (!Key.isUnbound(binding)){
for (final KeyMapping other : Minecraft.getInstance().options.keyMappings) { for(final KeyBinding other : OPTIONS.keysAll){
if (binding != other && binding.same(other)) { if (binding != other && binding.equals(other)){
hasConflict = true; hasConflict = true;
break; break;
} }
} }
} }
if (isEditing) { if (isEditing){
setMessage(Component.literal("> ").append(binding.getTranslatedKeyMessage().copy().withStyle(ChatFormatting.YELLOW)).append(" <").withStyle(ChatFormatting.YELLOW)); setMessage(Formatting.WHITE + "> " + Formatting.YELLOW + binding.getLocalizedName() + Formatting.WHITE + " <");
} }
else if (hasConflict) { else if (hasConflict){
setMessage(binding.getTranslatedKeyMessage().copy().withStyle(ChatFormatting.RED)); setMessage(Formatting.RED + Key.getBoundKeyText(binding));
} }
else { else{
setMessage(binding.isUnbound() ? Component.literal("(No Binding)") : binding.getTranslatedKeyMessage()); setMessage(Key.isUnbound(binding) ? "(No Binding)" : Key.getBoundKeyText(binding));
} }
} }
} }

View File

@@ -1,20 +1,26 @@
package chylex.bettercontrols.gui.elements; package chylex.bettercontrols.gui.elements;
import net.minecraft.client.gui.components.CycleButton; import chylex.bettercontrols.util.LiteralText;
import net.minecraft.network.chat.Component;
import java.util.List; import java.util.List;
import java.util.Objects; import java.util.Objects;
import java.util.function.Consumer;
public record Option<T>(T value, Component text) { public final class Option<T>{
public static <T> Option<T> find(final List<Option<T>> options, final T value) { private final T value;
return options.stream().filter(it -> Objects.equals(it.value, value)).findFirst().orElseGet(() -> options.get(0)); private final LiteralText text;
public Option(final T value, final LiteralText text){
this.value = value;
this.text = text;
} }
public static <T> CycleButton<Option<T>> button(final int x, final int y, final int width, final Component text, final List<Option<T>> options, final T initialValue, final Consumer<T> onValueChanged) { public T getValue(){
return CycleButton.<Option<T>>builder(Option::text) return value;
.displayOnlyValue() }
.withValues(options)
.withInitialValue(find(options, initialValue)) public LiteralText getText(){
.create(x, y, width, 20, text, (btn, newValue) -> onValueChanged.accept(newValue.value())); return text;
}
public static <T> Option<T> find(final List<Option<T>> options, final T value){
return options.stream().filter(it -> Objects.equals(it.value, value)).findFirst().orElseGet(() -> options.get(0));
} }
} }

View File

@@ -1,26 +1,23 @@
package chylex.bettercontrols.gui.elements; package chylex.bettercontrols.gui.elements;
import chylex.bettercontrols.gui.OptionListWidget.OptionWidget; import chylex.bettercontrols.gui.OptionListWidget.Widget;
import com.mojang.blaze3d.vertex.PoseStack; import chylex.bettercontrols.util.LiteralText;
import net.minecraft.client.Minecraft; import net.minecraft.client.MinecraftClient;
import net.minecraft.client.gui.Font; import net.minecraft.client.font.TextRenderer;
import net.minecraft.client.gui.GuiComponent; import net.minecraft.client.gui.DrawableHelper;
import net.minecraft.network.chat.Component;
import net.minecraft.util.FormattedCharSequence;
import org.jetbrains.annotations.NotNull;
import java.util.List; import java.util.List;
public final class TextWidget extends GuiComponent implements OptionWidget { public final class TextWidget extends DrawableHelper implements Widget{
public static final int LEFT = 0; public static final int LEFT = 0;
public static final int CENTER = 1; public static final int CENTER = 1;
private final Component text; private final LiteralText text;
private int x; private int x;
private int y; private int y;
private final int width; private final int width;
private final int height; private final int height;
private final int align; private final int align;
public TextWidget(final int x, final int y, final int width, final int height, final Component text, final int align) { public TextWidget(final int x, final int y, final int width, final int height, final LiteralText text, final int align){
this.x = x; this.x = x;
this.y = y; this.y = y;
this.width = width; this.width = width;
@@ -29,54 +26,46 @@ public final class TextWidget extends GuiComponent implements OptionWidget {
this.align = align; this.align = align;
} }
public TextWidget(final int x, final int y, final int width, final Component text, final int align) { public TextWidget(final int x, final int y, final int width, final LiteralText text, final int align){
this(x, y, width, 20, text, align); this(x, y, width, 20, text, align);
} }
public TextWidget(final int x, final int y, final int width, final Component text) { public TextWidget(final int x, final int y, final int width, final LiteralText text){
this(x, y, width, 20, text, LEFT); this(x, y, width, 20, text, LEFT);
} }
@Override @Override
public int getX() { public int getX(){
return x; return x;
} }
@Override @Override
public int getY() { public int getY(){
return y; return y;
} }
@Override @Override
public void setX(final int x) { public void setX(final int x){
this.x = x; this.x = x;
} }
@Override @Override
public void setY(final int y) { public void setY(final int y){
this.y = y; this.y = y;
} }
@Override @Override
public void setFocused(final boolean focused) {} public void render(final int mouseX, final int mouseY, final float delta){
final TextRenderer textRenderer = MinecraftClient.getInstance().textRenderer;
@Override final List<String> lines = textRenderer.wrapStringToWidthAsList(text.asFormattedString(), width);
public boolean isFocused() { final int lineHeight = textRenderer.fontHeight + 1;
return false;
}
@Override
public void render(final @NotNull PoseStack matrices, final int mouseX, final int mouseY, final float delta) {
final Font textRenderer = Minecraft.getInstance().font;
final List<FormattedCharSequence> lines = textRenderer.split(text, width);
final int lineHeight = textRenderer.lineHeight + 1;
final int finalX = align == CENTER ? x + (width / 2) - (lines.stream().mapToInt(textRenderer::width).max().orElse(0) / 2) : x; final int finalX = align == CENTER ? x + (width / 2) - (lines.stream().mapToInt(textRenderer::getStringWidth).max().orElse(0) / 2) : x;
final int finalY = y + (height / 2) - (lineHeight * lines.size() / 2) + 1; final int finalY = y + (height / 2) - (lineHeight * lines.size() / 2) + 1;
for (int i = 0; i < lines.size(); i++) { for(int i = 0; i < lines.size(); i++){
final FormattedCharSequence line = lines.get(i); final String line = lines.get(i);
textRenderer.drawShadow(matrices, line, finalX, finalY + (i * lineHeight), (255 << 16) | (255 << 8) | 255); textRenderer.drawWithShadow(line, finalX, finalY + (i * lineHeight), (255 << 16) | (255 << 8) | 255);
} }
} }
} }

View File

@@ -1,34 +1,39 @@
package chylex.bettercontrols.input; package chylex.bettercontrols.input;
import com.mojang.blaze3d.platform.InputConstants.Type; import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.KeyMapping; import net.minecraft.client.resource.language.I18n;
import net.minecraft.client.util.InputUtil.Type;
import org.jetbrains.annotations.Nullable; import org.jetbrains.annotations.Nullable;
public class KeyBindingWithModifier extends KeyMapping { public class KeyBindingWithModifier extends KeyBinding{
public static final String CATEGORY = "key.categories.bettercontrols"; public static final String CATEGORY = "key.categories.bettercontrols";
public static boolean checkCategoryMatches(final String name){
return I18n.translate(CATEGORY).equals(name);
}
@Nullable @Nullable
private ModifierKey modifier = null; private ModifierKey modifier = null;
public KeyBindingWithModifier(final String translationKey) { public KeyBindingWithModifier(final String translationKey){
super(translationKey, Type.KEYSYM, -1, CATEGORY); super(translationKey, Type.KEYSYM, -1, CATEGORY);
} }
public void setModifier(@Nullable final ModifierKey modifier) { public void setModifier(@Nullable final ModifierKey modifier){
this.modifier = modifier; this.modifier = modifier;
} }
@Nullable @Nullable
public ModifierKey getModifier() { public ModifierKey getModifier(){
return modifier; return modifier;
} }
@Override @Override
public boolean isDown() { public boolean isPressed(){
return super.isDown() && (modifier == null || modifier.isPressed()); return super.isPressed() && (modifier == null || modifier.isPressed());
} }
@Override @Override
public boolean consumeClick() { public boolean wasPressed(){
return super.consumeClick() && (modifier == null || modifier.isPressed()); return super.wasPressed() && (modifier == null || modifier.isPressed());
} }
} }

View File

@@ -1,42 +1,42 @@
package chylex.bettercontrols.input; package chylex.bettercontrols.input;
import net.minecraft.client.gui.screens.Screen; import net.minecraft.client.gui.screen.Screen;
public enum ModifierKey { public enum ModifierKey{
CONTROL(0) { CONTROL(0){
@Override @Override
public boolean isPressed() { public boolean isPressed(){
return Screen.hasControlDown(); return Screen.hasControlDown();
} }
}, },
SHIFT(1) { SHIFT(1){
@Override @Override
public boolean isPressed() { public boolean isPressed(){
return Screen.hasShiftDown(); return Screen.hasShiftDown();
} }
}, },
ALT(2) { ALT(2){
@Override @Override
public boolean isPressed() { public boolean isPressed(){
return Screen.hasAltDown(); return Screen.hasAltDown();
} }
}; };
public final int id; public final int id;
ModifierKey(final int id) { ModifierKey(final int id){
this.id = id; this.id = id;
} }
public abstract boolean isPressed(); public abstract boolean isPressed();
public static ModifierKey getById(final int id) { public static ModifierKey getById(final int id){
return switch (id) { switch(id){
case 0 -> CONTROL; case 0: return CONTROL;
case 1 -> SHIFT; case 1: return SHIFT;
case 2 -> ALT; case 2: return ALT;
default -> null; default: return null;
}; }
} }
} }

View File

@@ -1,6 +1,6 @@
package chylex.bettercontrols.input; package chylex.bettercontrols.input;
public enum SprintMode { public enum SprintMode{
TAP_TO_START, TAP_TO_START,
TAP_TO_TOGGLE, TAP_TO_TOGGLE,
HOLD HOLD

View File

@@ -1,9 +1,10 @@
package chylex.bettercontrols.input; package chylex.bettercontrols.input;
import net.minecraft.client.KeyMapping; import chylex.bettercontrols.util.Key;
import net.minecraft.client.options.KeyBinding;
public class ToggleTracker { public class ToggleTracker{
protected final KeyMapping bindingToggle; protected final KeyBinding bindingToggle;
protected final KeyMapping bindingReset; protected final KeyBinding bindingReset;
protected boolean isToggled; protected boolean isToggled;
@@ -11,7 +12,7 @@ public class ToggleTracker {
private boolean hasToggledWhileHoldingReset; private boolean hasToggledWhileHoldingReset;
private boolean skipNextToggle; private boolean skipNextToggle;
public ToggleTracker(final KeyMapping bindingToggle, final KeyMapping bindingReset) { public ToggleTracker(final KeyBinding bindingToggle, final KeyBinding bindingReset){
this.bindingToggle = bindingToggle; this.bindingToggle = bindingToggle;
this.bindingReset = bindingReset; this.bindingReset = bindingReset;
} }
@@ -40,15 +41,15 @@ public class ToggleTracker {
* +CTRL, +G, -CTRL, +CTRL, +G, +G --> toggled on * +CTRL, +G, -CTRL, +CTRL, +G, +G --> toggled on
*/ */
public boolean tick() { public boolean tick(){
final boolean isHoldingReset = isResetKeyPressed(); final boolean isHoldingReset = isResetKeyPressed();
if (bindingToggle.isDown()) { if (Key.isPressed(bindingToggle)){
if (!waitForRelease) { if (!waitForRelease){
if (skipNextToggle) { if (skipNextToggle){
skipNextToggle = false; skipNextToggle = false;
} }
else { else{
isToggled = !isToggled; isToggled = !isToggled;
} }
@@ -56,32 +57,32 @@ public class ToggleTracker {
hasToggledWhileHoldingReset = isHoldingReset; hasToggledWhileHoldingReset = isHoldingReset;
} }
} }
else { else{
waitForRelease = false; waitForRelease = false;
} }
if (isToggled) { if (isToggled){
if (hasToggledWhileHoldingReset && !isHoldingReset) { if (hasToggledWhileHoldingReset && !isHoldingReset){
hasToggledWhileHoldingReset = false; hasToggledWhileHoldingReset = false;
} }
else if (!hasToggledWhileHoldingReset && isHoldingReset) { else if (!hasToggledWhileHoldingReset && isHoldingReset){
isToggled = false; isToggled = false;
skipNextToggle = true; skipNextToggle = true;
} }
} }
if (skipNextToggle && !isHoldingReset) { if (skipNextToggle && !isHoldingReset){
skipNextToggle = false; skipNextToggle = false;
} }
return isToggled; return isToggled;
} }
protected boolean isResetKeyPressed() { protected boolean isResetKeyPressed(){
return bindingReset.isDown(); return Key.isPressed(bindingReset);
} }
public void reset() { public void reset(){
isToggled = false; isToggled = false;
waitForRelease = false; waitForRelease = false;
} }

View File

@@ -1,20 +1,20 @@
package chylex.bettercontrols.input; package chylex.bettercontrols.input;
import chylex.bettercontrols.mixin.AccessKeyBindingFields; import chylex.bettercontrols.mixin.AccessKeyBindingFields;
import it.unimi.dsi.fastutil.booleans.BooleanConsumer; import it.unimi.dsi.fastutil.booleans.BooleanConsumer;
import net.minecraft.client.KeyMapping; import net.minecraft.client.options.KeyBinding;
import java.util.HashSet; import java.util.HashSet;
import java.util.Set; import java.util.Set;
public final class ToggleTrackerForStickyKey extends ToggleTracker { public final class ToggleTrackerForStickyKey extends ToggleTracker{
private static final Set<KeyMapping> enabledOverrides = new HashSet<>(); private static final Set<KeyBinding> enabledOverrides = new HashSet<>();
public static boolean isOverrideEnabled(final KeyMapping binding) { public static boolean isOverrideEnabled(final KeyBinding binding){
return enabledOverrides.contains(binding); return enabledOverrides.contains(binding);
} }
private final BooleanConsumer setToggleState; private final BooleanConsumer setToggleState;
public ToggleTrackerForStickyKey(final KeyMapping bindingToggle, final KeyMapping bindingStickyReset, final BooleanConsumer setToggleState) { public ToggleTrackerForStickyKey(final KeyBinding bindingToggle, final KeyBinding bindingStickyReset, final BooleanConsumer setToggleState){
super(bindingToggle, bindingStickyReset); super(bindingToggle, bindingStickyReset);
this.setToggleState = setToggleState; this.setToggleState = setToggleState;
this.setToggleState.accept(false); this.setToggleState.accept(false);
@@ -22,14 +22,14 @@ public final class ToggleTrackerForStickyKey extends ToggleTracker {
} }
@Override @Override
public boolean tick() { public boolean tick(){
final boolean isToggled = super.tick(); final boolean isToggled = super.tick();
setToggleState.accept(isToggled); setToggleState.accept(isToggled);
return isToggled; return isToggled;
} }
@Override @Override
protected boolean isResetKeyPressed() { protected boolean isResetKeyPressed(){
return ((AccessKeyBindingFields)bindingReset).isPressedField(); return ((AccessKeyBindingFields)bindingReset).isPressedField();
} }
} }

View File

@@ -1,10 +1,14 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import net.minecraft.client.Camera; import net.minecraft.client.render.Camera;
import net.minecraft.entity.Entity;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor; import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(Camera.class) @Mixin(Camera.class)
public interface AccessCameraFields { public interface AccessCameraFields{
@Accessor @Accessor
void setEyeHeight(float y); Entity getFocusedEntity();
@Accessor
void setCameraY(float y);
} }

View File

@@ -1,10 +1,10 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import net.minecraft.client.player.LocalPlayer; import net.minecraft.client.network.ClientPlayerEntity;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor; import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(LocalPlayer.class) @Mixin(ClientPlayerEntity.class)
public interface AccessClientPlayerFields { public interface AccessClientPlayerFields{
@Accessor @Accessor("field_3935")
void setSprintTriggerTime(int value); void setTicksLeftToDoubleTapSprint(int value);
} }

View File

@@ -0,0 +1,10 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.screen.options.ControlsListWidget.CategoryEntry;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(CategoryEntry.class)
public interface AccessControlsListCategory{
@Accessor
String getName();
}

View File

@@ -0,0 +1,11 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.screen.options.ControlsListWidget.KeyBindingEntry;
import net.minecraft.client.options.KeyBinding;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(KeyBindingEntry.class)
public interface AccessControlsListKeyBinding{
@Accessor
KeyBinding getBinding();
}

View File

@@ -0,0 +1,10 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.render.GameRenderer;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(GameRenderer.class)
public interface AccessGameRendererFields{
@Accessor
void setMovementFovMultiplier(float value);
}

View File

@@ -1,19 +1,19 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import net.minecraft.client.KeyMapping; import net.minecraft.client.options.KeyBinding;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor; import org.spongepowered.asm.mixin.gen.Accessor;
import java.util.Map; import java.util.Map;
@Mixin(KeyMapping.class) @Mixin(KeyBinding.class)
public interface AccessKeyBindingFields { public interface AccessKeyBindingFields{
@Accessor("CATEGORY_SORT_ORDER") @Accessor
static Map<String, Integer> getCategoryOrderMap() { static Map<String, Integer> getCategoryOrderMap(){
throw new AssertionError(); throw new AssertionError();
} }
@Accessor("isDown") @Accessor("pressed")
boolean isPressedField(); boolean isPressedField();
@Accessor("isDown") @Accessor("pressed")
void setPressedField(boolean value); void setPressedField(boolean value);
} }

View File

@@ -0,0 +1,11 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.widget.OptionButtonWidget;
import net.minecraft.client.options.Option;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(OptionButtonWidget.class)
public interface AccessOptionButtonWidgetOption{
@Accessor
Option getOption();
}

View File

@@ -1,10 +1,10 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import net.minecraft.world.entity.player.Player; import net.minecraft.entity.player.PlayerEntity;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor; import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(Player.class) @Mixin(PlayerEntity.class)
public interface AccessPlayerFields { public interface AccessPlayerFields{
@Accessor @Accessor("field_7489")
void setJumpTriggerTime(int value); void setTicksLeftToDoubleTapFlight(int value);
} }

View File

@@ -0,0 +1,16 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.widget.AbstractButtonWidget;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
import org.spongepowered.asm.mixin.gen.Invoker;
import java.util.List;
@Mixin(Screen.class)
public interface AccessScreenButtons{
@Accessor
List<AbstractButtonWidget> getButtons();
@Invoker
<T extends AbstractButtonWidget> T callAddButton(T button);
}

View File

@@ -1,16 +1,16 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import net.minecraft.client.ToggleKeyMapping; import net.minecraft.client.options.StickyKeyBinding;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Mutable; import org.spongepowered.asm.mixin.Mutable;
import org.spongepowered.asm.mixin.gen.Accessor; import org.spongepowered.asm.mixin.gen.Accessor;
import java.util.function.BooleanSupplier; import java.util.function.BooleanSupplier;
@Mixin(ToggleKeyMapping.class) @Mixin(StickyKeyBinding.class)
public interface AccessStickyKeyBindingStateGetter { public interface AccessStickyKeyBindingStateGetter{
@Accessor @Accessor
BooleanSupplier getNeedsToggle(); BooleanSupplier getToggleGetter();
@Accessor @Accessor
@Mutable @Mutable
void setNeedsToggle(final BooleanSupplier toggleGetter); void setToggleGetter(final BooleanSupplier toggleGetter);
} }

View File

@@ -1,26 +0,0 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.player.PlayerTicker;
import net.minecraft.client.Minecraft;
import net.minecraft.client.player.AbstractClientPlayer;
import net.minecraft.client.player.LocalPlayer;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect;
import org.spongepowered.asm.mixin.injection.Slice;
@Mixin(AbstractClientPlayer.class)
public abstract class HookClientPlayerFOV {
@Redirect(
method = "getFieldOfViewModifier",
at = @At(value = "INVOKE", target = "Ljava/lang/Float;isNaN(F)Z"),
slice = @Slice(
from = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/player/Abilities;getWalkingSpeed()F"),
to = @At(value = "INVOKE", target = "Ljava/lang/Float;isInfinite(F)Z")
)
)
private boolean resetFOV(final float movementSpeed) {
final LocalPlayer player = Minecraft.getInstance().player;
return (player != null && PlayerTicker.get(player).shouldResetFOV(player)) || Float.isNaN(movementSpeed);
}
}

View File

@@ -1,24 +1,22 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import chylex.bettercontrols.player.PlayerTicker; import chylex.bettercontrols.player.PlayerTicker;
import net.minecraft.client.Minecraft; import net.minecraft.client.input.KeyboardInput;
import net.minecraft.client.player.Input; import net.minecraft.client.network.ClientPlayerEntity;
import net.minecraft.client.player.KeyboardInput;
import net.minecraft.client.player.LocalPlayer;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject; import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
import static org.spongepowered.asm.mixin.injection.At.Shift.AFTER; import static org.spongepowered.asm.mixin.injection.At.Shift.AFTER;
@Mixin(KeyboardInput.class) @Mixin(KeyboardInput.class)
public abstract class HookClientPlayerInputTick { public abstract class HookClientPlayerInputTick{
@Inject(method = "tick(ZF)V", at = @At(value = "FIELD", target = "Lnet/minecraft/client/player/KeyboardInput;up:Z", ordinal = 0, shift = AFTER)) @Inject(method = "tick(Z)V", at = @At(value = "FIELD", target = "Lnet/minecraft/client/input/KeyboardInput;pressingForward:Z", ordinal = 0, shift = AFTER))
private void afterInputTick(final CallbackInfo info) { private void afterInputTick(final CallbackInfo info){
@SuppressWarnings("ConstantConditions") final KeyboardInput input = (KeyboardInput)(Object)this;
final Input input = (Input)(Object)this; final ClientPlayerEntity player = MINECRAFT.player;
final LocalPlayer player = Minecraft.getInstance().player;
if (player != null) { if (player != null){
PlayerTicker.get(player).afterInputAssignsPressingForward(input); PlayerTicker.get(player).afterInputAssignsPressingForward(input);
} }
} }

View File

@@ -1,39 +1,36 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import chylex.bettercontrols.player.PlayerTicker; import chylex.bettercontrols.player.PlayerTicker;
import com.mojang.authlib.GameProfile; import com.mojang.authlib.GameProfile;
import net.minecraft.client.multiplayer.ClientLevel; import net.minecraft.client.network.AbstractClientPlayerEntity;
import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.network.ClientPlayerEntity;
import net.minecraft.client.player.LocalPlayer; import net.minecraft.client.world.ClientWorld;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject; import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import static org.spongepowered.asm.mixin.injection.At.Shift.AFTER; import static org.spongepowered.asm.mixin.injection.At.Shift.AFTER;
@Mixin(LocalPlayer.class) @Mixin(ClientPlayerEntity.class)
public abstract class HookClientPlayerTick extends AbstractClientPlayer { public abstract class HookClientPlayerTick extends AbstractClientPlayerEntity{
protected HookClientPlayerTick(final ClientLevel world, final GameProfile profile) { protected HookClientPlayerTick(final ClientWorld world, final GameProfile profile){
super(world, profile); super(world, profile);
} }
@Inject(method = "aiStep()V", at = @At("HEAD")) @Inject(method = "tickMovement()V", at = @At("HEAD"))
private void atHead(final CallbackInfo info) { private void atHead(final CallbackInfo info){
@SuppressWarnings("ConstantConditions") final ClientPlayerEntity player = (ClientPlayerEntity)(Object)this;
final LocalPlayer player = (LocalPlayer)(Object)this;
PlayerTicker.get(player).atHead(player); PlayerTicker.get(player).atHead(player);
} }
@Inject(method = "aiStep()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/Input;tick(ZF)V", ordinal = 0, shift = AFTER)) @Inject(method = "tickMovement()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/input/Input;tick(Z)V", ordinal = 0, shift = AFTER))
private void afterInputTick(final CallbackInfo info) { private void afterInputTick(final CallbackInfo info){
@SuppressWarnings("ConstantConditions") final ClientPlayerEntity player = (ClientPlayerEntity)(Object)this;
final LocalPlayer player = (LocalPlayer)(Object)this;
PlayerTicker.get(player).afterInputTick(player); PlayerTicker.get(player).afterInputTick(player);
} }
@Inject(method = "aiStep()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/player/AbstractClientPlayer;aiStep()V", ordinal = 0, shift = AFTER)) @Inject(method = "tickMovement()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/network/AbstractClientPlayerEntity;tickMovement()V", ordinal = 0, shift = AFTER))
private void afterSuperCall(final CallbackInfo info) { private void afterSuperCall(final CallbackInfo info){
@SuppressWarnings("ConstantConditions") final ClientPlayerEntity player = (ClientPlayerEntity)(Object)this;
final LocalPlayer player = (LocalPlayer)(Object)this;
PlayerTicker.get(player).afterSuperCall(player); PlayerTicker.get(player).afterSuperCall(player);
} }
} }

View File

@@ -1,24 +1,37 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import chylex.bettercontrols.BetterControlsCommon; import chylex.bettercontrols.BetterControlsMod;
import net.minecraft.client.KeyMapping; import chylex.bettercontrols.input.KeyBindingWithModifier;
import net.minecraft.client.Minecraft; import net.minecraft.client.MinecraftClient;
import net.minecraft.client.Options; import net.minecraft.client.gui.screen.options.ControlsListWidget;
import net.minecraft.client.gui.components.ContainerObjectSelectionList; import net.minecraft.client.gui.screen.options.ControlsListWidget.CategoryEntry;
import net.minecraft.client.gui.screens.controls.KeyBindsList; import net.minecraft.client.gui.screen.options.ControlsListWidget.Entry;
import net.minecraft.client.gui.screens.controls.KeyBindsList.Entry; import net.minecraft.client.gui.screen.options.ControlsListWidget.KeyBindingEntry;
import net.minecraft.client.gui.screen.options.ControlsOptionsScreen;
import net.minecraft.client.gui.widget.ElementListWidget;
import org.apache.commons.lang3.ArrayUtils; import org.apache.commons.lang3.ArrayUtils;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect; import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
@Mixin(KeyBindsList.class) @Mixin(ControlsListWidget.class)
public abstract class HookControlsListWidget extends ContainerObjectSelectionList<Entry> { public abstract class HookControlsListWidget extends ElementListWidget<Entry>{
public HookControlsListWidget(final Minecraft client, final int width, final int height, final int top, final int bottom, final int itemHeight) { public HookControlsListWidget(final MinecraftClient client, final int width, final int height, final int top, final int bottom, final int itemHeight){
super(client, width, height, top, bottom, itemHeight); super(client, width, height, top, bottom, itemHeight);
} }
@Redirect(method = "<init>", at = @At(value = "FIELD", target = "Lnet/minecraft/client/Options;keyMappings:[Lnet/minecraft/client/KeyMapping;")) @Inject(method = "<init>", at = @At("TAIL"))
private KeyMapping[] excludeOwnKeyBindings(final Options options) { public void init(final ControlsOptionsScreen parent, final MinecraftClient client, final CallbackInfo ci){
return ArrayUtils.removeElements(options.keyMappings, BetterControlsCommon.getConfig().getAllKeyBindings()); children().removeIf(it -> {
if (it instanceof CategoryEntry && KeyBindingWithModifier.checkCategoryMatches(((AccessControlsListCategory)it).getName())){
return true;
}
if (it instanceof KeyBindingEntry && ArrayUtils.contains(BetterControlsMod.config.getAllKeyBindings(), ((AccessControlsListKeyBinding)it).getBinding())){
return true;
}
return false;
});
} }
} }

View File

@@ -1,74 +0,0 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.gui.BetterControlsScreen;
import net.minecraft.client.Minecraft;
import net.minecraft.client.Options;
import net.minecraft.client.gui.components.AbstractWidget;
import net.minecraft.client.gui.components.Button;
import net.minecraft.client.gui.components.events.GuiEventListener;
import net.minecraft.client.gui.screens.OptionsSubScreen;
import net.minecraft.client.gui.screens.Screen;
import net.minecraft.client.gui.screens.controls.ControlsScreen;
import net.minecraft.network.chat.CommonComponents;
import net.minecraft.network.chat.Component;
import net.minecraft.network.chat.MutableComponent;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
@Mixin(ControlsScreen.class)
public abstract class HookControlsScreen extends OptionsSubScreen {
public HookControlsScreen(final Screen parentScreen, final Options options, final Component title) {
super(parentScreen, options, title);
}
@Inject(method = "init", at = @At("RETURN"))
public void afterInit(final CallbackInfo ci) {
@SuppressWarnings("ConstantConditions")
final ControlsScreen screen = (ControlsScreen)(Object)this;
final int center = width / 2;
int leftBottomY = 0;
int rightBottomY = 0;
AbstractWidget doneButton = null;
for (final GuiEventListener child : children()) {
if (!(child instanceof AbstractWidget widget)) {
continue;
}
if (widget instanceof Button button && button.getMessage() == CommonComponents.GUI_DONE) {
doneButton = widget;
continue;
}
final int bottomY = widget.getY() + widget.getHeight();
if (widget.getX() + widget.getWidth() < center) {
leftBottomY = Math.max(leftBottomY, bottomY);
}
if (widget.getX() >= center) {
rightBottomY = Math.max(rightBottomY, bottomY);
}
}
final int x, y;
if (leftBottomY <= rightBottomY) {
x = center - 155;
y = leftBottomY + 4;
}
else {
x = center + 5;
y = rightBottomY + 4;
}
final MutableComponent buttonTitle = BetterControlsScreen.TITLE.plainCopy().append("...");
addRenderableWidget(Button.builder(buttonTitle, btn -> Minecraft.getInstance().setScreen(new BetterControlsScreen(screen))).pos(x, y).size(150, 20).build());
if (doneButton != null) {
doneButton.setY(y + 24);
}
}
}

View File

@@ -1,9 +1,8 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import chylex.bettercontrols.BetterControlsCommon; import chylex.bettercontrols.BetterControlsMod;
import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.input.KeyBindingWithModifier; import chylex.bettercontrols.input.KeyBindingWithModifier;
import net.minecraft.client.KeyMapping; import net.minecraft.client.options.GameOptions;
import net.minecraft.client.Options; import net.minecraft.client.options.KeyBinding;
import org.apache.commons.lang3.ArrayUtils; import org.apache.commons.lang3.ArrayUtils;
import org.spongepowered.asm.mixin.Final; import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
@@ -13,28 +12,23 @@ import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject; import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
@Mixin(Options.class) @Mixin(GameOptions.class)
public abstract class HookLoadGameOptions { public abstract class HookLoadGameOptions{
private boolean hasLoaded = false; private boolean hasLoaded = false;
@Mutable @Mutable
@Final @Final
@Shadow @Shadow
public KeyMapping[] keyMappings; public KeyBinding[] keysAll;
@Inject(method = "load()V", at = @At("HEAD")) @Inject(method = "load()V", at = @At("HEAD"))
private void load(final CallbackInfo info) { private void load(final CallbackInfo info){
if (hasLoaded) { if (hasLoaded){
return;
}
final BetterControlsConfig config = BetterControlsCommon.getConfig();
if (config == null) {
return; return;
} }
hasLoaded = true; hasLoaded = true;
keyMappings = ArrayUtils.addAll(keyMappings, config.getAllKeyBindings()); keysAll = ArrayUtils.addAll(keysAll, BetterControlsMod.config.getAllKeyBindings());
AccessKeyBindingFields.getCategoryOrderMap().put(KeyBindingWithModifier.CATEGORY, Integer.valueOf(Integer.MAX_VALUE)); AccessKeyBindingFields.getCategoryOrderMap().put(KeyBindingWithModifier.CATEGORY, Integer.valueOf(Integer.MAX_VALUE));
} }
} }

View File

@@ -0,0 +1,28 @@
package chylex.bettercontrols.mixin;
import chylex.bettercontrols.gui.ScreenPatcher;
import net.minecraft.client.MinecraftClient;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.screen.options.AccessibilityScreen;
import net.minecraft.client.gui.screen.options.ControlsOptionsScreen;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
@Mixin(value = MinecraftClient.class, priority = 100)
public abstract class HookOpenScreen{
@Inject(method = "openScreen(Lnet/minecraft/client/gui/screen/Screen;)V", at = @At("TAIL"))
private void openScreen(final Screen ignore, final CallbackInfo ci){
final Screen screen = MINECRAFT.currentScreen;
if (screen != null && !Screen.hasAltDown()){
if (screen.getClass() == ControlsOptionsScreen.class){
ScreenPatcher.onControlsScreenOpened((ControlsOptionsScreen)screen);
}
else if (screen.getClass() == AccessibilityScreen.class){
ScreenPatcher.onAccessibilityScreenOpened((AccessibilityScreen)screen);
}
}
}
}

View File

@@ -1,29 +1,25 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import net.minecraft.world.entity.EntityType; import net.minecraft.entity.EntityType;
import net.minecraft.world.entity.LivingEntity; import net.minecraft.entity.LivingEntity;
import net.minecraft.world.entity.player.Player; import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.world.level.Level; import net.minecraft.world.World;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect; import org.spongepowered.asm.mixin.injection.Redirect;
import org.spongepowered.asm.mixin.injection.Slice; import org.spongepowered.asm.mixin.injection.Slice;
@SuppressWarnings("SameReturnValue") @Mixin(PlayerEntity.class)
@Mixin(Player.class) public abstract class HookPlayerFlightSpeed extends LivingEntity{
public abstract class HookPlayerFlightSpeed extends LivingEntity { protected HookPlayerFlightSpeed(final EntityType<? extends LivingEntity> type, final World world){
protected HookPlayerFlightSpeed(final EntityType<? extends LivingEntity> type, final Level world) {
super(type, world); super(type, world);
} }
@Redirect( @Redirect(
method = "getFlyingSpeed", method = "travel",
at = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/player/Player;isSprinting()Z"), at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/player/PlayerEntity;isSprinting()Z"),
slice = @Slice( slice = @Slice(from = @At(value = "INVOKE", target = "Lnet/minecraft/entity/player/PlayerAbilities;getFlySpeed()F"))
from = @At(value = "FIELD", target = "Lnet/minecraft/world/entity/player/Abilities;flying:Z"),
to = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/player/Abilities;getFlyingSpeed()F")
)
) )
private boolean disableVanillaSprintBoost(final Player player) { private boolean disableVanillaSprintBoost(final PlayerEntity player){
return false; return false;
} }
} }

View File

@@ -1,7 +1,7 @@
package chylex.bettercontrols.mixin; package chylex.bettercontrols.mixin;
import chylex.bettercontrols.input.ToggleTrackerForStickyKey; import chylex.bettercontrols.input.ToggleTrackerForStickyKey;
import net.minecraft.client.KeyMapping; import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.ToggleKeyMapping; import net.minecraft.client.options.StickyKeyBinding;
import org.spongepowered.asm.mixin.Final; import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow; import org.spongepowered.asm.mixin.Shadow;
@@ -10,26 +10,26 @@ import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import java.util.function.BooleanSupplier; import java.util.function.BooleanSupplier;
@Mixin(ToggleKeyMapping.class) @Mixin(StickyKeyBinding.class)
public abstract class HookStickyKeyBindingState extends KeyMapping { public abstract class HookStickyKeyBindingState extends KeyBinding{
@Shadow @Shadow
@Final @Final
private BooleanSupplier needsToggle; private BooleanSupplier toggleGetter;
public HookStickyKeyBindingState(final String translationKey, final int code, final String category) { public HookStickyKeyBindingState(final String translationKey, final int code, final String category){
super(translationKey, code, category); super(translationKey, code, category);
} }
@Inject(method = "setDown", at = @At("HEAD"), cancellable = true) @Inject(method = "setPressed(Z)V", at = @At("HEAD"), cancellable = true)
public void setPressed(final boolean pressed, final CallbackInfo info) { public void setPressed(final boolean pressed, final CallbackInfo info){
if (ToggleTrackerForStickyKey.isOverrideEnabled(this)) { if (ToggleTrackerForStickyKey.isOverrideEnabled(this)){
((AccessKeyBindingFields)this).setPressedField(pressed); ((AccessKeyBindingFields)this).setPressedField(pressed);
info.cancel(); info.cancel();
} }
} }
@Override @Override
public boolean isDown() { public boolean isPressed(){
return super.isDown() || (ToggleTrackerForStickyKey.isOverrideEnabled(this) && needsToggle.getAsBoolean()); return super.isPressed() || (ToggleTrackerForStickyKey.isOverrideEnabled(this) && toggleGetter.getAsBoolean());
} }
} }

View File

@@ -1,23 +0,0 @@
package chylex.bettercontrols.mixin;
import net.minecraft.client.OptionInstance;
import net.minecraft.client.Options;
import net.minecraft.client.gui.components.AbstractWidget;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
import java.util.function.Consumer;
@Mixin(OptionInstance.class)
public abstract class HookToggleOptionButtons {
@Inject(method = "createButton(Lnet/minecraft/client/Options;IIILjava/util/function/Consumer;)Lnet/minecraft/client/gui/components/AbstractWidget;", at = @At("RETURN"))
private <T> void disableToggleOptions(final Options options, final int x, final int y, final int width, final Consumer<T> callback, final CallbackInfoReturnable<AbstractWidget> cir) {
@SuppressWarnings("ConstantConditions")
final OptionInstance<?> me = (OptionInstance<?>)(Object)this;
if (me == options.toggleCrouch() || me == options.toggleSprint()) {
cir.getReturnValue().active = false;
}
}
}

View File

@@ -1,66 +1,66 @@
package chylex.bettercontrols.player; package chylex.bettercontrols.player;
import chylex.bettercontrols.BetterControlsCommon; import chylex.bettercontrols.BetterControlsMod;
import chylex.bettercontrols.config.BetterControlsConfig; import chylex.bettercontrols.config.BetterControlsConfig;
import net.minecraft.client.player.LocalPlayer; import net.minecraft.client.network.ClientPlayerEntity;
final class FlightHelper { final class FlightHelper{
private FlightHelper() {} private FlightHelper(){}
private static final float BASE_FLIGHT_SPEED = 0.05F; private static final float BASE_FLIGHT_SPEED = 0.05F;
private static final float BASE_VERTICAL_VELOCITY = 3F; private static final float BASE_VERTICAL_VELOCITY = 3F;
private static BetterControlsConfig cfg() { private static BetterControlsConfig cfg(){
return BetterControlsCommon.getConfig(); return BetterControlsMod.config;
} }
static boolean isFlyingCreativeOrSpectator(final LocalPlayer player) { static boolean isFlyingCreativeOrSpectator(final ClientPlayerEntity player){
return player.getAbilities().flying && (player.isCreative() || player.isSpectator()); return player.abilities.flying && (player.isCreative() || player.isSpectator());
} }
static boolean shouldFlyOnGround(final LocalPlayer player) { static boolean shouldFlyOnGround(final ClientPlayerEntity player){
return cfg().flyOnGroundInCreative && player.isCreative() && player.getAbilities().flying; return cfg().flyOnGroundInCreative && player.isCreative() && player.abilities.flying;
} }
static float getFlightSpeed(final LocalPlayer player, final boolean boost) { static float getFlightSpeed(final ClientPlayerEntity player, final boolean boost){
if (player.isCreative()) { if (player.isCreative()){
if (boost) { if (boost){
return BASE_FLIGHT_SPEED * cfg().flightSpeedMpCreativeSprinting; return BASE_FLIGHT_SPEED * cfg().flightSpeedMpCreativeSprinting;
} }
else { else{
return BASE_FLIGHT_SPEED * cfg().flightSpeedMpCreativeDefault; return BASE_FLIGHT_SPEED * cfg().flightSpeedMpCreativeDefault;
} }
} }
else if (player.isSpectator()) { else if (player.isSpectator()){
if (boost) { if (boost){
return BASE_FLIGHT_SPEED * cfg().flightSpeedMpSpectatorSprinting; return BASE_FLIGHT_SPEED * cfg().flightSpeedMpSpectatorSprinting;
} }
else { else{
return BASE_FLIGHT_SPEED * cfg().flightSpeedMpSpectatorDefault; return BASE_FLIGHT_SPEED * cfg().flightSpeedMpSpectatorDefault;
} }
} }
else { else{
return 0F; return 0F;
} }
} }
static float getExtraVerticalVelocity(final LocalPlayer player, final boolean isSprinting) { static float getExtraVerticalVelocity(final ClientPlayerEntity player, final boolean isSprinting){
if (player.isCreative()) { if (player.isCreative()){
if (isSprinting) { if (isSprinting){
return BASE_VERTICAL_VELOCITY * cfg().flightVerticalBoostCreativeSprinting; return BASE_VERTICAL_VELOCITY * cfg().flightVerticalBoostCreativeSprinting;
} }
else { else{
return BASE_VERTICAL_VELOCITY * cfg().flightVerticalBoostCreativeDefault; return BASE_VERTICAL_VELOCITY * cfg().flightVerticalBoostCreativeDefault;
} }
} }
else if (player.isSpectator()) { else if (player.isSpectator()){
if (isSprinting) { if (isSprinting){
return BASE_VERTICAL_VELOCITY * cfg().flightVerticalBoostSpectatorSprinting; return BASE_VERTICAL_VELOCITY * cfg().flightVerticalBoostSpectatorSprinting;
} }
else { else{
return BASE_VERTICAL_VELOCITY * cfg().flightVerticalBoostSpectatorDefault; return BASE_VERTICAL_VELOCITY * cfg().flightVerticalBoostSpectatorDefault;
} }
} }
else { else{
return 0F; return 0F;
} }
} }

View File

@@ -1,5 +1,5 @@
package chylex.bettercontrols.player; package chylex.bettercontrols.player;
import chylex.bettercontrols.BetterControlsCommon; import chylex.bettercontrols.BetterControlsMod;
import chylex.bettercontrols.config.BetterControlsConfig; import chylex.bettercontrols.config.BetterControlsConfig;
import chylex.bettercontrols.gui.BetterControlsScreen; import chylex.bettercontrols.gui.BetterControlsScreen;
import chylex.bettercontrols.input.SprintMode; import chylex.bettercontrols.input.SprintMode;
@@ -7,51 +7,48 @@ import chylex.bettercontrols.input.ToggleTracker;
import chylex.bettercontrols.input.ToggleTrackerForStickyKey; import chylex.bettercontrols.input.ToggleTrackerForStickyKey;
import chylex.bettercontrols.mixin.AccessCameraFields; import chylex.bettercontrols.mixin.AccessCameraFields;
import chylex.bettercontrols.mixin.AccessClientPlayerFields; import chylex.bettercontrols.mixin.AccessClientPlayerFields;
import chylex.bettercontrols.mixin.AccessGameRendererFields;
import chylex.bettercontrols.mixin.AccessPlayerFields; import chylex.bettercontrols.mixin.AccessPlayerFields;
import chylex.bettercontrols.mixin.AccessStickyKeyBindingStateGetter; import chylex.bettercontrols.mixin.AccessStickyKeyBindingStateGetter;
import net.minecraft.client.Camera; import chylex.bettercontrols.util.Key;
import net.minecraft.client.KeyMapping; import net.minecraft.client.input.Input;
import net.minecraft.client.Minecraft; import net.minecraft.client.input.KeyboardInput;
import net.minecraft.client.Options; import net.minecraft.client.network.ClientPlayerEntity;
import net.minecraft.client.player.Input;
import net.minecraft.client.player.LocalPlayer;
import java.lang.ref.WeakReference; import java.lang.ref.WeakReference;
import java.util.function.BooleanSupplier; import java.util.function.BooleanSupplier;
import static chylex.bettercontrols.util.Statics.KEY_FORWARD;
import static chylex.bettercontrols.util.Statics.KEY_JUMP;
import static chylex.bettercontrols.util.Statics.KEY_SNEAK;
import static chylex.bettercontrols.util.Statics.KEY_SPRINT;
import static chylex.bettercontrols.util.Statics.MINECRAFT;
import static chylex.bettercontrols.util.Statics.OPTIONS;
public final class PlayerTicker { public final class PlayerTicker{
private static final Minecraft MINECRAFT = Minecraft.getInstance();
private static final Options OPTIONS = MINECRAFT.options;
private static final KeyMapping KEY_SPRINT = OPTIONS.keySprint;
private static final KeyMapping KEY_SNEAK = OPTIONS.keyShift;
private static final KeyMapping KEY_FORWARD = OPTIONS.keyUp;
private static final KeyMapping KEY_JUMP = OPTIONS.keyJump;
private static PlayerTicker ticker = new PlayerTicker(null); private static PlayerTicker ticker = new PlayerTicker(null);
public static PlayerTicker get(final LocalPlayer player) { public static PlayerTicker get(final ClientPlayerEntity player){
if (ticker.ref.get() != player) { if (ticker.ref.get() != player){
ticker = new PlayerTicker(player); ticker = new PlayerTicker(player);
} }
return ticker; return ticker;
} }
private static BetterControlsConfig cfg() { private static BetterControlsConfig cfg(){
return BetterControlsCommon.getConfig(); return BetterControlsMod.config;
} }
private final WeakReference<LocalPlayer> ref; private final WeakReference<ClientPlayerEntity> ref;
private PlayerTicker(final LocalPlayer player) { private PlayerTicker(final ClientPlayerEntity player){
this.ref = new WeakReference<>(player); this.ref = new WeakReference<>(player);
setup(); setup();
} }
// Logic // Logic
private final ToggleTracker toggleSprint = new ToggleTrackerForStickyKey(cfg().keyToggleSprint, KEY_SPRINT, OPTIONS.toggleSprint()::set); private final ToggleTracker toggleSprint = new ToggleTrackerForStickyKey(cfg().keyToggleSprint, KEY_SPRINT, toggled -> OPTIONS.sprintToggled = toggled);
private final ToggleTracker toggleSneak = new ToggleTrackerForStickyKey(cfg().keyToggleSneak, KEY_SNEAK, OPTIONS.toggleCrouch()::set); private final ToggleTracker toggleSneak = new ToggleTrackerForStickyKey(cfg().keyToggleSneak, KEY_SNEAK, toggled -> OPTIONS.sneakToggled = toggled);
private final ToggleTracker toggleWalkForward = new ToggleTracker(cfg().keyToggleWalkForward, KEY_FORWARD); private final ToggleTracker toggleWalkForward = new ToggleTracker(cfg().keyToggleWalkForward, KEY_FORWARD);
private final ToggleTracker toggleJump = new ToggleTracker(cfg().keyToggleJump, KEY_JUMP); private final ToggleTracker toggleJump = new ToggleTracker(cfg().keyToggleJump, KEY_JUMP);
@@ -66,79 +63,79 @@ public final class PlayerTicker {
private boolean holdingSneakWhileTouchingGround = false; private boolean holdingSneakWhileTouchingGround = false;
private int temporaryFlyOnGroundTimer = 0; private int temporaryFlyOnGroundTimer = 0;
private void setup() { private void setup(){
final AccessStickyKeyBindingStateGetter sprint = (AccessStickyKeyBindingStateGetter)KEY_SPRINT; final AccessStickyKeyBindingStateGetter sprint = (AccessStickyKeyBindingStateGetter)KEY_SPRINT;
BooleanSupplier getter = sprint.getNeedsToggle(); BooleanSupplier getter = sprint.getToggleGetter();
if (getter instanceof final SprintPressGetter g) { if (getter instanceof SprintPressGetter){
getter = g.wrapped(); getter = ((SprintPressGetter)getter).getWrapped();
} }
sprint.setNeedsToggle(new SprintPressGetter(getter, () -> temporarySprintTimer > 0)); sprint.setToggleGetter(new SprintPressGetter(getter, () -> temporarySprintTimer > 0));
} }
public void atHead(final LocalPlayer player) { public void atHead(final ClientPlayerEntity player){
if (FlightHelper.shouldFlyOnGround(player)) { if (FlightHelper.shouldFlyOnGround(player)){
player.setOnGround(false); player.onGround = false;
} }
if (!cfg().doubleTapForwardToSprint) { if (!cfg().doubleTapForwardToSprint){
((AccessClientPlayerFields)player).setSprintTriggerTime(0); ((AccessClientPlayerFields)player).setTicksLeftToDoubleTapSprint(0);
} }
if (!cfg().doubleTapJumpToToggleFlight) { if (!cfg().doubleTapJumpToToggleFlight){
((AccessPlayerFields)player).setJumpTriggerTime(0); ((AccessPlayerFields)player).setTicksLeftToDoubleTapFlight(0);
} }
final SprintMode sprintMode = cfg().sprintMode; final SprintMode sprintMode = cfg().sprintMode;
final boolean wasSprintToggled = Boolean.TRUE.equals(OPTIONS.toggleSprint().get()); final boolean wasSprintToggled = OPTIONS.sprintToggled;
final boolean isSprintToggled = toggleSprint.tick(); final boolean isSprintToggled = toggleSprint.tick();
if (temporarySprintTimer > 0) { if (temporarySprintTimer > 0){
stopSprintingAfterReleasingSprintKey = false; stopSprintingAfterReleasingSprintKey = false;
waitingForSprintKeyRelease = false; waitingForSprintKeyRelease = false;
final int nextTemporarySprintTimer = temporarySprintTimer - 1; final int nextTemporarySprintTimer = temporarySprintTimer - 1;
temporarySprintTimer = 0; temporarySprintTimer = 0;
if (!KEY_SPRINT.isDown() && KEY_FORWARD.isDown()) { if (!Key.isPressed(KEY_SPRINT) && Key.isPressed(KEY_FORWARD)){
temporarySprintTimer = nextTemporarySprintTimer; temporarySprintTimer = nextTemporarySprintTimer;
} }
else if (sprintMode == SprintMode.TAP_TO_TOGGLE) { else if (sprintMode == SprintMode.TAP_TO_TOGGLE){
stopSprintingAfterReleasingSprintKey = true; stopSprintingAfterReleasingSprintKey = true;
} }
} }
if (isSprintToggled) { if (isSprintToggled){
stopSprintingAfterReleasingSprintKey = false; stopSprintingAfterReleasingSprintKey = false;
waitingForSprintKeyRelease = false; waitingForSprintKeyRelease = false;
} }
else if (wasSprintToggled) { else if (wasSprintToggled){
stopSprintingAfterReleasingSprintKey = true; stopSprintingAfterReleasingSprintKey = true;
waitingForSprintKeyRelease = true; waitingForSprintKeyRelease = true;
} }
else if (sprintMode == SprintMode.TAP_TO_TOGGLE) { else if (sprintMode == SprintMode.TAP_TO_TOGGLE){
if (KEY_SPRINT.isDown()) { if (Key.isPressed(KEY_SPRINT)){
if (!waitingForSprintKeyRelease) { if (!waitingForSprintKeyRelease){
waitingForSprintKeyRelease = true; waitingForSprintKeyRelease = true;
stopSprintingAfterReleasingSprintKey = player.isSprinting(); stopSprintingAfterReleasingSprintKey = player.isSprinting();
} }
} }
else { else{
if (player.isSprinting() && !waitingForSprintKeyRelease) { if (player.isSprinting() && !waitingForSprintKeyRelease){
stopSprintingAfterReleasingSprintKey = false; stopSprintingAfterReleasingSprintKey = false;
} }
waitingForSprintKeyRelease = false; waitingForSprintKeyRelease = false;
} }
} }
else if (sprintMode == SprintMode.HOLD) { else if (sprintMode == SprintMode.HOLD){
if (KEY_SPRINT.isDown()) { if (Key.isPressed(KEY_SPRINT)){
stopSprintingAfterReleasingSprintKey = true; stopSprintingAfterReleasingSprintKey = true;
} }
} }
if (stopSprintingAfterReleasingSprintKey && !KEY_SPRINT.isDown()) { if (stopSprintingAfterReleasingSprintKey && !Key.isPressed(KEY_SPRINT)){
stopSprintingAfterReleasingSprintKey = false; stopSprintingAfterReleasingSprintKey = false;
waitingForSprintKeyRelease = false; waitingForSprintKeyRelease = false;
player.setSprinting(false); player.setSprinting(false);
@@ -147,53 +144,51 @@ public final class PlayerTicker {
toggleSneak.tick(); toggleSneak.tick();
} }
public void afterInputAssignsPressingForward(final Input input) { public void afterInputAssignsPressingForward(final KeyboardInput input){
if (MINECRAFT.screen == null) { if (MINECRAFT.currentScreen == null){
//noinspection NonShortCircuitBooleanExpression input.pressingForward |= toggleWalkForward.tick();
input.up |= toggleWalkForward.tick();
} }
} }
public void afterInputTick(final LocalPlayer player) { public void afterInputTick(final ClientPlayerEntity player){
final Input input = player.input; final Input input = player.input;
if (MINECRAFT.screen == null && !player.getAbilities().flying) { if (MINECRAFT.currentScreen == null && !player.abilities.flying){
//noinspection NonShortCircuitBooleanExpression
input.jumping |= toggleJump.tick(); input.jumping |= toggleJump.tick();
} }
if (FlightHelper.isFlyingCreativeOrSpectator(player)) { if (FlightHelper.isFlyingCreativeOrSpectator(player)){
final boolean boost = KEY_SPRINT.isDown(); final boolean boost = Key.isPressed(KEY_SPRINT);
final float flightSpeed = FlightHelper.getFlightSpeed(player, boost); final float flightSpeed = FlightHelper.getFlightSpeed(player, boost);
final float verticalVelocity = FlightHelper.getExtraVerticalVelocity(player, boost); final float verticalVelocity = FlightHelper.getExtraVerticalVelocity(player, boost);
if (flightSpeed > 0F) { if (flightSpeed > 0F){
player.getAbilities().setFlyingSpeed(flightSpeed); player.abilities.setFlySpeed(flightSpeed);
} }
if (Math.abs(verticalVelocity) > 1E-5F && player == MINECRAFT.getCameraEntity()) { if (Math.abs(verticalVelocity) > 1E-5F && player == MINECRAFT.getCameraEntity()){
int direction = 0; int direction = 0;
if (input.shiftKeyDown) { if (input.sneaking){
--direction; --direction;
} }
if (input.jumping) { if (input.jumping){
++direction; ++direction;
} }
if (direction != 0) { if (direction != 0){
player.setDeltaMovement(player.getDeltaMovement().add(0D, flightSpeed * verticalVelocity * direction, 0D)); player.setVelocity(player.getVelocity().add(0D, flightSpeed * verticalVelocity * direction, 0D));
} }
} }
} }
if (cfg().resumeSprintingAfterHittingObstacle) { if (cfg().resumeSprintingAfterHittingObstacle){
if (wasHittingObstacle != player.horizontalCollision) { if (wasHittingObstacle != player.horizontalCollision){
if (!wasHittingObstacle) { if (!wasHittingObstacle){
wasSprintingBeforeHittingObstacle = player.isSprinting() || KEY_SPRINT.isDown(); wasSprintingBeforeHittingObstacle = player.isSprinting() || Key.isPressed(KEY_SPRINT);
} }
else if (wasSprintingBeforeHittingObstacle) { else if (wasSprintingBeforeHittingObstacle){
wasSprintingBeforeHittingObstacle = false; wasSprintingBeforeHittingObstacle = false;
temporarySprintTimer = 10; temporarySprintTimer = 10;
} }
@@ -202,110 +197,110 @@ public final class PlayerTicker {
wasHittingObstacle = player.horizontalCollision; wasHittingObstacle = player.horizontalCollision;
} }
} }
else { else{
wasHittingObstacle = player.horizontalCollision; wasHittingObstacle = player.horizontalCollision;
wasSprintingBeforeHittingObstacle = false; wasSprintingBeforeHittingObstacle = false;
} }
if (cfg().disableChangingFovWhileFlying && FlightHelper.isFlyingCreativeOrSpectator(player)){
((AccessGameRendererFields)MINECRAFT.gameRenderer).setMovementFovMultiplier(1F);
}
} }
public void afterSuperCall(final LocalPlayer player) { public void afterSuperCall(final ClientPlayerEntity player){
if (FlightHelper.shouldFlyOnGround(player)) { if (FlightHelper.shouldFlyOnGround(player)){
final boolean isSneaking = player.isShiftKeyDown(); final boolean isSneaking = player.isSneaking();
final boolean isOnGround = player.isOnGround(); final boolean isOnGround = player.onGround;
if (!isSneaking) { if (!isSneaking){
wasSneakingBeforeTouchingGround = false; wasSneakingBeforeTouchingGround = false;
} }
else if (!isOnGround) { else if (!isOnGround){
wasSneakingBeforeTouchingGround = true; wasSneakingBeforeTouchingGround = true;
} }
if (!isOnGround) { if (!isOnGround){
holdingSneakWhileTouchingGround = false; holdingSneakWhileTouchingGround = false;
} }
else { else{
boolean cancelLanding = true; boolean cancelLanding = true;
if (!wasSneakingBeforeTouchingGround) { if (!wasSneakingBeforeTouchingGround){
if (isSneaking) { if (isSneaking){
holdingSneakWhileTouchingGround = true; holdingSneakWhileTouchingGround = true;
} }
else if (holdingSneakWhileTouchingGround) { else if (holdingSneakWhileTouchingGround){
player.getAbilities().flying = false; player.abilities.flying = false;
player.onUpdateAbilities(); player.sendAbilitiesUpdate();
cancelLanding = false; cancelLanding = false;
} }
} }
if (cancelLanding) { if (cancelLanding){
player.setOnGround(false); player.onGround = false;
} }
} }
} }
else { else{
wasSneakingBeforeTouchingGround = false; wasSneakingBeforeTouchingGround = false;
holdingSneakWhileTouchingGround = false; holdingSneakWhileTouchingGround = false;
} }
if (FlightHelper.isFlyingCreativeOrSpectator(player) && cfg().disableFlightInertia) { if (FlightHelper.isFlyingCreativeOrSpectator(player) && cfg().disableFlightInertia){
final Input input = player.input; final Input input = player.input;
if (input.forwardImpulse == 0F && input.leftImpulse == 0F) { if (input.movementForward == 0F && input.movementSideways == 0F){
player.setDeltaMovement(player.getDeltaMovement().multiply(0.0, 1.0, 0.0)); player.setVelocity(player.getVelocity().multiply(0.0, 1.0, 0.0));
} }
if (!input.jumping && !input.shiftKeyDown) { if (!input.jumping && !input.sneaking){
player.setDeltaMovement(player.getDeltaMovement().multiply(1.0, 0.0, 1.0)); player.setVelocity(player.getVelocity().multiply(1.0, 0.0, 1.0));
} }
} }
if (player.isCreative()) { if (player.isCreative()){
if (cfg().keyToggleFlight.consumeClick()) { if (Key.wasPressed(cfg().keyToggleFlight)){
final boolean isFlying = !player.getAbilities().flying; final boolean isFlying = !player.abilities.flying;
player.getAbilities().flying = isFlying; player.abilities.flying = isFlying;
player.onUpdateAbilities(); player.sendAbilitiesUpdate();
if (isFlying) { if (isFlying){
temporaryFlyOnGroundTimer = 10; temporaryFlyOnGroundTimer = 10;
} }
} }
if (temporaryFlyOnGroundTimer > 0) { if (temporaryFlyOnGroundTimer > 0){
if (player.isShiftKeyDown()) { if (player.isSneaking()){
temporaryFlyOnGroundTimer = 0; temporaryFlyOnGroundTimer = 0;
} }
else { else{
--temporaryFlyOnGroundTimer; --temporaryFlyOnGroundTimer;
player.setOnGround(false); player.onGround = false;
} }
} }
} }
else { else{
temporaryFlyOnGroundTimer = 0; temporaryFlyOnGroundTimer = 0;
} }
if (!cfg().sneakingMovesCameraSmoothly) { if (!cfg().sneakingMovesCameraSmoothly){
final Camera camera = MINECRAFT.gameRenderer.getMainCamera(); final AccessCameraFields camera = (AccessCameraFields)MINECRAFT.gameRenderer.getCamera();
if (camera.getEntity() == player) { if (camera.getFocusedEntity() == player){
((AccessCameraFields)camera).setEyeHeight(player.getEyeHeight()); camera.setCameraY(player.getStandingEyeHeight());
} }
} }
if (cfg().keyResetAllToggles.consumeClick()) { if (Key.wasPressed(cfg().keyResetAllToggles)){
toggleSprint.reset(); toggleSprint.reset();
toggleSneak.reset(); toggleSneak.reset();
toggleWalkForward.reset(); toggleWalkForward.reset();
toggleJump.reset(); toggleJump.reset();
} }
if (cfg().keyOpenMenu.isDown()) { if (Key.isPressed(cfg().keyOpenMenu)){
MINECRAFT.setScreen(new BetterControlsScreen(null)); MINECRAFT.openScreen(new BetterControlsScreen(null));
} }
} }
public boolean shouldResetFOV(final LocalPlayer player) {
return cfg().disableChangingFovWhileFlying && FlightHelper.isFlyingCreativeOrSpectator(player);
}
} }

View File

@@ -1,9 +1,21 @@
package chylex.bettercontrols.player; package chylex.bettercontrols.player;
import java.util.function.BooleanSupplier; import java.util.function.BooleanSupplier;
record SprintPressGetter(BooleanSupplier wrapped, BooleanSupplier or) implements BooleanSupplier { final class SprintPressGetter implements BooleanSupplier{
private final BooleanSupplier wrapped;
private final BooleanSupplier or;
public SprintPressGetter(final BooleanSupplier wrapped, final BooleanSupplier or){
this.wrapped = wrapped;
this.or = or;
}
public BooleanSupplier getWrapped(){
return wrapped;
}
@Override @Override
public boolean getAsBoolean() { public boolean getAsBoolean(){
return wrapped.getAsBoolean() || or.getAsBoolean(); return wrapped.getAsBoolean() || or.getAsBoolean();
} }
} }

View File

@@ -0,0 +1,45 @@
package chylex.bettercontrols.util;
import net.minecraft.client.options.KeyBinding;
import net.minecraft.client.util.InputUtil;
public final class Key{
private Key(){}
public static final InputUtil.KeyCode INVALID = InputUtil.UNKNOWN_KEYCODE;
public static boolean isUnbound(final KeyBinding binding){
return binding.isNotBound();
}
public static boolean isPressed(final KeyBinding binding){
return binding.isPressed();
}
public static boolean wasPressed(final KeyBinding binding){
return binding.wasPressed();
}
public static String getBoundKeyText(final KeyBinding binding){
return binding.getLocalizedName();
}
public static void bind(final KeyBinding binding, final InputUtil.KeyCode input){
binding.setKeyCode(input);
}
public static String writeBinding(final KeyBinding binding){
return binding.getName();
}
public static void readBinding(final KeyBinding binding, final String serialized){
bind(binding, InputUtil.fromName(serialized));
}
public static InputUtil.KeyCode inputFromMouse(final int button){
return InputUtil.Type.MOUSE.createFromCode(button);
}
public static InputUtil.KeyCode inputFromKeyboard(final int keyCode, final int scanCode){
return InputUtil.getKeyCode(keyCode, scanCode);
}
}

View File

@@ -0,0 +1,11 @@
package chylex.bettercontrols.util;
public final class LiteralText extends net.minecraft.text.LiteralText{
public static LiteralText text(final String text){
return new LiteralText(text);
}
public LiteralText(final String msg){
super(msg);
}
}

View File

@@ -0,0 +1,16 @@
package chylex.bettercontrols.util;
import net.minecraft.client.MinecraftClient;
import net.minecraft.client.options.GameOptions;
import net.minecraft.client.options.KeyBinding;
public final class Statics{
private Statics(){}
public static final MinecraftClient MINECRAFT = MinecraftClient.getInstance();
public static final GameOptions OPTIONS = MINECRAFT.options;
public static final KeyBinding KEY_SPRINT = OPTIONS.keySprint;
public static final KeyBinding KEY_SNEAK = OPTIONS.keySneak;
public static final KeyBinding KEY_FORWARD = OPTIONS.keyForward;
public static final KeyBinding KEY_JUMP = OPTIONS.keyJump;
}

View File

@@ -0,0 +1,8 @@
package io.github.prospector.modmenu.api;
import net.minecraft.client.gui.screen.Screen;
@SuppressWarnings("unused")
@FunctionalInterface
public interface ConfigScreenFactory<S extends Screen>{
S create(Screen var1);
}

View File

@@ -0,0 +1,16 @@
package io.github.prospector.modmenu.api;
import com.google.common.collect.ImmutableMap;
import java.util.Map;
@SuppressWarnings("unused")
public interface ModMenuApi{
String getModId();
default ConfigScreenFactory<?> getModConfigScreenFactory(){
return ignore -> null;
}
default Map<String, ConfigScreenFactory<?>> getProvidedConfigScreenFactories(){
return ImmutableMap.of();
}
}

View File

Before

Width:  |  Height:  |  Size: 21 KiB

After

Width:  |  Height:  |  Size: 21 KiB

View File

@@ -2,23 +2,25 @@
"required": true, "required": true,
"minVersion": "0.8", "minVersion": "0.8",
"package": "chylex.bettercontrols.mixin", "package": "chylex.bettercontrols.mixin",
"refmap": "bettercontrols.refmap.json", "compatibilityLevel": "JAVA_8",
"compatibilityLevel": "JAVA_17", "mixins": [
"client": [
"AccessCameraFields", "AccessCameraFields",
"AccessClientPlayerFields", "AccessClientPlayerFields",
"AccessControlsListCategory",
"AccessControlsListKeyBinding",
"AccessGameRendererFields",
"AccessKeyBindingFields", "AccessKeyBindingFields",
"AccessOptionButtonWidgetOption",
"AccessPlayerFields", "AccessPlayerFields",
"AccessScreenButtons",
"AccessStickyKeyBindingStateGetter", "AccessStickyKeyBindingStateGetter",
"HookClientPlayerFOV",
"HookClientPlayerInputTick", "HookClientPlayerInputTick",
"HookClientPlayerTick", "HookClientPlayerTick",
"HookControlsListWidget", "HookControlsListWidget",
"HookControlsScreen",
"HookLoadGameOptions", "HookLoadGameOptions",
"HookOpenScreen",
"HookPlayerFlightSpeed", "HookPlayerFlightSpeed",
"HookStickyKeyBindingState", "HookStickyKeyBindingState"
"HookToggleOptionButtons"
], ],
"injectors": { "injectors": {
"defaultRequire": 1 "defaultRequire": 1

View File

@@ -0,0 +1,33 @@
{
"schemaVersion": 1,
"id": "bettercontrols",
"version": "${version}",
"name": "Better Controls",
"description": "Adds many powerful key bindings and options to control your movement.\nThe features complement vanilla mechanics without giving unfair advantages, so server use should be fine.",
"icon": "assets/bettercontrols/icon.png",
"license": "MPL-2.0",
"authors": [ "chylex" ],
"contact": {
"homepage": "",
"sources": "https://github.com/chylex/Better-Controls",
"issues": "https://github.com/chylex/Better-Controls/issues"
},
"environment": "client",
"entrypoints": {
"client": [ "chylex.bettercontrols.BetterControlsMod" ],
"modmenu": [ "chylex.bettercontrols.compatibility.ModMenuSupport" ]
},
"mixins": [{
"config": "bettercontrols.mixins.json",
"environment": "client"
}],
"depends": {
"fabricloader": ">=0.7.4",
"minecraft": "1.15.x"
}
}

View File

@@ -1,7 +0,0 @@
{
"pack": {
"description": "${name}",
"pack_format": 7,
"_comment": ""
}
}