1
0
mirror of https://github.com/chylex/.NET-Community-Toolkit.git synced 2024-11-25 10:42:45 +01:00
Commit Graph

1970 Commits

Author SHA1 Message Date
Sergio Pedri
d32592c69c Added missing nullability annotations 2021-02-13 00:16:31 +01:00
Sergio Pedri
f1da0ed9ad Tweaked ObservableValidator constructors, added tests 2021-02-13 00:16:31 +01:00
Sergio Pedri
1834f9581c Added custom ValidationContext to ObservableValidator 2021-02-13 00:16:31 +01:00
Sergio Pedri
fca033b27a Added missing types to NuGet description 2021-02-13 00:16:30 +01:00
Sergio Pedri
e61ef82070 Added .NET 5 target (and removed built-in package) 2021-02-13 00:16:30 +01:00
Sergio Pedri
c5800998ae Added missing nullability annotations 2021-02-13 00:16:30 +01:00
Sergio Pedri
7bdcd48b4f Added caching for reflection setup in ValidateAllProperties 2021-02-13 00:16:30 +01:00
Sergio Pedri
a5e5c1115d Added ObservableValidator.ValidateAllProperties() API 2021-02-13 00:16:29 +01:00
Sergio Pedri
12e7c96c50 Added unit tests for ClearErrors 2021-02-13 00:16:29 +01:00
Sergio Pedri
b16656a845 Added ObservableValidator.ClearErrors(string) API 2021-02-13 00:16:29 +01:00
Sergio Pedri
70821903f2 Fixed unit tests with RelayCommand and value types 2021-02-13 00:16:29 +01:00
Sergio Pedri
c1778f1eae Switched ObservableValidator.ValidateProperty to protected 2021-02-13 00:16:28 +01:00
Sergio Pedri
657eaac84a Fixed NRE when calling CanExecute(null) over value types 2021-02-13 00:16:28 +01:00
Sergio Pedri
0b92c97764 Minor code style tweaks 2021-02-13 00:16:28 +01:00
Sergio Pedri
752c15196c Updated NuGet packages 2021-02-13 00:16:27 +01:00
Sergio Pedri
562c505a82 Minor code tweaks 2021-02-13 00:16:27 +01:00
Sergio Pedri
451111ff82 Minor codegen improvements 2021-02-13 00:16:27 +01:00
Sergio Pedri
262eadd387 Improved nullability annotations in commands 2021-02-13 00:16:27 +01:00
Sergio Pedri
c7fa6c54dd Changed command CanExecute args to Predicate<T> 2021-02-13 00:16:26 +01:00
Sergio Pedri
5622686e88 Added generic ObservableValidator.GetErrors return 2021-02-13 00:16:26 +01:00
Sergio Pedri
cb4eca6d1a Memory improvements for weak messenger on NS2.0 2021-02-13 00:16:26 +01:00
Sergio Pedri
bc32b05448 Enabled C# 9, switched to target typed new() 2021-02-13 00:16:25 +01:00
Sergio Pedri
a333585ea7 Merge pull request #3645 from Sergio0694/feature/dangerous-ref-enumerable
[ReadOnly]RefEnumerable<T>.DangerousCreate static constructors
2021-02-13 00:15:36 +01:00
Sergio Pedri
4f8c2f34f4 Added unit tests 2021-02-12 22:36:27 +01:00
Sergio Pedri
3a5b69743f Minor code tweaks using target-typed new() expression 2021-02-12 22:36:27 +01:00
Sergio Pedri
a87294b586 Added missing explicit in modifiers, for clarity 2021-02-12 22:36:27 +01:00
Sergio Pedri
f06c753fcb Added [ReadOnly]RefEnumerable<T>.DangerousCreate 2021-02-12 22:36:27 +01:00
Kyaa Dost
13332e6753 Merge branch 'master' into Kyaa-UpdateIssueTemplate 2021-02-09 15:08:30 -08:00
msftbot[bot]
43b79699a4 Simplified namespaces in HighPerformance package (#3687)
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->

<!-- 📝 It is preferred if you keep the "☑️ Allow edits by maintainers" checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork.  This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 -->


## Related to #3422 
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->

<!-- Add a brief overview here of the feature/bug & fix. -->

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

- Refactoring
- Improvements
<!-- - Bugfix -->
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## Overview
Following the suggestion from @mrlacey for non-breaking changes, this PR moves the new `Span2D<T>` and `Memory2D<T>` types introduced in version 7.0 to the root `Microsoft.Toolkit.HighPerformance` namespace (instead of `.Memory`). This is simpler to use for consumers, it makes sense given that the root namespace already contains some other "primitive" types, and it's also more consistent to how the `Span<T>` and `Memory<T>` types are included in the `System.Memory` package, but are still located in the root `System` namespace.

This PR also includes some minor codegen improvements to some other extensions, while I was at it 😄

## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] ~~Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->~~
- [ ] ~~Sample in sample app has been added / updated (for bug fixes / features)~~
    - [ ] ~~Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)~~
- [X] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/windows-toolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
- [X] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [X] Contains **NO** breaking changes
2021-02-05 09:18:20 +00:00
Sergio Pedri
99d3d42aa4 Fixed some remaining unit tests 2021-02-05 00:04:56 +01:00
Sergio Pedri
7e45efef6b Updated unit test files 2021-02-05 00:04:56 +01:00
Sergio Pedri
dccfe8dfda Moved [Memory|Span]2D types to root namespace 2021-02-05 00:04:55 +01:00
Sergio Pedri
11ea673508 Minor codegen improvements 2021-02-05 00:04:55 +01:00
Michael Hawker MSFT (XAML Llama)
48514e9532 Merge pull request #3503 from ratishphilip/feature/win2dparser
Added the Win2d Path Geometry parser.
2021-02-04 14:35:34 -08:00
Sergio Pedri
cd4113c07c Merge branch 'master' into feature/win2dparser 2021-02-04 21:58:23 +01:00
msftbot[bot]
814b174725 Split Microsoft.Toolkit.Diagnostics package (#3726)
### Related to #3594, working towards reducing footprint and increasing modularity

<!-- Add a brief overview here of the feature/bug & fix. -->

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

<!-- - Bugfix -->
<!-- - Feature -->
<!-- - Code style update (formatting) -->
- Refactoring (no functional changes, no api changes)
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
The `Guard` and `ThrowHelper` APIs are part of the `Microsoft.Toolkit` package.
This has a few downsides with respect to binary size for consuming package and overall API surface for consumers.

The `Guard` and `ThrowHelper` APIs relied on a number of different NuGet packages that needed to be pulled in:
 - `System.Diagnostics.Contracts`
 - `System.ValueTuple`
 - `System.Memory`
 - `System.Runtime.CompilerServices.Unsafe`

These packages are _only_ needed by those APIs, and yet with `Microsoft.Toolkit` being referenced by every other package in the whole Toolkit, every other package ended up having a dependency on those as well even when there was no use for them at all. This is not ideal both for final binary size, for the increased number of potentially unwanted APIs being imported by consumers, and due to the fact that many consumers want to minimize the number of NuGet dependencies in general.

Furthermore, the `.Diagnostics` APIs can be very useful for all kinds of developers, especially those working in backend scenarios and with a particular focus on performance. It was not ideal to force those developers to also import APIs such as observable collections and other more UI-oriented APIs that were available in the base package (in fact I've spoken with a few devs that didn't like having to include anything other than just the `Guard` and `ThrowHelper` APIs when adding the package).

For consumers on .NET 5 that don't use .NET Native, splitting the `Guard` and `ThrowHelper` APIs away means 80KB less in binary size (when not using IL trimming) when those APIs are not needed, which is effectively a 75% reduction on the base package.

## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->
The `Guard` and `ThrowHelper` APIs have now been moved to a new `Microsoft.Toolkit.Diagnostics` package.
Splitting this package completely removes all those dependencies from all other packages too 🚀
This work will also make it easier in the future to introduce a `.Diagnostics` source-only package, if we wanted to.

**Note:** marking as breaking change due to the APIs being moved to a different package, but this PR doesn't do any changes to the overall API surface across the various packages - the APIs are still all exactly the same, just modularized differently.

## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] ~~Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->~~
- [ ] ~~Sample in sample app has been added / updated (for bug fixes / features)~~
    - [ ] ~~Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)~~
- [X] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/windows-toolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
- [X] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [ ] Contains **NO** breaking changes
2021-02-04 17:15:55 +00:00
Sergio Pedri
bf18a2c1b0 Fixed T4 linked files in .csproj file 2021-02-03 22:47:12 +01:00
Sergio Pedri
92131a4cbf Added missing references to test projects 2021-02-03 12:05:29 +01:00
Sergio Pedri
80dd1f927f Fixed .csproj files for base and Diagnostics packages 2021-02-03 02:17:31 +01:00
Sergio Pedri
9ae8782847 Split Microsoft.Toolkit.Diagnostics package 2021-02-02 23:00:41 +01:00
Kyaa Dost
641292b74f Merge pull request #2 from windows-toolkit/master
UPDATE
2021-02-02 10:58:25 -08:00
Ratish Philip
60ae79b4bc Merge branch 'master' into feature/win2dparser 2021-01-28 11:01:28 -08:00
msftbot[bot]
cafb0a5054 Guard overloads for nint/nuint, codegen improvements (#3573)
## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

<!-- - Bugfix -->
- Feature
- Optimization
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
There are no `nint`/`nuint` overloads for the any `Guard` APIs. These types have been introduced with C# 9, so it makes sense to add proper support for them given that #3356 added full support for C# 9 and .NET 5 to these packages.
Also there were some codegen bits in `Guard.IsCloseTo` that were not ideal.
Additionally, the codegen for the `Guard` APIs didn't leverage compiler support properly.

## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->
 Added new `nint`/`nuint` overloads to `Guard` APIs
🚀 Improved codegen in a number of `Guard.IsCloseTo` overloads
🚀 Improved codegen for faulting blocks

## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [ ] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [X] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [X] Contains **NO** breaking changes
2021-01-28 18:17:57 +00:00
Michael Hawker MSFT (XAML Llama)
f0e5805112 Merge branch 'master' into feature/nint-guard-apis 2021-01-28 08:39:59 -08:00
Ratish Philip
2b36530c10 Merge branch 'master' into feature/win2dparser 2021-01-21 18:27:23 -08:00
msftbot[bot]
d210795043 Add lazy loading threshold for ImageEx control (#3483)
## Fixes
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->
Add lazy loading threshold for ```ImageEx``` control and change the lazy loading implement that will be also fixed #3258 .

<!-- Add a brief overview here of the feature/bug & fix. -->

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

 - Bugfix 
 - Feature 
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
If enable lazy loading, only the ImageEx entered the viewport, the source will start to load.

## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->
Give a threshold for triggering the lazy loading behavior, the default value is 300 px.

## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tested code with current [supported SDKs](../readme.md#supported)
- [x] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/pull/387<!-- docs PR link -->
- [x] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [x] Contains **NO** breaking changes

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
     Please note that breaking changes are likely to be rejected. -->


## Other information
2021-01-21 22:57:59 +00:00
Ratish Philip
5686b3a37f Removed ThrowHelper.ThrowNullReferenceException which I had added.
Using ThrowHelper.ThrowArgumentNullException instead.
2021-01-17 17:35:51 -08:00
Ratish Philip
503f22b579 Merge branch 'master' into feature/win2dparser 2021-01-17 11:14:55 -08:00
Ratish Philip
bdf52bdfd2 Implemented changes based on Sergio's review comments. 2021-01-17 11:13:51 -08:00
Michael Hawker MSFT (XAML Llama)
4d68cf8f1e Merge branch 'master' into lazyLoadingThreshold 2021-01-14 13:51:44 -08:00